Maniphest T13481

Don't require "git remote get-url" in Arcanist
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	epriestley
	Jan 23 2020, 10:09 PM

Tags

Referenced Files

None

Subscribers

Description

See PHI1617. The git remote get-url subcommand was added circa Git 2.7 (Late 2015?). Perforce support (from T13434) added a call to this command, so arc land now fails on some workflows in older versions of Git.

When this command does not exist, we could just assume the remote is pushable.

Revisions and Commits

rARC Arcanist
	D20952	rARC21a1828ea06c Omit "--" in older fallback commands for Git remote URIs
	D20950	rARC70c0fd3f2233 In Git, fall back across versions more cleanly when trying to get the URI for a…

Related Objects

Mentioned In: 2020 Week 5 (Very Late January)
T13434: Support Perforce/Git in "arc land"
Mentioned Here: T13434: Support Perforce/Git in "arc land"

Event Timeline

epriestley triaged this task as Wishlist priority.Jan 23 2020, 10:09 PM

epriestley created this task.

Herald added a subscriber: amckinley. · View Herald TranscriptJan 23 2020, 10:09 PM

epriestley updated the task description. (Show Details)Jan 23 2020, 10:12 PM

epriestley added a revision: D20950: In Git, fall back across versions more cleanly when trying to get the URI for a remote.Jan 23 2020, 11:17 PM

epriestley closed this task as Resolved by committing rARC70c0fd3f2233: In Git, fall back across versions more cleanly when trying to get the URI for a….Jan 23 2020, 11:19 PM

epriestley added a commit: rARC70c0fd3f2233: In Git, fall back across versions more cleanly when trying to get the URI for a….

epriestley added a revision: D20952: Omit "--" in older fallback commands for Git remote URIs.Jan 24 2020, 12:39 AM

epriestley added a commit: rARC21a1828ea06c: Omit "--" in older fallback commands for Git remote URIs.Jan 24 2020, 12:51 AM

epriestley mentioned this in T13434: Support Perforce/Git in "arc land".Jan 30 2020, 6:44 PM

epriestley mentioned this in 2020 Week 5 (Very Late January).Jan 30 2020, 9:35 PM