Page MenuHomePhabricator
Feed All Stories

May 23 2018

epriestley triaged T13146: Phacility account import tool fails to recognize usernames with differing case, e.g. "Alice" vs "alice" as Low priority.
May 23 2018, 12:15 PM · Phacility

May 22 2018

avivey added a comment to T8093: Evaluate virtualizing Git refs by proxying the protocol.

Very soon now, git is getting an exciting new wire protocol. Highlights are improving performance on repos with unholy amount of refs, and being "easier to expand".

May 22 2018, 11:37 PM · Restricted Project, Harbormaster
epriestley updated the task description for T13145: Build results can't be viewed while logged out, but there's no reason for them to be private.
May 22 2018, 7:04 PM · Harbormaster
epriestley triaged T13145: Build results can't be viewed while logged out, but there's no reason for them to be private as Low priority.
May 22 2018, 7:04 PM · Harbormaster
epriestley added a member for Community: aeiser.
May 22 2018, 7:03 PM
spawnlt awarded T8783: Unprototype Nuance (v1) a Party Time token.
May 22 2018, 7:26 AM · Nuance, Restricted Project
spawnlt awarded T12738: Nuance: As a Helpdesk, for Phabricator/Phacility support a Party Time token.
May 22 2018, 7:23 AM · Nuance
epriestley triaged T13144: During Phacility instance import, "bin/services wipe" needs updating for new password storage as Low priority.
May 22 2018, 12:08 AM · Phacility

May 19 2018

epriestley edited the content of Changelog.
May 19 2018, 12:24 AM
epriestley edited the content of 2018 Week 20 (Late May).
May 19 2018, 12:23 AM
epriestley created 2018 Week 20 (Late May).
May 19 2018, 12:23 AM

May 18 2018

epriestley added a comment to T13143: Git treats large text files as binary, which probably has security implications around audit and "enormous changes".

In D19455 I've reduced our "enormous change" threshold from 1GB to 256MB, which puts us underneath Git's 512MB magic number. This probably mitigates this to at least some degree.

May 18 2018, 9:03 PM · Diffusion, Security
epriestley added a revision to T13142: Enormous change detection considers commits individually and can fail when many large commits are pushed simultaneously: Unknown Object (Differential Revision).
May 18 2018, 8:47 PM · Diffusion
epriestley triaged T13143: Git treats large text files as binary, which probably has security implications around audit and "enormous changes" as Low priority.
May 18 2018, 5:53 PM · Diffusion, Security
epriestley renamed T13141: MySQL 8.0.4+ uses "caching_sha2_password", which is incompatible with older clients and raises error 2054 ("The server requested authentication method unknown to the client") with virtually no setup guidance from Recent (?) MySQL may raise Error 2054 ("The server requested authentication method unknown to the client") with little setup guidance to MySQL 8.0.4+ uses "caching_sha2_password", which is incompatible with older clients and raises error 2054 ("The server requested authentication method unknown to the client") with virtually no setup guidance.
May 18 2018, 4:01 PM · Setup
epriestley added a comment to T13141: MySQL 8.0.4+ uses "caching_sha2_password", which is incompatible with older clients and raises error 2054 ("The server requested authentication method unknown to the client") with virtually no setup guidance.

The companion "provide more guidance" patch would be something like this:

May 18 2018, 3:57 PM · Setup
epriestley added a comment to T13141: MySQL 8.0.4+ uses "caching_sha2_password", which is incompatible with older clients and raises error 2054 ("The server requested authentication method unknown to the client") with virtually no setup guidance.

This is involved, and default_authentication_plugin=mysql_native_password doesn't fix it.

May 18 2018, 3:55 PM · Setup
apierritba edited the content of Organizations Using Phabricator.
May 18 2018, 3:45 PM
epriestley triaged T13142: Enormous change detection considers commits individually and can fail when many large commits are pushed simultaneously as Normal priority.
May 18 2018, 2:41 PM · Diffusion

May 17 2018

epriestley added a revision to T13141: MySQL 8.0.4+ uses "caching_sha2_password", which is incompatible with older clients and raises error 2054 ("The server requested authentication method unknown to the client") with virtually no setup guidance: Unknown Object (Differential Revision).
May 17 2018, 1:03 PM · Setup
epriestley closed T13140: Phabricator fails to parse unusual protocol requests emitted by Subversion as Resolved by committing Restricted Diffusion Commit.
May 17 2018, 12:12 AM · Subversion

May 16 2018

epriestley added a member for Community: jlinahan.
May 16 2018, 6:52 PM
epriestley added a revision to T13137: Plans: 2018 Week 19 - Week 22 Bonus Content: Unknown Object (Differential Revision).
May 16 2018, 4:10 PM · Plans
epriestley added a revision to T13137: Plans: 2018 Week 19 - Week 22 Bonus Content: Unknown Object (Differential Revision).
May 16 2018, 3:45 PM · Plans
epriestley added a comment to T13137: Plans: 2018 Week 19 - Week 22 Bonus Content.

When comparing diff 1 to diff 2, hide all files which have not changed [and have no {old/right/undone} inline comments].

May 16 2018, 1:25 PM · Plans
epriestley added a comment to T13141: MySQL 8.0.4+ uses "caching_sha2_password", which is incompatible with older clients and raises error 2054 ("The server requested authentication method unknown to the client") with virtually no setup guidance.

An adjacent issue is that the actual connection exception doesn't make it up to setup guidance. It's somewhat tricky to raise it through the stack since the mechanics are substantially delegated to a bunch of cluster connection management, but we should make more of an effort to get it up to top level.

May 16 2018, 1:17 PM · Setup
epriestley added a comment to T13141: MySQL 8.0.4+ uses "caching_sha2_password", which is incompatible with older clients and raises error 2054 ("The server requested authentication method unknown to the client") with virtually no setup guidance.

In MySQL 8.0.4:

May 16 2018, 1:08 PM · Setup
epriestley triaged T13141: MySQL 8.0.4+ uses "caching_sha2_password", which is incompatible with older clients and raises error 2054 ("The server requested authentication method unknown to the client") with virtually no setup guidance as Normal priority.
May 16 2018, 1:02 PM · Setup
cspeckmim added a comment to T9548: Support Mercurial's bundle2 wire protocol.

Mercurial 4.6 has added hg help internals.bundle2 which will render a book to your console with details about the format/protocol. I did a high-speed skim and then tried out hg help internals.changegroup on a whim which produced an even longer book about the stream protocol (SSH only maybe?).

May 16 2018, 1:13 AM · Diffusion, Mercurial

May 15 2018

epriestley added a revision to T13140: Phabricator fails to parse unusual protocol requests emitted by Subversion: Unknown Object (Differential Revision).
May 15 2018, 10:58 PM · Subversion
epriestley triaged T13140: Phabricator fails to parse unusual protocol requests emitted by Subversion as Normal priority.
May 15 2018, 10:24 PM · Subversion
epriestley renamed T9008: Arcanist linters do not have convenient tools for converting between encoding-aware character offsets and raw byte offsets from Arcanist linters do not handle UTF8 well to Arcanist linters do not have convenient tools for converting between encoding-aware character offsets and raw byte offsets.
May 15 2018, 6:37 PM · Lint, Arcanist
epriestley merged task T13139: Custom linters have no easy way to get line+char from char-offset in file into T9008: Arcanist linters do not have convenient tools for converting between encoding-aware character offsets and raw byte offsets.
May 15 2018, 6:37 PM · Lint
epriestley merged T13139: Custom linters have no easy way to get line+char from char-offset in file into T9008: Arcanist linters do not have convenient tools for converting between encoding-aware character offsets and raw byte offsets.
May 15 2018, 6:37 PM · Lint, Arcanist
avivey created T13139: Custom linters have no easy way to get line+char from char-offset in file.
May 15 2018, 6:08 PM · Lint

May 14 2018

tiguchi awarded T5793: Add support for personal workboards a Like token.
May 14 2018, 5:03 PM · User Delight, Wikimedia, Workboards
epriestley edited the content of Changelog.
May 14 2018, 5:01 PM
epriestley created 2018 Week 19 (Mid May).
May 14 2018, 5:00 PM
epriestley renamed T13137: Plans: 2018 Week 19 - Week 22 Bonus Content from Plans: 2018 Week 19 Bonus Content to Plans: 2018 Week 19 / Week 20 Bonus Content.
May 14 2018, 3:56 PM · Plans
epriestley updated the task description for T13133: Phabricator Query Layer Overview.
May 14 2018, 3:52 PM · Guides
epriestley triaged T13138: Improve consistency of MFA requirements to invite/approve users as Wishlist priority.
May 14 2018, 2:14 PM · People, Security
tanami awarded T13133: Phabricator Query Layer Overview a Dat Boi token.
May 14 2018, 6:01 AM · Guides

May 12 2018

johnclyde added a comment to T12190: In PHP7, include-time warnings from source files are ignored.

I added a linter and I accidentally included this line which references a different already-existing linter

final class ArcanistChmodLinter extends ArcanistLinter {
May 12 2018, 9:55 PM · Infrastructure

May 11 2018

jcox awarded T13133: Phabricator Query Layer Overview a Mountain of Wealth token.
May 11 2018, 7:37 PM · Guides

May 10 2018

epriestley updated the task description for T13137: Plans: 2018 Week 19 - Week 22 Bonus Content.
May 10 2018, 5:21 PM · Plans
epriestley added a revision to T13137: Plans: 2018 Week 19 - Week 22 Bonus Content: Unknown Object (Differential Revision).
May 10 2018, 5:19 PM · Plans
epriestley added a revision to T13137: Plans: 2018 Week 19 - Week 22 Bonus Content: Unknown Object (Differential Revision).
May 10 2018, 5:02 PM · Plans
sheershoff awarded T12676: Dialog box closes with ESC key even when there's unsaved change a Mountain of Wealth token.
May 10 2018, 11:57 AM · Bug Report
amckinley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: Unknown Object (Differential Revision).
May 10 2018, 1:45 AM · Customer Impact, Diffusion (v3)

May 9 2018

epriestley closed T1246: Intraline diff bailout at 80 characters is inflexible and undesirable as Resolved by committing Restricted Diffusion Commit.
May 9 2018, 8:38 PM · Differential
epriestley added a comment to T1246: Intraline diff bailout at 80 characters is inflexible and undesirable.

D19442 is marked as fixing this, although it just raises the limit from 80 to 100. This span measures the number of characters between the first changed character and the last changed character (not the total number of characters on the line) and we haven't seen tons of interest in this over the last several years so I think few installs are running into issues with it even at 80. Bumping it to 100 should give us a bit more breathing room but I don't currently plan to make it configurable (see T8227).

May 9 2018, 8:37 PM · Differential
epriestley updated the task description for T13137: Plans: 2018 Week 19 - Week 22 Bonus Content.
May 9 2018, 8:33 PM · Plans
epriestley added a revision to T1246: Intraline diff bailout at 80 characters is inflexible and undesirable: Unknown Object (Differential Revision).
May 9 2018, 8:33 PM · Differential
epriestley updated the task description for T13137: Plans: 2018 Week 19 - Week 22 Bonus Content.
May 9 2018, 6:43 PM · Plans

May 8 2018

am9obgo awarded T418: Integrate CustomField into more interfaces a Like token.
May 8 2018, 5:46 AM · Restricted Project, Restricted Project, Restricted Project, Custom Fields, Maniphest

May 7 2018

epriestley added a revision to T13137: Plans: 2018 Week 19 - Week 22 Bonus Content: Unknown Object (Differential Revision).
May 7 2018, 9:20 PM · Plans
epriestley added a revision to T13137: Plans: 2018 Week 19 - Week 22 Bonus Content: Unknown Object (Differential Revision).
May 7 2018, 8:50 PM · Plans
epriestley updated the task description for T13098: Plans: Arcanist toolsets and extensions.
May 7 2018, 7:30 PM · Arcanist, Plans
epriestley added a comment to T13137: Plans: 2018 Week 19 - Week 22 Bonus Content.

An install would like a way to filter commits by a particular branch, plus normal filter criteria.

May 7 2018, 5:54 PM · Plans
G3292 awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Love token.
May 7 2018, 11:59 AM · Workboards (v3), Restricted Project

May 6 2018

epriestley closed T13130: Plans: 2018 Week 17/18 Bonus Content as Resolved.

Some of this moved forward to T13137.

May 6 2018, 4:07 PM · Plans
epriestley updated the task description for T13137: Plans: 2018 Week 19 - Week 22 Bonus Content.
May 6 2018, 1:47 PM · Plans
epriestley triaged T13137: Plans: 2018 Week 19 - Week 22 Bonus Content as Normal priority.
May 6 2018, 1:45 PM · Plans
epriestley updated the task description for T13130: Plans: 2018 Week 17/18 Bonus Content.
May 6 2018, 1:35 PM · Plans
zhzhqcdu awarded Welcome a Like token.
May 6 2018, 12:39 PM
epriestley edited the content of Changelog.
May 6 2018, 12:03 PM
epriestley created 2018 Week 18 (Early May).
May 6 2018, 12:03 PM

May 5 2018

amckinley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: Unknown Object (Differential Revision).
May 5 2018, 3:24 AM · Customer Impact, Diffusion (v3)

May 4 2018

epriestley added a revision to T13130: Plans: 2018 Week 17/18 Bonus Content: Unknown Object (Differential Revision).
May 4 2018, 10:11 PM · Plans
epriestley added a revision to T13065: Move storage for `mailKey` to the Mail application: Unknown Object (Differential Revision).
May 4 2018, 8:44 PM · Mail
epriestley added a revision to T13130: Plans: 2018 Week 17/18 Bonus Content: Unknown Object (Differential Revision).
May 4 2018, 8:44 PM · Plans
epriestley added a revision to T13130: Plans: 2018 Week 17/18 Bonus Content: Unknown Object (Differential Revision).
May 4 2018, 8:30 PM · Plans
epriestley added a revision to T13130: Plans: 2018 Week 17/18 Bonus Content: Unknown Object (Differential Revision).
May 4 2018, 7:33 PM · Plans
epriestley updated the task description for T13115: Handle mail bounces inside Phabricator.
May 4 2018, 6:42 PM · Mail
epriestley updated the task description for T13130: Plans: 2018 Week 17/18 Bonus Content.
May 4 2018, 5:58 PM · Plans
epriestley closed T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4" as Resolved by committing Restricted Diffusion Commit.
May 4 2018, 4:28 PM · Files
epriestley added a revision to T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4": Unknown Object (Differential Revision).
May 4 2018, 4:25 PM · Files
epriestley added a comment to T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4".

I like that reasoning a lot better than mine, and simply omitting type appears to produce the correct behavior in every browser, at least for this file. I'll try that instead, and we can revisit this after we write a video transcoder in PHP and can offer files in multiple formats.

May 4 2018, 3:14 PM · Files
asherkin added a comment to T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4".

My knowledge is centred around broadcast video / IPTV (UDP multicast) rather than HTML5 video, but that seems fairly reasonable. I don't think anything should try and download the file twice unless it is a complete clownshoes implementation that probably has multiple other serious bugs wasting bandwidth. I think the worst case with no type that might be hit here is that the browser could decide to download the entire file on load to figure out the format and duration, rather than starting with byte-range requests, but this is easy to test and unlikely (I'd expect any sane one to always request chunks).

May 4 2018, 3:11 PM · Files
epriestley added a comment to T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4".

I can imagine that two <source /> tags might, in some bizarre world, cause browsers to download the file twice when you click "Play", if they're super confused about how to process videos, don't notice that the URLs are the same, and don't hit any caching. But that's a pretty minor bad effect, and I didn't immediately see any kind of bad behavior locally.

May 4 2018, 2:50 PM · Files
epriestley added a comment to T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4".

Thanks! I wouldn't mind parsing that but I'm hesitant to ask installs to install it -- but it's helpful in understanding that I'm not completely crazy here and that there's at least some basis for "video/mp4" being a quasi-legitimate way to label the video file.

May 4 2018, 2:47 PM · Files
asherkin added a comment to T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4".

mediainfo is the tool for this, but is really overkill for programmatic use.

May 4 2018, 1:29 PM · Files

May 3 2018

epriestley updated the task description for T13133: Phabricator Query Layer Overview.
May 3 2018, 3:57 PM · Guides
epriestley added a comment to T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4".

One easy approach we could take is just:

May 3 2018, 3:45 PM · Files
epriestley triaged T13135: Chrome does not play some videos with type "video/quicktime", but does play them with type "video/mp4" as Normal priority.
May 3 2018, 3:31 PM · Files
scp awarded T3875: Allow arc to perform cascading rebases, maybe during or after `arc land` a Mountain of Wealth token.
May 3 2018, 3:24 PM · Prioritized, Restricted Project, Arcanist

May 2 2018

epriestley added a comment to T13130: Plans: 2018 Week 17/18 Bonus Content.

An install is hitting the "large blame does not degrade gracefully" issue mentioned in that task

May 2 2018, 3:42 AM · Plans
avivey edited the content of 2018 Week 17 (Very Late April).
May 2 2018, 2:53 AM
scp awarded T182: Commit into repository directly from differential a Love token.
May 2 2018, 12:45 AM · Haskell.org, Restricted Project, Differential

May 1 2018

amckinley added a revision to T12164: Put an indirection layer between author/committer strings and user accounts: Unknown Object (Differential Revision).
May 1 2018, 8:36 PM · Customer Impact, Diffusion (v3)
epriestley closed T13132: `arc download` broken for non-CDN Phabricator as Resolved by committing Restricted Diffusion Commit.
May 1 2018, 5:08 PM · Conduit, Files
epriestley added projects to T13132: `arc download` broken for non-CDN Phabricator : Files, Conduit.
May 1 2018, 4:06 PM · Conduit, Files
epriestley updated the task description for T13130: Plans: 2018 Week 17/18 Bonus Content.
May 1 2018, 2:24 PM · Plans
epriestley added a revision to T13130: Plans: 2018 Week 17/18 Bonus Content: Unknown Object (Differential Revision).
May 1 2018, 2:24 PM · Plans
epriestley added a revision to T13132: `arc download` broken for non-CDN Phabricator : Unknown Object (Differential Revision).
May 1 2018, 2:21 PM · Conduit, Files
amckinley created P2102 migration.sql.
May 1 2018, 12:27 AM
amckinley created P2101 (An Untitled Masterwork).
May 1 2018, 12:26 AM
epriestley updated the task description for T13130: Plans: 2018 Week 17/18 Bonus Content.
May 1 2018, 12:10 AM · Plans
amckinley created P2100 (An Untitled Masterwork).
May 1 2018, 12:03 AM

Apr 30 2018

asherkin awarded T13133: Phabricator Query Layer Overview a Mountain of Wealth token.
Apr 30 2018, 10:35 PM · Guides