Page MenuHomePhabricator
Feed All Stories

Jul 5 2017

chad closed T12892: arc diff --update Created a new Differential revision not Update existing revision as Resolved.
Jul 5 2017, 6:24 AM · Bug Report
jbhateja updated the task description for T12898: Option to remove changes under a Diff ID from a Differential revision.
Jul 5 2017, 5:15 AM · Bug Report
jbhateja updated the task description for T12898: Option to remove changes under a Diff ID from a Differential revision.
Jul 5 2017, 5:14 AM · Bug Report
jbhateja created T12898: Option to remove changes under a Diff ID from a Differential revision.
Jul 5 2017, 5:14 AM · Bug Report
avivey closed T12897: Ambiguous URL rejection broke commit importing as Invalid.
Jul 5 2017, 3:16 AM · Bug Report
jbeck added a comment to T12897: Ambiguous URL rejection broke commit importing.

Sorry I hadn't updated my worker hosts, you can close this as invalid.

Jul 5 2017, 3:16 AM · Bug Report
jbeck updated the task description for T12897: Ambiguous URL rejection broke commit importing.
Jul 5 2017, 3:15 AM · Bug Report
avivey added a comment to T12897: Ambiguous URL rejection broke commit importing.

Is that a bad url that's contained in the commit message? Is the commit message literally Change the recognised url from showcase://?ITEM_ID to showcase://item/ITEM_ID where ITEMID is the ID of the showcase item?

Jul 5 2017, 3:14 AM · Bug Report
mnxheng added a comment to T12892: arc diff --update Created a new Differential revision not Update existing revision.

Oh I see. That's the problem. I tried repositor in the diffusion, it works well.
My fault, thank you guys. This task could be close.

Jul 5 2017, 2:59 AM · Bug Report
mnxheng added a comment to T12892: arc diff --update Created a new Differential revision not Update existing revision.

I did't add my git repositor into Diffusion. Does that matter?

Jul 5 2017, 2:37 AM · Bug Report
jbeck created T12897: Ambiguous URL rejection broke commit importing.
Jul 5 2017, 2:06 AM · Bug Report

Jul 4 2017

hach-que added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

I can try checking if SSH compression is enabled later today (but I doubt it; I'm just using the defaults). Keep in mind the upload speed to Phacility is 8 MiB/s, it's just the download speed that's 100 KiB/s.

Jul 4 2017, 9:35 PM · Feature Request
mavit created T12896: It isn’t obvious when repository observation breaks.
Jul 4 2017, 4:19 PM · Diffusion, Feature Request
chad closed T12895: Do not include hidden .php files (like editor backups) as extensions as Wontfix.
Jul 4 2017, 3:09 PM · Bug Report
AndiDog created T12895: Do not include hidden .php files (like editor backups) as extensions.
Jul 4 2017, 2:57 PM · Bug Report
johnny-bit added a comment to T12892: arc diff --update Created a new Differential revision not Update existing revision.

instead of git branch once could use arc feature which does (I think) basically the same, but gives hint about what mindset to use where.

Jul 4 2017, 10:07 AM · Bug Report
chad added a comment to T12892: arc diff --update Created a new Differential revision not Update existing revision.

The arc workflow is:

Jul 4 2017, 9:34 AM · Bug Report
asherkin added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

Have you tried changing SSH options on your end, such as disabling compression or using weaker encryption ciphers (such as arcfour, no encryption cant be done without agreement of the server)? This can make a significant difference with SSH transfer speeds, and may function as a decent workaround for now.

Jul 4 2017, 9:33 AM · Feature Request
mnxheng added a comment to T12892: arc diff --update Created a new Differential revision not Update existing revision.

And here is the --trace information

Jul 4 2017, 6:59 AM · Bug Report
mnxheng added a comment to T12892: arc diff --update Created a new Differential revision not Update existing revision.

I create a new empty project on my gitlab and clone it to local. And add .arcconfig file then commit it. After that I ran the arc diff command and it create a new revision on phabricator.
When I want to update the existing revision, I modify a README.md file and ran arc diff --update <Revision Number>. It's create a new revision every single time.
I'm using Mac, and it's the same on my mate's Windows computer. I don't know why.
Maybe I didn't configure currectly. So I want to know where was wrong. Here is my phabricator information.

Jul 4 2017, 6:40 AM · Bug Report
hach-que updated the task description for T12891: Phacility does not currently offer instances in the Sydney region.
Jul 4 2017, 4:33 AM · Feature Request
hach-que added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

That's the obvious solution, but I'm not sure it's practical given Phacility's infrastructure.

Jul 4 2017, 4:31 AM · Feature Request
avivey added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

So probably, the actionables here are "Allow HTTPS in Phacility"?

Jul 4 2017, 3:49 AM · Feature Request
hach-que added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

It is for SSH - but compared with GitHub HTTPS it's much slower.

Jul 4 2017, 3:01 AM · Feature Request
avivey added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

It looks like it's the same speed?

Jul 4 2017, 2:46 AM · Feature Request
hach-que added a comment to T12891: Phacility does not currently offer instances in the Sydney region.

Final statistics are in after letting it clone overnight. Let me know if you need any more information to diagnose speed issues.

Jul 4 2017, 2:26 AM · Feature Request
hach-que updated the task description for T12891: Phacility does not currently offer instances in the Sydney region.
Jul 4 2017, 2:25 AM · Feature Request

Jul 3 2017

epriestley added a comment to T12893: Instance reports consistent bad repository device versions for clustered, observed Git repositories.

Synchronously in the request. I'll look at adding logging.

Jul 3 2017, 11:31 PM · Restricted Project, Clusters, Diffusion, Customer Impact
jmeador added a comment to T12893: Instance reports consistent bad repository device versions for clustered, observed Git repositories.

If you go through the process manually with the web UI, are the versions OK after initial creation? After adding an observed URI?

Jul 3 2017, 7:16 PM · Restricted Project, Clusters, Diffusion, Customer Impact
avivey updated the task description for T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs.
Jul 3 2017, 6:14 PM · Arcanist, Bug Report
epriestley closed T12894: Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first) as Resolved by committing Restricted Diffusion Commit.
Jul 3 2017, 4:28 PM · Customer Impact, Bug Report, Typeahead, Restricted Project
epriestley renamed T12894: Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first) from Install reporting an "exact match" issue with global search typeahead to Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first).
Jul 3 2017, 3:02 PM · Customer Impact, Bug Report, Typeahead, Restricted Project
epriestley added a revision to T12894: Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first): Unknown Object (Differential Revision).
Jul 3 2017, 2:27 PM · Customer Impact, Bug Report, Typeahead, Restricted Project
epriestley added a comment to T12894: Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first).

This is an issue specific to the repository names containing hyphens. The code is already calling calling the correct sort functions.

Jul 3 2017, 2:25 PM · Customer Impact, Bug Report, Typeahead, Restricted Project
epriestley added a comment to T12894: Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first).

I created these repositories:

Jul 3 2017, 2:14 PM · Customer Impact, Bug Report, Typeahead, Restricted Project
epriestley placed T9084: Use a typeaheads for querying Object Types in Flags up for grabs.
Jul 3 2017, 2:13 PM · Contributor Onboarding, Flags
epriestley updated the task description for T12894: Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first).
Jul 3 2017, 1:21 PM · Customer Impact, Bug Report, Typeahead, Restricted Project
epriestley created T12894: Repositories with hyphens sort un-usefully in global search typeahead (exact matches not necessarily first).
Jul 3 2017, 1:21 PM · Customer Impact, Bug Report, Typeahead, Restricted Project
epriestley added a comment to T12893: Instance reports consistent bad repository device versions for clustered, observed Git repositories.

So I'm not immediately able to reproduce this. Some possible questions:

Jul 3 2017, 1:14 PM · Restricted Project, Clusters, Diffusion, Customer Impact
epriestley added a comment to T12893: Instance reports consistent bad repository device versions for clustered, observed Git repositories.

I used this parameter bundle to create a repository:

Jul 3 2017, 1:10 PM · Restricted Project, Clusters, Diffusion, Customer Impact
epriestley added a comment to T12893: Instance reports consistent bad repository device versions for clustered, observed Git repositories.

I'm attempting to reproduce this from the web UI first. I created a new repository, and get 0 versions as expected:

Jul 3 2017, 12:34 PM · Restricted Project, Clusters, Diffusion, Customer Impact
epriestley created T12893: Instance reports consistent bad repository device versions for clustered, observed Git repositories.
Jul 3 2017, 12:25 PM · Restricted Project, Clusters, Diffusion, Customer Impact
epriestley added a comment to T12892: arc diff --update Created a new Differential revision not Update existing revision.

I am unable to reproduce this problem given the instructions provided:

Jul 3 2017, 12:17 PM · Bug Report
mnxheng created T12892: arc diff --update Created a new Differential revision not Update existing revision.
Jul 3 2017, 12:01 PM · Bug Report
epriestley added a parent task for T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
Jul 3 2017, 10:48 AM · Arcanist, Bug Report
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs.
Jul 3 2017, 10:48 AM · Arcanist, Differential
epriestley renamed T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs from ArcanistDiffParser fails to parse filenames to Improve parsing of unusual "git diff --no-index --no-prefix" diffs.
Jul 3 2017, 10:48 AM · Arcanist, Bug Report
epriestley triaged T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs as Wishlist priority.

That change fixed a lot of bugs, so we aren't going to revert it: reverting it would break all the things it fixed and added test cases for. --no-index --no-prefix diffs have never been part of the test suite and it is just coincidence that it worked before that change.

Jul 3 2017, 10:47 AM · Arcanist, Bug Report
Pawka added a comment to T12835: Improve parsing of unusual "git diff --no-index --no-prefix" diffs.

--no-index - diff is created outside of repository by comparing directories.
--no-prefix - I'm not sure about this - some historical reasons and code in the service which generates diffs. But as I understand this was supported since D3744 and until rARCd0957c344156356123048be2219fb95a54c89a85.

Jul 3 2017, 10:40 AM · Arcanist, Bug Report
chad added a comment to Q630: I'd like to use the snazzy eye icon for a mattermost webhook, but it's served rather indirectly. (Answer 553).

You could probably add a route for the icon in apache/whatever manually if we're hyjacking the request

Jul 3 2017, 8:28 AM
benjumanji added a comment to Q630: I'd like to use the snazzy eye icon for a mattermost webhook, but it's served rather indirectly. (Answer 553).

That's what I suspected (I did find the rsrc link, but it seemed a bit suspect, and my default setup doesn't serve it anyway). Thanks!

Jul 3 2017, 8:23 AM
benjumanji closed Q630: I'd like to use the snazzy eye icon for a mattermost webhook, but it's served rather indirectly. as resolved.
Jul 3 2017, 8:22 AM
hach-que renamed T12891: Phacility does not currently offer instances in the Sydney region from Slow cloning on Phacility to Slow cloning over Phacility SSH for large repository.
Jul 3 2017, 6:25 AM · Feature Request
hach-que updated the task description for T12891: Phacility does not currently offer instances in the Sydney region.
Jul 3 2017, 6:20 AM · Feature Request
hach-que added a comment to T12856: Evaluate various "infrastructure-as-code" products.

In my personal experience, CloudFormation is vastly better than Ansible/Chef/insertflavourofthemonthtoolhere. Those other tools all require some specialised syntax, meanwhile CF is just JSON and you can use the CloudFormation designer to get the JSON for any AWS resource that you're not sure how to describe with JSON.

Jul 3 2017, 5:43 AM · Ops, Phacility
hach-que updated the task description for T12891: Phacility does not currently offer instances in the Sydney region.
Jul 3 2017, 5:24 AM · Feature Request
hach-que updated the task description for T12891: Phacility does not currently offer instances in the Sydney region.
Jul 3 2017, 5:23 AM · Feature Request
hach-que created T12891: Phacility does not currently offer instances in the Sydney region.
Jul 3 2017, 5:22 AM · Feature Request

Jul 2 2017

isfs awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Jul 2 2017, 9:52 PM · Workboards (v3), Restricted Project
quark.zju added a comment to T12618: Parse multiple commits and commit metadata from "hg log --patch" and "hg export".

Parsing hg export metadata is an elegant solution. # HG changeset patch could imply sourceControlSystem = 'hg'. Thanks for merging the task!

Jul 2 2017, 7:30 PM · Arcanist, Mercurial, Differential, Conduit, Feature Request
epriestley merged task T12890: Add sourceControlSystem parameter to differential.createrawdiff into T12618: Parse multiple commits and commit metadata from "hg log --patch" and "hg export".
Jul 2 2017, 7:22 PM · Feature Request
epriestley merged T12890: Add sourceControlSystem parameter to differential.createrawdiff into T12618: Parse multiple commits and commit metadata from "hg log --patch" and "hg export".
Jul 2 2017, 7:22 PM · Arcanist, Mercurial, Differential, Conduit, Feature Request
quark.zju added a comment to T12890: Add sourceControlSystem parameter to differential.createrawdiff.

The background is the Mercurial community wants to try Phabricator as an experimental review system. It's using emails now. I'd like to make Phabricator workflow as convenient as traditional email workflow.

Jul 2 2017, 7:16 PM · Feature Request
MissyTS added a comment to T5474: Support workboard column triggers which activate when a task is dropped into a column.

Thanks for the reply @chad.

Jul 2 2017, 6:53 PM · Workboards (v3), Restricted Project
epriestley added a comment to T12890: Add sourceControlSystem parameter to differential.createrawdiff.

I'm writing a Mercurial extension to send changesets to Differential like hg email provided by patchbomb extension.

Jul 2 2017, 6:51 PM · Feature Request
quark.zju created T12890: Add sourceControlSystem parameter to differential.createrawdiff.
Jul 2 2017, 6:47 PM · Feature Request
chad added a comment to T5474: Support workboard column triggers which activate when a task is dropped into a column.

There is no secret tracker with a different set of priorities or timelines
for features. Everything we plan is 100% open. This feature is not on any
short or medium term roadmap and you can read Planning for more
information on how we build the roadmap. We do plan to offer paid support
soon which will let installs prioritize features they need.

Jul 2 2017, 6:40 PM · Workboards (v3), Restricted Project
MissyTS added a comment to T5474: Support workboard column triggers which activate when a task is dropped into a column.

Hi,
My small team & I have been using Phabricator for a year. This is the feature that we lack and that makes our day-to-day work difficult. It would be nice to have even the basics (drag & drop to a column -> update to a given status). Any advise or workaround in the meanwhile would also be nice if they are some. Sorry if I lack Phabricator knowledge and missed an obvious workaround feature.

Jul 2 2017, 6:00 PM · Workboards (v3), Restricted Project
avivey closed T12889: Phabricator Setup Error as Invalid.

We don't maintain that instance. Please contact llvm.org directly for it.

Jul 2 2017, 5:43 PM · Bug Report
MissyTS awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Burninate token.
Jul 2 2017, 5:40 PM · Workboards (v3), Restricted Project
jbhateja created T12889: Phabricator Setup Error.
Jul 2 2017, 5:38 PM · Bug Report
chad closed T12888: repository.query doc points to invalid API diffusion.repository.query as Resolved by committing Restricted Diffusion Commit.
Jul 2 2017, 2:25 PM · Bug Report
chad added a revision to T12888: repository.query doc points to invalid API diffusion.repository.query: Unknown Object (Differential Revision).
Jul 2 2017, 2:12 PM · Bug Report
quark.zju renamed T12888: repository.query doc points to invalid API diffusion.repository.query from `repository.query` points to invalid API `diffusion.repository.query` to repository.query doc points to invalid API diffusion.repository.query.
Jul 2 2017, 1:00 AM · Bug Report
quark.zju created T12888: repository.query doc points to invalid API diffusion.repository.query.
Jul 2 2017, 1:00 AM · Bug Report

Jul 1 2017

epriestley edited the content of Changelog.
Jul 1 2017, 12:16 AM
epriestley created 2017 Week 26 (Very Late June).
Jul 1 2017, 12:15 AM

Jun 30 2017

avivey added a comment to T12856: Evaluate various "infrastructure-as-code" products.

costanzapopcorn

Jun 30 2017, 11:35 PM · Ops, Phacility
epriestley added a comment to T12856: Evaluate various "infrastructure-as-code" products.

Also we aren't the only ones to be surprised by the AWS NAT junk:

Jun 30 2017, 10:55 PM · Ops, Phacility
epriestley added a comment to T12856: Evaluate various "infrastructure-as-code" products.

It looks like Terraform probably can add a listener without destroying the LB (since it's a separate resource type? But the "changing the size of a volume destroys the instance" case suggests maybe it doesn't work like this, if that's how that works), but if you want to enable access logging on your LBs hope you didn't need 'em for anything important? I could probably just install it and figure this out / nuke production forever.

Jun 30 2017, 10:19 PM · Ops, Phacility
epriestley added a comment to T12856: Evaluate various "infrastructure-as-code" products.

If PHP just injects that information into the templates during generation, we might not need to feed anything back into Almanac.

Jun 30 2017, 9:02 PM · Ops, Phacility
amckinley added a comment to T12856: Evaluate various "infrastructure-as-code" products.

Maybe we should just use CloudFormation ¯\_(ツ)_/¯

Jun 30 2017, 8:30 PM · Ops, Phacility
amckinley added a comment to T12856: Evaluate various "infrastructure-as-code" products.

First, a disclaimer that I'm not by any means wedded to terraform. From playing with the other tools, terraform looked like the clearest pathway towards my goal of "minimizing AWS UI clicks", so I decided to see what the terraform config for a private cluster would look like and play with the tool. See example terraform configs here: P2063 P2064. I agree with the general thrust of your comment, which I interpret as "this all sounds terrifying and we probably shouldn't do it", but I wanted to at least get a feeling for the tool and build a proof of concept.

Jun 30 2017, 7:58 PM · Ops, Phacility
epriestley closed T12887: Can't add members to "parent project" when all subprojects are archived as Invalid.

Yes, this is expected. The process of converting a project to become a parent project can not be undone:

Jun 30 2017, 7:31 PM · Bug Report
chad added a comment to T12887: Can't add members to "parent project" when all subprojects are archived.

This behavior sounds correct to me.

Jun 30 2017, 7:27 PM · Bug Report
epriestley added a comment to T12856: Evaluate various "infrastructure-as-code" products.

Terraform also seems to have terraform taint (mark a resource for destruction) but no, e.g., terraform freeze (mark a resource for preservation). This is sort of philosophically bewildering to me. Is the modern approach to ops just like "data isn't important"? Is everyone just really, really careful when they type commands into their fully-automatic resource destruction rifles loaded with high-explosive foot-seeking shells?

Jun 30 2017, 7:27 PM · Ops, Phacility
xp500 created T12887: Can't add members to "parent project" when all subprojects are archived.
Jun 30 2017, 7:23 PM · Bug Report
epriestley added a comment to T12856: Evaluate various "infrastructure-as-code" products.

How does the weekly deployment to all clusters work?

Jun 30 2017, 6:39 PM · Ops, Phacility
amckinley edited P2064 example_customer.tf.
Jun 30 2017, 6:33 PM
amckinley updated the title for P2064 example_customer.tf from uber.tf to example_customer.tf.
Jun 30 2017, 6:29 PM
jcox added a comment to T12880: Expose the ability to add some JS to every page.

Haha to be clear we're using an open-source self-hosted tracking solution, I was just throwing GA out there as an example. But I do understand your point vis-a-vis data security.

Jun 30 2017, 5:37 PM · Feature Request
epriestley added a comment to T12880: Expose the ability to add some JS to every page.

I guess everyone uses GMail nowadays anyway (as mandated by international galactic law) so my paranoia is probably mostly moot because they can undetectably read all email communication anyway.

Jun 30 2017, 5:14 PM · Feature Request
mplough added a comment to T12883: Harbormaster build completion information displays build start time.

Glad I could help! Thanks for getting the fix in so quickly!

Jun 30 2017, 4:05 PM · Bug Report
amckinley created P2064 example_customer.tf.
Jun 30 2017, 3:53 PM
amckinley created P2063 shared.tf.
Jun 30 2017, 3:53 PM
epriestley closed T12880: Expose the ability to add some JS to every page as Wontfix.

I think you probably won't be able to answer most of those questions with Google Analytics. For example, bots will never hit client-side analytics, so any question about bots probably can't be served by GA. Likewise, GA can't see Conduit/API activity.

Jun 30 2017, 2:45 PM · Feature Request
epriestley added a comment to T12879: Put crontabs in VCS and deploy them during provisioning.

(Both adjust and doc/symbol documentation affect an entire service tier rather than particular servers, too -- we only need to generate docs or make schema adjustments once, no matter how many hosts are in the secure or admin tiers.)

Jun 30 2017, 2:25 PM · Phacility, Ops
epriestley added a comment to T12879: Put crontabs in VCS and deploy them during provisioning.

My recollection is a little fuzzy, but I think admin may have once had a hacky crontab for backups that I replaced with a normal backup trigger at some point when the infrastructure matured a little.

Jun 30 2017, 2:23 PM · Phacility, Ops
jcox added a comment to T12880: Expose the ability to add some JS to every page.

Why do you want to track users with Google Analytics or a similar library?

Jun 30 2017, 2:17 PM · Feature Request
epriestley awarded Bug Meister to recipient: ephemeris.
Jun 30 2017, 2:13 PM