Page MenuHomePhabricator
Feed All Stories

Sep 28 2016

epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 2:32 PM · Restricted Project, Prioritized, Calendar
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

(The major goal of using refs instead of tags wouldn't really be to hide them per se, just to make them extremely difficult to fetch by accident.)

Sep 28 2016, 2:07 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

Maybe my assumptions about default behaviors are off, or the more-recent base tags (but not necessarily the diff tags) are getting fetched because they're often ancestors of master?

Sep 28 2016, 2:04 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

I'm a little confused about how these tags are appearing so widely in developer working copies in the first place. Is git clone fetching them by default? Do you have unusual default options configured? Do users regularly explicitly fetch all tags present in the remote?

Sep 28 2016, 2:00 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
gd added a comment to T8238: Formally support side-band change handoff in external repositories.

I think cleaning up closed tags probably isn't a particularly great long-term solution since some fraction of the revisions likely just get left open forever -- so you'd have 500 tags instead of 50000, but I assume that still causes about as many problems, and you'll be back to 50000 in just 100 more years anyway.

Sep 28 2016, 1:55 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a comment to T8238: Formally support side-band change handoff in external repositories.

I think cleaning up closed tags probably isn't a particularly great long-term solution since some fraction of the revisions likely just get left open forever -- so you'd have 500 tags instead of 50000, but I assume that still causes about as many problems, and you'll be back to 50000 in just 100 more years anyway.

Sep 28 2016, 12:29 PM · Restricted Project, Restricted Project, Diffusion, Harbormaster
epriestley added a comment to T11706: Retrieve event date from Calendar "calendar.event.search" method API.

See some discussion in T7944, particularly T7944#194982.

Sep 28 2016, 12:10 PM · Calendar, Feature Request
epriestley added a comment to T9893: Support ElasticSearch 2.0 - 5.1.

We're planning to put application-level stemming on the MySQL index (see T6740). Are there problems with the InnoDB search that you're aware of that aren't fixable with application adjustments?

Sep 28 2016, 12:05 PM · Elasticsearch, Search
20after4 added a comment to T9893: Support ElasticSearch 2.0 - 5.1.

With InnoDB now mostly finished indexing, search seems to be working and the service isn't getting killed by locked tables. More info at the link I pasted above ^

Sep 28 2016, 8:56 AM · Elasticsearch, Search
gd added a comment to T8238: Formally support side-band change handoff in external repositories.

We see how bad this is (does pushing tags to the same repository create a big user-facing mess?) and then go from there.

Sep 28 2016, 8:31 AM · Restricted Project, Restricted Project, Diffusion, Harbormaster
immars added a comment to T11707: Creating master branch by default in diffusion.

a quick and dirty fix for this could be

Sep 28 2016, 8:12 AM · Diffusion, Feature Request
immars created T11707: Creating master branch by default in diffusion.
Sep 28 2016, 8:09 AM · Diffusion, Feature Request
apons created T11706: Retrieve event date from Calendar "calendar.event.search" method API.
Sep 28 2016, 7:19 AM · Calendar, Feature Request
andy.xu awarded T5427: Force a line break in a table cell a Like token.
Sep 28 2016, 6:41 AM · Remarkup
20after4 added a comment to T9893: Support ElasticSearch 2.0 - 5.1.

Wikimedia is considering another stab at elasticsearch because we just hit a fairly serious scalability issue with myisam (https://phabricator.wikimedia.org/T146673) and it looks like innodb isn't a lot better. In addition to that, the mysql fulltext engines don't seem to handle stemming or even simple prefix matching.

Sep 28 2016, 5:21 AM · Elasticsearch, Search
chad closed T11623: Make Conpherence send text with bare return key, like a chatroom as Resolved by committing Restricted Diffusion Commit.
Sep 28 2016, 2:54 AM · Conpherence (v4)
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 2:18 AM · Restricted Project, Prioritized, Calendar
joshuaspence added a comment to T11705: Repositories are getting stuck.

I clicked "Update Now" and the update frequency for our most active repository has dropped back down to 15 seconds.

Sep 28 2016, 2:04 AM · Diffusion, Daemons
joshuaspence created T11705: Repositories are getting stuck.
Sep 28 2016, 2:03 AM · Diffusion, Daemons
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 1:24 AM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 1:06 AM · Restricted Project, Prioritized, Calendar
chad added a project to T11704: Conpherence should have a 'joinable' search filter?: Conpherence.
Sep 28 2016, 12:57 AM · Conpherence (v4)
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 12:48 AM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 12:28 AM · Restricted Project, Prioritized, Calendar
20after4 added a comment to T8345: Add task tabs for "Mentions" and "Merged".

+1 for mentions, that would serve the same purpose as see also: or related tasks: would. Primarily it would just be nice to be able to see them in one place instead of hiding in comments...

Sep 28 2016, 12:22 AM · Restricted Project, FreeBSD, Maniphest
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 12:17 AM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 28 2016, 12:08 AM · Restricted Project, Prioritized, Calendar

Sep 27 2016

epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 27 2016, 11:39 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 27 2016, 11:30 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Restricted Differential Revision.
Sep 27 2016, 11:20 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 27 2016, 10:52 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 27 2016, 10:41 PM · Restricted Project, Prioritized, Calendar
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 27 2016, 10:32 PM · Restricted Project, Prioritized, Calendar
chad created T11704: Conpherence should have a 'joinable' search filter?.
Sep 27 2016, 10:27 PM · Conpherence (v4)
jcox closed T10715: Badge name on badge cards should be a link to the badge page as Resolved by committing Restricted Diffusion Commit.
Sep 27 2016, 7:31 PM · Contributor Onboarding, Badges
jcox added a revision to T10715: Badge name on badge cards should be a link to the badge page: Unknown Object (Differential Revision).
Sep 27 2016, 7:27 PM · Contributor Onboarding, Badges
chad added a comment to T11692: Open differential submission and public view.

@beber does setting EFL to "Public" resolve your issue?s

Sep 27 2016, 6:50 PM · Differential, Bug Report (Needs Information)
epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 27 2016, 6:41 PM · Restricted Project, Prioritized, Calendar
jcox closed T9063: Conduit application search as Resolved by committing Restricted Diffusion Commit.
Sep 27 2016, 6:34 PM · Contributor Onboarding, Restricted Project, Conduit
jcox added a revision to T9063: Conduit application search: Unknown Object (Differential Revision).
Sep 27 2016, 5:53 PM · Contributor Onboarding, Restricted Project, Conduit
bizrad6 added a comment to T11650: Owners does not assign as reviewer if an Owners package with the same path has been archived.

Yes, thanks!

Sep 27 2016, 5:47 PM · Restricted Project, Bug Report
chad added a comment to T11692: Open differential submission and public view.

https://phab.enlightenment.org/diffusion/EFL/ view policy is set to "All Users".

Sep 27 2016, 5:32 PM · Differential, Bug Report (Needs Information)
swisspol closed T11445: Commits with failed HarborMaster builds stuck in "Building" state in Diffusion as Invalid.

This has been solved AFAIK since I haven't seen this issue in a while.

Sep 27 2016, 5:12 PM · Bug Report
epriestley added a comment to T4190: Rebuild remarkup image proxying.

(I'll follow up on this once I have a chance to bang on it a bit, but I want to try to finish up the RRULE stuff while it's still somewhat fresh in my mind.)

Sep 27 2016, 5:03 PM · Contributor Onboarding, Remarkup
jcox closed T10681: Add Phurl Conduit API methods as Resolved by committing Restricted Diffusion Commit.
Sep 27 2016, 4:53 PM · Contributor Onboarding, Restricted Project, Conduit, Phurl
epriestley closed T11524: Import-time diff generation fails for particular commits in cluster mode as Resolved.

This went out a while ago and I confirmed the fix in production.

Sep 27 2016, 4:43 PM · Phacility, Clusters, Daemons, Diffusion
epriestley closed T11650: Owners does not assign as reviewer if an Owners package with the same path has been archived as Resolved.

I'm going to presume we got this, but reopen or yell if you're still seeing issues on the new code.

Sep 27 2016, 4:38 PM · Restricted Project, Bug Report
epriestley closed T11703: Floating point issue on points on workboards as Resolved by committing Restricted Diffusion Commit.
Sep 27 2016, 4:36 PM · Workboards, Bug Report
epriestley moved T11661: Change PhabricatorPhurlURLViewController to use EditEngine for commenting from Backlog to Basic on the Contributor Onboarding board.
Sep 27 2016, 4:35 PM · Contributor Onboarding, Modernization
epriestley added a project to T11661: Change PhabricatorPhurlURLViewController to use EditEngine for commenting: Contributor Onboarding.
Sep 27 2016, 4:35 PM · Contributor Onboarding, Modernization
epriestley edited projects for T11692: Open differential submission and public view, added: Bug Report (Needs Information); removed Bug Report.
Sep 27 2016, 4:33 PM · Differential, Bug Report (Needs Information)
epriestley claimed T11703: Floating point issue on points on workboards.
Sep 27 2016, 4:32 PM · Workboards, Bug Report
epriestley added a comment to T11703: Floating point issue on points on workboards.

Thanks for the report! The detailed reproduction instructions were very helpful in resolving this.

Sep 27 2016, 4:32 PM · Workboards, Bug Report
epriestley added a revision to T11703: Floating point issue on points on workboards: Unknown Object (Differential Revision).
Sep 27 2016, 4:31 PM · Workboards, Bug Report
chad added a comment to T11217: Make Tokens modular / real application.

I did order an iPhone 7 plus, so I'll have a better understanding if 2x is actually noticeably bad.

Sep 27 2016, 4:24 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
chad added a comment to T11217: Make Tokens modular / real application.

This isn't like something I'm looking for immediately, btw. Just like, next time I have to make 50 images.

Sep 27 2016, 4:18 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley added a comment to T11217: Make Tokens modular / real application.

I'm also not sure if we can use SVG as a data: URL in CSS. It probably should work, but if it doesn't we'll have to rasterize (and, I guess, serve 5+ different sizes to every user).

Sep 27 2016, 4:18 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley added a comment to T11217: Make Tokens modular / real application.

Alright -- we can have bin/celerity map rasterize SVG into arbitrary sizes if I'm not comfortable serving SVG directly from Celerity.

Sep 27 2016, 4:17 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
chad added a comment to T11217: Make Tokens modular / real application.

I'd like to generate 1 image and have them work 1x, 2x, 3x, etc or any size I need. I can't think of any other long term solution.

Sep 27 2016, 4:16 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley moved T10715: Badge name on badge cards should be a link to the badge page from Backlog to Basic on the Contributor Onboarding board.
Sep 27 2016, 4:12 PM · Contributor Onboarding, Badges
epriestley reassigned T10715: Badge name on badge cards should be a link to the badge page from lpriestley to jcox.
  • Create a badge.
  • Award it to a user.
  • Visit their profile page.
  • On the profile page, the badge title should link to the badge detail page (currently: no way to get to the badge detail page).
Sep 27 2016, 4:11 PM · Contributor Onboarding, Badges
epriestley moved T9063: Conduit application search from Backlog to Basic on the Contributor Onboarding board.
Sep 27 2016, 4:08 PM · Contributor Onboarding, Restricted Project, Conduit
epriestley reassigned T9063: Conduit application search from joshuaspence to jcox.

I'm not really sure this is actually useful given that every method is now named <application>.whatever and you can search by substring.

Sep 27 2016, 4:08 PM · Contributor Onboarding, Restricted Project, Conduit
epriestley added a comment to T11217: Make Tokens modular / real application.

(That will give us slightly bad scale-downs on 1X screens, but I bet they're not worse than scaling down an SVG would be.)

Sep 27 2016, 4:05 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley added a comment to T11217: Make Tokens modular / real application.

I think we can just do 2x in all cases for these, if that's reasonable?

Sep 27 2016, 4:04 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
chad added a comment to T11217: Make Tokens modular / real application.

fwiw, I want to convert all bitmaps to SVG if possible, so we can skip building 1x and 2x images.

Sep 27 2016, 4:01 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
chad added a comment to T11217: Make Tokens modular / real application.

Don't know if D16178 is worth comandeering? But feel free.

Sep 27 2016, 4:00 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley assigned T11217: Make Tokens modular / real application to jcox.

This one is a little scattered, so let me know where I can fill in any gaps. Most of the details are in D16178.

Sep 27 2016, 3:59 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley moved T11701: Add a lint rule for `if (CONSTANT) { ... }` from Backlog to Ready on the Contributor Onboarding board.
Sep 27 2016, 3:57 PM · Contributor Onboarding, Infrastructure, Arcanist, Lint
epriestley added a project to T11701: Add a lint rule for `if (CONSTANT) { ... }`: Contributor Onboarding.
Sep 27 2016, 3:57 PM · Contributor Onboarding, Infrastructure, Arcanist, Lint
epriestley moved T11217: Make Tokens modular / real application from Backlog to Intermediate on the Contributor Onboarding board.
Sep 27 2016, 3:47 PM · Restricted Project, Contributor Onboarding, Celerity, Tokens
epriestley reassigned T10681: Add Phurl Conduit API methods from lpriestley to jcox.
Sep 27 2016, 3:46 PM · Contributor Onboarding, Restricted Project, Conduit, Phurl
epriestley moved T10681: Add Phurl Conduit API methods from Backlog to Intermediate on the Contributor Onboarding board.
Sep 27 2016, 3:46 PM · Contributor Onboarding, Restricted Project, Conduit, Phurl
jcox added a revision to T10681: Add Phurl Conduit API methods : Unknown Object (Differential Revision).
Sep 27 2016, 2:34 PM · Contributor Onboarding, Restricted Project, Conduit, Phurl

Sep 26 2016

epriestley added a revision to T10747: Import and export ICS from Calendar: Unknown Object (Differential Revision).
Sep 26 2016, 10:50 PM · Restricted Project, Prioritized, Calendar
chad added a comment to T11703: Floating point issue on points on workboards.

Thanks!

Sep 26 2016, 9:34 PM · Workboards, Bug Report
isfs added a comment to T11687: No way to unsubscribe from a blog you created.

Thanks, Chad. I've just used the Administrators group and adjusted the EditEngine permissions, which is sufficient for us; anyone authoritative enough to create blogs is authoritative and technically proficient enough to have admin privs, too.

Sep 26 2016, 9:19 PM · Phame, Feature Request
rbalik created T11703: Floating point issue on points on workboards.
Sep 26 2016, 9:01 PM · Workboards, Bug Report
chad added a comment to T11702: Floating point issue on point totals.

Please see Contributing Bug Reports for what information is required for bug reports.

Sep 26 2016, 8:33 PM · Bug Report
chad closed T11702: Floating point issue on point totals as Invalid.
Sep 26 2016, 8:32 PM · Bug Report
mchamati closed Q495: It used to have an option in Phabricator to mark a task as duplicate. Where is this option? as resolved.
Sep 26 2016, 6:29 PM
rbalik created T11702: Floating point issue on point totals.
Sep 26 2016, 6:28 PM · Bug Report
chad added a comment to Q495: It used to have an option in Phabricator to mark a task as duplicate. Where is this option?.

On the right side in actions

Sep 26 2016, 6:23 PM
mchamati updated Q495: It used to have an option in Phabricator to mark a task as duplicate. Where is this option? from to It used to have an option in Phabricator to mark a task as duplicate. Where is this option?.
Sep 26 2016, 4:50 PM
yelirekim added a comment to T11693: Make drydock command interfaces accessible via SSH workflows.

(not building locally anymore, eg, any time I want to do anything with a built binary at all, i'm actually doing it with a binary on a remote server because I can get the build results faster)

Sep 26 2016, 4:44 PM · Restricted Project, Drydock
yelirekim added a comment to T11693: Make drydock command interfaces accessible via SSH workflows.

Well one facet of this is that remote servers tend to be significantly more powerful than developer machines, and so since I've implemented this downstream, I have basically taken to not building locally anymore.

Sep 26 2016, 4:43 PM · Restricted Project, Drydock
epriestley created T11701: Add a lint rule for `if (CONSTANT) { ... }`.
Sep 26 2016, 3:12 PM · Contributor Onboarding, Infrastructure, Arcanist, Lint
jcox added a revision to T4190: Rebuild remarkup image proxying: Restricted Differential Revision.
Sep 26 2016, 2:01 PM · Contributor Onboarding, Remarkup
• olivier-squid added a comment to T8135: drag & drop on a workboard sorted by priority behavior is surprising.
In T8135#195971, @chad wrote:

@olivier-squid is the main issue people don't know it's going to happen, or that we just get it wrong. Will the headers help or are you expecting this to just not happen at all when you drag (ie, no sort changes happen at all).

Sep 26 2016, 1:47 PM · Restricted Project, Workboards (v3), Restricted Project
chad closed T11687: No way to unsubscribe from a blog you created as Resolved.

Yeah, it makes sense to not auto-subscribe and I'm afraid I don't have better plans ready for cases where you don't want everyone creating blogs. You could at least make a group like "blog creators" and delegate.

Sep 26 2016, 1:37 PM · Phame, Feature Request
aubort added a comment to T11165: Changing a callsign throws a 404.

+1 it's very confusing

Sep 26 2016, 1:34 PM · Diffusion (v3), Bug Report
epriestley added a comment to T11693: Make drydock command interfaces accessible via SSH workflows.

Do you have any use cases which are not approximately some flavor of:

Sep 26 2016, 1:31 PM · Restricted Project, Drydock
johnny-bit added a comment to T8135: drag & drop on a workboard sorted by priority behavior is surprising.

Maaaybe Iam misinterpreting but if enabling sort by priority why not show in workboards something like

Sep 26 2016, 1:28 PM · Restricted Project, Workboards (v3), Restricted Project
chad added a comment to T8135: drag & drop on a workboard sorted by priority behavior is surprising.

@olivier-squid is the main issue people don't know it's going to happen, or that we just get it wrong. Will the headers help or are you expecting this to just not happen at all when you drag (ie, no sort changes happen at all).

Sep 26 2016, 1:27 PM · Restricted Project, Workboards (v3), Restricted Project
epriestley added a comment to T8135: drag & drop on a workboard sorted by priority behavior is surprising.

I mean, it's probably not worse-worse, and but it feels like trading one kind of confusion for possibly-moderately-less-confusion more than putting a reasonable stopgap behavior in place until we can fix it properly.

Sep 26 2016, 1:25 PM · Restricted Project, Workboards (v3), Restricted Project
epriestley added a comment to T8135: drag & drop on a workboard sorted by priority behavior is surprising.

Oh. To me, that's sort of worse? You end up with "Sort by priority" and your tasks aren't actually sorted by priority if you've moved them between columns, and jump around if you reload, and other users won't see the same ordering if they're trying to follow along in a presentation or whatever.

Sep 26 2016, 1:23 PM · Restricted Project, Workboards (v3), Restricted Project
chad added a comment to T8135: drag & drop on a workboard sorted by priority behavior is surprising.

I think I'm doing a bad job at saying that though.

Sep 26 2016, 1:22 PM · Restricted Project, Workboards (v3), Restricted Project
chad added a comment to T8135: drag & drop on a workboard sorted by priority behavior is surprising.

I'm suggesting removing it until T10333

Sep 26 2016, 1:22 PM · Restricted Project, Workboards (v3), Restricted Project
epriestley added a comment to T8135: drag & drop on a workboard sorted by priority behavior is surprising.

Sorry, I think I'm still not understanding. When the column is grouped by priority, I still expect the auto-reprioritize behavior to work more or less as it does today: if you drag a task into the "High" group, it will change to "High" priority. I don't think we can avoid that without greater confusion.

Sep 26 2016, 1:20 PM · Restricted Project, Workboards (v3), Restricted Project
chad added a comment to T8135: drag & drop on a workboard sorted by priority behavior is surprising.

I assume "Group by" would have dragging support, so by assignee, I could easily re-assign tasks. With that in mind "Group by" and priority, you could drag and drop by priority, thus allowing us to remove the "automatic" feature we have today in the current priority sort.

Sep 26 2016, 1:15 PM · Restricted Project, Workboards (v3), Restricted Project