Page MenuHomePhabricator
Feed Advanced Search

Feb 5 2018

epriestley triaged T13062: Trying to manage anything in Gsuite is kind of not great? as Wishlist priority.
Feb 5 2018, 3:51 PM · Phacility, Ops
epriestley added a comment to T11760: Phacility Cluster: Ad-Hoc Query Log.

We received our first credit card dispute on January 31st.

Feb 5 2018, 2:51 PM · Phacility
epriestley added a revision to T13048: Implement a "take action only when this rule didn't match last time" repetition policy for Herald: Unknown Object (Differential Revision).
Feb 5 2018, 2:05 PM · Herald

Feb 4 2018

epriestley added a revision to T10448: Modularize mail tags: Unknown Object (Differential Revision).
Feb 4 2018, 5:40 PM · Prioritized, Restricted Project, Mail, User Preferences, Owners, Feature Request
epriestley added a revision to T5554: arc fails with svn/git/hg non english locales: Unknown Object (Differential Revision).
Feb 4 2018, 3:53 PM · Arcanist
epriestley added a revision to T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable: Unknown Object (Differential Revision).
Feb 4 2018, 3:53 PM · Diffusion (v3)
epriestley added a revision to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails: Unknown Object (Differential Revision).
Feb 4 2018, 3:53 PM · Diffusion
epriestley added a comment to T5554: arc fails with svn/git/hg non english locales.

See some additional discussion in T13060 and T7339. Pretty much everything here remains unchanged, but those tasks discover an additional constrain: a parent process has LANG=POSIX (or similar, some non-UTF8 locale), it can not pass UTF8 to subprocesses in argument lists.

Feb 4 2018, 3:11 PM · Arcanist
epriestley added a comment to T12807: Diffusion's "Grep File Content" doesn't work with UTF characters.

See T13060 and T7339 for followups and additional discussion.

Feb 4 2018, 3:01 PM · Diffusion, Bug Report
epriestley added a comment to T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable.

D18988 addresses the issue from D18105 (git grep 🐑 fails) more directly by calling @setlocale(LC_ALL, 'en_US.UTF-8') unconditionally during startup. The motivating case in T13060 is:

Feb 4 2018, 2:59 PM · Diffusion (v3)
epriestley added a revision to T13061: Explain more clearly that "arc lint --everything" only lints stuff tracked by the VCS: Unknown Object (Differential Revision).
Feb 4 2018, 2:24 PM · Documentation, Arcanist
epriestley added a revision to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails: Unknown Object (Differential Revision).
Feb 4 2018, 2:09 PM · Diffusion
epriestley added a revision to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails: Unknown Object (Differential Revision).
Feb 4 2018, 2:01 PM · Diffusion
epriestley triaged T13061: Explain more clearly that "arc lint --everything" only lints stuff tracked by the VCS as Low priority.
Feb 4 2018, 1:45 PM · Documentation, Arcanist

Feb 3 2018

epriestley added a comment to T10817: Allow more characters for built-in `filename` linter.

(Future me, see also PHI343.)

Feb 3 2018, 8:09 PM · Lint, Feature Request
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

I think I didn't kick Apache hard enough since I eventually rammed this through with setlocale().

Feb 3 2018, 4:20 PM · Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

setlocale(...) doesn't (?) appear to work from within Apache (?).

Feb 3 2018, 4:15 PM · Diffusion
epriestley renamed T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails from Commits may partially fail to import when affecting files with UTF8 characters to When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.
Feb 3 2018, 4:07 PM · Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

Thankfully, it seems that setlocale(LC_ALL, 'en_US.UTF-8'); from within PHP does work, so we don't need to figure out what PAM initialization cache file Ubuntu is actually reading LANG settings from.

Feb 3 2018, 4:02 PM · Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

sudo update-locale LC_ALL=en_US.UTF-8 LANG=en_US.UTF-8 also does not work, although this is apparently just a Perl script that rewrites /etc/default/locale for you.

Feb 3 2018, 3:54 PM · Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

Setting LANG in /etc/environment had no effect on anything.

Feb 3 2018, 3:50 PM · Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

I now strongly believe this is some kind of terminal environment problem. This script has different behavior in production and on my laptop:

Feb 3 2018, 3:39 PM · Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

No luck, I don't even see any bugs in Differential locally with that change (the en-dash decodes and renders properly). So this might be in the realm of T7339.

Feb 3 2018, 2:04 PM · Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

Same result.

Feb 3 2018, 1:57 PM · Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

Same results for spaces.

Feb 3 2018, 1:54 PM · Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

To try to reproduce this, I did this:

Feb 3 2018, 1:53 PM · Diffusion
epriestley triaged T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails as Normal priority.
Feb 3 2018, 1:47 PM · Diffusion

Feb 2 2018

epriestley added a comment to T13053: Plans: Mail Tags and Failover.

Vaguely related, the subject line for this mail is currently something like:

Feb 2 2018, 11:07 PM · Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13053: Plans: Mail Tags and Failover.

🐱 🐟

Feb 2 2018, 11:03 PM · Plans, Must Encrypt Mail, Mail
epriestley added a project to T13053: Plans: Mail Tags and Failover: Must Encrypt Mail.
Feb 2 2018, 11:02 PM · Plans, Must Encrypt Mail, Mail
epriestley created Must Encrypt Mail.
Feb 2 2018, 10:56 PM
epriestley edited the content of Changelog.
Feb 2 2018, 9:29 PM
epriestley created 2018 Week 5 (Very Early February).
Feb 2 2018, 9:28 PM
epriestley updated the task description for T13059: Write a lint rule for detecting unreachable blocks.
Feb 2 2018, 5:12 PM · Arcanist, Lint
epriestley triaged T13059: Write a lint rule for detecting unreachable blocks as Normal priority.
Feb 2 2018, 5:07 PM · Arcanist, Lint
epriestley added a comment to T13053: Plans: Mail Tags and Failover.

contains complex HTML elements (like inline comments) which would also need to be stored in a structured way and then rendered just-in-time

Feb 2 2018, 4:30 PM · Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13053: Plans: Mail Tags and Failover.

While it's on my mind -- these messages link to /mail/whatever/123/ right now, but that page doesn't hyperlink links in the mail body, which is a fairly significant usability issue since the workflow is: click the link to go to the mail, read the mail body, copy paste the link in the mail body into your address bar.

Feb 2 2018, 4:25 PM · Plans, Must Encrypt Mail, Mail

Feb 1 2018

epriestley closed T11138: mail is not delivered if metamta.placeholder-to-recipient is null as Invalid.

This report doesn't include working reproduction instructions so we can't move forward.

Feb 1 2018, 10:58 PM · Mail, Bug Report
epriestley closed T12630: Phabricator fails with a fatal PHP error if it receives a mail with no plain text part as Resolved.

I can't reproduce this; it may have been fixed by D18776 + D18778.

Feb 1 2018, 10:54 PM · Mail, Bug Report
epriestley closed T13037: An attacker gained staff access to Mailgun and was able to read customer API keys as Resolved.

My call with Mailgun was generally reassuring. Based on an uncharitable reading of the January 5th disclosure, my major concern was that they might be starting from a cultural position which was blind to internal actors as threats and everyone just used root / hunter2 written on a sticky note to log in to everything or something like that.

Feb 1 2018, 9:42 PM · Phacility, Security, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 1 2018, 8:04 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 1 2018, 7:37 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 1 2018, 5:34 PM · Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13053: Plans: Mail Tags and Failover.

I suppose another reasonable attacker is "laptop thieves", but deleting any locally stored mail which was accidentally transmitted in the open seems like a reasonable way to recover from any confusion that arises until we figure out how foolproof the behavior needs to be.

Feb 1 2018, 5:05 PM · Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13053: Plans: Mail Tags and Failover.

The intended trigger for "Must Encrypt" is Herald rules like this:

Feb 1 2018, 5:03 PM · Plans, Must Encrypt Mail, Mail
epriestley added a revision to T13053: Plans: Mail Tags and Failover: Unknown Object (Differential Revision).
Feb 1 2018, 4:39 PM · Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13053: Plans: Mail Tags and Failover.

The "Must Encrypt" change will necessarily link into the existing /mail/ web UI so users can read the mail content, so it's probably worth considering possible improvements.

Feb 1 2018, 4:08 PM · Plans, Must Encrypt Mail, Mail
epriestley updated the task description for T13053: Plans: Mail Tags and Failover.
Feb 1 2018, 3:26 PM · Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13053: Plans: Mail Tags and Failover.

Although I'm suppressing the X-Phabricator-To and X-Phabricator-Cc headers for "Must Encrypt" mail (and the "To: ..." and "Cc: ..." footers in the body), the recipients will still be visible in the actual "To" and "Cc" lines if metamta.one-mail-per-recipient has been configured to false instead of the default (which is true).

Feb 1 2018, 3:24 PM · Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13053: Plans: Mail Tags and Failover.

On Thread-Topic, this very old thread suggests that Outlook can show the header in some cases: https://bugzilla.mozilla.org/show_bug.cgi?id=411601

Feb 1 2018, 3:14 PM · Plans, Must Encrypt Mail, Mail
epriestley updated the task description for T13053: Plans: Mail Tags and Failover.
Feb 1 2018, 3:02 PM · Plans, Must Encrypt Mail, Mail
epriestley added a comment to T13058: Indicate that the "upload file" modal dialog is doing something when uploading large files.

From rereading D18600, maybe "ridiculously strong" is an understatement and it was actually so powerful it took effect even if you didn't enable it.

Feb 1 2018, 3:16 AM
epriestley added a comment to T13058: Indicate that the "upload file" modal dialog is doing something when uploading large files.

Locally, seems like "No Notifications" correctly has no effect on the "Upload" bubble being shown at HEAD of master.

Feb 1 2018, 3:15 AM
epriestley added a comment to T13058: Indicate that the "upload file" modal dialog is doing something when uploading large files.

Not unless something super weird/buggy is going on.

Feb 1 2018, 3:13 AM
epriestley added a comment to T13058: Indicate that the "upload file" modal dialog is doing something when uploading large files.

It's possible that adjusting Settings → Notifications to No Notifications disables this bubble, if that's a compounding factor here. D18600 pulled back some of the aggressiveness of that setting but I'd guess it might still be hitting the upload progress bubbles.

Feb 1 2018, 3:11 AM
epriestley added a comment to T13058: Indicate that the "upload file" modal dialog is doing something when uploading large files.

What browser are you using? I get a progress bubble in the lower left immediately. Here's a screenshot -- note the blue upload progress element in the lower left corner.

Feb 1 2018, 3:07 AM

Jan 31 2018

epriestley closed T12800: When Excel opens a CSV file, it just runs whatever arbitrary code might be in the file as Resolved by committing Restricted Diffusion Commit.
Jan 31 2018, 11:33 PM · Security
epriestley added a revision to T13057: Formalize "reverts" and "resurrects" between revisions: Unknown Object (Differential Revision).
Jan 31 2018, 8:27 PM · Differential
epriestley updated the task description for T13053: Plans: Mail Tags and Failover.
Jan 31 2018, 7:26 PM · Plans, Must Encrypt Mail, Mail
epriestley updated the task description for T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction.
Jan 31 2018, 4:48 PM · Plans, Differential, Harbormaster
epriestley added a comment to T8232: Automatically claim a task when a differential is submitted.

I think T11934 and an explicit !claim Txxx action (which would mean "reassign + ref"; maybe with a !claim-and-fix Txxx to mean "reassign + fixes" or some kind of !claim+fix X syntax which expands to !claim <args>; !fix <args>) is a possible way forward on this, but I don't want to make "ref" automatically mean "claim".

Jan 31 2018, 3:51 PM · Differential, Maniphest
epriestley closed T10050: Differential-to-Asana integration, like with JIRA as Wontfix.

Because of the high degree of complexity there's basically zero chance we'll ever build this without active customer interest, and we have none today. Closing this until interest arises.

Jan 31 2018, 3:48 PM · Doorkeeper, Differential, Asana, Feature Request
epriestley closed T3906: Generalize the "Ref / Fixes" relationship between revisions and tasks in all systems as Wontfix.

We don't have any use cases for this today so I don't plan to pursue it. It's conceptually reasonable, but complex, and there's no customer interest.

Jan 31 2018, 3:45 PM · Restricted Project, Doorkeeper, Differential
epriestley added a comment to T3577: Web UI can only create "reference" relationships between Revisions and Tasks, not "close" relationships.

T11934 is a possible way forward on this (and other niche things) without adding a lot of Javascript and UI complexity, by supporting it through !fixes.

Jan 31 2018, 3:44 PM · Customer Impact, Maniphest, Differential
epriestley added a comment to T5132: Document the special syntax you can use in commit messages to cause effects.

One possible approach for this is:

Jan 31 2018, 3:41 PM · Guides, Diffusion
epriestley closed T1751: Consider ways to improve revert handling as Resolved.

I'm going to roll this forward into T13057.

Jan 31 2018, 3:39 PM · Restricted Project, Diffusion, Differential
epriestley triaged T13057: Formalize "reverts" and "resurrects" between revisions as Normal priority.
Jan 31 2018, 3:38 PM · Differential
epriestley closed T8345: Add task tabs for "Mentions" and "Merged" as Resolved.

We shipped "Mentions" and "Duplicates" some time ago.

Jan 31 2018, 3:13 PM · Restricted Project, FreeBSD, Maniphest
epriestley closed T8345: Add task tabs for "Mentions" and "Merged", a subtask of T10034: Plan the future of Maniphest task relationships, as Resolved.
Jan 31 2018, 3:13 PM · Maniphest
epriestley closed T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs as Resolved.

See T13056 for followup.

Jan 31 2018, 2:40 PM · Transactions, Ops, Phacility
epriestley triaged T13056: Remove "data" from edge infrastructure as Low priority.
Jan 31 2018, 2:40 PM · Infrastructure
epriestley added a comment to T13055: Maybe "translation.override" should be locked.

One attack is that you can override the content of email and then send invite or welcome mail that says whatever you want, whether the victim has a Phabricator account (welcome) or not (invite).

Jan 31 2018, 12:33 PM · Config, Security
epriestley triaged T13055: Maybe "translation.override" should be locked as Low priority.
Jan 31 2018, 4:20 AM · Config, Security
epriestley closed T6187: Allow query results to be exported to spreadsheet rendered in the browser as Wontfix.

After T13049 this is relatively within reach, but we haven't seen other requests for it so I don't currently plan to pursue it.

Jan 31 2018, 12:38 AM · ApplicationSearch
epriestley added a revision to T12800: When Excel opens a CSV file, it just runs whatever arbitrary code might be in the file: Unknown Object (Differential Revision).
Jan 31 2018, 12:25 AM · Security

Jan 30 2018

epriestley added a comment to T12800: When Excel opens a CSV file, it just runs whatever arbitrary code might be in the file.

This is relevant now that work related to T13049 has added CSV support.

Jan 30 2018, 11:54 PM · Security
epriestley closed T3461: Improve documentation around Maniphest Excel exports as Wontfix.

More or less obsoleted by work in T13049.

Jan 30 2018, 11:49 PM · Maniphest
epriestley closed T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.) as Resolved.

That's as far as I plan to take this for now. I think the additional features described above (filter, reorder, reformat, and broader field and application support) are all reasonable if use cases arise, but am not currently aware of use cases. We can return to that stuff when use cases arise.

Jan 30 2018, 11:48 PM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 30 2018, 9:35 PM · Plans, Data Exporters
epriestley triaged T13054: Plans: Harbormaster Interactions with Differential / Chaos Reduction as Normal priority.
Jan 30 2018, 8:53 PM · Plans, Differential, Harbormaster
epriestley added a comment to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs.

I just let that run for a while but it finished at some point:

Jan 30 2018, 8:43 PM · Transactions, Ops, Phacility
epriestley updated the task description for T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.).
Jan 30 2018, 8:38 PM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 30 2018, 8:16 PM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 30 2018, 8:07 PM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 30 2018, 7:52 PM · Plans, Data Exporters
epriestley closed T10655: Phacility cluster mail deliverability issue as Resolved.
Jan 30 2018, 7:14 PM · Ops, Phacility
epriestley added a comment to T10655: Phacility cluster mail deliverability issue .

I'm going to roll this forward into T12677 since SES managed to one-up this by a healthy margin in T12237.

Jan 30 2018, 7:14 PM · Ops, Phacility
epriestley added a comment to T13037: An attacker gained staff access to Mailgun and was able to read customer API keys.

(They got back to me and we're scheduling a call.)

Jan 30 2018, 7:01 PM · Phacility, Security, Mail
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 30 2018, 4:06 PM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 30 2018, 3:59 PM · Plans, Data Exporters
epriestley added a comment to T13037: An attacker gained staff access to Mailgun and was able to read customer API keys.

Mailgun has yet to respond to me after about three weeks, so I send them a followup.

Jan 30 2018, 3:25 PM · Phacility, Security, Mail
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 30 2018, 3:06 PM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 30 2018, 2:12 PM · Plans, Data Exporters
epriestley added a revision to T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.): Unknown Object (Differential Revision).
Jan 30 2018, 1:54 PM · Plans, Data Exporters
epriestley added a comment to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs.
...
 OPTIMIZE  Optimizing table "<instance>_audit"."audit_transaction"...
  DONE  Compacted table by 139 GB in 910,219ms.
...
Jan 30 2018, 12:53 PM · Transactions, Ops, Phacility
epriestley added a comment to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs.

The compaction completed overnight. I'm optimizing the tables now.

Jan 30 2018, 12:32 PM · Transactions, Ops, Phacility
epriestley added a comment to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs.

Pool is full again, repo is upgrading, edges are compacting on the instance shard.

Jan 30 2018, 3:23 AM · Transactions, Ops, Phacility
epriestley added a comment to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs.

web004 is deploying now.

Jan 30 2018, 3:16 AM · Transactions, Ops, Phacility
epriestley added a comment to T13051: Transaction edge storage is inefficient / an instance has 130GB of commit cross-refs.

web004 died abruptly so I'm going to fix that and deploy these changes at the same time.

Jan 30 2018, 3:12 AM · Transactions, Ops, Phacility

Jan 29 2018

epriestley updated the task description for T13049: Plans: Data Exporters (Excel, JSON, CSV, etc.).
Jan 29 2018, 11:10 PM · Plans, Data Exporters