Page MenuHomePhabricator
Feed Advanced Search

Jan 29 2016

epriestley closed T10229: In iOS Safari, buttons must be tapped twice to fire. as Resolved by committing Restricted Diffusion Commit.
Jan 29 2016, 2:55 PM · Safari, Mobile, Bug Report
epriestley closed T9969: Differential 1-up render doesn't trigger on iOS as Resolved by committing Restricted Diffusion Commit.
Jan 29 2016, 2:55 PM · Safari, Differential, Bug Report
epriestley added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

Specifically, this is my best guess at what's going on:

Jan 29 2016, 2:55 PM · Safari, Differential, Bug Report
epriestley claimed T9969: Differential 1-up render doesn't trigger on iOS.
Jan 29 2016, 2:48 PM · Safari, Differential, Bug Report
epriestley claimed T10229: In iOS Safari, buttons must be tapped twice to fire..
Jan 29 2016, 2:47 PM · Safari, Mobile, Bug Report
epriestley added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

I've marked D15135 as fixing this out of a general abundance of sunny optimism.

Jan 29 2016, 1:58 PM · Safari, Differential, Bug Report
epriestley added a comment to T9969: Differential 1-up render doesn't trigger on iOS.

I think D15135 actually fixes this. I can't reproduce it in iOS Simulator after applying that patch.

Jan 29 2016, 1:57 PM · Safari, Differential, Bug Report
epriestley added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

D15136 distinguishes between "touch-device" mouseovers and "mouse-device" mouseovers rather than relying on device detection, since the screen resolution of the iPad Pro is apparently a billion pixels by a trillion pixels and device detection is clearly increasingly hopeless.

Jan 29 2016, 1:51 PM · Safari, Mobile, Bug Report
epriestley added a revision to T10229: In iOS Safari, buttons must be tapped twice to fire.: Unknown Object (Differential Revision).
Jan 29 2016, 1:49 PM · Safari, Mobile, Bug Report
epriestley added a comment to T10229: In iOS Safari, buttons must be tapped twice to fire..

Nice work! I arrived at the same conclusion shortly after you did.

Jan 29 2016, 1:09 PM · Safari, Mobile, Bug Report
epriestley added a revision to T9969: Differential 1-up render doesn't trigger on iOS: Unknown Object (Differential Revision).
Jan 29 2016, 1:00 PM · Safari, Differential, Bug Report
epriestley added a revision to T10229: In iOS Safari, buttons must be tapped twice to fire.: Unknown Object (Differential Revision).
Jan 29 2016, 1:00 PM · Safari, Mobile, Bug Report
epriestley reopened T10229: In iOS Safari, buttons must be tapped twice to fire. as "Open".

I can reproduce this on my iPhone 4s which correctly selects 1-up mode, so I agree that this is probably not a duplicate of T9969.

Jan 29 2016, 12:57 PM · Safari, Mobile, Bug Report
epriestley added a comment to T10239: Ability to pass more info to custom linters.

(Oh, there's a missing comma after e in some of the output above, but that's just because I typed the replacement text for the patch wrong in my "linter".)

Jan 29 2016, 11:53 AM · Feature Request
epriestley added a comment to T10239: Ability to pass more info to custom linters.

Here's what I did:

Jan 29 2016, 11:52 AM · Feature Request
epriestley added a comment to T10239: Ability to pass more info to custom linters.

(Where "XYZ" and "QWERTY" can be arbitrarily long sequences and may each contain zero or more newlines, and may each be of arbitrary length -- you can replace a single character with a huge block, or vice versa, etc. -- lint is not line-oriented internally.)

Jan 29 2016, 2:18 AM · Feature Request
epriestley added a comment to T10239: Ability to pass more info to custom linters.

The expectation is that this will just work properly already. We have a number of similar rules in the upstream.

Jan 29 2016, 2:17 AM · Feature Request
epriestley added a comment to T10239: Ability to pass more info to custom linters.
  • Emit messages for every line with a problem.
  • If you raise them at "warning" severity, they will only be shown if the user modified the line.
Jan 29 2016, 1:02 AM · Feature Request

Jan 28 2016

epriestley closed T10238: File remains 'attached' to a ticket even once removed from any current comment as Wontfix.

This is intentional. The file is visible in the UI in the edit history of the comment, and still part of the object in that sense.

Jan 28 2016, 10:45 PM · Maniphest, Files, Bug Report
epriestley added a comment to T5240: Dragging items (cards, panels) could be better in Workboards.

I think we can do the background drag thing too, that shouldn't interact poorly with anything else (I think? Probably?).

Jan 28 2016, 9:21 PM · Projects (v3), Workboards
epriestley closed T10226: diffusion blame: Only first line number is highlighted as Resolved by committing Restricted Diffusion Commit.
Jan 28 2016, 7:17 PM · Diffusion, Bug Report
epriestley added a revision to T10226: diffusion blame: Only first line number is highlighted: Unknown Object (Differential Revision).
Jan 28 2016, 7:10 PM · Diffusion, Bug Report
epriestley created P1933 WMFLockTaskController.php.
Jan 28 2016, 6:06 PM
epriestley created P1932 WMFLockTaskEventListener.php.
Jan 28 2016, 6:05 PM
epriestley created P1931 WMFExtensionsApplication.php.
Jan 28 2016, 6:05 PM
epriestley closed T7160: Allow administrators to irrevocably destroy all data for a cancelled instance as Resolved.

bin/host destroy exists now and no one has specifically asked for this, so I think it's OK to leave it as an "email us" option until the workload justifies making it explicit.

Jan 28 2016, 5:37 PM · Phacility
epriestley closed T10166: Build a permanent destruction workflow for Phacility instances as Resolved.

I've implemented this and relieved pressure on db005, although see followup in T10236.

Jan 28 2016, 5:37 PM · Phacility
epriestley created T10236: Enable `innodb_file_per_table` and migrate existing databases in the cluster.
Jan 28 2016, 5:36 PM · Phacility
mliberty awarded T7125: Provide tooling to for periodic reminders (like renewing domains and update SSL certificates) a Like token.
Jan 28 2016, 3:14 PM · Calendar
epriestley added a revision to T10228: Switching imported repository to hosted, then cloning over HTTP in Phacility production fails: Unknown Object (Differential Revision).
Jan 28 2016, 2:40 PM · Phacility, Diffusion
joshuaspence added a project to T10234: When using a PhabricatorRemarkupCustomInlineRule with caching disabled, custom rules may end up with incorrect engines: Remarkup.
Jan 28 2016, 9:51 AM · Remarkup, Bug Report
epriestley closed T10234: When using a PhabricatorRemarkupCustomInlineRule with caching disabled, custom rules may end up with incorrect engines as Invalid.

Sorry, we don't offer support for custom development. See Support Resources and Contributing Bug Reports for details.

Jan 28 2016, 5:17 AM · Remarkup, Bug Report

Jan 27 2016

epriestley added a comment to T10233: arc error message unclear for accepted revision in "plan change" state.

Would this phrasing be more clear?

Jan 27 2016, 10:48 PM · Restricted Project, Bug Report
epriestley closed T10231: öl as Spite.
Jan 27 2016, 9:56 PM · Feature Request
rdfree50 awarded T9905: Upgrading: ApplicationEditor changes in Maniphest a Love token.
Jan 27 2016, 8:08 PM · Maniphest, Installing & Upgrading
epriestley created T10228: Switching imported repository to hosted, then cloning over HTTP in Phacility production fails.
Jan 27 2016, 5:36 PM · Phacility, Diffusion
epriestley added a comment to T7303: Provide OAuth access to Conduit.

Please see Planning. We update tasks when new information is available, we don't have a secret shadow tracker with lots of juicy secrets that we aren't sharing.

Jan 27 2016, 3:55 PM · Restricted Project, Conduit, Restricted Project
mliberty awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Jan 27 2016, 6:03 AM · Workboards (v3), Restricted Project

Jan 26 2016

epriestley closed T10213: Edit project menu got 404 as Resolved by committing Restricted Diffusion Commit.
Jan 26 2016, 4:26 PM · Bug Report
epriestley closed T10223: Documentation uses removed `--global` argument to `arc set-config` as Resolved by committing Restricted Diffusion Commit.
Jan 26 2016, 4:26 PM · Arcanist, Documentation, Bug Report
epriestley added a revision to T10213: Edit project menu got 404: Unknown Object (Differential Revision).
Jan 26 2016, 3:29 PM · Bug Report
epriestley claimed T10223: Documentation uses removed `--global` argument to `arc set-config`.
Jan 26 2016, 3:29 PM · Arcanist, Documentation, Bug Report
epriestley closed T10218: S3 storage completely broken after 10 jan 2016 as Invalid.

There is no cache mechanism which would be cleared by adjusting configuration that is not also cleared by restarting the webserver and daemons, so it sounds like this was caused by evil spirits.

Jan 26 2016, 3:26 PM · Bug Report
epriestley added a revision to T10223: Documentation uses removed `--global` argument to `arc set-config`: Unknown Object (Differential Revision).
Jan 26 2016, 3:23 PM · Arcanist, Documentation, Bug Report
epriestley renamed T10222: Consider soft-locked and mergeable EditEngine field settings from Creating a subtask no longer copies project from supertask to Consider soft-locked and mergeable EditEngine field settings.
Jan 26 2016, 3:15 PM · ApplicationEditor, Feature Request
exp10r3r awarded Roadmap a Love token.
Jan 26 2016, 9:01 AM
exp10r3r awarded T9378: Build Projects v3 a Love token.
Jan 26 2016, 8:40 AM · Projects (v3), Prioritized

Jan 25 2016

epriestley added a comment to T10218: S3 storage completely broken after 10 jan 2016.

This is the policy on the IAM user:

Jan 25 2016, 9:33 PM · Bug Report
epriestley added a comment to T10219: Show suggested lint autofix in Differential web view.

Can you give me an example of a rule which is sometimes wrong and where the implied patch is not obvious from the rule name?

Jan 25 2016, 5:35 PM · Lint, Differential
epriestley added a comment to T10218: S3 storage completely broken after 10 jan 2016.

It may also be useful to run arc unit --everything in libphutil/, as that will trigger a number of signature-related test cases.

Jan 25 2016, 5:32 PM · Bug Report
epriestley added a comment to P1853 InsecureRemarkupGraphvizBlockInterpreter.php.

PhabricatorEmbedFileRemarkupRule has the "correct" solution for this problem, via a chain of permissions grants tied together with KEY_EMBED_FILE_PHIDS. This will grant the file the same permissions as the relevant object (e.g., the task or whatever).

Jan 25 2016, 5:26 PM
epriestley added a comment to T10218: S3 storage completely broken after 10 jan 2016.

Broadly, here's a command string (with live, active credentials) which works for me to put data into an eu-west-1 bucket:

Jan 25 2016, 5:14 PM · Bug Report
epriestley added a comment to T10218: S3 storage completely broken after 10 jan 2016.

I can't reproduce this. Before we move further, it looks like libphutil may be out of date?

Jan 25 2016, 5:12 PM · Bug Report
epriestley added a comment to T10218: S3 storage completely broken after 10 jan 2016.

We are too; that's expected to work correctly.

Jan 25 2016, 5:01 PM · Bug Report
epriestley added a comment to T10218: S3 storage completely broken after 10 jan 2016.

Thanks. I'll bring up a eu-west-1 bucket and see if I can reproduce this.

Jan 25 2016, 4:55 PM · Bug Report
epriestley added a comment to T10218: S3 storage completely broken after 10 jan 2016.

Can you show me the output of this command on your system?

Jan 25 2016, 4:16 PM · Bug Report
epriestley closed T10217: reStructuredText appears twice in the syntax highlighting dropdown as Resolved by committing Restricted Diffusion Commit.
Jan 25 2016, 2:47 PM · Config, Paste, Bug Report
epriestley claimed T10217: reStructuredText appears twice in the syntax highlighting dropdown.
Jan 25 2016, 2:47 PM · Config, Paste, Bug Report
epriestley added a revision to T10217: reStructuredText appears twice in the syntax highlighting dropdown: Unknown Object (Differential Revision).
Jan 25 2016, 2:46 PM · Config, Paste, Bug Report
epriestley set the color for Abuse to Yellow.
Jan 25 2016, 11:27 AM
epriestley added a revision to T10054: Define product direction for Project/Profile UIs: Unknown Object (Differential Revision).
Jan 25 2016, 11:23 AM · Projects
epriestley moved T4909: Rate limit or restrict access to comment removal from Backlog to Monitor on the Abuse board.
Jan 25 2016, 11:06 AM · Abuse, Wikimedia
epriestley moved T7593: Allow administrators to disable files to prevent "l33t w4r3z" abuse cases from Backlog to Monitor on the Abuse board.
Jan 25 2016, 11:06 AM · Abuse, Files
epriestley moved T10215: Provide tools to combat and recover from abuse from Backlog to Monitor on the Abuse board.
Jan 25 2016, 11:06 AM · Abuse
epriestley added a project to T10215: Provide tools to combat and recover from abuse: Abuse.
Jan 25 2016, 11:06 AM · Abuse
epriestley added a project to T7593: Allow administrators to disable files to prevent "l33t w4r3z" abuse cases: Abuse.
Jan 25 2016, 11:05 AM · Abuse, Files
epriestley edited projects for T4909: Rate limit or restrict access to comment removal, added: Abuse; removed Maniphest.
Jan 25 2016, 11:05 AM · Abuse, Wikimedia
epriestley created T10215: Provide tools to combat and recover from abuse.
Jan 25 2016, 11:05 AM · Abuse
epriestley removed a member for Abuse: epriestley.
Jan 25 2016, 10:58 AM
epriestley created Abuse.
Jan 25 2016, 10:57 AM
epriestley updated subscribers of T10214: Daemons try and fail to publish transactions for newly created diffs.
Jan 25 2016, 10:29 AM · Bug Report
epriestley merged task T9338: PhabricatorApplicationTransactionPublishWorker errors with Unable to load transactions into T10214: Daemons try and fail to publish transactions for newly created diffs.
Jan 25 2016, 10:29 AM · Daemons
epriestley added a comment to T9338: PhabricatorApplicationTransactionPublishWorker errors with Unable to load transactions.

At least some of these were likely T10214. I'm just going to merge this there until more evidence crops up.

Jan 25 2016, 10:29 AM · Daemons
epriestley added a comment to T10213: Edit project menu got 404.

I also can't reproduce this here or locally. I tried several different projects, and tried users with and without permission to edit the menu.

Jan 25 2016, 10:28 AM · Bug Report
epriestley closed T10214: Daemons try and fail to publish transactions for newly created diffs as Resolved.

This should be resolved by D15112. I've made a note in T9789 to catch this class of issue sooner before we make the consequences more dire by pursuing changes planned there.

Jan 25 2016, 10:20 AM · Bug Report
epriestley updated the task description for T9789: Make it easier to write custom transaction types.
Jan 25 2016, 10:19 AM · Modernization, Transactions

Jan 24 2016

epriestley added a revision to T10163: Remarkup Autocomplete Errata: Unknown Object (Differential Revision).
Jan 24 2016, 10:43 PM · Remarkup, Typeahead
joshuaspence added a comment to T10163: Remarkup Autocomplete Errata.

The only issue that I've noticed so far is that @{article: triggers the autocomplete, whereas it probably should not.

Jan 24 2016, 9:36 PM · Remarkup, Typeahead
epriestley closed T10144: Document why projects will never affect visibility as Resolved by committing Restricted Diffusion Commit.
Jan 24 2016, 6:02 PM · Projects, Documentation, Feature Request
epriestley closed T6501: Expose project icons and other metadata through project.query as Resolved by committing Restricted Diffusion Commit.
Jan 24 2016, 6:02 PM · Projects, Conduit
epriestley added a revision to T10144: Document why projects will never affect visibility: Unknown Object (Differential Revision).
Jan 24 2016, 5:42 PM · Projects, Documentation, Feature Request
epriestley added a revision to T10144: Document why projects will never affect visibility: Unknown Object (Differential Revision).
Jan 24 2016, 5:24 PM · Projects, Documentation, Feature Request
epriestley claimed T6501: Expose project icons and other metadata through project.query.
Jan 24 2016, 3:28 PM · Projects, Conduit
epriestley added a comment to T6501: Expose project icons and other metadata through project.query.

After D15105:

Jan 24 2016, 3:25 PM · Projects, Conduit
epriestley added a revision to T6501: Expose project icons and other metadata through project.query: Unknown Object (Differential Revision).
Jan 24 2016, 3:22 PM · Projects, Conduit
epriestley added a revision to T10054: Define product direction for Project/Profile UIs: Unknown Object (Differential Revision).
Jan 24 2016, 2:36 PM · Projects
epriestley added Q288: Importing from another Phabricator install (Answer 316).
Jan 24 2016, 1:19 PM
techdragon awarded T10115: Upgrading: Unique, Sensible Repository Slugs a Mountain of Wealth token.
Jan 24 2016, 1:05 PM · Diffusion, Installing & Upgrading
epriestley renamed T10199: NSS on Red Hat derivative OSes does not support ECC cipher-suites and can not connect to CloudFlare HTTPS from cURL: User defined ciphers to NSS on Red Hat derivative OSes does not support ECC cipher-suites and can not connect to CloudFlare HTTPS.
Jan 24 2016, 12:37 PM · Infrastructure
epriestley added a comment to T10199: NSS on Red Hat derivative OSes does not support ECC cipher-suites and can not connect to CloudFlare HTTPS.

This looks like a known issue with implementors using NSS instead of OpenSSL. Here's the Red Hat bug:

Jan 24 2016, 12:36 PM · Infrastructure
• oysterFAKE awarded T9378: Build Projects v3 a Love token.
Jan 24 2016, 3:40 AM · Projects (v3), Prioritized
epriestley added a revision to T10054: Define product direction for Project/Profile UIs: Unknown Object (Differential Revision).
Jan 24 2016, 1:15 AM · Projects
epriestley added a comment to T10212: Toggling syntax highlighting in Diffusion causes Unhandled Exception.

This should be fixed in HEAD. Thanks for the report!

Jan 24 2016, 1:10 AM · Diffusion, Bug Report
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Jan 24 2016, 1:09 AM
epriestley closed T10212: Toggling syntax highlighting in Diffusion causes Unhandled Exception as Resolved by committing Restricted Diffusion Commit.
Jan 24 2016, 1:07 AM · Diffusion, Bug Report
epriestley claimed T10212: Toggling syntax highlighting in Diffusion causes Unhandled Exception.
Jan 24 2016, 1:05 AM · Diffusion, Bug Report
epriestley added a revision to T10212: Toggling syntax highlighting in Diffusion causes Unhandled Exception: Unknown Object (Differential Revision).
Jan 24 2016, 1:04 AM · Diffusion, Bug Report

Jan 23 2016

epriestley moved T4863: Allow Workboard Cards to be customized for display from Projects v3 to Future on the Projects board.
Jan 23 2016, 8:34 PM · Projects, Workboards, Wikimedia
epriestley added a comment to T10199: NSS on Red Hat derivative OSes does not support ECC cipher-suites and can not connect to CloudFlare HTTPS.

What system are you on that doesn't support this cipher?

Jan 23 2016, 8:31 PM · Infrastructure
epriestley closed T10211: wrong text, if you recreate a destroyed credential as Resolved by committing Restricted Diffusion Commit.
Jan 23 2016, 8:26 PM · Passphrase, Bug Report