Page MenuHomePhabricator
Feed Advanced Search

Jun 11 2015

epriestley added a revision to T5681: Allow applications to provide custom policy rules: Unknown Object (Differential Revision).
Jun 11 2015, 7:55 PM · FreeBSD, Policy
epriestley added a comment to T5681: Allow applications to provide custom policy rules.

@20after4, D13252 changes the signature of two methods in PhabricatorPolicyRule:

Jun 11 2015, 7:26 PM · FreeBSD, Policy
epriestley added a revision to T5681: Allow applications to provide custom policy rules: Unknown Object (Differential Revision).
Jun 11 2015, 7:24 PM · FreeBSD, Policy
epriestley added a revision to T5681: Allow applications to provide custom policy rules: Unknown Object (Differential Revision).
Jun 11 2015, 7:08 PM · FreeBSD, Policy
epriestley added a revision to T6860: Allow creation of parameterized application policies: Unknown Object (Differential Revision).
Jun 11 2015, 7:08 PM · Policy
epriestley added a subtask for T6860: Allow creation of parameterized application policies: T5681: Allow applications to provide custom policy rules.
Jun 11 2015, 7:05 PM · Policy
epriestley added a parent task for T5681: Allow applications to provide custom policy rules: T6860: Allow creation of parameterized application policies.
Jun 11 2015, 7:05 PM · FreeBSD, Policy
epriestley closed T6306: Add a "members of associated projects" visibility setting to repositories as Wontfix.

It will be possible to define this rule locally after T5681, but I don't anticipate bringing it upstream.

Jun 11 2015, 7:04 PM · Projects, Diffusion
epriestley closed T8496: Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages as Resolved.

Presuming this is resolved since we found a reasonable explanation for the case above. Let me know if anyone is still seeing issues.

Jun 11 2015, 6:33 PM · Restricted Project, Auth
epriestley added a comment to T8376: Develop Spaces (v1).

Maybe -- it's linked for me, and I would expect it to be linked for you because you have access to the space:

Jun 11 2015, 6:30 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley closed T8515: Differential comments show incorrect state as Resolved.

This was fixed by rP9c82881c, which is slightly ahead of you.

Jun 11 2015, 6:00 PM · Differential
epriestley added a subtask for T8434: Accommodate the "Security" workflow: T5681: Allow applications to provide custom policy rules.
Jun 11 2015, 5:50 PM · Wikimedia, Policy, Prioritized
epriestley added a parent task for T5681: Allow applications to provide custom policy rules: T8434: Accommodate the "Security" workflow.
Jun 11 2015, 5:50 PM · FreeBSD, Policy
epriestley claimed T5681: Allow applications to provide custom policy rules.

We want this for T8488 and it's probably a component in moving T8434 forward.

Jun 11 2015, 5:49 PM · FreeBSD, Policy
epriestley added a comment to T8376: Develop Spaces (v1).

Per T8498, you can now send mail to test-space-bugs@phabricator.com to create tasks directly in S2 (join Space Test Users first if you can't see it). T8514 is an example.

Jun 11 2015, 5:30 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley set the image for Spaces to F494326: project.png.
Jun 11 2015, 5:27 PM
epriestley set the icon for Spaces to fa-cloud.
Jun 11 2015, 5:26 PM
epriestley closed T8503: Feed query may fail to progress while paging on 32-bit systems as Resolved by committing Restricted Diffusion Commit.
Jun 11 2015, 5:23 PM · Conduit
epriestley removed a subtask for T8320: Bring Owners out of the dark ages: T8426: permit owners to be bound to an "external thing" or let owners be determined by an extension.
Jun 11 2015, 5:00 PM · Prioritized, Owners
epriestley removed a parent task for T8426: permit owners to be bound to an "external thing" or let owners be determined by an extension: T8320: Bring Owners out of the dark ages.
Jun 11 2015, 5:00 PM · Restricted Project, FreeBSD, Owners
epriestley moved T8427: Make owners typeahead browsable so installs can have more than 100 packages from Backlog to Dark Ages on the Owners board.
Jun 11 2015, 5:00 PM · Owners
epriestley moved T8428: Allow packages to be disabled from Backlog to Dark Ages on the Owners board.
Jun 11 2015, 5:00 PM · Owners
epriestley added a comment to T8513: `differential.querydiffs` returns array instead of object when lacking permissions.

Ah, interesting. I'm glad to hear it's been working out (although I'm a little surprised!).

Jun 11 2015, 4:52 PM · Conduit
epriestley added a comment to T8503: Feed query may fail to progress while paging on 32-bit systems.

Yell if that doesn't actually fix things once it lands, but I'm pretty confident it's the issue.

Jun 11 2015, 4:46 PM · Conduit
epriestley added a revision to T8503: Feed query may fail to progress while paging on 32-bit systems: Unknown Object (Differential Revision).
Jun 11 2015, 4:45 PM · Conduit
epriestley renamed T8503: Feed query may fail to progress while paging on 32-bit systems from Awarding a token breaks parts of conduit to Feed query may fail to progress while paging on 32-bit systems.
Jun 11 2015, 4:43 PM · Conduit
epriestley added a comment to T8513: `differential.querydiffs` returns array instead of object when lacking permissions.

I'm also not sure how well arc patch handoff has been working for you, but T8090 has some discussion of some more reliable approaches we're evaluating and moving toward.

Jun 11 2015, 4:41 PM · Conduit
epriestley updated subscribers of T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
Jun 11 2015, 4:39 PM · Restricted Project, FreeBSD, Arcanist
epriestley merged task T8513: `differential.querydiffs` returns array instead of object when lacking permissions into T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
Jun 11 2015, 4:39 PM · Conduit
epriestley added a comment to T8513: `differential.querydiffs` returns array instead of object when lacking permissions.

This is an artifact of the PHP json_encode() method's rules for guessing whether a PHP array is an JSON object or a JSON list.

Jun 11 2015, 4:39 PM · Conduit
epriestley added a revision to T8498: Integrate Spaces into shared infrastructure: Unknown Object (Differential Revision).
Jun 11 2015, 4:34 PM · FreeBSD, Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8449: Spaces v1 Errata: Unknown Object (Differential Revision).
Jun 11 2015, 4:23 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley updated the task description for T8498: Integrate Spaces into shared infrastructure.
Jun 11 2015, 2:44 PM · FreeBSD, Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8498: Integrate Spaces into shared infrastructure: Unknown Object (Differential Revision).
Jun 11 2015, 2:30 PM · FreeBSD, Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8498: Integrate Spaces into shared infrastructure: Unknown Object (Differential Revision).
Jun 11 2015, 2:06 PM · FreeBSD, Spaces, Wikimedia, Policy, Prioritized
epriestley added a comment to T8376: Develop Spaces (v1).

Development Log

Jun 11 2015, 2:02 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley added a comment to T8503: Feed query may fail to progress while paging on 32-bit systems.

Thanks! 99% sure that's the fix, then: you're on a 32-bit system and the 'int' type can't represent the 64-bit chronologicalKey.

Jun 11 2015, 1:25 PM · Conduit
epriestley added a comment to T8503: Feed query may fail to progress while paging on 32-bit systems.

It's possible that the paging code is breaking somehow, although I still haven't been able to reproduce this and can't see any way it could. Can you log the value of $cursor passed to getPagingValueMap() each time through the loop? It should look like this:

Jun 11 2015, 1:11 PM · Conduit
epriestley closed T8502: Add Audit/Review status to Maniphest as Wontfix.

We aren't interested in making this a default.

Jun 11 2015, 12:59 PM · Maniphest
catalindazoot awarded T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction a Mountain of Wealth token.
Jun 11 2015, 12:55 PM · Herald
epriestley added a comment to T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction.

Thanks! I think D13245 should really fix this.

Jun 11 2015, 12:54 PM · Herald
epriestley closed T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction as Resolved by committing Restricted Diffusion Commit.
Jun 11 2015, 12:53 PM · Herald
epriestley closed T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction, a subtask of T8455: Herald rules with mailing lists are broken after mailing list -> user migration, as Resolved.
Jun 11 2015, 12:53 PM · Herald, Mailing Lists, Restricted Project
epriestley added a comment to T8345: Add task tabs for "Mentions" and "Merged".

Although T4207 is sort of related, in that it proposes a new kind of "parent/child" relationship (distinct from "blocks / blocked by").

Jun 11 2015, 12:52 PM · Restricted Project, FreeBSD, Maniphest
epriestley added a comment to T8345: Add task tabs for "Mentions" and "Merged".

Oh, sorry, I completely misread, ignore me.

Jun 11 2015, 12:47 PM · Restricted Project, FreeBSD, Maniphest
epriestley added a comment to T8345: Add task tabs for "Mentions" and "Merged".

See T4207 for task graphs.

Jun 11 2015, 12:47 PM · Restricted Project, FreeBSD, Maniphest
epriestley added a revision to T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction: Unknown Object (Differential Revision).
Jun 11 2015, 12:45 PM · Herald
epriestley closed T8512: Test Task #4 as Invalid.
Jun 11 2015, 12:20 PM
epriestley created T8512: Test Task #4.
Jun 11 2015, 12:19 PM
epriestley closed T8511: Test Task #3 as Wontfix.
Jun 11 2015, 12:19 PM
epriestley created T8511: Test Task #3.
Jun 11 2015, 12:19 PM
epriestley closed T8507: SKIP STAGING as Wontfix.

There is no way to disable this.

Jun 11 2015, 12:08 PM
jayvdb awarded T8232: Automatically claim a task when a differential is submitted a Like token.
Jun 11 2015, 3:18 AM · Differential, Maniphest
joshuaspence created T8506: LESS Linter does not use path in linter message.
Jun 11 2015, 1:45 AM · Lint

Jun 10 2015

epriestley added a revision to T8449: Spaces v1 Errata: Restricted Differential Revision.
Jun 10 2015, 11:57 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley shifted T8376: Develop Spaces (v1) from the S1 Core space to the S3 Hyperspace space.
Jun 10 2015, 11:52 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley added a revision to T8498: Integrate Spaces into shared infrastructure: Unknown Object (Differential Revision).
Jun 10 2015, 11:51 PM · FreeBSD, Spaces, Wikimedia, Policy, Prioritized
joshuaspence created T8505: Extending testing functionality.
Jun 10 2015, 9:36 PM · libphutil, Infrastructure
epriestley added a comment to T8496: Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages.

You can likely work around it in the meantime by setting isEmailVerified to 1 in that table. (I expect D13239 will land in the next few hours.)

Jun 10 2015, 9:16 PM · Restricted Project, Auth
epriestley added a comment to T8496: Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages.

Sorry, bad at reading. Yeah, that's the issue. D13239 will fix things.

Jun 10 2015, 9:15 PM · Restricted Project, Auth
epriestley added a comment to T8496: Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages.

Oh, is auth.email-domains set?

Jun 10 2015, 9:15 PM · Restricted Project, Auth
joshuaspence closed T8473: Garbage collect old notifications as Resolved by committing Restricted Diffusion Commit.
Jun 10 2015, 8:55 PM · Notifications
epriestley added a comment to T8442: Build Space switching UI.

I poked at this a bit, but it doesn't feel great to me, at least with the current header design:

Jun 10 2015, 8:39 PM · Restricted Project, Spaces, Wikimedia, Policy
epriestley renamed T8496: Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages from login fail to Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages.
Jun 10 2015, 8:30 PM · Restricted Project, Auth
epriestley added a comment to T8496: Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages.

D13239 will fix this in some cases.

Jun 10 2015, 8:29 PM · Restricted Project, Auth
epriestley added a revision to T8496: Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages: Unknown Object (Differential Revision).
Jun 10 2015, 8:24 PM · Restricted Project, Auth
epriestley added a comment to T8496: Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages.

Maybe. Do you have approval queues on, or email verification on?

Jun 10 2015, 8:16 PM · Restricted Project, Auth
epriestley added a comment to T8496: Inactive users are unable to establish web sessions in order to see "You must wait for approval" messages.

I can't reproduce this locally.

Jun 10 2015, 8:12 PM · Restricted Project, Auth
epriestley added a comment to T8503: Feed query may fail to progress while paging on 32-bit systems.

(If you can, set debug.time-limit to 10 and then repro it; it should give you a more useful stack trace.)

Jun 10 2015, 8:07 PM · Conduit
epriestley added a comment to T8503: Feed query may fail to progress while paging on 32-bit systems.

Can you reproduce this by calling feed.query manually from the web UI?

Jun 10 2015, 8:06 PM · Conduit
epriestley added a revision to T8377: Build the core "Spaces" Application: Unknown Object (Differential Revision).
Jun 10 2015, 7:42 PM · Spaces, Wikimedia, Policy
epriestley closed T8484: Maniphest query, order by "Date Updated", inverse ordering as Resolved by committing Restricted Diffusion Commit.
Jun 10 2015, 7:21 PM · Maniphest
epriestley added a comment to T8502: Add Audit/Review status to Maniphest.

No problem, let us know if you run into anything else.

Jun 10 2015, 6:10 PM · Maniphest
epriestley added a comment to T8502: Add Audit/Review status to Maniphest.

You can use maniphest.statuses in Config to create, remove, or change statuses.

Jun 10 2015, 6:04 PM · Maniphest
epriestley added a revision to T8377: Build the core "Spaces" Application: Unknown Object (Differential Revision).
Jun 10 2015, 4:07 PM · Spaces, Wikimedia, Policy
epriestley added a comment to T8442: Build Space switching UI.

I'm also still not totally sure that we need/want icons. I'm probably going to do a diff where we just use the icon everywhere and see if that looks reasonable or not. If it's better than names, we can go from there.

Jun 10 2015, 4:00 PM · Restricted Project, Spaces, Wikimedia, Policy
epriestley added a comment to T8442: Build Space switching UI.

Hmm.. I'm not sure if we'd pick up enough generic/flexible icons to justify adding it. A lot of the icons seem not-generic-enough or duplicated in Font Awesome.

Jun 10 2015, 3:52 PM · Restricted Project, Spaces, Wikimedia, Policy
epriestley added a comment to T8442: Build Space switching UI.

After thinking about this, I sort of like reserving some of the more geometric shapes for Badges (T6526), since v1 is probably going to have to use icons.

Jun 10 2015, 3:34 PM · Restricted Project, Spaces, Wikimedia, Policy
epriestley closed T8500: Test Task 2 as Invalid.
Jun 10 2015, 2:56 PM
epriestley added a comment to T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction.

I can't reproduce this. I created T8499 and immediately received mail about it to my "molepeople" list:

Jun 10 2015, 2:55 PM · Herald
epriestley created T8500: Test Task 2.
Jun 10 2015, 2:51 PM
epriestley closed T8499: Molepeople Test as Invalid.
Jun 10 2015, 2:48 PM
epriestley created T8499: Molepeople Test.
Jun 10 2015, 2:48 PM
epriestley added a comment to T8376: Develop Spaces (v1).

Development Log

Jun 10 2015, 2:39 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley closed T8424: Integrate Spaces into the core policy infrastructure as Resolved.

This looks like it's done, although we may revisit it after T8434 has a more solid path forward.

Jun 10 2015, 2:33 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley closed T8424: Integrate Spaces into the core policy infrastructure, a subtask of T8376: Develop Spaces (v1), as Resolved.
Jun 10 2015, 2:33 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley added a comment to T8491: Show a file in Diffusion without knowing the branch.

If you want to pick some unobjectionable "default" token which is not a valid tag or branch name in Git or Mercurial (and, ideally, unlikely to ever be a valid ref in any VCS) I'm happy to implement that and shove it in the documentation. Not great, but seems least-bad to me.

Jun 10 2015, 1:55 PM · Restricted Project, Diffusion
epriestley added a comment to T8491: Show a file in Diffusion without knowing the branch.

I think the original form only worked by accident, we don't use it in the UI anywhere. This behavior likely changed when I fixed T7100.

Jun 10 2015, 1:52 PM · Restricted Project, Diffusion
epriestley added a comment to T8493: Integrate Spaces into more applications.

I'm not sure how much I'd trust a !space command to be honest.

Jun 10 2015, 1:40 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley created T8498: Integrate Spaces into shared infrastructure.
Jun 10 2015, 12:42 PM · FreeBSD, Spaces, Wikimedia, Policy, Prioritized
epriestley added a comment to T8493: Integrate Spaces into more applications.

I think the difference with the Wikimedia Procurement use case is that tasks with files are created via email (i.e. a provider sends an offer to an email address).

Jun 10 2015, 12:33 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a comment to T8493: Integrate Spaces into more applications.

At HEAD, the underlying use case discussed on that task should already be secure:

Jun 10 2015, 12:23 PM · Spaces, Wikimedia, Policy, Prioritized
joshuaspence added a revision to T8473: Garbage collect old notifications: Unknown Object (Differential Revision).
Jun 10 2015, 12:16 PM · Notifications
epriestley added a comment to T8441: Integrate Spaces into ApplicationSearch.

Here's how it works slightly-ahead-of-HEAD:

Jun 10 2015, 12:08 PM · Spaces, Wikimedia, Policy, Prioritized
joshuaspence merged T8494: Autoloader throws if class does not exist into T1116: Function __phutil_autoload should probably not throw an exception if it is the only registered autoload function.
Jun 10 2015, 11:15 AM · libphutil
joshuaspence merged task T8494: Autoloader throws if class does not exist into T1116: Function __phutil_autoload should probably not throw an exception if it is the only registered autoload function.
Jun 10 2015, 11:15 AM · libphutil
joshuaspence added a comment to T8454: User approval not working.

No, I'm not using auth.email-domains.

Jun 10 2015, 11:02 AM · People
joshuaspence claimed T8495: Write a linter wrapper for PHPDCD.
Jun 10 2015, 11:00 AM · Lint
joshuaspence claimed T8475: Clean up remnants of old Differential hunk storage.
Jun 10 2015, 11:00 AM · Infrastructure, Restricted Project, Differential
joshuaspence claimed T8476: Rename `phabricator_repository` database.
Jun 10 2015, 11:00 AM · Restricted Project, Database, Diffusion