Maniphest T8515

Differential comments show incorrect state
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	mrkanaly
	Jun 11 2015, 5:47 PM

Tags

Referenced Files

	F494336: 2015-06-11_10-41-57.png
	Jun 11 2015, 5:47 PM

	F494334: 2015-06-11_10-45-13.png
	Jun 11 2015, 5:47 PM

	F494338: 2015-06-11_10-43-04.png
	Jun 11 2015, 5:47 PM

Subscribers

Description

After selecting the "Done" box on several inline comments, adding a general comment, and submitting, the inline comments now show an incorrect state. Inline comments that were submitted by OTHER users, now show as unsubmitted. The timeline entry of the revision also shows that "I marked 0 comments as not done"

2015-06-11_10-45-13.png (426×950 px, 31 KB)

2015-06-11_10-41-57.png (173×465 px, 8 KB)

Related Objects

Mentioned Here: rP9c82881cac2e: Fix "unmarked 0 inline comments as not undone" transactions
T8483: Odd text in inline comment transaction
rARC7d15b85a1bc0: Mark some strings for translation
rPHU92882eb9404d: Mark some strings for translation
rPf47e69c01594: Mark some strings for translation

Event Timeline

mrkanaly created this task.Jun 11 2015, 5:47 PM

mrkanaly assigned this task to epriestley.

mrkanaly raised the priority of this task from to Normal.

mrkanaly updated the task description. (Show Details)

mrkanaly added a project: Differential.

mrkanaly updated the task description. (Show Details)

mrkanaly added a subscriber: mrkanaly.

Are you at HEAD?

Did an upgrade earlier this week, so probably pretty close... here are the commit hashes.

Phabricator	f47e69c01594e504e63a25f2083b051c998b60e2
Libphutil	92882eb9404da16ba2ea498c1182cd3c1278877f
Arcanist	7d15b85a1bc099e34a3bbf194fc8f92c33bc69a9

This was fixed by rP9c82881c, which is slightly ahead of you.

See T8483.

Awww. my google-foo has failed. Good deal.