Page MenuHomePhabricator
Feed Advanced Search

May 18 2015

joshuaspence added a comment to T7604: Remove "Arcanist Projects".

Ah nice.

May 18 2015, 12:03 AM · Diffusion
joshuaspence placed T7286: Re-evaluate whether passing GET data in the body is a good idea up for grabs.

I haven't actually done anything on this.

May 18 2015, 12:02 AM · libphutil
joshuaspence edited projects for T8165: Investigate high CPU usage, added: Performance; removed Infrastructure.
May 18 2015, 12:01 AM · Performance
joshuaspence added a parent task for T8042: PhutilUnitTestEngine can't execute a single test path: T7215: ArcanistXMLLinterTestCase test failure.
May 18 2015, 12:00 AM · Arcanist
joshuaspence added a subtask for T7215: ArcanistXMLLinterTestCase test failure: T8042: PhutilUnitTestEngine can't execute a single test path.
May 18 2015, 12:00 AM · Lint

May 17 2015

joshuaspence added a comment to T7215: ArcanistXMLLinterTestCase test failure.

This will be much easier to test after T8042.

May 17 2015, 11:59 PM · Lint
joshuaspence closed T8231: exception in arc which as Resolved by committing Restricted Diffusion Commit.
May 17 2015, 11:41 PM · Arcanist
joshuaspence closed T8215: Revert detection in Diffusion crosses repositories as Resolved by committing Restricted Diffusion Commit.
May 17 2015, 11:40 PM · Diffusion
epriestley added a comment to T7604: Remove "Arcanist Projects".

We have logic to determine the repository already (you can see it at the user-facing level in arc which, for example). You should just be able to remove projects completely, I believe.

May 17 2015, 10:58 PM · Diffusion
joshuaspence added a member for Symbols: joshuaspence.
May 17 2015, 10:43 PM
joshuaspence closed T8207: Add linter rule to prevent exceptions from being thrown in a __toString method as Resolved by committing Restricted Diffusion Commit.
May 17 2015, 10:23 PM · Lint
joshuaspence created T8232: Automatically claim a task when a differential is submitted.
May 17 2015, 10:15 PM · Differential, Maniphest
joshuaspence added a revision to T8231: exception in arc which: Unknown Object (Differential Revision).
May 17 2015, 10:05 PM · Arcanist
joshuaspence updated subscribers of T7604: Remove "Arcanist Projects".

@epriestley, do you have any idea how Differential would work without Arcanist Projects? My only thought is that we could do some sort of Conduit call to determine the repository. Probably this should happen server-side I guess.

May 17 2015, 9:35 PM · Diffusion
epriestley closed T8228: 'link' type in custom fields does not work as Invalid.

Your version of Phabricator is from April 16th. The "link" field type was added about a week later, on April 24th. See D12543.

May 17 2015, 3:56 PM · Projects
epriestley added a comment to T8228: 'link' type in custom fields does not work.

What version of Phabricator are you running? You can find it in the header in Config → All Settings. It should look like this:

May 17 2015, 3:08 PM · Projects
epriestley added a revision to T8219: Remove phutil_exit(): Unknown Object (Differential Revision).
May 17 2015, 3:06 PM
epriestley created T8227: Why not just add an option/setting/preference?.
May 17 2015, 2:09 PM · Guides
epriestley closed T8224: While Phabricator web request is running, MySQL aborts other independant connections as Invalid.

We run a large number of SQL queries, including large SQL queries, and hold a large number of connections open simultaneously. On a properly configured database, none of these behaviors should abort other unrelated connections.

May 17 2015, 1:27 PM
epriestley added a comment to T8225: Permission denied error when pushing to hosted Git repository.

I notice /opt/bitnami in your path. If you're using a Bitnami image, you should seek support from them. We do not offer support for third-party packages. See T4200 for some discussion.

May 17 2015, 1:11 PM · Diffusion
epriestley updated subscribers of T5558: Fix the bog of questionable value that is Project detail pages.
May 17 2015, 1:10 PM · Projects, Dashboards
epriestley merged task T8226: Projects should link to source, documentation etc... into T5558: Fix the bog of questionable value that is Project detail pages.
May 17 2015, 1:10 PM · Projects
epriestley added a comment to T8226: Projects should link to source, documentation etc....

You can edit the task description and add whatever links you want.

May 17 2015, 1:09 PM · Projects
epriestley added a comment to T6920: Move Voting in Ponder to "Helpfuls".

No. There is no task tracking that. T3578#90847 has a small amount of discussion.

May 17 2015, 1:08 PM · Ponder
• JamesRamm awarded T4558: Make Diviner useful for third-parties a Like token.
May 17 2015, 9:49 AM · Diviner
• JamesRamm awarded T4558: Make Diviner useful for third-parties a Pterodactyl token.
May 17 2015, 9:49 AM · Diviner
epriestley added a comment to T8208: Create a plan for consistent use of icons, colors and text style when rendering Calendar events.

Maybe more in-line with that intent would be "orange dot = away for less than X hours". That information is available by clicking through, but not part of the dot. But that doesn't cover "I'm working, but have family in town and will take longer than usual to respond". See more discussion in T8183.

May 17 2015, 4:44 AM · Calendar
epriestley added a comment to T8216: Make mailKey-related errors more obvious when testing new mail code.

Thanks.

May 17 2015, 2:42 AM · Projects
epriestley added a revision to T8203: Make Phacility account import default to "ignore" and confirm imports: Unknown Object (Differential Revision).
May 17 2015, 2:09 AM · Phacility
epriestley closed T7811: Phacility Cluster: Apache exited on repo001.phacility.net as Resolved.
  • I added logrotate configuration as part of the deploy process for hosts running apache.
  • I added swap configuration as part of the deploy process and enabled 16GB of swap for repo-tier hosts.
  • Things have been consistently stable since making the original changes.
  • I also recently added more billing-status review tools and pruned a bunch more demo/test instances, which gave us more headroom here (host load is currently hovering comfortably around 0.60, with physical memory only about 90% consumed).
May 17 2015, 12:54 AM · Phacility
epriestley renamed T7811: Phacility Cluster: Apache exited on repo001.phacility.net from Apache exited on repo001.phacility.net to Phacility Cluster: Apache exited on repo001.phacility.net.
May 17 2015, 12:22 AM · Phacility

May 16 2015

epriestley added a revision to T7769: $0 invoices should be automatically payable: Unknown Object (Differential Revision).
May 16 2015, 8:08 PM · Phortune, Phacility
epriestley added a revision to T7769: $0 invoices should be automatically payable: Unknown Object (Differential Revision).
May 16 2015, 8:02 PM · Phortune, Phacility
epriestley added a comment to T8216: Make mailKey-related errors more obvious when testing new mail code.

We should fix this permanently since this is something like the third time we've hit it and it's super dumb that this mistake is possible (you'll hit this pathway only if your email is configured in a certain way). Some possible approaches:

May 16 2015, 3:01 PM · Projects
epriestley closed T5694: AphrontWriteGuard was not properly disposed of as Resolved.

I've removed this error completely (see rPHUbd087f55).

May 16 2015, 2:26 PM · Aphront
epriestley created T8219: Remove phutil_exit().
May 16 2015, 2:20 PM
epriestley closed T8218: Image embeding failed as Resolved.
May 16 2015, 2:02 PM · Remarkup, Files
epriestley edited the content of 2015 Week 20 (Mid May).
May 16 2015, 1:26 PM
epriestley edited the content of Changelog.
May 16 2015, 1:25 PM
epriestley created 2015 Week 20 (Mid May).
May 16 2015, 1:25 PM
epriestley triaged T8216: Make mailKey-related errors more obvious when testing new mail code as Normal priority.
May 16 2015, 1:09 PM · Projects
joshuaspence added a revision to T8215: Revert detection in Diffusion crosses repositories: Unknown Object (Differential Revision).
May 16 2015, 7:13 AM · Diffusion
joshuaspence added a comment to T8215: Revert detection in Diffusion crosses repositories.

Out of curiosity, why do you have the same repository imported multiple times?

May 16 2015, 5:23 AM · Diffusion
joshuaspence claimed T8215: Revert detection in Diffusion crosses repositories.

Seems fair enough. I'll take a crack at this seeing as I implemented a lot of the revert stuff.

May 16 2015, 5:22 AM · Diffusion
epriestley updated subscribers of T8216: Make mailKey-related errors more obvious when testing new mail code.

I'll headed to bed right now but I'll probably fix this tomorrow morning and cowboy commit it before deploying, just a heads up for when that lands.

May 16 2015, 4:43 AM · Projects
epriestley merged task T8214: Support repeating events in Calendar into Restricted Maniphest Task.
May 16 2015, 12:34 AM · Calendar

May 15 2015

epriestley added a revision to T7829: PhabricatorBotFeedNotificationHandler is completely broken and unusable: Restricted Differential Revision.
May 15 2015, 10:06 PM · Conpherence, Phabot
epriestley changed the visibility for T524: OpenID Authentication as an Auth Option.
May 15 2015, 9:52 PM · Phabricator
btrahan awarded T8210: Phacility Cluster: Bastion host stopped responding a Doubloon token.
May 15 2015, 8:10 PM · Ops, Phacility
epriestley closed T8212: Add an option to configure `security.require-multi-factor-auth` to cluster admin console as Resolved by committing Restricted Diffusion Commit.
May 15 2015, 7:45 PM · Phacility
epriestley added a revision to T8212: Add an option to configure `security.require-multi-factor-auth` to cluster admin console: Unknown Object (Differential Revision).
May 15 2015, 7:25 PM · Phacility
epriestley renamed T7829: PhabricatorBotFeedNotificationHandler is completely broken and unusable from Cannot get PhabricatorBotFeedNotificationHandler configured to work correctly to PhabricatorBotFeedNotificationHandler is completely broken and unusable.
May 15 2015, 7:09 PM · Conpherence, Phabot
epriestley merged task T6911: PhabricatorBotFeedNotificationHandler ignores notification.channels into T7829: PhabricatorBotFeedNotificationHandler is completely broken and unusable.
May 15 2015, 7:09 PM · Conpherence, Phabot
epriestley updated subscribers of T7829: PhabricatorBotFeedNotificationHandler is completely broken and unusable.
May 15 2015, 7:09 PM · Conpherence, Phabot
epriestley merged task T8213: ChatBot Feed Notification not working into T7829: PhabricatorBotFeedNotificationHandler is completely broken and unusable.
May 15 2015, 7:08 PM · Phabot
epriestley updated subscribers of T7829: PhabricatorBotFeedNotificationHandler is completely broken and unusable.
May 15 2015, 7:08 PM · Conpherence, Phabot
epriestley closed T8209: Migrations which use handles may fail after introduction of cache columns as Resolved by committing Restricted Diffusion Commit.
May 15 2015, 6:55 PM
epriestley closed T8211: Cluster backup locks may exceed 64-byte lock length limit as Resolved by committing Restricted Diffusion Commit.
May 15 2015, 6:54 PM · Phacility
epriestley created T8212: Add an option to configure `security.require-multi-factor-auth` to cluster admin console.
May 15 2015, 6:53 PM · Phacility
chad awarded T8206: Make authorize-user part of bastion deployment a Mountain of Wealth token.
May 15 2015, 6:14 PM · Phacility
epriestley added a revision to T8211: Cluster backup locks may exceed 64-byte lock length limit: Unknown Object (Differential Revision).
May 15 2015, 5:52 PM · Phacility
epriestley added a comment to T8206: Make authorize-user part of bastion deployment.

I also realigned the use of DNS. We now use:

May 15 2015, 5:45 PM · Phacility
epriestley added a comment to T8204: Stop using EC2 micro instances.

I've converted the bastion host to an m3.large instance.

May 15 2015, 5:43 PM · Phacility
epriestley closed T8206: Make authorize-user part of bastion deployment, a subtask of T8210: Phacility Cluster: Bastion host stopped responding, as Resolved.
May 15 2015, 5:42 PM · Ops, Phacility
epriestley closed T8206: Make authorize-user part of bastion deployment as Resolved.

Deploying a bastion host now synchronizes account, key and sudoer state automatically.

May 15 2015, 5:42 PM · Phacility
epriestley edited the content of Phacility Cluster CLI Tools.
May 15 2015, 5:41 PM
epriestley edited the content of Adding Hardware.
May 15 2015, 5:40 PM
epriestley edited the content of Adding Hardware.
May 15 2015, 5:40 PM
epriestley created T8211: Cluster backup locks may exceed 64-byte lock length limit.
May 15 2015, 5:35 PM · Phacility
epriestley updated the task description for T8210: Phacility Cluster: Bastion host stopped responding.
May 15 2015, 2:51 PM · Ops, Phacility
epriestley updated subscribers of T7338: Build more status tools for monitoring Phacility cluster health.
May 15 2015, 1:19 PM · Almanac, Phacility
epriestley renamed T7338: Build more status tools for monitoring Phacility cluster health from BES EOL determine strategy to sunset in place to Build more status tools for monitoring Phacility cluster health.
May 15 2015, 1:18 PM · Almanac, Phacility
epriestley added a parent task for T8205: Add timeouts to commands executed through the bastion: T8210: Phacility Cluster: Bastion host stopped responding.
May 15 2015, 1:10 PM · Phacility
epriestley added a parent task for T8206: Make authorize-user part of bastion deployment: T8210: Phacility Cluster: Bastion host stopped responding.
May 15 2015, 1:10 PM · Phacility
epriestley added a parent task for T8203: Make Phacility account import default to "ignore" and confirm imports: T8210: Phacility Cluster: Bastion host stopped responding.
May 15 2015, 1:10 PM · Phacility
epriestley added a parent task for T8204: Stop using EC2 micro instances: T8210: Phacility Cluster: Bastion host stopped responding.
May 15 2015, 1:10 PM · Phacility
epriestley added subtasks for T8210: Phacility Cluster: Bastion host stopped responding: T8206: Make authorize-user part of bastion deployment, T8205: Add timeouts to commands executed through the bastion, T8204: Stop using EC2 micro instances, T8203: Make Phacility account import default to "ignore" and confirm imports.
May 15 2015, 1:10 PM · Ops, Phacility
epriestley created T8210: Phacility Cluster: Bastion host stopped responding.
May 15 2015, 1:09 PM · Ops, Phacility
epriestley added a comment to T8208: Create a plan for consistent use of icons, colors and text style when rendering Calendar events.

Depending on exactly how T8026 sorts out, we might also have a stronger "public event" vs "private event" state in the future.

May 15 2015, 1:00 PM · Calendar
epriestley renamed T8208: Create a plan for consistent use of icons, colors and text style when rendering Calendar events from Placeholder for the fate of the dots in user handles (previously used for labeling "away" or "sporadic" status of a user, based on Calendar availability) to Create a plan for consistent use of icons, colors and text style when rendering Calendar events.
May 15 2015, 12:56 PM · Calendar
epriestley added a comment to T4571: Allow Phabricator to run in Read-Only Mode.

In T8209, we hit an issue where a migration performed a cache fill as a side effect of loading handles. This created a problem because the cache fill happened from a migration that runs before the cache was introduced.

May 15 2015, 12:54 PM · Phacility
epriestley added a comment to T8209: Migrations which use handles may fail after introduction of cache columns.

In the long term, I think we should probably add an interaction with T4571 to reduce the likelihood of these issues. I'll make some notes there.

May 15 2015, 12:47 PM
epriestley added a revision to T8209: Migrations which use handles may fail after introduction of cache columns: Unknown Object (Differential Revision).
May 15 2015, 12:46 PM
epriestley added a comment to T8183: Remove "Away" and "Sporadic" statuses..

D12857 should fix the issue with list views (including /upcoming/).

May 15 2015, 12:39 PM · Calendar
epriestley added a revision to T8183: Remove "Away" and "Sporadic" statuses.: Unknown Object (Differential Revision).
May 15 2015, 12:39 PM · Calendar
epriestley added a comment to T8183: Remove "Away" and "Sporadic" statuses..

Ah, thanks! I'll clean that up.

May 15 2015, 12:32 PM · Calendar
epriestley created T8209: Migrations which use handles may fail after introduction of cache columns.
May 15 2015, 12:31 PM
joshuaspence added a revision to T8207: Add linter rule to prevent exceptions from being thrown in a __toString method: Unknown Object (Differential Revision).
May 15 2015, 6:19 AM · Lint
joshuaspence claimed T8207: Add linter rule to prevent exceptions from being thrown in a __toString method.
May 15 2015, 6:16 AM · Lint
epriestley added a comment to T8208: Create a plan for consistent use of icons, colors and text style when rendering Calendar events.

One other signal we could use is adding or removing backgrounds from icons, if we add them:

May 15 2015, 4:00 AM · Calendar
epriestley added a comment to T8208: Create a plan for consistent use of icons, colors and text style when rendering Calendar events.

Few different parts:

May 15 2015, 3:50 AM · Calendar
joshuaspence added a revision to T8156: Linter failures don't provide relevant stacktraces: Unknown Object (Differential Revision).
May 15 2015, 2:23 AM · Arcanist, Lint
joshuaspence created T8207: Add linter rule to prevent exceptions from being thrown in a __toString method.
May 15 2015, 1:55 AM · Lint
epriestley created T8206: Make authorize-user part of bastion deployment.
May 15 2015, 1:47 AM · Phacility
epriestley created T8205: Add timeouts to commands executed through the bastion.
May 15 2015, 1:30 AM · Phacility
epriestley created T8204: Stop using EC2 micro instances.
May 15 2015, 1:29 AM · Phacility
epriestley added a comment to T550: Build an SSH conduit client.

... on the host

May 15 2015, 12:39 AM · Prioritized, Arcanist, Restricted Project, Restricted Project, Conduit
epriestley added a comment to T550: Build an SSH conduit client.

I'd exec ssh directly. If there's some major advantage to using libssh2 (but what?), I'd possibly use that optionally if it was available on the host.

May 15 2015, 12:37 AM · Prioritized, Arcanist, Restricted Project, Restricted Project, Conduit
epriestley closed T8201: Breaking UserConduitAPIMethod.php error as Resolved.

Should be fixed in HEAD. Thanks for the report!

May 15 2015, 12:24 AM · People, Conduit
epriestley added a revision to T8201: Breaking UserConduitAPIMethod.php error : Unknown Object (Differential Revision).
May 15 2015, 12:24 AM · People, Conduit