Page MenuHomePhabricator
Feed Advanced Search

Oct 15 2015

epriestley edited the content of Phacility Cluster Devices.
Oct 15 2015, 6:44 PM
epriestley edited the content of Phacility Cluster Devices.
Oct 15 2015, 6:44 PM
epriestley created T9581: Expand Phacility cluster repo and db tiers (add nodes: 004).
Oct 15 2015, 6:38 PM · Ops, Phacility
epriestley added a comment to T9580: Slow POST/PUTs.

(We caught up in IRC.)

Oct 15 2015, 6:34 PM · Phacility Support
epriestley added a comment to T9579: Outbound mail stopped working. Large items 'Queued'. ./bin/mail send-test works..

We can't reproduce this issue, other installs haven't reported similar problems, and you're about two months behind HEAD. Please refer to this document for instructions on filing an actionable bug report which we can help you with:

Oct 15 2015, 5:44 PM · Mail
epriestley closed T9551: Strip strange characters out of project hashtags, or support parsing strange hashtag characters in other contexts as Resolved.

One followup in T9573 but I don't think anything exploded, otherwise.

Oct 15 2015, 5:21 PM · Prioritized, Projects
epriestley closed T9273: Replace PhabricatorMarkupInterface with a better-suited API/abstraction as Resolved by committing Restricted Diffusion Commit.
Oct 15 2015, 5:20 PM · Prioritized, Remarkup
epriestley added a revision to T9273: Replace PhabricatorMarkupInterface with a better-suited API/abstraction: Unknown Object (Differential Revision).
Oct 15 2015, 5:09 PM · Prioritized, Remarkup
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

I also tried using the ref name (refs/tags/phabricator/diff/123) and the tag name (phabricator/diff/123) as branch names without success, so I'm pretty sure this isn't fixable on our side.

Oct 15 2015, 4:43 PM · Restricted Project, Harbormaster
epriestley added a revision to T9456: Evaluate upstream support for third-party build systems: Unknown Object (Differential Revision).
Oct 15 2015, 4:38 PM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

This basically works, but there's a minor problem which I can't fix on our side that stops things from working: CircleCI does not git fetch --tags, and does not fetch the tag explicitly when building a tag. It does resolve the tag, but never actually downloads the corresponding commit. This means that tags and other refs which are not ancestors of a branch head (which is to say: everything in the staging area) are not buildable. I don't think I can work around this because we need the commit to be fetched in order to make it to the checkout: post: step.

Oct 15 2015, 4:34 PM · Restricted Project, Harbormaster
epriestley closed T9577: Why do workboards have story point displays and limits if there's no way to customize the size of a card? as Wontfix.

I think I misunderstood and by "size" you just meant "point value". This will happen eventually as part of other projects work (T9378, T3670) but those need to happen first. I'm not yet sure if we're going to make this a first-class value or let you designate a custom field as a "points field" or something else.

Oct 15 2015, 3:12 PM · Workboards
epriestley added a comment to T9577: Why do workboards have story point displays and limits if there's no way to customize the size of a card?.

Your expectation is that a card worth 10 points is rendered 10 times larger than a card worth 1 point?

Oct 15 2015, 2:59 PM · Workboards
epriestley closed T9573: Documents with " - " space hyphen space are inaccessible as Resolved by committing Restricted Diffusion Commit.
Oct 15 2015, 2:04 PM · Phriction
epriestley added a comment to T9576: "Send an email when projects include X" Herald rule ignores the "Ignore subscriber changes" email notification preference.

This is definitely something which can be improved -- the transcript has been updated recently and is fairly clear ("Forced Mail", "...ignoring notification preferences..."). The /mail/ UI is fairly clear too, but hard to find right now. Other UIs and interactions haven't been updated as recently and aren't as clear.

Oct 15 2015, 2:02 PM · Notifications
epriestley added a comment to T9576: "Send an email when projects include X" Herald rule ignores the "Ignore subscriber changes" email notification preference.

See also this in the transcript:

Oct 15 2015, 1:17 PM · Notifications
epriestley added a comment to T9576: "Send an email when projects include X" Herald rule ignores the "Ignore subscriber changes" email notification preference.

aklapper (Andre Klapper)

  • Mail Tags: This mail has tags which control which users receive it, and this recipient has not elected to receive mail with any of the tags on this message (Settings > Email Preferences).
  • Forced by Herald: This recipient was added by a "Send me an Email" rule in Herald, which overrides some delivery settings.
Oct 15 2015, 1:16 PM · Notifications
joshuaspence added a project to T4721: Improve user-facing documentation for Passphrase: Documentation.
Oct 15 2015, 12:04 PM · Documentation, Passphrase
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

Branch name issues aside, CircleCI still isn't running builds for me, so I'm going to have to shelve this for now.

Oct 15 2015, 11:03 AM · Restricted Project, Harbormaster
epriestley claimed T9573: Documents with " - " space hyphen space are inaccessible .
Oct 15 2015, 10:32 AM · Phriction
epriestley added a revision to T9573: Documents with " - " space hyphen space are inaccessible : Unknown Object (Differential Revision).
Oct 15 2015, 10:32 AM · Phriction
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

Screen Shot 2015-10-15 at 3.25.21 AM.png (590×1 px, 80 KB)

Oct 15 2015, 10:29 AM · Restricted Project, Harbormaster
epriestley merged T9575: Make Passphrase policies clearer into T4721: Improve user-facing documentation for Passphrase.
Oct 15 2015, 10:26 AM · Documentation, Passphrase
epriestley merged task T9575: Make Passphrase policies clearer into T4721: Improve user-facing documentation for Passphrase.
Oct 15 2015, 10:26 AM · Policy, Passphrase
joshuaspence created T9575: Make Passphrase policies clearer.
Oct 15 2015, 10:24 AM · Policy, Passphrase
d.maznekov awarded T7924: Unprototype Calendar (v1) a Mountain of Wealth token.
Oct 15 2015, 6:57 AM · Restricted Project, Prioritized, Calendar
• loic.dreux awarded T4548: Support "Mylyn" Eclipse plugin a Love token.
Oct 15 2015, 6:07 AM · Feature Request, Maniphest
epriestley added Q178: Advice on tracking benchmarks/performance per diff or commit (Answer 210).
Oct 15 2015, 4:26 AM
epriestley updated the task description for T9456: Evaluate upstream support for third-party build systems.
Oct 15 2015, 4:12 AM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

CircleCI still isn't running builds for me so I can't reasonably do step 4 (the webhook part) tonight. Presumably they'll be back up by tomorrow and I can finish this up.

Oct 15 2015, 4:06 AM · Restricted Project, Harbormaster
epriestley added a revision to T9456: Evaluate upstream support for third-party build systems: Unknown Object (Differential Revision).
Oct 15 2015, 4:02 AM · Restricted Project, Harbormaster
epriestley reopened T9572: Thumbs up icon should be clickable as "Open".
Oct 15 2015, 4:00 AM · Ponder
epriestley added a comment to Q177: Is it possible to provide the `--nounit` flag to `arc diff` by default?.
CommandNowRequire --everythingCheck Parent Workflow
arc diffRuns TestsNo TestsNo Tests
arc unitRuns Tests No Tests Runs Tests
arc unit --everythingRuns TestsRuns TestsRuns Tests
Oct 15 2015, 3:44 AM · Arcanist
epriestley added a comment to Q177: Is it possible to provide the `--nounit` flag to `arc diff` by default?.

The test engine can figure out if --everything is present or not but I don't think it can reach up to the workflow object right now. So you can disable arc unit as a sub-step of arc diff, but not without also disabling arc unit when run without --everything.

Oct 15 2015, 3:42 AM · Arcanist
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

We can use a branch name like "zzz_harbormaster" or something so the console doesn't clutter up too much.

Oct 15 2015, 3:28 AM · Restricted Project, Harbormaster
epriestley added a comment to Q177: Is it possible to provide the `--nounit` flag to `arc diff` by default?.

Is running arc unit interactively ever desirable? Can you either disconnect the integration entirely, or have it no-op if the --everything flag is not present (if you rely on --target for build integration)?

Oct 15 2015, 3:27 AM · Arcanist
epriestley added a comment to Q175: Should I Reuse Device Keys? (Answer 207).

Right. If you put it on multiple devices, we can't choose a single identity when you try to do anything with that key. I don't actually remember why we're even allowing that at all and suspect it's some legacy stuff from an early draft that no longer makes any sense.

Oct 15 2015, 3:17 AM
joshuaspence added a project to Q176: Where should I run the repository pull daemon with `--no-discovery`: Daemons.
Oct 15 2015, 3:03 AM · Daemons
joshuaspence added a comment to Q175: Should I Reuse Device Keys? (Answer 207).

So it's fine to reuse a key across multiple hosts which are registering as the same Almanac device, but I shouldn't reuse that key for different Almanac devices?

Oct 15 2015, 2:48 AM
joshuaspence added a comment to Q175: Should I Reuse Device Keys? (Answer 207).
Oct 15 2015, 2:47 AM
joshuaspence added a comment to T9077: Some applications don't support the "Quote" action on comments properly.

Quotes also don't work in Ponder.

Oct 15 2015, 2:45 AM · Restricted Project, Transactions
epriestley closed T9571: Ponder questions don't get parsed in remarkup as Resolved.
Oct 15 2015, 2:43 AM · Ponder
epriestley added a comment to Q174: Should / Can I Reuse an Almanac Device (Answer 208).

No, it's more like this:

Oct 15 2015, 2:38 AM
joshuaspence added a comment to Q174: Should / Can I Reuse an Almanac Device (Answer 208).

Oh... so a single instance can register as more than one Almanac device?

Oct 15 2015, 2:27 AM
joshuaspence added a comment to Q176: Where should I run the repository pull daemon with `--no-discovery`.

I guess that my question here is two-fold:

Oct 15 2015, 2:25 AM · Daemons
joshuaspence added a comment to Q175: Should I Reuse Device Keys? (Answer 207).

Sorry, I don't quite follow...

Oct 15 2015, 2:18 AM
joshuaspence created T9572: Thumbs up icon should be clickable.
Oct 15 2015, 2:14 AM · Ponder
epriestley added a comment to T9571: Ponder questions don't get parsed in remarkup.

I think I just configured remarkup.ignored-object-names wrong when I added S3, should be OK now going forward.

Oct 15 2015, 2:10 AM · Ponder
joshuaspence created T9571: Ponder questions don't get parsed in remarkup.
Oct 15 2015, 2:03 AM · Ponder
joshuaspence updated the language for P1866 /etc/init.d/phd from autodetect to bash.
Oct 15 2015, 1:59 AM · Daemons
epriestley added a comment to T9529: Upload coverage to a diff.

Try the diff PHID -- $diff->getPHID()?

Oct 15 2015, 1:59 AM · Restricted Project, Restricted Project, Conduit, Differential, Harbormaster
joshuaspence updated Q176: Where should I run the repository pull daemon with `--no-discovery` from to Where should I run the repository pull daemon with `--no-discovery`.
Oct 15 2015, 1:58 AM · Daemons
joshuaspence edited P1867 /etc/init.d/phd.
Oct 15 2015, 1:58 AM · Daemons
joshuaspence edited P1866 /etc/init.d/phd.
Oct 15 2015, 1:57 AM · Daemons
epriestley added a revision to T9456: Evaluate upstream support for third-party build systems: Unknown Object (Differential Revision).
Oct 15 2015, 1:54 AM · Restricted Project, Harbormaster
epriestley added a revision to T9456: Evaluate upstream support for third-party build systems: Unknown Object (Differential Revision).
Oct 15 2015, 1:40 AM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

So if I set that up to push a tag, will that be guaranteed to be on the remote before the build starts?

Oct 15 2015, 1:39 AM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

haha

Oct 15 2015, 1:23 AM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

sorry I broke CircleCI ;_;

Oct 15 2015, 1:22 AM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

Oh, it's actually been ~down for ~4 hours? Roughly since I touched it earlier this afternoon. o.O

Oct 15 2015, 1:21 AM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

Specifically, this is workable because requests like this are handled in a desirable way (note loldoesnotexist branch, which does not exist):

Oct 15 2015, 1:20 AM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

Here's the specific flow that I think is workable:

Oct 15 2015, 1:15 AM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

Okay, it looks like we can pass any ref-like thing as revision and pretty much whatever we want as branch, and branch is just completely ignored if revision is present, so building tags isn't an issue. We should be able to do a proper integration here cleanly.

Oct 15 2015, 12:57 AM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

oh

Oct 15 2015, 12:51 AM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

You can currently configure a "Staging Area", which will cause arc diff to push to a tag in an arbitrary remote as a side effect. I generally think this is a better way forward than pushing to named branches in the "real" remote, because it doesn't imply an end state where your remote has "master", "develop", and a million named branches that you can't get rid of. T8092 and linked tasks discuss eventually moving beyond this and virtualizing these refs so they're invisible to users but visible to the build system (for hosted repositories), but just using a different remote is approximately as good today.

Oct 15 2015, 12:46 AM · Restricted Project, Harbormaster
epriestley added Q173: How to disable MySQL file storage (Answer 209).
Oct 15 2015, 12:16 AM
epriestley added Q174: Should / Can I Reuse an Almanac Device (Answer 208).
Oct 15 2015, 12:14 AM
epriestley added Q175: Should I Reuse Device Keys? (Answer 207).
Oct 15 2015, 12:09 AM

Oct 14 2015

epriestley added a comment to T9529: Upload coverage to a diff.

It looks like that code isn't interacting with Harbormaster at all and is making an HTTP request to Changes directly from inside a Herald action. We (fairly strongly) discourage this as a way to communicate with external systems (see T5462 for discussion/rationale -- it's synchronous and blocks the UI, error handling can't happen properly, and there's no way to retry if it fails). There is no build target available during the execution of Herald actions and I can't really come up with a reasonable way to generate one.

Oct 14 2015, 11:49 PM · Restricted Project, Restricted Project, Conduit, Differential, Harbormaster
joshuaspence updated Q175: Should I Reuse Device Keys? from to Should I Reuse Device Keys.
Oct 14 2015, 11:31 PM · Drydock, Almanac
joshuaspence updated Q174: Should / Can I Reuse an Almanac Device from to Should / Can I Reuse an Almanac Device.
Oct 14 2015, 11:29 PM · Almanac
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

Phabricator is not a good fit for your workflow, then, and never will be.

Oct 14 2015, 11:08 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Arcanist, Differential
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

For example, here's a reasonable way you might perform these changes:

Oct 14 2015, 11:06 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Arcanist, Differential
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

Increasing max_allowed_packet to a much larger number (say, 512MB) will likely resolve the 2013 error.

Oct 14 2015, 10:58 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Arcanist, Differential
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

What is max_allowed_packet set to in MySQL?

Oct 14 2015, 10:46 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Arcanist, Differential
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

Differential just can't load the change set into its database.

Oct 14 2015, 10:21 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Arcanist, Differential
epriestley added a comment to T9570: Can a hosted Phacility instance be exported?.

Yes, with caveats. See T7148 for discussion of why this is complex. Roughly, here's the state of the world today:

Oct 14 2015, 9:04 PM · Phacility Support
epriestley edited projects for T9570: Can a hosted Phacility instance be exported?, added: Phacility Support; removed Support.
Oct 14 2015, 8:53 PM · Phacility Support
epriestley updated subscribers of T9456: Evaluate upstream support for third-party build systems.

For those of you using CircleCI, what sort of integration are you hoping for?

Oct 14 2015, 8:51 PM · Restricted Project, Harbormaster
joshuaspence updated Q173: How to disable MySQL file storage from to How to disable MySQL file storage.
Oct 14 2015, 8:48 PM · Files
turadg awarded T182: Commit into repository directly from differential a Orange Medal token.
Oct 14 2015, 8:34 PM · Haskell.org, Restricted Project, Differential
epriestley added a comment to T9252: Unprototype Drydock (v1).

Progress here:

Oct 14 2015, 8:04 PM · Prioritized, Drydock
epriestley added a comment to T9519: Design the Drydock Blueprint selection mechanism.

It's just this thing, basically:

Oct 14 2015, 7:53 PM · Drydock
epriestley added a comment to T9519: Design the Drydock Blueprint selection mechanism.

I'm broadly pretty happy with this after using it for a bit, at least for use cases we have today. It does feel a little bit labor intensive, but not overwhelmingly so, and all the stuff is pretty well linked up so once you get the hang of it you're almost always only a click away from wherever you want to be to do the next thing. It's also reassuring to be able to go to a blueprint and check what might be using it at a glance.

Oct 14 2015, 7:21 PM · Drydock
epriestley added a comment to T182: Commit into repository directly from differential.

General progress update here: this now works, technically. Almost every part of it -- particularly, the UI -- is still total garbage for now, but if you ship a revision against rGITTEST up to this server you'll get a "Land Revision" button on it which has worked twice in the past and might work again. I would recommend extending the list of pasta varieties found in the pasta file if you want to try this (the button should appear and function without requiring the revision to be accepted for now, and everyone has write access to the repo anyway).

Oct 14 2015, 7:08 PM · Haskell.org, Restricted Project, Differential
epriestley added a revision to T182: Commit into repository directly from differential: Unknown Object (Differential Revision).
Oct 14 2015, 5:39 PM · Haskell.org, Restricted Project, Differential
epriestley edited P1865 syncProviders.php.
Oct 14 2015, 4:56 PM
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

Releeph will execute all the same core display code and have all the same ingrained workflow assumptions. If your changes are too big to review in Differential, they will also be too big to review in Audit, and Releeph will not have dedicated review tools.

Oct 14 2015, 4:03 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Differential, Arcanist
epriestley closed T9568: Passphrase credentials do not preserve "Space" when edited as Resolved by committing Restricted Diffusion Commit.
Oct 14 2015, 3:15 PM · Passphrase
epriestley updated subscribers of T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
Oct 14 2015, 3:08 PM · Restricted Project, FreeBSD, Arcanist
epriestley merged task T9569: arc tasks --unassigned displays assigned tasks into T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
Oct 14 2015, 3:08 PM · Arcanist
epriestley added a revision to T9568: Passphrase credentials do not preserve "Space" when edited: Unknown Object (Differential Revision).
Oct 14 2015, 2:51 PM · Passphrase
epriestley claimed T9568: Passphrase credentials do not preserve "Space" when edited.
Oct 14 2015, 2:49 PM · Passphrase
epriestley edited the content of Phacility Cluster Devices.
Oct 14 2015, 1:44 PM
epriestley edited the content of Adding Hardware.
Oct 14 2015, 1:41 PM
epriestley created T9568: Passphrase credentials do not preserve "Space" when edited.
Oct 14 2015, 1:35 PM · Passphrase
epriestley added a revision to T9252: Unprototype Drydock (v1): Unknown Object (Differential Revision).
Oct 14 2015, 12:26 PM · Prioritized, Drydock
epriestley added a revision to T9252: Unprototype Drydock (v1): Unknown Object (Differential Revision).
Oct 14 2015, 12:02 PM · Prioritized, Drydock
epriestley closed T9565: webhook support as Invalid.

Please read this document carefully before filing a feature request:

Oct 14 2015, 11:49 AM · Notifications
epriestley added a comment to T7478: Inbound email is wrapped when sent from Gmail.

I'm not sure there's anything we can really do about this. Gmail is applying a destructive transformation to outbound mail, and there is no inverse function we can apply to restore the original mail.

Oct 14 2015, 10:46 AM · Mail