Page MenuHomePhabricator
Feed Advanced Search

Jun 14 2016

chad added a comment to T11142: Side-by-side diff viewer breaks lines on word boundaries and makes diffing difficult in some situations.

We still need a complete bug report for this. See Contributing Bug Reports.

Jun 14 2016, 12:48 AM · Restricted Project, Bug Report (Needs Information), Differential
markwei added a comment to T11142: Side-by-side diff viewer breaks lines on word boundaries and makes diffing difficult in some situations.

I'll do so as soon as I can.

Jun 14 2016, 12:43 AM · Restricted Project, Bug Report (Needs Information), Differential
chad added a project to T11138: mail is not delivered if metamta.placeholder-to-recipient is null: Mail.
Jun 14 2016, 12:37 AM · Mail, Bug Report
chad added a comment to T9897: Unbeta Feedback on Phame.

I can probably copy-pasta that feature.

Jun 14 2016, 12:36 AM · Phame
chad updated the task description for T9897: Unbeta Feedback on Phame.
Jun 14 2016, 12:35 AM · Phame
chad updated the task description for T9897: Unbeta Feedback on Phame.
Jun 14 2016, 12:35 AM · Phame
chad added a comment to T11142: Side-by-side diff viewer breaks lines on word boundaries and makes diffing difficult in some situations.

The movie isn't playable for me.

Jun 14 2016, 12:34 AM · Restricted Project, Bug Report (Needs Information), Differential
markwei created T11142: Side-by-side diff viewer breaks lines on word boundaries and makes diffing difficult in some situations.
Jun 14 2016, 12:32 AM · Restricted Project, Bug Report (Needs Information), Differential
rphl added a comment to T9897: Unbeta Feedback on Phame.

any plans/chance to implement search if you unbeta phame? T6383?

Jun 14 2016, 12:22 AM · Phame
avivey added a comment to T11140: Support at-rest encryption in Files.

One thing I've seen people do is something like an encrypted ssh key (For SSL certs):

Jun 14 2016, 12:12 AM · Prioritized, Files

Jun 13 2016

epriestley added a revision to T11098: Feedback and Errata for Global Settings: Unknown Object (Differential Revision).
Jun 13 2016, 10:23 PM · Prioritized, Restricted Project, User Preferences
epriestley added a comment to T11098: Feedback and Errata for Global Settings.

Cool, pretty sure I've got a repro then -- real fix coming up in a second.

Jun 13 2016, 10:15 PM · Prioritized, Restricted Project, User Preferences
bizrad6 added a comment to T11098: Feedback and Errata for Global Settings.

Yup, that did the trick!

Jun 13 2016, 10:11 PM · Prioritized, Restricted Project, User Preferences
epriestley added a comment to T11098: Feedback and Errata for Global Settings.

Ah, I think I've got a repro. Does this "fix" it?

Jun 13 2016, 9:57 PM · Prioritized, Restricted Project, User Preferences
bizrad6 added a comment to T11098: Feedback and Errata for Global Settings.

We are seeing an issue where the global default email preferences are not reflected in the user email preferences.

Jun 13 2016, 9:53 PM · Prioritized, Restricted Project, User Preferences
epriestley added a revision to T9789: Make it easier to write custom transaction types: Unknown Object (Differential Revision).
Jun 13 2016, 9:49 PM · Modernization, Transactions
epriestley added a comment to T10811: `phd-daemon` crash after automatic restart following config change.

There's a very small possibility that D16110 fixed a race condition which was causing this, but that seems like quite a stretch.

Jun 13 2016, 8:56 PM · Daemons, Bug Report
epriestley added a revision to T10811: `phd-daemon` crash after automatic restart following config change: Unknown Object (Differential Revision).
Jun 13 2016, 8:49 PM · Daemons, Bug Report
jdforrester added a comment to T11141: "Adjust timezone" dialog does not default to "ignore" in Chrome.

Is the behavior you want the same as @vinzent's desired behavior, your phone's behavior, and your laptop's behavior? That is, blindly trust client timezone unconditionally, without prompting or notifying you? From the original description, it seemed like you wanted essentially the opposite behavior.

Jun 13 2016, 8:11 PM · Feature Request, User Preferences
epriestley added a comment to T11141: "Adjust timezone" dialog does not default to "ignore" in Chrome.

GitHub does not appear to ever render absolute time. Instead, it renders relative times like "5 hours ago", etc.

Jun 13 2016, 8:01 PM · Feature Request, User Preferences
vinzent added a comment to T11141: "Adjust timezone" dialog does not default to "ignore" in Chrome.

what do others do about that timezone thing? I'm not aware that i needed to specify a timezone on other services.

Jun 13 2016, 7:47 PM · Feature Request, User Preferences
epriestley added a comment to T11141: "Adjust timezone" dialog does not default to "ignore" in Chrome.

Is the behavior you want the same as @vinzent's desired behavior, your phone's behavior, and your laptop's behavior? That is, blindly trust client timezone unconditionally, without prompting or notifying you? From the original description, it seemed like you wanted essentially the opposite behavior.

Jun 13 2016, 7:43 PM · Feature Request, User Preferences
jdforrester added a comment to T11141: "Adjust timezone" dialog does not default to "ignore" in Chrome.

auto-adjusted based on location

If you auto-adjust the primary local time displayed on your system, why don't you also want to adjust Phabricator?

We pop this dialog because your browser's time (which only has one time, and which is the only time we can see) has changed.

Jun 13 2016, 7:38 PM · Feature Request, User Preferences
epriestley added a comment to T11141: "Adjust timezone" dialog does not default to "ignore" in Chrome.

auto-adjusted based on location

Jun 13 2016, 7:28 PM · Feature Request, User Preferences
epriestley renamed T11141: "Adjust timezone" dialog does not default to "ignore" in Chrome from "Adjust timezone" dialog doesn't have a way to cancel/ignore to "Adjust timezone" dialog does not default to "ignore" in Chrome.
Jun 13 2016, 7:25 PM · Feature Request, User Preferences
jdforrester added a comment to T11141: "Adjust timezone" dialog does not default to "ignore" in Chrome.

Or, perhaps more specifically: why do you want to change your machine's local timezone, but not change Phabricator's timezone to be consistent? If you just didn't want to change your timezone at all, you could leave everything in PST while in London and your system clock and Phabricator would both remain in PST, but you did change your system clock.

Jun 13 2016, 7:25 PM · Feature Request, User Preferences
epriestley added a comment to T11141: "Adjust timezone" dialog does not default to "ignore" in Chrome.

why not using the browsers timezone by default and giving the possibility to set a static one in the settings if really required (without this message popping up)

Jun 13 2016, 7:25 PM · Feature Request, User Preferences
epriestley added a comment to T11141: "Adjust timezone" dialog does not default to "ignore" in Chrome.

"Adjust timezone" dialog doesn't have a way to cancel/ignore

Jun 13 2016, 7:23 PM · Feature Request, User Preferences
chad edited projects for T11141: "Adjust timezone" dialog does not default to "ignore" in Chrome, added: Feature Request; removed Bug Report.
Jun 13 2016, 7:22 PM · Feature Request, User Preferences
vinzent added a comment to T11141: "Adjust timezone" dialog does not default to "ignore" in Chrome.

why not using the browsers timezone by default and giving the possibility to set a static one in the settings if really required (without this message popping up)

Jun 13 2016, 7:21 PM · Feature Request, User Preferences
epriestley added a comment to T11141: "Adjust timezone" dialog does not default to "ignore" in Chrome.

Or, perhaps more specifically: why do you want to change your machine's local timezone, but not change Phabricator's timezone to be consistent? If you just didn't want to change your timezone at all, you could leave everything in PST while in London and your system clock and Phabricator would both remain in PST, but you did change your system clock.

Jun 13 2016, 7:20 PM · Feature Request, User Preferences
chad renamed T11141: "Adjust timezone" dialog does not default to "ignore" in Chrome from "Adjust timezone" dialog has some poor UX issues to "Adjust timezone" dialog doesn't have a way to cancel/ignore.
Jun 13 2016, 7:20 PM · Feature Request, User Preferences
epriestley added a comment to T11141: "Adjust timezone" dialog does not default to "ignore" in Chrome.

Why don't you want to change your timezone?

Jun 13 2016, 7:18 PM · Feature Request, User Preferences
vinzent awarded T11141: "Adjust timezone" dialog does not default to "ignore" in Chrome a Like token.
Jun 13 2016, 7:18 PM · Feature Request, User Preferences
jdforrester created T11141: "Adjust timezone" dialog does not default to "ignore" in Chrome.
Jun 13 2016, 7:15 PM · Feature Request, User Preferences
epriestley moved T11140: Support at-rest encryption in Files from Backlog to Preflight on the Prioritized board.
Jun 13 2016, 7:15 PM · Prioritized, Files
epriestley added a comment to T7643: Improve prose diffs (was: description changes don't generate usable diffs).

Catching a couple more funky diffs:

Jun 13 2016, 7:14 PM · Prioritized, Transactions
chad updated the task description for T9897: Unbeta Feedback on Phame.
Jun 13 2016, 7:08 PM · Phame
• julienstroheker edited the content of Community Resources.
Jun 13 2016, 7:08 PM
aubort added Q419: Slow imports of commit and how to scale up (Answer 394).
Jun 13 2016, 6:57 PM
epriestley created T11140: Support at-rest encryption in Files.
Jun 13 2016, 6:57 PM · Prioritized, Files
epriestley added a revision to T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks: Unknown Object (Differential Revision).
Jun 13 2016, 6:27 PM · Prioritized, Wikimedia, Remarkup
chad updated the task description for T9897: Unbeta Feedback on Phame.
Jun 13 2016, 6:21 PM · Phame
chad updated the task description for T9897: Unbeta Feedback on Phame.
Jun 13 2016, 6:20 PM · Phame
chad added a revision to T9897: Unbeta Feedback on Phame: Unknown Object (Differential Revision).
Jun 13 2016, 6:19 PM · Phame
neonbadger closed T10850: Search revisions by "Repository Projects" as Resolved by committing Restricted Diffusion Commit.
Jun 13 2016, 6:08 PM · Restricted Project, Restricted Project, Differential, Feature Request
neonbadger closed T10850: Search revisions by "Repository Projects", a subtask of T9287: Working with many repositories, as Resolved.
Jun 13 2016, 6:08 PM · Restricted Project, Restricted Project, Diffusion
• howelljr.ellis awarded T5375: Tokenizers fail in Firefox on Android a Like token.
Jun 13 2016, 6:03 PM · Firefox, Android
epriestley moved T7441: Support OAuth providers in the cluster from The Queue to Paused on the Prioritized board.
Jun 13 2016, 5:48 PM · Auth, Phacility
epriestley added a comment to T7441: Support OAuth providers in the cluster.

I enabled Google for central auth since I think everything we need for it to work already works fine in the cluster, although it's possible some of the invite flow stuff is a little shaky.

Jun 13 2016, 5:39 PM · Auth, Phacility
chad updated the task description for T9897: Unbeta Feedback on Phame.
Jun 13 2016, 5:34 PM · Phame
epriestley closed T10547: Remote SVN repository imports over SSH do not tidy up temporary directories as Resolved.

I believe this is fixed now, but reproduction has always been somewhat elusive so I'm not completely certain. Please let us know if you still see issues after updating. Thanks for the report!

Jun 13 2016, 5:31 PM · Prioritized, Subversion, Bug Report
epriestley added a comment to T11139: Non-latin commit messages are disappear in history view.

This commit now appears properly in the history view on this install, so I think the issue is resolved:

Jun 13 2016, 5:29 PM · Bug Report
saggid added a comment to T11139: Non-latin commit messages are disappear in history view.

So fast :)) Many thanks for you work)

Jun 13 2016, 5:28 PM · Bug Report
epriestley closed T11139: Non-latin commit messages are disappear in history view as Resolved by committing Restricted Diffusion Commit.
Jun 13 2016, 5:16 PM · Bug Report
saggid renamed T11139: Non-latin commit messages are disappear in history view from Non-UTF8 Commit messages are disappear in history view to Non-latin commit messages are disappear in history view.
Jun 13 2016, 5:14 PM · Bug Report
epriestley added a revision to T11139: Non-latin commit messages are disappear in history view: Unknown Object (Differential Revision).
Jun 13 2016, 5:14 PM · Bug Report
saggid added a comment to T11139: Non-latin commit messages are disappear in history view.

Look at my repo history without bug fixing.

Jun 13 2016, 5:05 PM · Bug Report
saggid added a comment to T11139: Non-latin commit messages are disappear in history view.

No, not in full commit info. See history window with all commits of project.

Jun 13 2016, 5:02 PM · Bug Report
epriestley added a comment to T11139: Non-latin commit messages are disappear in history view.

I can't reproduce this -- rGITTESTaa541e7b324424e201c124dc58588c33e48d8bf5 seems to work fine for me.

Jun 13 2016, 5:01 PM · Bug Report
saggid added a comment to T11139: Non-latin commit messages are disappear in history view.

I found source of problem: many lines of code in libphutil and phabricator use a strlen and substr functions instead of using mb_strlen and mb_substr. If you replace this functions to multibyte-analogs, this bug go away)

Jun 13 2016, 5:01 PM · Bug Report
saggid created T11139: Non-latin commit messages are disappear in history view.
Jun 13 2016, 4:57 PM · Bug Report
chad added a revision to T9897: Unbeta Feedback on Phame: Unknown Object (Differential Revision).
Jun 13 2016, 4:49 PM · Phame
epriestley added a comment to T11118: Herald Rule to assign Owners to an Audit.

If the "Audit" setting for packages had three settings instead, would that solve your use case?

Jun 13 2016, 4:39 PM · Restricted Project, Audit, Herald, Owners, Feature Request
epriestley added a revision to T11137: Unable to update Git repositories with latest stable: Unknown Object (Differential Revision).
Jun 13 2016, 4:33 PM · Diffusion, Bug Report
epriestley added a revision to T10547: Remote SVN repository imports over SSH do not tidy up temporary directories: Unknown Object (Differential Revision).
Jun 13 2016, 4:23 PM · Prioritized, Subversion, Bug Report
epriestley added a comment to T11137: Unable to update Git repositories with latest stable.

Thanks. That trace is consistent with the one I was able to reproduce, so I suspect the changes above fix this. I'll leave this open for a bit in case anyone else shows up, this fix is the kind of fix that's likely to have spooky side effects.

Jun 13 2016, 4:00 PM · Diffusion, Bug Report
ivo added a comment to T11137: Unable to update Git repositories with latest stable.

The command output was:

[2016-06-13 17:45:26] EXCEPTION: (InvalidArgumentException) Argument 1 passed to DiffusionCommandEngine::setURI() must be an instance of PhutilURI, instance of PhutilGitURI given, called in /home/ubuntu/phabricator/src/applications/repository/storage/PhabricatorRepository.php on line 511 and defined at [<phutil>/src/error/PhutilErrorHandler.php:200]
arcanist(head=stable, ref.master=e8a0ebaeffaa, ref.stable=7b0aac5c6f31), phabricator(head=1558175ec84c7b13ba3f692b897464901bc00578, ref.master=55767aac0f86, custom=2), phutil(head=stable, ref.master=dad3ab8d7e87, ref.stable=ad458fb7df59)
  #0 PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<phabricator>/src/applications/diffusion/protocol/DiffusionCommandEngine.php:52]
  #1 DiffusionCommandEngine::setURI(PhutilGitURI) called at [<phabricator>/src/applications/repository/storage/PhabricatorRepository.php:511]
  #2 PhabricatorRepository::newRemoteCommandEngine(array) called at [<phabricator>/src/applications/repository/storage/PhabricatorRepository.php:497]
  #3 PhabricatorRepository::newRemoteCommandFuture(array) called at [<phabricator>/src/applications/repository/storage/PhabricatorRepository.php:488]
  #4 PhabricatorRepository::getRemoteCommandFuture(string, string) called at [<phabricator>/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php:350]
  #5 PhabricatorRepositoryPullEngine::executeGitUpdate() called at [<phabricator>/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php:125]
  #6 PhabricatorRepositoryPullEngine::pullRepositoryWithLock() called at [<phabricator>/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php:40]
  #7 PhabricatorRepositoryPullEngine::pullRepository() called at [<phabricator>/src/applications/repository/management/PhabricatorRepositoryManagementPullWorkflow.php:43]
  #8 PhabricatorRepositoryManagementPullWorkflow::execute(PhutilArgumentParser) called at [<phutil>/src/parser/argument/PhutilArgumentParser.php:410]
  #9 PhutilArgumentParser::parseWorkflowsFull(array) called at [<phutil>/src/parser/argument/PhutilArgumentParser.php:303]
  #10 PhutilArgumentParser::parseWorkflows(array) called at [<phabricator>/scripts/repository/manage_repositories.php:22]

The latest commit on stable fixes the problem for us 👍

Jun 13 2016, 3:59 PM · Diffusion, Bug Report
epriestley moved T10547: Remote SVN repository imports over SSH do not tidy up temporary directories from Backlog to The Queue on the Prioritized board.
Jun 13 2016, 2:44 PM · Prioritized, Subversion, Bug Report
epriestley added a comment to T10547: Remote SVN repository imports over SSH do not tidy up temporary directories.

I appear to have found a reproduction case for this in the cluster.

Jun 13 2016, 2:43 PM · Prioritized, Subversion, Bug Report
epriestley claimed T10547: Remote SVN repository imports over SSH do not tidy up temporary directories.
Jun 13 2016, 2:43 PM · Prioritized, Subversion, Bug Report
epriestley added a comment to T11137: Unable to update Git repositories with latest stable.

I'm deploying this to the cluster now.

Jun 13 2016, 2:25 PM · Diffusion, Bug Report
epriestley moved T7441: Support OAuth providers in the cluster from Paused to The Queue on the Prioritized board.
Jun 13 2016, 2:21 PM · Auth, Phacility
20after4 added a reviewer for D16101: DiffusionCommitTagsHeraldField: epriestley.
Jun 13 2016, 2:17 PM
20after4 retitled D16101: DiffusionCommitTagsHeraldField from to DiffusionCommitTagsHeraldField.
Jun 13 2016, 2:17 PM
aubort added a project to Q419: Slow imports of commit and how to scale up: Daemons.
Jun 13 2016, 1:56 PM · Daemons
aubort updated the question details for Q419: Slow imports of commit and how to scale up.
Jun 13 2016, 1:55 PM · Daemons
aubort updated Q419: Slow imports of commit and how to scale up from to Slow imports of commit and how to scale up.
Jun 13 2016, 1:54 PM · Daemons
epriestley claimed T11137: Unable to update Git repositories with latest stable.
Jun 13 2016, 1:36 PM · Diffusion, Bug Report
OCram added a comment to T10936: arc feature error while creating a new feature branch.

This specific issue also happens on my computer, which is running Windows 7 SP1 with PHP 5.6.20

I'm using stable versions of libphutil and arcanist as of May 16th.

If I rollback Arcanist to commit rARC737f5c0df976 the problem is gone.

Jun 13 2016, 1:33 PM · Windows, Arcanist, Bug Report
epriestley added a revision to T11137: Unable to update Git repositories with latest stable: Unknown Object (Differential Revision).
Jun 13 2016, 1:14 PM · Diffusion, Bug Report
epriestley added a comment to T11137: Unable to update Git repositories with latest stable.

@ivo, if you see this before I post a fix, can you show me the output of this command so I can make sure I'm reproducing exactly the same issue?

Jun 13 2016, 1:02 PM · Diffusion, Bug Report
epriestley added a revision to T11137: Unable to update Git repositories with latest stable: Unknown Object (Differential Revision).
Jun 13 2016, 12:41 PM · Diffusion, Bug Report
epriestley added a comment to T11137: Unable to update Git repositories with latest stable.

This issue describes a narrow issue with typehinting URIs, introduced by T10227.

Jun 13 2016, 12:39 PM · Diffusion, Bug Report
epriestley merged T11004: git URI normalization is not reliable into T11137: Unable to update Git repositories with latest stable.
Jun 13 2016, 12:32 PM · Diffusion, Bug Report
epriestley merged task T11004: git URI normalization is not reliable into T11137: Unable to update Git repositories with latest stable.
Jun 13 2016, 12:32 PM · Diffusion, Bug Report
epriestley added a comment to T11004: git URI normalization is not reliable.

I'm going to merge this into T11137. They don't describe the same issue, but I'm planning to fix them in the same way.

Jun 13 2016, 12:32 PM · Diffusion, Bug Report
Vivekanand created T11138: mail is not delivered if metamta.placeholder-to-recipient is null.
Jun 13 2016, 10:29 AM · Mail, Bug Report
ivo added a comment to T11137: Unable to update Git repositories with latest stable.

Reverted commit rP55a698a28a750017e787979a72dd125858997fa5 on our install and repository updates now work again.

Jun 13 2016, 9:24 AM · Diffusion, Bug Report
ivo created T11137: Unable to update Git repositories with latest stable.
Jun 13 2016, 9:12 AM · Diffusion, Bug Report
chad closed T11136: Pull the latest code, and upgrade it, But is can access now! as Invalid.
Jun 13 2016, 3:17 AM · Bug Report
• brucenan999 added a comment to T11136: Pull the latest code, and upgrade it, But is can access now!.

sorry, I don't restart the php-fpm, maybe the old process is still running.

Jun 13 2016, 3:07 AM · Bug Report
• brucenan999 updated the task description for T11136: Pull the latest code, and upgrade it, But is can access now!.
Jun 13 2016, 3:05 AM · Bug Report
• brucenan999 created T11136: Pull the latest code, and upgrade it, But is can access now!.
Jun 13 2016, 3:03 AM · Bug Report
eadler added a comment to T11126: Allow embedding XKCD panes in Remarkup.

Silly question but can't we use CSP Level 2's referrer directive (https://www.w3.org/TR/CSP11/#directive-referrer) to avoid leaking information without the need to build full image proxying?
If that doesn't work can we use <iframe seamless referrerpolicy="no-referrer"> ?

Jun 13 2016, 1:42 AM · Restricted Project, User Delight, Remarkup, Feature Request

Jun 12 2016

chad added a comment to T11132: New Phabricator NUX.

ɯɯɯɯɯɥ

Jun 12 2016, 11:43 PM · Design, Phacility, NUX
chad added a comment to T11132: New Phabricator NUX.

hmmmmm

Jun 12 2016, 11:38 PM · Design, Phacility, NUX
chad added a comment to T11132: New Phabricator NUX.

hmmmmm

Jun 12 2016, 11:37 PM · Design, Phacility, NUX
epriestley added a comment to T11132: New Phabricator NUX.

(And those UIs might also not actually be useful for future-administrators, particularly since I don't really plan to ever help users with third-party stuff, although who knows.)

Jun 12 2016, 11:09 PM · Design, Phacility, NUX
epriestley added a comment to T11132: New Phabricator NUX.

My intent with a lot of that stuff is to make administration and support (particularly in the future, once third-party applications are more common) easier, so they're targeted primarily at future-administrators who have questions like these, possibly because we've asked them for the information:

Jun 12 2016, 11:08 PM · Design, Phacility, NUX