Page MenuHomePhabricator
Feed Advanced Search

Aug 30 2015

joshuaspence updated the task description for T8801: Cannot find a way to generate a request with the right requestData.
Aug 30 2015, 4:15 AM · Config, Aphront, Maniphest
joshuaspence updated the task description for T8801: Cannot find a way to generate a request with the right requestData.
Aug 30 2015, 4:15 AM · Config, Aphront, Maniphest

Aug 6 2015

ChristopherHJohnson added a comment to T9066: Add logic in AphrontDefaultApplicationConfiguration to check for and parse application/json Content-Type.

Thank you for the response.

Aug 6 2015, 9:15 AM · Aphront

Aug 5 2015

chad added a comment to T9066: Add logic in AphrontDefaultApplicationConfiguration to check for and parse application/json Content-Type.

@ChristopherHJohnson the problem is that it isn't "just one change", we get requests in this vein several times a day and without a clear line on what "free support" looks like, the Phabricator project does not move forward. We just aren't staffed to manage these requests in any sort of reasonable timeframe. "Wishlist" items at best are 2-3 years out. We'd rather be honest about what the upstream can and cannot do in a reasonable timeframe so you have time to explore alternatives.

Aug 5 2015, 3:54 PM · Aphront
epriestley updated subscribers of T9066: Add logic in AphrontDefaultApplicationConfiguration to check for and parse application/json Content-Type.

I am not asking for "support" per se, so I am not sure the referenced link is applicable for this task.

Aug 5 2015, 3:54 PM · Aphront
ChristopherHJohnson added a comment to T9066: Add logic in AphrontDefaultApplicationConfiguration to check for and parse application/json Content-Type.

I am not asking for "support" per se, so I am not sure the referenced link is applicable for this task. The use case of application/json requests is major, so rejecting it outright as some kind of non-essential fringe "custom code" seems rather strong. The problem is pretty simple and the fix even more so. I am asking you to consider the benefits of parsing a specific content-type request with an appropriate parser. I totally understand that you have priorities, etc., but this is the situation with my team. We have code on GitHub and associated build tools that will probably never move to Phabricator. How can I not consider the need to integrate these "third-party" tools seriously? I am open to suggestions. Worst case scenario is that we maintain a patched version of this class, which for such a trivial change seems ridiculous.

Aug 5 2015, 3:08 PM · Aphront

Aug 4 2015

epriestley added a comment to T9066: Add logic in AphrontDefaultApplicationConfiguration to check for and parse application/json Content-Type.

See also:

Aug 4 2015, 7:19 PM · Aphront
epriestley closed T9066: Add logic in AphrontDefaultApplicationConfiguration to check for and parse application/json Content-Type as Invalid.

Sorry, we do not support third-party application development. See T5447 for discussion.

Aug 4 2015, 7:18 PM · Aphront
ChristopherHJohnson created T9066: Add logic in AphrontDefaultApplicationConfiguration to check for and parse application/json Content-Type.
Aug 4 2015, 4:51 PM · Aphront

Aug 1 2015

chad added revisions to T8628: Modernize AphrontControllers to implement handleRequest: D13773: Partially update Maniphest for handleProcess, D13772: Update Help for handleRequest, D13771: Update Audit for handleRequest, D13770: Update XHProf for handleRequest, D13769: Update UIExamples for handleRequest, D13768: Update Phortune for handleRequest, D13767: Update Notifications for handleRequest, D13766: Update Paste for handleRequest, D13765: Update Herald for handleRequest.
Aug 1 2015, 5:02 PM · Contributor Onboarding, Modernization, Badge Awarded, Aphront

Jul 29 2015

chad added revisions to T8628: Modernize AphrontControllers to implement handleRequest: D13748: Update Auth for handleRequest, D13747: Update Calendar for handleRequest.
Jul 29 2015, 5:23 PM · Contributor Onboarding, Modernization, Badge Awarded, Aphront
chad added a project to T8628: Modernize AphrontControllers to implement handleRequest: Badge Awarded.
Jul 29 2015, 5:19 PM · Contributor Onboarding, Modernization, Badge Awarded, Aphront

Jul 26 2015

chad triaged T8628: Modernize AphrontControllers to implement handleRequest as Low priority.
Jul 26 2015, 9:07 PM · Contributor Onboarding, Modernization, Badge Awarded, Aphront
chad added revisions to T8628: Modernize AphrontControllers to implement handleRequest: D13727: Update Config app for handleRequest, D13726: Convert Passhrase to handleRequest, D13724: Convert Macro to handleRequest.
Jul 26 2015, 9:07 PM · Contributor Onboarding, Modernization, Badge Awarded, Aphront

Jul 23 2015

joshuaspence claimed T8692: Include request URL in error logs.
Jul 23 2015, 8:51 AM · Restricted Project, Aphront, Infrastructure

Jul 22 2015

chad added revisions to T8628: Modernize AphrontControllers to implement handleRequest: D13682: Update Phriction for handleRequest, D13680: Update Dashboard for handleRequest, D13679: Update Ponder for handleRequest, D13678: Update Tokens for handleRequest, D13677: Modernize Phame process handlers.
Jul 22 2015, 7:48 PM · Contributor Onboarding, Modernization, Badge Awarded, Aphront
chad claimed T8628: Modernize AphrontControllers to implement handleRequest.
Jul 22 2015, 1:59 PM · Contributor Onboarding, Modernization, Badge Awarded, Aphront

Jul 8 2015

epriestley closed T8801: Cannot find a way to generate a request with the right requestData as Wontfix.

Sorry, we don't offer support with third-party custom development. See "Supported Issues" here:

Jul 8 2015, 3:56 PM · Config, Aphront, Maniphest
luna_rawas added projects to T8801: Cannot find a way to generate a request with the right requestData: Aphront, Config.
Jul 8 2015, 3:48 PM · Config, Aphront, Maniphest

Jun 29 2015

epriestley closed T5702: Make Aphront "virtual hosts"/sites modular as Resolved by committing rP6b7183a76232: Modularize Aphront "sites".
Jun 29 2015, 9:04 PM · Aphront
epriestley closed T5702: Make Aphront "virtual hosts"/sites modular, a subtask of T1806: Move Aphront to libphutil, as Resolved.
Jun 29 2015, 9:04 PM · Aphront
epriestley added a revision to T5702: Make Aphront "virtual hosts"/sites modular: D13474: Modularize Aphront "sites".
Jun 29 2015, 7:53 PM · Aphront
epriestley added a parent task for T5702: Make Aphront "virtual hosts"/sites modular: T8685: Move secure.phabriactor.com halfway into the cluster.
Jun 29 2015, 6:37 PM · Aphront

Jun 27 2015

joshuaspence created T8692: Include request URL in error logs.
Jun 27 2015, 12:39 AM · Restricted Project, Aphront, Infrastructure

Jun 21 2015

joshuaspence updated the task description for T8628: Modernize AphrontControllers to implement handleRequest.
Jun 21 2015, 6:44 AM · Contributor Onboarding, Modernization, Badge Awarded, Aphront
joshuaspence updated the task description for T8628: Modernize AphrontControllers to implement handleRequest.
Jun 21 2015, 6:43 AM · Contributor Onboarding, Modernization, Badge Awarded, Aphront
joshuaspence created T8628: Modernize AphrontControllers to implement handleRequest.
Jun 21 2015, 6:42 AM · Contributor Onboarding, Modernization, Badge Awarded, Aphront

Jun 17 2015

josetesan added a comment to T8582: Can't create projects.

i had a lot of projects created before, but starting from today's update, can't create anymore.
And yes, i checked and had exactly the same code .

Jun 17 2015, 12:24 PM · Projects
epriestley added a comment to T8582: Can't create projects.

I can not reproduce this.

Jun 17 2015, 12:16 PM · Projects
josetesan created T8582: Can't create projects.
Jun 17 2015, 11:36 AM · Projects

Jun 16 2015

btrahan closed T8542: Can't create new users as Invalid.

Let us know if restarting didn't resolve this. Thanks!

Jun 16 2015, 6:33 PM · Aphront

Jun 15 2015

epriestley added a comment to T8542: Can't create new users.

Can you try restarting apache (or php-fpm) and see if that resolves this issue?

Jun 15 2015, 12:59 PM · Aphront
josetesan created T8542: Can't create new users.
Jun 15 2015, 9:30 AM · Aphront

Jun 1 2015

epriestley closed T8372: Resource cache as Resolved by committing rP7a9174fa21b7: Digest resource cachekeys to maximum length.
Jun 1 2015, 4:04 PM · Aphront, Celerity
epriestley added a comment to T8372: Resource cache.

Awesome, thanks for testing! We'll get this upstreamed shortly.

Jun 1 2015, 3:48 PM · Aphront, Celerity
Zolli added a comment to T8372: Resource cache.

Oh no, its not a silly question :D Sorry, i justy quickly look this patch and totally forget restarting web-server... It works lik a charm ;) Thanks.

Jun 1 2015, 3:46 PM · Aphront, Celerity
epriestley added a comment to T8372: Resource cache.

Probably a silly question, but did you restart Apache or php-fpm after applying the patch?

Jun 1 2015, 3:38 PM · Aphront, Celerity
Zolli added a comment to T8372: Resource cache.

Applyed this diff to my local install but does not seems to be helped. The trace, and the throwed exception is the same as before.

Jun 1 2015, 1:39 PM · Aphront, Celerity
epriestley added a comment to T8372: Resource cache.

Pretty sure D13095 will fix this.

Jun 1 2015, 1:27 PM · Aphront, Celerity
epriestley added a revision to T8372: Resource cache: D13095: Digest resource cachekeys to maximum length.
Jun 1 2015, 1:27 PM · Aphront, Celerity
Zolli added a comment to T8372: Resource cache.
[2015-06-01 08:43:09] EXCEPTION: (AphrontQueryException) #1406: Data too long for column 'cacheKey' at row 1 at [<phutil>/src/aphront/storage/connection/mysql/AphrontBaseMySQLDatabaseConnection.php:311]
FastCGI: server "/usr/lib/cgi-bin/php5-fcgi" stderr: PHP message: arcanist(head=master, ref.master=0b1acf0dc02a), phabricator(head=master, ref.master=c4bcfc85f160), phutil(head=master, ref.master=ee6d0c3fe26e)
FastCGI: server "/usr/lib/cgi-bin/php5-fcgi" stderr: PHP message:   #0 phlog(AphrontQueryException) called at [<phabricator>/src/aphront/configuration/AphrontDefaultApplicationConfiguration.php:226]
FastCGI: server "/usr/lib/cgi-bin/php5-fcgi" stderr: PHP message:   #1 AphrontDefaultApplicationConfiguration::handleException(AphrontQueryException) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:230]
FastCGI: server "/usr/lib/cgi-bin/php5-fcgi" stderr: PHP message:   #2 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:140]
FastCGI: server "/usr/lib/cgi-bin/php5-fcgi" stderr: PHP message:   #3 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabricator>/webroot/index.php:19]
Jun 1 2015, 1:26 PM · Aphront, Celerity
epriestley added a comment to T8372: Resource cache.

Do you have a full stack trace in your error log? Usually /var/log/apache2/error_log or something like that, depending on exactly which webserver/OS you're running.

Jun 1 2015, 1:16 PM · Aphront, Celerity
Zolli created T8372: Resource cache.
Jun 1 2015, 6:21 AM · Aphront, Celerity

May 16 2015

epriestley closed T5694: AphrontWriteGuard was not properly disposed of as Resolved.

I've removed this error completely (see rPHUbd087f55).

May 16 2015, 2:26 PM · Aphront

May 14 2015

epriestley closed T8198: Unguarded write error on every page as Resolved by committing rPdb1cd6586609: Allow setup checks to perform writes.
May 14 2015, 5:39 PM · Aphront
epriestley added a revision to T8198: Unguarded write error on every page: D12842: Allow setup checks to perform writes.
May 14 2015, 5:21 PM · Aphront
epriestley added a revision to T8198: Unguarded write error on every page: D12841: Make AphrontWriteGuard disposal more durable.
May 14 2015, 5:14 PM · Aphront
epriestley claimed T8198: Unguarded write error on every page.

Ah, perfect.

May 14 2015, 4:57 PM · Aphront
btrahan added a comment to T8198: Unguarded write error on every page.

OoOoO, great tip.

May 14 2015, 4:56 PM · Aphront
epriestley added a comment to T8198: Unguarded write error on every page.

Just doing phlog($ex) might be useful (or phlog(new Exception()) if you aren't actually catching one).

May 14 2015, 4:54 PM · Aphront
btrahan added a comment to T8198: Unguarded write error on every page.

I have to walk the dog so I will be afk 20ish minutes but this will be what I am working on when I get back.

May 14 2015, 4:53 PM · Aphront
btrahan added a comment to T8198: Unguarded write error on every page.

Basically got useless stuff like the below

May 14 2015, 4:51 PM · Aphront
btrahan added a comment to T8198: Unguarded write error on every page.

Error logs are quiet. I put in a phlog(debug_backtrace()) and played with print_r but its hard to get a lot of text out of phlog?

May 14 2015, 4:51 PM · Aphront
epriestley added a comment to T8198: Unguarded write error on every page.

I can't immediately reproduce this -- do you have a trace in the Apache/php-fpm error log?

May 14 2015, 4:48 PM · Aphront
btrahan created T8198: Unguarded write error on every page.
May 14 2015, 4:46 PM · Aphront

Apr 7 2015

joshuaspence added a comment to T5694: AphrontWriteGuard was not properly disposed of.

FWIW, I'm seeing this roughly 60 times per day in our error logs.

Apr 7 2015, 10:29 PM · Aphront
GMTA added a comment to T7486: All responses use "OK" as the status text.

Hi, I'm not sure how Phabricator handles compatibility libraries but PHP has http_response_code() available which sets the status code and message in one go. The fix for this task could be introduced as a compat method for PHP < 5.4.

Apr 7 2015, 8:03 AM · Aphront

Apr 6 2015

joshuaspence added a comment to T7768: Status codes seem incorrect.

Oh right. I would've expected a 302 to /auth/login/ or similar.

Apr 6 2015, 10:00 PM · Aphront
epriestley closed T7768: Status codes seem incorrect as Wontfix.

This is intentional. This is a login page, not a 404. We don't 404 logged-out users because we don't want to disclose the existence of applications.

Apr 6 2015, 9:59 PM · Aphront
joshuaspence closed T7486: All responses use "OK" as the status text as Resolved by committing rPb2c23d88e8f9: Implement HTTP response messages.
Apr 6 2015, 9:43 PM · Aphront
joshuaspence created T7768: Status codes seem incorrect.
Apr 6 2015, 9:32 PM · Aphront
joshuaspence added a revision to T7486: All responses use "OK" as the status text: D12299: Implement HTTP response messages.
Apr 6 2015, 12:53 PM · Aphront

Mar 8 2015

joshuaspence claimed T7486: All responses use "OK" as the status text.

I might give this a go.

Mar 8 2015, 1:23 AM · Aphront
joshuaspence added a comment to T7486: All responses use "OK" as the status text.

Specifically, in the screenshot shown, the response is shown as 404 OK instead of 404 Not Found.

Mar 8 2015, 1:20 AM · Aphront

Mar 7 2015

joshuaspence created T7486: All responses use "OK" as the status text.
Mar 7 2015, 1:53 AM · Aphront

Feb 16 2015

epriestley triaged T7259: Case insensitive URLs as Low priority.

I think this is desirable, it's just kind of a pain to implement:

Feb 16 2015, 6:06 PM · Restricted Project, Aphront

Feb 15 2015

epriestley closed T7273: Fix page title for AphrontUsageException as Resolved by committing rP80e399def946: Show exception title as page title for AphrontUsageException.
Feb 15 2015, 3:39 PM · Phacility, Aphront
epriestley moved T7273: Fix page title for AphrontUsageException from Backlog to v0 Closed Beta on the Phacility board.
Feb 15 2015, 3:28 PM · Phacility, Aphront
epriestley claimed T7273: Fix page title for AphrontUsageException.
Feb 15 2015, 3:27 PM · Phacility, Aphront
epriestley added a revision to T7273: Fix page title for AphrontUsageException: D11771: Show exception title as page title for AphrontUsageException.
Feb 15 2015, 3:27 PM · Phacility, Aphront
Mnkras added a project to T7273: Fix page title for AphrontUsageException: Aphront.
Feb 15 2015, 4:34 AM · Phacility, Aphront

Feb 14 2015

joshuaspence renamed T7259: Case insensitive URLs from Case insensitive app ids to Case insensitive URLs.
Feb 14 2015, 3:09 AM · Restricted Project, Aphront

Nov 16 2014

epriestley removed a project from T5702: Make Aphront "virtual hosts"/sites modular: Phacility.
Nov 16 2014, 2:23 PM · Aphront

Nov 11 2014

epriestley added a comment to T5702: Make Aphront "virtual hosts"/sites modular.

The SiteConfig mechanism might let us get away without really taking this too far, since it acts really early in the stack and can sort of end run around the handling here. I expect I'll push this forward a bit more but probably not get it to a really polished state before launch.

Nov 11 2014, 10:51 PM · Aphront
btrahan moved T5702: Make Aphront "virtual hosts"/sites modular from Backlog to v0 Closed Beta on the Phacility board.
Nov 11 2014, 10:40 PM · Aphront

Nov 3 2014

joshuaspence added a comment to T5694: AphrontWriteGuard was not properly disposed of.

@chad, yes it is.

Nov 3 2014, 8:02 AM · Aphront
chad removed a project from T5694: AphrontWriteGuard was not properly disposed of: Phabricator.
Nov 3 2014, 3:44 AM · Aphront
chad added a comment to T5694: AphrontWriteGuard was not properly disposed of.

@joshuaspence, is this still occurring?

Nov 3 2014, 2:58 AM · Aphront

Oct 13 2014

epriestley added a comment to T1806: Move Aphront to libphutil.

When a component moves, apply any breaking API changes or generalizations that it should have to be general-purpose. An example is that I think willProcessRequest(array $data) + processRequest() was probably a mistake. A better signature would be processRequest(AphrontRequest $request, array $route_data) -- or even making the route data a property of $request -- because 99% of willProcessRequest() methods just copy route data to properties, and 90% of processRequest() methods begin with $request = $this->getRequest(). Another example is that AphrontRequest->getUser() should probably be AphrontRequest->getViewer().

Oct 13 2014, 10:01 PM · Aphront
epriestley added a revision to T5702: Make Aphront "virtual hosts"/sites modular: D10698: Decouple some aspects of request routing and construction.
Oct 13 2014, 9:56 PM · Aphront
epriestley added a revision to T5702: Make Aphront "virtual hosts"/sites modular: D10696: Make Celerity a real application.
Oct 13 2014, 5:26 PM · Aphront
epriestley added a revision to T5702: Make Aphront "virtual hosts"/sites modular: D10695: Move DarkConsole to an application.
Oct 13 2014, 5:21 PM · Aphront

Oct 3 2014

epriestley added a comment to T5702: Make Aphront "virtual hosts"/sites modular.

We need this, at a minimum, to unblock host-based configuration. We might need some more work after this, too.

Oct 3 2014, 5:08 AM · Aphront
epriestley added a project to T5702: Make Aphront "virtual hosts"/sites modular: Phacility.
Oct 3 2014, 5:08 AM · Aphront

Aug 13 2014

trubachoff closed T5816: Unhandled Exception ("AphrontQueryException") as Resolved.

I'm change phabricator/.devinercache owner
and exception don't appear.

Aug 13 2014, 12:42 PM · Aphront, Maniphest
trubachoff added a comment to T5816: Unhandled Exception ("AphrontQueryException").
In T5816#7, @epriestley wrote:

Can you show us the output of this command?

phabricator/ $ ./bin/storage upgrade

`$ ./bin/storage upgrade
Before running storage upgrades, you should take down the Phabricator web
interface and stop any running Phabricator daemons (you can disable this
warning with --force).

Aug 13 2014, 10:21 AM · Aphront, Maniphest