Paths

Table of Contentst

Differential D13748

Update Auth for handleRequest
ClosedPublic
Actions

Authored by chad on Jul 28 2015, 6:48 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 27, 5:31 PM

	Unknown Object (File)
	Sat, Dec 14, 5:31 PM

	Unknown Object (File)
	Fri, Dec 6, 4:58 AM

	Unknown Object (File)
	Thu, Dec 5, 7:57 PM

	Unknown Object (File)
	Sun, Dec 1, 10:07 AM

	Unknown Object (File)
	Nov 24 2024, 11:41 PM

	Unknown Object (File)
	Nov 20 2024, 1:38 PM

	Unknown Object (File)
	Nov 11 2024, 5:18 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T8628: Modernize AphrontControllers to implement handleRequest

Commits

Restricted Diffusion Commit
rP36103dfa182c: Update Auth for handleRequest

Summary

Updates Auth app for handleRequest

Test Plan

Tested what I could, Log in, Log out, Change Password, New account, Verify account... but extra eyes very helpful here.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 33208.Jul 28 2015, 6:48 PM

chad retitled this revision from to Update Auth for handleRequest.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptJul 28 2015, 6:48 PM

chad added inline comments.Jul 28 2015, 6:57 PM

src/applications/auth/controller/PhabricatorAuthInviteController.php
11 ↗	(On Diff #33208)	maybe this is wrong
src/applications/auth/controller/PhabricatorAuthUnlinkController.php
115	derp
src/applications/auth/controller/PhabricatorEmailLoginController.php
11	derp2

clean up derps

chad added a task: T8628: Modernize AphrontControllers to implement handleRequest.Jul 29 2015, 5:23 PM

epriestley accepted this revision.Aug 1 2015, 10:42 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/auth/controller/PhabricatorAuthInviteController.php
11 ↗	(On Diff #33209)	`$request->getViewer()` and `$this->getViewer()` do exactly the same thing, but `$this->getViewer()` is the newer / more-preferred mechanism. It works more consistently in more places.

This revision is now accepted and ready to land.Aug 1 2015, 10:42 PM

clean up derps
Update to $viewer = $this->getViewer();

Closed by commit rP36103dfa182c: Update Auth for handleRequest (authored by chad, committed by chad). · Explain WhyAug 1 2015, 11:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

auth/

controller/

PhabricatorAuthConfirmLinkController.php

14 lines

PhabricatorAuthDowngradeSessionController.php

5 lines

PhabricatorAuthFinishController.php

5 lines

PhabricatorAuthLinkController.php

25 lines

PhabricatorAuthLoginController.php

12 lines

PhabricatorAuthNeedsApprovalController.php

7 lines

PhabricatorAuthNeedsMultiFactorController.php

5 lines

PhabricatorAuthOldOAuthRedirectController.php

14 lines

PhabricatorAuthOneTimeLoginController.php

30 lines

PhabricatorAuthRegisterController.php

15 lines

PhabricatorAuthRevokeTokenController.php

16 lines

PhabricatorAuthSSHKeyEditController.php

2 lines

PhabricatorAuthTerminateSessionController.php

16 lines

PhabricatorAuthUnlinkController.php

10 lines

PhabricatorAuthValidateController.php

5 lines

PhabricatorDisabledUserController.php

11 lines

PhabricatorEmailLoginController.php

3 lines

PhabricatorEmailVerificationController.php

26 lines

PhabricatorLogoutController.php

13 lines

PhabricatorMustVerifyEmailController.php

13 lines

PhabricatorRefreshCSRFController.php

7 lines

Diff 33263

src/applications/auth/controller/PhabricatorAuthConfirmLinkController.php

Loading...

src/applications/auth/controller/PhabricatorAuthDowngradeSessionController.php

Loading...

src/applications/auth/controller/PhabricatorAuthFinishController.php

Loading...

src/applications/auth/controller/PhabricatorAuthLinkController.php

Loading...

src/applications/auth/controller/PhabricatorAuthLoginController.php

Loading...

src/applications/auth/controller/PhabricatorAuthNeedsApprovalController.php

Loading...

src/applications/auth/controller/PhabricatorAuthNeedsMultiFactorController.php

Loading...

src/applications/auth/controller/PhabricatorAuthOldOAuthRedirectController.php

Loading...

src/applications/auth/controller/PhabricatorAuthOneTimeLoginController.php

Loading...

src/applications/auth/controller/PhabricatorAuthRegisterController.php

Loading...

src/applications/auth/controller/PhabricatorAuthRevokeTokenController.php

Loading...

src/applications/auth/controller/PhabricatorAuthSSHKeyEditController.php

Loading...

src/applications/auth/controller/PhabricatorAuthTerminateSessionController.php

Loading...

src/applications/auth/controller/PhabricatorAuthUnlinkController.php

Loading...

src/applications/auth/controller/PhabricatorAuthValidateController.php

Loading...

src/applications/auth/controller/PhabricatorDisabledUserController.php

Loading...

src/applications/auth/controller/PhabricatorEmailLoginController.php

Loading...

src/applications/auth/controller/PhabricatorEmailVerificationController.php

Loading...

src/applications/auth/controller/PhabricatorLogoutController.php

Loading...

src/applications/auth/controller/PhabricatorMustVerifyEmailController.php

Loading...

src/applications/auth/controller/PhabricatorRefreshCSRFController.php

Loading...