Page MenuHomePhabricator

Move DarkConsole to an application
ClosedPublic

Authored by epriestley on Oct 13 2014, 5:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 10, 2:01 AM
Unknown Object (File)
Sat, Mar 30, 3:55 AM
Unknown Object (File)
Mon, Mar 25, 1:46 PM
Unknown Object (File)
Mon, Mar 25, 1:45 PM
Unknown Object (File)
Sun, Mar 24, 7:11 AM
Unknown Object (File)
Mar 19 2024, 10:28 PM
Unknown Object (File)
Feb 21 2024, 12:45 PM
Unknown Object (File)
Jan 28 2024, 4:49 AM

Details

Summary

Ref T5702. Primarily, this gets the custom DarkConsole URI routes out of the Aphront core and into an Application, like almost all other routes.

Test Plan

Used DarkConsole.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Move DarkConsole to an application.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Oct 13 2014, 5:43 PM
This revision was automatically updated to reflect the committed changes.

After a git pull today, I get

[Core Exception/PhutilBootloaderException] Include of '*cleaned*/phabricator/src/aphront/console/plugin/event/DarkConsoleEventPluginAPI.php' failed!

when visiting my phab installation.

Then (maybe assuming too much :)) it seems that https://github.com/phacility/phabricator/blob/af4ebc67c66fb90bc6d73ea42ddb8d2bd7ba9dac/scripts/install/update_phabricator.sh doesn't mention "arc liberate" (which I found from $ head src/__phutil_library_map__.php) and thus have wrong paths.

OK then, trying arc liberate:

$ arc liberate
Finding source files...
Found 2,879 files.
Loading symbol cache...
Found 0 files in cache.
Analyzing 2,879 files with 8 subprocesses...
[2014-10-14 11:36:31] EXCEPTION: (CommandException) Command failed with error #137!
COMMAND
php '*cleaned*/libphutil/src/moduleutils/../../scripts/phutil_symbols.php' --ugly -- '*cleaned*/phabricator/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php'

STDOUT
(empty)

STDERR
Killed
 at [<phutil>/src/future/exec/ExecFuture.php:397]
  #0 ExecFuture::resolvex(NULL) called at [<phutil>/src/future/exec/ExecFuture.php:419]
  #1 ExecFuture::resolveJSON() called at [<phutil>/src/moduleutils/PhutilLibraryMapBuilder.php:458]
  #2 PhutilLibraryMapBuilder::analyzeLibrary() called at [<phutil>/src/moduleutils/PhutilLibraryMapBuilder.php:77]
  #3 PhutilLibraryMapBuilder::buildMap() called at [<phutil>/src/moduleutils/PhutilLibraryMapBuilder.php:109]
  #4 PhutilLibraryMapBuilder::buildAndWriteMap() called at [<phutil>/scripts/phutil_rebuild_map.php:72]

I get different errors for each time, but always with #137. Googling leads me to timeouts but I'm thinking - I'll just stop here for a while and confirm that I'm on the right track :)

The revisions I am using:
arcanist
52947cfd92b331916adffa1ff3233546446c881b

libphutil
160eeba602bf5329ec7fee0fc0834e924557d9b3

phabricator
af4ebc67c66fb90bc6d73ea42ddb8d2bd7ba9dac

(Do you want me to create a new bug for this instead of keeping a conversation here, or how should I continue?)

Restart Apache or php-fpm. APC has cached an old map, including an old path. Use a script like this to update Phabricator and make sure APC is flushed when you restart:

https://secure.phabricator.com/diffusion/P/browse/master/scripts/install/update_phabricator.sh

Restart Apache or php-fpm. APC has cached an old map, including an old path. Use a script like this to update Phabricator and make sure APC is flushed when you restart:

https://secure.phabricator.com/diffusion/P/browse/master/scripts/install/update_phabricator.sh

This fixed it for me. Thanks.