Page MenuHomePhabricator
Differential D13767

Update Notifications for handleRequest
ClosedPublic
Actions

Authored by chad on Aug 1 2015, 2:18 AM.
Tags
None
Referenced Files
F14060687: D13767.diff
Mon, Nov 18, 2:59 AM
F14046167: D13767.diff
Wed, Nov 13, 6:56 PM
F14042599: D13767.diff
Tue, Nov 12, 4:43 AM
F14039342: D13767.id33294.diff
Mon, Nov 11, 5:18 AM
F14034941: D13767.diff
Sun, Nov 10, 3:05 AM
F14023482: D13767.id33294.diff
Thu, Nov 7, 2:17 AM
F14021724: D13767.diff
Wed, Nov 6, 11:44 AM
F14016034: D13767.diff
Mon, Nov 4, 4:30 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T8628: Modernize AphrontControllers to implement handleRequest
Commits
Restricted Diffusion Commit
rPf5be68c59c39: Update Notifications for handleRequest
Summary

Updates Notifcations for handleRequest

Test Plan

Test as much as I could, mark all, view, lists.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad updated this revision to Diff 33244.Aug 1 2015, 2:18 AM
chad retitled this revision from to Update Notifications for handleRequest.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 1 2015, 2:18 AM
chad added a task: T8628: Modernize AphrontControllers to implement handleRequest.Aug 1 2015, 5:02 PM
epriestley requested changes to this revision.Aug 1 2015, 10:36 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/notification/controller/PhabricatorNotificationClearController.php
10

getStr() and getURIData() are not the same.

getStr() reads values out of the query parameters, like /?chronoKey=123. getURIData() reads the route regexps.

For example, a URI like /task/edit/123/?id=456 might return 123 from getURIData(), but 456 from getInt().

This should stay as getStr().

This revision now requires changes to proceed.Aug 1 2015, 10:36 PM
chad marked an inline comment as done.Aug 2 2015, 12:08 AM

thanks for the info!

chad updated this revision to Diff 33267.Aug 2 2015, 12:09 AM
chad edited edge metadata.
  • Fix getStr
epriestley accepted this revision.Aug 4 2015, 4:32 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Aug 4 2015, 4:32 PM
Closed by commit rPf5be68c59c39: Update Notifications for handleRequest (authored by chad, committed by chad). · Explain WhyAug 4 2015, 4:33 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 33294

View Options

src/applications/notification/controller/PhabricatorNotificationClearController.php

Loading...
View Options

src/applications/notification/controller/PhabricatorNotificationIndividualController.php

Loading...
View Options

src/applications/notification/controller/PhabricatorNotificationListController.php

Loading...
View Options

src/applications/notification/controller/PhabricatorNotificationPanelController.php

Loading...
View Options

src/applications/notification/controller/PhabricatorNotificationStatusController.php

Loading...
View Options

src/applications/notification/controller/PhabricatorNotificationTestController.php

Loading...
Phabricator · Built by Phacility