Page MenuHomePhabricator
Create Task
Maniphest T7486

All responses use "OK" as the status text
Closed, ResolvedPublic
Actions

Description

It seems that all Aphront responses use OK as the status text, regardless of the actual response code.

404.png (744×1 px, 95 KB)

Revisions and Commits

rP Phabricator
D12299rPb2c23d88e8f9 Implement HTTP response messages

Event Timeline

joshuaspence created this task.Mar 7 2015, 1:53 AM
joshuaspence raised the priority of this task from to Needs Triage.
joshuaspence updated the task description. (Show Details)
joshuaspence added a project: Aphront.
joshuaspence added a subscriber: joshuaspence.
joshuaspence added a comment.Mar 8 2015, 1:20 AM

Specifically, in the screenshot shown, the response is shown as 404 OK instead of 404 Not Found.

joshuaspence claimed this task.Mar 8 2015, 1:23 AM

I might give this a go.

joshuaspence added a revision: D12299: Implement HTTP response messages.Apr 6 2015, 12:53 PM
joshuaspence closed this task as Resolved by committing rPb2c23d88e8f9: Implement HTTP response messages.Apr 6 2015, 9:43 PM
joshuaspence added a commit: rPb2c23d88e8f9: Implement HTTP response messages.
GMTA added a subscriber: GMTA.Apr 7 2015, 8:03 AM

Hi, I'm not sure how Phabricator handles compatibility libraries but PHP has http_response_code() available which sets the status code and message in one go. The fix for this task could be introduced as a compat method for PHP < 5.4.

Phabricator · Built by Phacility