Page MenuHomePhabricator

Partially update Maniphest for handleProcess
ClosedPublic

Authored by chad on Aug 1 2015, 4:49 PM.
Tags
None
Referenced Files
F15457865: D13773.diff
Sun, Mar 30, 7:34 PM
F15441198: D13773.id33265.diff
Wed, Mar 26, 4:53 PM
F15426584: D13773.id33265.diff
Sun, Mar 23, 9:51 AM
F15426583: D13773.id33251.diff
Sun, Mar 23, 9:51 AM
Unknown Object (File)
Mon, Mar 3, 5:42 PM
Unknown Object (File)
Feb 21 2025, 8:26 PM
Unknown Object (File)
Feb 18 2025, 4:41 AM
Unknown Object (File)
Feb 13 2025, 3:31 AM
Subscribers

Details

Summary

Starts conversion of Maniphest to handleProcess, chopping up to reduce errors.

Test Plan

New Task, Edit Task, Change Priority, Move on workboard, view reports, batch edit tasks

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

chad retitled this revision from to Partially update Maniphest for handleProcess.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/maniphest/controller/ManiphestBatchEditController.php
6 ↗(On Diff #33251)

$this->getViewer() is preferred.

src/applications/maniphest/controller/ManiphestExportController.php
16–17

Or $dialog = $this->newDialog(); to automatically set the user.

This revision is now accepted and ready to land.Aug 1 2015, 10:34 PM
chad marked 2 inline comments as done.
chad edited edge metadata.
  • full update
This revision was automatically updated to reflect the committed changes.