Paths

Table of Contentst

Differential D13773

Partially update Maniphest for handleProcess
ClosedPublic
Actions

Authored by chad on Aug 1 2015, 4:49 PM.

Tags

None

Referenced Files

	F14057094: D13773.diff
	Sun, Nov 17, 12:23 AM

	F14043774: D13773.diff
	Tue, Nov 12, 12:48 PM

	F14039984: D13773.id33265.diff
	Mon, Nov 11, 7:00 AM

	F14039351: D13773.id33251.diff
	Mon, Nov 11, 5:18 AM

	F14039350: D13773.diff
	Mon, Nov 11, 5:18 AM

	F14023492: D13773.id33251.diff
	Thu, Nov 7, 2:27 AM

	F14023490: D13773.diff
	Thu, Nov 7, 2:21 AM

	F14014688: D13773.id33266.diff
	Sun, Nov 3, 6:43 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T8628: Modernize AphrontControllers to implement handleRequest

Commits

Restricted Diffusion Commit
rP3b0ca7b76995: Partially update Maniphest for handleProcess

Summary

Starts conversion of Maniphest to handleProcess, chopping up to reduce errors.

Test Plan

New Task, Edit Task, Change Priority, Move on workboard, view reports, batch edit tasks

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 33251.Aug 1 2015, 4:49 PM

chad retitled this revision from to Partially update Maniphest for handleProcess.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 1 2015, 4:49 PM

chad added a task: T8628: Modernize AphrontControllers to implement handleRequest.Aug 1 2015, 5:02 PM

epriestley accepted this revision.Aug 1 2015, 10:34 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/maniphest/controller/ManiphestBatchEditController.php
6 ↗	(On Diff #33251)	`$this->getViewer()` is preferred.
src/applications/maniphest/controller/ManiphestExportController.php
16–17	Or `$dialog = $this->newDialog();` to automatically set the user.

This revision is now accepted and ready to land.Aug 1 2015, 10:34 PM

full update

Closed by commit rP3b0ca7b76995: Partially update Maniphest for handleProcess (authored by chad, committed by chad). · Explain WhyAug 2 2015, 12:07 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

maniphest/

controller/

ManiphestExportController.php

36 lines

ManiphestReportController.php

40 lines

ManiphestSubpriorityController.php

11 lines

ManiphestTaskDetailController.php

41 lines

ManiphestTaskEditController.php

76 lines

ManiphestTaskListController.php

10 lines

ManiphestTransactionPreviewController.php

27 lines

ManiphestTransactionSaveController.php

25 lines

Diff 33266

src/applications/maniphest/controller/ManiphestExportController.php

Loading...

src/applications/maniphest/controller/ManiphestReportController.php

Loading...

src/applications/maniphest/controller/ManiphestSubpriorityController.php

Loading...

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Loading...

src/applications/maniphest/controller/ManiphestTaskEditController.php

Loading...

src/applications/maniphest/controller/ManiphestTaskListController.php

Loading...

src/applications/maniphest/controller/ManiphestTransactionPreviewController.php

Loading...

src/applications/maniphest/controller/ManiphestTransactionSaveController.php

Loading...