Page MenuHomePhabricator

Partially update Maniphest for handleProcess
ClosedPublic

Authored by chad on Aug 1 2015, 4:49 PM.

Details

Summary

Starts conversion of Maniphest to handleProcess, chopping up to reduce errors.

Test Plan

New Task, Edit Task, Change Priority, Move on workboard, view reports, batch edit tasks

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

chad updated this revision to Diff 33251.Aug 1 2015, 4:49 PM
chad retitled this revision from to Partially update Maniphest for handleProcess.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley accepted this revision.Aug 1 2015, 10:34 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/maniphest/controller/ManiphestBatchEditController.php
6 ↗(On Diff #33251)

$this->getViewer() is preferred.

src/applications/maniphest/controller/ManiphestExportController.php
16–17

Or $dialog = $this->newDialog(); to automatically set the user.

This revision is now accepted and ready to land.Aug 1 2015, 10:34 PM
chad updated this revision to Diff 33265.Aug 2 2015, 12:03 AM
chad marked 2 inline comments as done.
chad edited edge metadata.
  • full update
This revision was automatically updated to reflect the committed changes.