Page MenuHomePhabricator
Create Task
Maniphest T13365

Conduit API method "diffusion.historyquery" fatals under Git/Mercurial if passed a bad "commit"
Open, LowPublic
Actions

Description

See https://discourse.phabricator-community.org/t/unhandled-exception-when-going-to-a-tag-that-does-not-exist-in-diffusion/2991.

If you specify an invalid commit/refname to diffusion.historyquery, the call fatals.

At time of writing, this can be reproduced here:

https://secure.phabricator.com/source/libphutil/history/master/;does-not-exist

The API call should have better behavior, and the UI on top of it should have friendlier messaging.

Related Objects

Event Timeline

epriestley triaged this task as Low priority.Aug 2 2019, 1:58 PM
epriestley created this task.
Herald added a subscriber: amckinley. · View Herald TranscriptAug 2 2019, 1:58 PM
nfirmani added a subscriber: nfirmani.Aug 8 2019, 7:28 PM
cspeckmim renamed this task from Conduit API method "diffusion.historyquery" fatals under Git if passed a bad "commit" to Conduit API method "diffusion.historyquery" fatals if passed a bad "commit".Sep 3 2021, 10:23 PM
cspeckmim renamed this task from Conduit API method "diffusion.historyquery" fatals if passed a bad "commit" to Conduit API method "diffusion.historyquery" fatals under Git/Mercurial if passed a bad "commit".
cspeckmim mentioned this in T13666: Improve error-handling behavior of Diffusion repository landing page on non-clustered installations.
Phabricator · Built by Phacility