Page MenuHomePhabricator

Conduit API method "diffusion.historyquery" fatals under Git/Mercurial if passed a bad "commit"
Open, LowPublic

Description

See https://discourse.phabricator-community.org/t/unhandled-exception-when-going-to-a-tag-that-does-not-exist-in-diffusion/2991.

If you specify an invalid commit/refname to diffusion.historyquery, the call fatals.

At time of writing, this can be reproduced here:

https://secure.phabricator.com/source/libphutil/history/master/;does-not-exist

The API call should have better behavior, and the UI on top of it should have friendlier messaging.

Event Timeline

epriestley created this task.
cspeckmim renamed this task from Conduit API method "diffusion.historyquery" fatals under Git if passed a bad "commit" to Conduit API method "diffusion.historyquery" fatals if passed a bad "commit".Fri, Sep 3, 10:23 PM
cspeckmim renamed this task from Conduit API method "diffusion.historyquery" fatals if passed a bad "commit" to Conduit API method "diffusion.historyquery" fatals under Git/Mercurial if passed a bad "commit".