Page MenuHomePhabricator
Differential D20775

Allow repository service lookups to return an ordered list of service refs
ClosedPublic
Actions

Authored by epriestley on Sep 3 2019, 3:58 PM.
Tags
None
Referenced Files
F18092703: D20775.id49540.diff
Thu, Aug 7, 12:31 PM
F18092702: D20775.id.diff
Thu, Aug 7, 12:31 PM
F18092229: D20775.id49537.diff
Thu, Aug 7, 8:51 AM
F17949746: D20775.id49537.diff
Thu, Jul 31, 11:48 PM
F17939723: D20775.diff
Thu, Jul 31, 3:22 AM
F17824938: D20775.diff
Jul 26 2025, 5:54 AM
F17638272: D20775.diff
Jul 11 2025, 4:29 PM
Unknown Object (File)
Jun 27 2025, 12:38 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover
Commits
rPb6420e0f0ad8: Allow repository service lookups to return an ordered list of service refs
Summary

Ref T13286. To support request retries, allow the service lookup method to return an ordered list of structured service references.

Existing callsites continue to immediately discard all but the first reference and pull a URI out of it.

Test Plan

Ran git pull in a clustered repository with an "up" node and a "down" node, saw 50% serivce failures and 50% clean pulls.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Sep 3 2019, 3:58 PM
Harbormaster completed remote builds in B23363: Diff 49537.Sep 3 2019, 4:00 PM
epriestley requested review of this revision.Sep 3 2019, 4:00 PM
epriestley added a child revision: D20776: On Git cluster read failure, retry safe requests.Sep 3 2019, 4:50 PM
This revision was not accepted when it landed; it landed in state Needs Review.Sep 3 2019, 5:05 PM
Closed by commit rPb6420e0f0ad8: Allow repository service lookups to return an ordered list of service refs (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.
epriestley added a commit: rPb6420e0f0ad8: Allow repository service lookups to return an ordered list of service refs.
epriestley mentioned this in D21576: Correct behavior of "writable" Almanac service binding for repository services.Feb 25 2021, 8:15 PM
epriestley added inline comments.Feb 25 2021, 8:21 PM
src/applications/repository/storage/PhabricatorRepository.php
1980

This variable should have been renamed. See T13611.

epriestley mentioned this in rPf970b350ea2f: Correct behavior of "writable" Almanac service binding for repository services.Feb 25 2021, 8:29 PM
epriestley mentioned this in D19357: Allow repository cluster bindings to be marked as not "writable", making them read-only.Feb 25 2021, 8:30 PM
epriestley mentioned this in T13611: In clusters, "writable" property on bindings may not actually prevent writes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
ref/
48 lines
ssh/
22 lines
repository/
storage/
62 lines

Diff 49540

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/diffusion/ref/DiffusionServiceRef.php

Loading...
View Options

src/applications/diffusion/ssh/DiffusionSSHWorkflow.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepository.php

Loading...
Phabricator · Built by Phacility