Page MenuHomePhabricator

Correct a parameter order swap in "diffusion.historyquery" for Mercurial
ClosedPublic

Authored by epriestley on Sep 5 2021, 12:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 12, 6:58 PM
Unknown Object (File)
Tue, Mar 5, 8:49 AM
Unknown Object (File)
Mon, Feb 19, 6:01 PM
Unknown Object (File)
Feb 14 2024, 4:17 AM
Unknown Object (File)
Feb 10 2024, 8:12 PM
Unknown Object (File)
Feb 4 2024, 1:25 AM
Unknown Object (File)
Feb 2 2024, 3:29 AM
Unknown Object (File)
Jan 10 2024, 10:08 AM
Subscribers
None

Details

Summary

Ref T13666. See T13666#256253. The order of these parameters is incorrect (introduced in D18817, which was trying to turn the revset "A or B" into "B or A"), but when "commit" is the single head of "branch" (which is common), the revset is functionally equivalent.

Test Plan

An easy reproduction case is to make a "diffusion.historyquery" call manually against a Mercurial repository, with a valid "branch" name and some non-head "commit".

  • Before patch, queried "head^" (by commit hash, not by symbol) of "default" and got "head" too (wrong).
  • Applied patch to secure001.phacility.net (my local hg web environment is iffy right now).
  • Re-ran the same query, saw "head^" as the first result rather than "head" (all hashes rather than symbols, as above), which is desired.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable