Page MenuHomePhabricator

Internally, align commit processing tasks around PHIDs, not IDs
ClosedPublic

Authored by epriestley on Feb 1 2021, 8:07 PM.

Details

Summary

Ref T13591. This is a minor consistency change to use PHIDs instead of IDs in the commit import processing pipeline. PHIDs are generally more powerful in more contexts and it would be unusual for a modern worker to use an ID here.

Test Plan
  • Made the "accept either ID or PHID" part of the change only.
  • Pushed a commit, parsed and reparsed it step by step (this tests that "commitID" tasks can still process normally).
  • Made the "write PHIDs" part of the change.
  • Pushed a commit, parsed and reparsed it step by step.
  • Looked at the task row in the database, saw PHID data.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 2 2021, 9:40 PM
This revision was automatically updated to reflect the committed changes.