Differential D21576

Correct behavior of "writable" Almanac service binding for repository services
ClosedPublic
Actions

Authored by epriestley on Feb 25 2021, 8:15 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 14, 2:42 PM

	Unknown Object (File)
	Thu, Nov 14, 6:53 AM

	Unknown Object (File)
	Thu, Nov 14, 6:41 AM

	Unknown Object (File)
	Thu, Nov 14, 6:40 AM

	Unknown Object (File)
	Thu, Nov 14, 6:20 AM

	Unknown Object (File)
	Wed, Nov 6, 12:25 AM

	Unknown Object (File)
	Wed, Nov 6, 12:25 AM

	Unknown Object (File)
	Wed, Nov 6, 12:25 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13611: In clusters, "writable" property on bindings may not actually prevent writes
Commits: rPf970b350ea2f: Correct behavior of "writable" Almanac service binding for repository services

Summary

Ref T13611. This property worked correctly when implemented in D19357. The behavior was broken by D20775, which tested node-level routing but did not specifically re-test the "writable" property. This was difficult to spot because ref query outcomes weren't observable in the UI, and the ref itself had the correct property value.

Test Plan

See D21575. After this change, the UI shows the correct state, rather than showing a read-only service ref as writable:

Screen Shot 2021-02-25 at 12.13.24 PM.png (384×721 px, 43 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Feb 25 2021, 8:15 PM

Harbormaster completed remote builds in B25170: Diff 51362.Feb 25 2021, 8:16 PM

epriestley requested review of this revision.Feb 25 2021, 8:16 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 25 2021, 8:29 PM

Closed by commit rPf970b350ea2f: Correct behavior of "writable" Almanac service binding for repository services (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley added a commit: rPf970b350ea2f: Correct behavior of "writable" Almanac service binding for repository services.

epriestley mentioned this in D19357: Allow repository cluster bindings to be marked as not "writable", making them read-only.Feb 25 2021, 8:30 PM

epriestley mentioned this in T13611: In clusters, "writable" property on bindings may not actually prevent writes.

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

storage/

PhabricatorRepository.php

2 lines

Diff 51363

src/applications/repository/storage/PhabricatorRepository.php

Loading...