Page MenuHomePhabricator
Feed All Stories

Oct 25 2019

epriestley moved T13434: Support Perforce/Git in "arc land" from Backlog to arc land on the Arcanist board.
Oct 25 2019, 6:02 PM · Arcanist
epriestley added a comment to T13434: Support Perforce/Git in "arc land".

Why not just implement the basic path for arc land and fail with an error if the user has some esoteric setup?

Oct 25 2019, 5:54 PM · Arcanist
swisspol added a comment to T13434: Support Perforce/Git in "arc land".

It's possible I'm misreading/misunderstanding this, so maybe the right algorithm is actually to select the "p4" remote ahead of the "origin" remote, i.e. swap steps (2) and (3).

Oct 25 2019, 5:17 PM · Arcanist
epriestley triaged T13435: When "phabricator.base-uri" changes, the repository "uriindex" table must be rebuilt as Low priority.
Oct 25 2019, 10:43 AM · Diffusion
epriestley added a comment to T13434: Support Perforce/Git in "arc land".

the config with the dépôt path to “fetch” latest changelists from is saved inside .git directory

Oct 25 2019, 10:26 AM · Arcanist
swisspol added a comment to T13434: Support Perforce/Git in "arc land".

You don’t need to pass any arguments to git p4 sync: the config with the dépôt path to “fetch” latest changelists from is saved inside .git directory. Did you follow the exact instructions I provided?

Oct 25 2019, 6:43 AM · Arcanist
epriestley added a comment to T13434: Support Perforce/Git in "arc land".

I got Git/Perforce working after a large amount of bashing my head into errors like these:

Oct 25 2019, 3:20 AM · Arcanist
epriestley triaged T13434: Support Perforce/Git in "arc land" as Low priority.
Oct 25 2019, 2:12 AM · Arcanist
epriestley closed T13431: Make "Members" lists in projects more clear about disabled members as Resolved by committing Restricted Diffusion Commit.
Oct 25 2019, 1:41 AM · Projects
epriestley closed T13433: Continue showing custom login instructions on provider-specific login screens as Resolved by committing Restricted Diffusion Commit.
Oct 25 2019, 1:38 AM · Auth
epriestley added a revision to T13431: Make "Members" lists in projects more clear about disabled members: Unknown Object (Differential Revision).
Oct 25 2019, 1:35 AM · Projects
epriestley added a revision to T13433: Continue showing custom login instructions on provider-specific login screens: Unknown Object (Differential Revision).
Oct 25 2019, 1:07 AM · Auth
epriestley triaged T13433: Continue showing custom login instructions on provider-specific login screens as Low priority.
Oct 25 2019, 12:56 AM · Auth
epriestley closed T13430: Provide more information in "diffusion.repository.search" (default branch, description, last push date) as Resolved by committing Restricted Diffusion Commit.
Oct 25 2019, 12:17 AM · Conduit, Diffusion

Oct 24 2019

epriestley added a revision to T13430: Provide more information in "diffusion.repository.search" (default branch, description, last push date): Restricted Differential Revision.
Oct 24 2019, 11:44 PM · Conduit, Diffusion
epriestley added a comment to T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly.

One change we can make here is to explicitly specify -c diff.suppressBlankEmpty false in the arc diff command, as we currently use --src-prefix and --dst-prefix to override diff.mnemonicprefix. This is likely desirable, but it would be good to also parse these diffs properly if they arrive through --raw or copy/pasting, etc.

Oct 24 2019, 11:02 PM · Differential
dennisv updated dennisv.
Oct 24 2019, 3:59 PM
Pawka awarded T1022: arc patch fails to properly apply a patch which changes a symlink to a real file a Like token.
Oct 24 2019, 5:48 AM · Arcanist
epriestley renamed T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly from Diffs that have had tailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly to Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly.
Oct 24 2019, 2:43 AM · Differential
epriestley added a parent task for T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly: T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats.
Oct 24 2019, 2:43 AM · Differential
epriestley added a subtask for T12664: Update diff/patch parsing to extract more metadata and parse a wider range of formats: T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly.
Oct 24 2019, 2:43 AM · Arcanist, Differential
epriestley triaged T13432: Diffs that have had trailing whitespace trimmed or were generated with the Git "diff.suppressBlankEmpty" config option render oddly as Wishlist priority.
Oct 24 2019, 2:43 AM · Differential

Oct 22 2019

swisspol edited P2123 Masterwork From Distant Lands.
Oct 22 2019, 9:33 PM
epriestley triaged T13431: Make "Members" lists in projects more clear about disabled members as Low priority.
Oct 22 2019, 5:38 PM · Projects
artms added a revision to T13416: Transaction logs may overheat explosively: Unknown Object (Differential Revision).
Oct 22 2019, 7:43 AM · Feed

Oct 18 2019

artms added a comment to T13427: Task to reproduce lack of transaction object validation.

Thanks!

Oct 18 2019, 6:35 AM · artms

Oct 17 2019

epriestley triaged T13430: Provide more information in "diffusion.repository.search" (default branch, description, last push date) as Low priority.
Oct 17 2019, 5:27 PM · Conduit, Diffusion
epriestley closed T13427: Task to reproduce lack of transaction object validation as Resolved.

This now renders properly; see T13429 for followup.

Oct 17 2019, 5:03 PM · artms
epriestley added a revision to T13429: Edge transactions are broadly non-modular and lack transaction hooks, including hooks for validation behavior: Unknown Object (Differential Revision).
Oct 17 2019, 4:43 PM · Transactions
epriestley triaged T13429: Edge transactions are broadly non-modular and lack transaction hooks, including hooks for validation behavior as Low priority.
Oct 17 2019, 4:34 PM · Transactions
epriestley closed T13428: PHP 7.4 now warns about "implode()" argument order as Resolved by committing Restricted Diffusion Commit.
Oct 17 2019, 4:11 PM · Infrastructure
epriestley updated the task description for T13428: PHP 7.4 now warns about "implode()" argument order.
Oct 17 2019, 4:08 PM · Infrastructure
epriestley added a revision to T13428: PHP 7.4 now warns about "implode()" argument order: Unknown Object (Differential Revision).
Oct 17 2019, 4:07 PM · Infrastructure
epriestley added a revision to T13428: PHP 7.4 now warns about "implode()" argument order: Unknown Object (Differential Revision).
Oct 17 2019, 4:05 PM · Infrastructure
epriestley added a revision to T13428: PHP 7.4 now warns about "implode()" argument order: Unknown Object (Differential Revision).
Oct 17 2019, 4:03 PM · Infrastructure
epriestley triaged T13428: PHP 7.4 now warns about "implode()" argument order as Low priority.
Oct 17 2019, 4:03 PM · Infrastructure

Oct 15 2019

Krinkle added a comment to T13421: Implement OpenGraph metadata in Phame for Twitter cards.

I did some trial and error last week with Twitter via https://cards-dev.twitter.com/validator. That was for my personal blog, but some of it might apply here as well.

Oct 15 2019, 12:46 AM · Phame
Krinkle updated Krinkle.
Oct 15 2019, 12:19 AM
Krinkle updated Krinkle.
Oct 15 2019, 12:18 AM
Krinkle updated Krinkle.
Oct 15 2019, 12:17 AM

Oct 14 2019

artms added a project to T13427: Task to reproduce lack of transaction object validation: artms.
Oct 14 2019, 11:46 AM · artms
artms created T13427: Task to reproduce lack of transaction object validation.
Oct 14 2019, 11:45 AM · artms

Oct 10 2019

epriestley added a comment to T13322: Allow parent projects to have direct members.

See PHI1492. After this change, the parent/subproject modes of the script in T10350 can be brought upstream safely, since they would no longer be destructive operations on membership lists. This wouldn't cover the "convert a project into a milestone" mode, but that seems less important.

Oct 10 2019, 2:51 PM · Projects
epriestley added a parent task for T10350: Scripts to migrate old "points" fields and move projects beneath other projects: T13322: Allow parent projects to have direct members.
Oct 10 2019, 2:50 PM · Projects (v3)
epriestley added a subtask for T13322: Allow parent projects to have direct members: T10350: Scripts to migrate old "points" fields and move projects beneath other projects.
Oct 10 2019, 2:50 PM · Projects
epriestley added a revision to T13416: Transaction logs may overheat explosively: Unknown Object (Differential Revision).
Oct 10 2019, 2:35 PM · Feed

Oct 8 2019

20after4 awarded T13419: Fully modularize object relationships, to support custom relationships like "Subtask/Parent Task" a Love token.
Oct 8 2019, 9:57 PM · Infrastructure

Oct 7 2019

slashsBin updated slashsBin.
Oct 7 2019, 11:06 PM

Oct 3 2019

woodings added a comment to E1672: Test demo.

1231231

Oct 3 2019, 5:29 PM

Oct 2 2019

epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: Unknown Object (Differential Revision).
Oct 2 2019, 3:50 PM · Differential

Oct 1 2019

mcorteel awarded T13410: Update Phriction UI structural behaviors a Love token.
Oct 1 2019, 6:32 AM · Phriction

Sep 30 2019

epriestley edited the content of Changelog.
Sep 30 2019, 6:12 PM
epriestley created an object: 2019 Week 39 (Very Late September).
Sep 30 2019, 6:08 PM
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: Unknown Object (Differential Revision).
Sep 30 2019, 5:34 PM · Differential
epriestley added a comment to T13425: Support diffs between abstract block lists in the UI.

Context isn't automatically unfolding around inlines, but should.

Sep 30 2019, 5:28 PM · Differential
epriestley added a comment to T13425: Support diffs between abstract block lists in the UI.

Oh, and maybe lack of source code intraline diffs, although that's likely not too much work.

Sep 30 2019, 5:24 PM · Differential
epriestley added a comment to T13425: Support diffs between abstract block lists in the UI.

I think the major remaining issues are:

Sep 30 2019, 4:26 PM · Differential

Sep 28 2019

epriestley edited the content of Migrating Repository Shards.
Sep 28 2019, 2:59 PM · Phacility
epriestley edited the content of Phacility Cluster Documentation.
Sep 28 2019, 2:59 PM
epriestley created an object: Migrating Repository Shards.
Sep 28 2019, 2:59 PM · Phacility
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: Unknown Object (Differential Revision).
Sep 28 2019, 12:25 AM · Differential

Sep 27 2019

epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: Unknown Object (Differential Revision).
Sep 27 2019, 9:31 PM · Differential
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: Unknown Object (Differential Revision).
Sep 27 2019, 8:18 PM · Differential
epriestley added a comment to T13426: Add a "Saved States" indirection layer on top of "Staging Areas".

One broad problem here is "chain of custody" issues in T182. A "Saved State" can easily accommodate multiple representations, and the plan above imagines using Drydock to build tags/branches out of non-repository representations, so we'd have cases where a given "Saved State" has a way to build it with a "patch list" (from the client) or a "ref pointer" (from Drydock).

Sep 27 2019, 6:43 PM · Harbormaster, Drydock, Arcanist
epriestley triaged T13426: Add a "Saved States" indirection layer on top of "Staging Areas" as Normal priority.
Sep 27 2019, 6:28 PM · Harbormaster, Drydock, Arcanist
epriestley added a comment to T524: OpenID Authentication as an Auth Option.

OIDC is just OAuth2 in a ghost costume, so the implementation is nearly trivial.

Sep 27 2019, 1:54 AM · Phabricator
storrgie added a comment to T524: OpenID Authentication as an Auth Option.

Apologies, I should have provided more context. We've been futzing with this project which OIDC. We'd be looking to ensure that it works with Dex.

Sep 27 2019, 1:18 AM · Phabricator
epriestley added a comment to T524: OpenID Authentication as an Auth Option.

I'm not sure how I'd even test OpenID these days. Offhand, I haven't seen any provider offering OpenID in years.

Sep 27 2019, 1:16 AM · Phabricator
storrgie added a comment to T524: OpenID Authentication as an Auth Option.

Would you considered taking prioritized funding for implementing OpenID?

Sep 27 2019, 1:04 AM · Phabricator

Sep 26 2019

epriestley updated the task description for T11860: Bot email addresses can't be edited.
Sep 26 2019, 4:03 AM · Setup, People
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: Unknown Object (Differential Revision).
Sep 26 2019, 2:51 AM · Differential

Sep 25 2019

epriestley closed T13414: Raise the effective corpus size limit in "PhutilProseDifferenceEngine" by using "diff" for coarse passes as Resolved by committing Restricted Diffusion Commit.
Sep 25 2019, 11:50 PM · Infrastructure
epriestley added a revision to T13414: Raise the effective corpus size limit in "PhutilProseDifferenceEngine" by using "diff" for coarse passes: Unknown Object (Differential Revision).
Sep 25 2019, 10:12 PM · Infrastructure
epriestley added a revision to T13414: Raise the effective corpus size limit in "PhutilProseDifferenceEngine" by using "diff" for coarse passes: Unknown Object (Differential Revision).
Sep 25 2019, 9:40 PM · Infrastructure
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: Unknown Object (Differential Revision).
Sep 25 2019, 9:40 PM · Differential
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Sep 25 2019, 9:40 PM · libphutil
epriestley added a revision to T13395: Strip libphutil for parts: Unknown Object (Differential Revision).
Sep 25 2019, 9:36 PM · libphutil
epriestley added a revision to T13414: Raise the effective corpus size limit in "PhutilProseDifferenceEngine" by using "diff" for coarse passes: Unknown Object (Differential Revision).
Sep 25 2019, 9:36 PM · Infrastructure
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: Unknown Object (Differential Revision).
Sep 25 2019, 9:36 PM · Differential
epriestley added a comment to T13425: Support diffs between abstract block lists in the UI.

Screen Shot 2019-09-25 at 1.57.05 PM.png (892×1 px, 149 KB)

Sep 25 2019, 9:18 PM · Differential
epriestley added a revision to T13414: Raise the effective corpus size limit in "PhutilProseDifferenceEngine" by using "diff" for coarse passes: Unknown Object (Differential Revision).
Sep 25 2019, 9:05 PM · Infrastructure
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: Unknown Object (Differential Revision).
Sep 25 2019, 9:05 PM · Differential
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: Unknown Object (Differential Revision).
Sep 25 2019, 8:25 PM · Differential
epriestley added a comment to T13425: Support diffs between abstract block lists in the UI.

??? it just works ???

Sep 25 2019, 7:50 PM · Differential
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: Unknown Object (Differential Revision).
Sep 25 2019, 7:48 PM · Differential
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: Unknown Object (Differential Revision).
Sep 25 2019, 7:04 PM · Differential
epriestley added a comment to T13425: Support diffs between abstract block lists in the UI.

Jupyter as blocks, no diffing or inlines yet:

Sep 25 2019, 7:03 PM · Differential
epriestley added a comment to T13425: Support diffs between abstract block lists in the UI.
  • Differential shows a "this file is big, so syntax highlighting is disabled by default" warning even when a document engine which does not use syntax highlighting renders the document.
Sep 25 2019, 6:46 PM · Differential
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: Unknown Object (Differential Revision).
Sep 25 2019, 6:21 PM · Differential
epriestley added a comment to T13425: Support diffs between abstract block lists in the UI.
  • There's also no "render as native source" option, but there is a "View as Source" option, which doesn't work. Gotcha!
Sep 25 2019, 5:47 PM · Differential
epriestley added a comment to T13425: Support diffs between abstract block lists in the UI.
  • The options in the "View As..." dropdown are exhaustive, and most do not work, because they aren't based on the changeset being rendered (so we'll give you an option to render a Jupyter notebook as audio, for example). This isn't trivial to fix and it isn't terribly important for this to function as an escape hatch back to old behavior.
  • Since we expect most documents to have a relatively small number of options here, a list of clickable options might be better than a <select /> dropdown.
Sep 25 2019, 5:46 PM · Differential
epriestley added a comment to T13425: Support diffs between abstract block lists in the UI.

In an effort to "do no harm", I'm planning to add a "Render with Document Engine..." option to the View Options dropdown next. This will let you (for example) view a Jupyter notebook as a raw source diff if you want, if the "fancy" diff is broken or unhelpful for some reason, so you always have an escape hatch back to a lower level representation.

Sep 25 2019, 5:23 PM · Differential
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: Unknown Object (Differential Revision).
Sep 25 2019, 5:15 PM · Differential
epriestley added a comment to T13425: Support diffs between abstract block lists in the UI.
  • TwoUp image comments aren't triggering (also in master).
  • OneUp image comments need some cell span adjustments.
Sep 25 2019, 5:10 PM · Differential
epriestley added a revision to T13425: Support diffs between abstract block lists in the UI: Unknown Object (Differential Revision).
Sep 25 2019, 4:26 PM · Differential
epriestley triaged T13425: Support diffs between abstract block lists in the UI as Normal priority.
Sep 25 2019, 4:19 PM · Differential
epriestley added a comment to T13299: Herald only triggers for commits once, during the initial publish phase.

I've moved the issue in PHI1264 (roughly, "commenting on an unpublished commit should still work normally") here from T13284, since it ended up not really fitting into that scope particularly well.

Sep 25 2019, 4:01 PM · Diffusion, Herald
epriestley updated the task description for T13299: Herald only triggers for commits once, during the initial publish phase.
Sep 25 2019, 4:00 PM · Diffusion, Herald
epriestley updated the task description for T13284: When a previously non-permanent ref is marked permanent, unpublished commits reachable from that ref are not published.
Sep 25 2019, 4:00 PM · Diffusion
epriestley closed T13284: When a previously non-permanent ref is marked permanent, unpublished commits reachable from that ref are not published as Resolved by committing Restricted Diffusion Commit.
Sep 25 2019, 3:55 PM · Diffusion