I'm strongly considering allowing phutil_build_http_querystring() to build PHP-flavored query strings out of arrays again.

The error is less opaque in PHP 7.3:

I don't want to speak too soon, but the instances.state cache doesn't seem to have any other glaring issues. This load chart for admin001, where steady state CPU load has dropped from ~20% to ~10%, suggests that the new scheme is legitimately more efficient and the deploy actually changed something:

We can trivially serialize() before grabbing the lock to reduce the lock window. We could also write before grabbing the lock.

... and can take some real amount of time ...

Deploying the "instances.state" cache hit one issue on the repo tier:

When we reach getCustomFieldSpecificationForRole($role), via EditEngine, the $this object currently does not have a subtype set, so it can't make any decisions about which fields to expose. This appears to have a fairly surgical fix in EditEngine, but if there are like 10 more of these coming it might merit another look.

Maybe T6038.

At least for now, copy/paste is keeping these largely consistent.

For now, maybe I'll just keep an eye on how that rule would impact things.

D20093 fixes a mobile application menu in Mail. It would be very nice to fix this in a generic way instead. (This may also affect Instances.)

Legalpad uses ExternalAccount to store arbitrary email addresses as an identity.

(Misfire in the plain text of D20105.)

This task is kind of all over the place, but I expect it to be functionally resolved by changes attached to T13244 in service of (internal) PHI774.

I've marked D20106 as resolving this. Although all possible permutations of this situation aren't completely fixed, I believe we've added enough tools that this situation can be resolved by clicking a couple of things, and usually resolved by users without administrator intervention:

Here are some general technical blockers here:

It's true that it has been 12 years, but I'm sure fwrite() will start returning an error code when it encounters a permanent, fatal EPIPE error condition soon.