Page MenuHomePhabricator
Feed Advanced Search

Dec 14 2016

epriestley closed T12014: Failed to create diff by web as Resolved.

I believe this is fixed in HEAD of master now. Let us know if you're still seeing issues after upgrading.

Dec 14 2016, 3:31 PM · Bug Report
netroby added a comment to T12014: Failed to create diff by web .

oh, sorry. i saw it as " I had fix it a few hours before..."

Dec 14 2016, 12:52 PM · Bug Report
epriestley added a comment to T12014: Failed to create diff by web .

Oh, sorry, maybe you misread? I said "I think I'll have it fixed in a few hours", meaning that I don't expect it to be fixed until later today. Unless you can pull changes from the future, it won't work yet. I'll update this task once things are fixed.

Dec 14 2016, 12:43 PM · Bug Report
netroby added a comment to T12014: Failed to create diff by web .

No, sir. i just upgrade to latest git commits. still can not do it.

Dec 14 2016, 12:42 PM · Bug Report
epriestley added a comment to T12014: Failed to create diff by web .

This is related to changes in T11114. I think I'll have it fixed in a few hours.

Dec 14 2016, 12:37 PM · Bug Report
netroby added a comment to T12014: Failed to create diff by web .

Using arc diff is ok. but using the web form is not working at all

Dec 14 2016, 11:36 AM · Bug Report
• 1stone created T12015: Unable to resolve method 'describeAutomaticCapability'..
Dec 14 2016, 9:38 AM · Diviner, Bug Report
netroby created T12014: Failed to create diff by web .
Dec 14 2016, 7:38 AM · Bug Report

Dec 13 2016

epriestley added a comment to T12013: Enabling zlib.output_compression results in wrong Content-Length.

I think this is fixed now -- let us know if you're still seeing issues. Thanks for the very thorough report!

Dec 13 2016, 10:27 PM · Bug Report
epriestley closed T12013: Enabling zlib.output_compression results in wrong Content-Length as Resolved by committing Restricted Diffusion Commit.
Dec 13 2016, 10:25 PM · Bug Report
avivey added a comment to T12013: Enabling zlib.output_compression results in wrong Content-Length.

Using Chrome's network tab + disable cache, loading a page from the effected system shows that some rsrc requests take 55s each, during which chrome is "loading". Since they're static resources, I guess it's hard to notice when cache is on. Also, I don't think secure-dot is effected.

Dec 13 2016, 10:14 PM · Bug Report
epriestley added a comment to T12013: Enabling zlib.output_compression results in wrong Content-Length.

I wasn't able to reproduce any hangs or bad behavior from curl locally, but I think D17045 should cause us to select either compression or Content-Length, which is a reasonable thing to expect us to do.

Dec 13 2016, 10:10 PM · Bug Report
epriestley added a revision to T12013: Enabling zlib.output_compression results in wrong Content-Length: Restricted Differential Revision.
Dec 13 2016, 10:07 PM · Bug Report
avivey added a comment to T12013: Enabling zlib.output_compression results in wrong Content-Length.

I can see this too with an unknown version of Apache (Probably 2.2.15) over HTTPS, PHP 5.3.3 (built: Aug 11 2016 17:13:57) (w/o explicitly setting the header) :

curl -v 'https://..../res/defaultX/phabricator/e18bf0da/core.pkg.css'  --compressed > /dev/null
...
curl: (18) transfer closed with 170238 bytes remaining to read
Dec 13 2016, 10:06 PM · Bug Report
pzinovkin created T12013: Enabling zlib.output_compression results in wrong Content-Length.
Dec 13 2016, 9:00 PM · Bug Report
rfreebern added a comment to T12012: Diffusion doesn't handle non-bare hosted git repos.

Okay, thanks!

Dec 13 2016, 7:39 PM · Git, Diffusion, Bug Report
epriestley closed T12012: Diffusion doesn't handle non-bare hosted git repos as Invalid.

Oh, I think the issue is this:

Dec 13 2016, 7:38 PM · Git, Diffusion, Bug Report
epriestley added a comment to T12012: Diffusion doesn't handle non-bare hosted git repos.

I also can't reproduce this:

Dec 13 2016, 7:33 PM · Git, Diffusion, Bug Report
rfreebern added a comment to T12012: Diffusion doesn't handle non-bare hosted git repos.

It's fine to consider it not a bug. Mainly I wanted to provide the info that it doesn't work for documentation purposes, in case anyone else runs into the same situation in the future. (We ran into this by trying to transition from a very old Phabricator installation to a new one with hosted repos, but with a legacy deployment setup that needs a non-bare repo copy, and didn't realize that Phabricator didn't fully support hosted non-bare repos.)

Dec 13 2016, 7:29 PM · Git, Diffusion, Bug Report
epriestley added a comment to T12012: Diffusion doesn't handle non-bare hosted git repos.

Why do you consider this to be a bug, then?

Dec 13 2016, 7:23 PM · Git, Diffusion, Bug Report
rfreebern added a comment to T12012: Diffusion doesn't handle non-bare hosted git repos.

No.

Dec 13 2016, 6:54 PM · Git, Diffusion, Bug Report
epriestley added a comment to T12012: Diffusion doesn't handle non-bare hosted git repos.

Do we tell you to do this in the documentation anywhere?

Dec 13 2016, 6:36 PM · Git, Diffusion, Bug Report
rfreebern created T12012: Diffusion doesn't handle non-bare hosted git repos.
Dec 13 2016, 6:32 PM · Git, Diffusion, Bug Report
epriestley closed T4045: Store diffs as binary, not UTF-8, a subtask of T5229: Fixing up invalid encoding confuses archanists utf8-check, as Resolved.
Dec 13 2016, 5:44 PM · Bug Report, Arcanist
epriestley added a comment to T12011: Support builds with Travis CI.

This isn't a bug. Diff properties are not intended to be an arbitrary key-value datastore for API consumers.

Dec 13 2016, 5:36 PM · Harbormaster, Feature Request
mwek created T12011: Support builds with Travis CI.
Dec 13 2016, 5:28 PM · Harbormaster, Feature Request
cspeckmim added a comment to T11708: Daemons erroneously saying "Diff does not exist".

When this is in stable and we upgrade I will have a reminder to keep an eye on logs and come back here

Dec 13 2016, 4:20 PM · Daemons, Differential, Bug Report
epriestley moved T11660: Diff creation fails when submitting too long file paths from Backlog to v3 (Infrastructure) on the Differential board.
Dec 13 2016, 4:20 PM · Differential, Bug Report
epriestley added a comment to T11708: Daemons erroneously saying "Diff does not exist".

Although it's still a little early to be sure, we appear to have fixed the policy issue with unit test failures (D17029). Not sure if that actually impacted this or not.

Dec 13 2016, 4:12 PM · Daemons, Differential, Bug Report
epriestley closed T12001: Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in as Resolved by committing Restricted Diffusion Commit.
Dec 13 2016, 3:34 PM · Files, Documentation, Bug Report
epriestley renamed T12001: Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in from Upload Failure to Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in.
Dec 13 2016, 12:59 PM · Files, Documentation, Bug Report
epriestley added a comment to T12001: Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in.

D17037 should fix the documentation, it definitely wasn't very clear as written. That should land some time today and the docs should be updated in about 24 hours.

Dec 13 2016, 12:58 PM · Files, Documentation, Bug Report
Darakir added a comment to T12001: Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in.

Omg. I feel so stupid now. In the guide I read, that should be interpreted as 8MB, but I guess it wasn't... Works fine now, thanks a bunch!
This can be closed..

Dec 13 2016, 12:57 PM · Files, Documentation, Bug Report
epriestley added a revision to T12001: Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in: Restricted Differential Revision.
Dec 13 2016, 12:57 PM · Files, Documentation, Bug Report
epriestley added a comment to T12001: Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in.

In the first row of that table, it appears that you have configured a storage.mysql-engine.max-size of 8 ("8 bytes"). Try using 8388608 ("8 megabytes") instead?

Dec 13 2016, 12:54 PM · Files, Documentation, Bug Report
pouyana updated the task description for T12002: Set header for CURL query for the Notification server status to HTTP:Upgrade = websocket.
Dec 13 2016, 12:54 PM · Bug Report
Darakir added a comment to T12001: Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in.

Sure, here goes:

storage-engines.png (357×1 px, 31 KB)

Dec 13 2016, 12:52 PM · Files, Documentation, Bug Report
pouyana created T12002: Set header for CURL query for the Notification server status to HTTP:Upgrade = websocket.
Dec 13 2016, 11:36 AM · Bug Report
epriestley added a comment to T12001: Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in.

Can you browse to https://your.install.com/applications/view/PhabricatorFilesApplication/ and post a screenshot of the "Storage Engines" panel on that page? It should look a little bit like this (example from this install), although your settings are presumably different:

Dec 13 2016, 11:32 AM · Files, Documentation, Bug Report
Darakir created T12001: Documentation is misleading about the unit that "storage.mysql-engine.max-size" is measured in.
Dec 13 2016, 11:00 AM · Files, Documentation, Bug Report

Dec 12 2016

Volans added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

@epriestley I can confirm it works fine both on Mac and Linux for me. Thanks a lot for the finding and quick fix!

Dec 12 2016, 6:50 PM · Bug Report
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

That Chrome change seems at least plausible as a root cause to me, but I definitely don't know enough about the Chrome internals to really hazard a guess.

Dec 12 2016, 6:46 PM · Bug Report
epriestley closed T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden as Resolved by committing Restricted Diffusion Commit.
Dec 12 2016, 6:39 PM · Bug Report
epriestley added a revision to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden: Restricted Differential Revision.
Dec 12 2016, 6:36 PM · Bug Report
epriestley closed T11999: Fatal on "Customize Menu..." on home as Resolved by committing Restricted Diffusion Commit.
Dec 12 2016, 6:33 PM · Bug Report
epriestley renamed T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden from Chrome 55 no longer scrolls to elements which are completely hidden to When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.
Dec 12 2016, 6:16 PM · Bug Report
epriestley added a revision to T11999: Fatal on "Customize Menu..." on home: Restricted Differential Revision.
Dec 12 2016, 6:16 PM · Bug Report
epriestley renamed T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden from Links to Task's messages don't scroll to the message on Chrome 55 to Chrome 55 no longer scrolls to elements which are completely hidden.
Dec 12 2016, 6:16 PM · Bug Report
chad created T11999: Fatal on "Customize Menu..." on home.
Dec 12 2016, 6:14 PM · Bug Report
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

See also https://code.google.com/p/chromium/issues/detail?id=473657 for earlier adventures in Chrome.

Dec 12 2016, 6:13 PM · Bug Report
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

Here's my upstream report:

Dec 12 2016, 6:11 PM · Bug Report
chad added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

Chromez

Dec 12 2016, 6:09 PM · Bug Report
Volans added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

@chad was that for me or for Chrome? 😄

Dec 12 2016, 6:08 PM · Bug Report
chad added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

2392289.png (225×300 px, 35 KB)

Dec 12 2016, 6:06 PM · Bug Report
Volans added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

@epriestley could it be related to this change? https://chromium.googlesource.com/chromium/src/+/a67debf9a9b78f60e7b10b5574ae4ceab49af31b%5E%21/#F2

Dec 12 2016, 6:01 PM · Bug Report
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

Here's my reduced test case for Chome 55:

Dec 12 2016, 5:55 PM · Bug Report
chad added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

Hah, I was on Chrome 54, and my report above works. But after updating to 55, it no longer works. Something changed in Chrome. Not sure what though.

Dec 12 2016, 5:47 PM · Bug Report
Volans added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

@chad I was replying but saw now your last comments, thanks @epriestley for narrowing it down. Interesting that I can repro on Chrome 55/Mac while you can't.

Dec 12 2016, 5:36 PM · Bug Report
chad added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

Basically, I've found:

Dec 12 2016, 5:32 PM · Bug Report
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

Oh, it reproduces for me.

Dec 12 2016, 5:31 PM · Bug Report
epriestley added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

This appears to be a bug in Chrome, because this fixes it:

Dec 12 2016, 5:31 PM · Bug Report
chad added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.

This doesn't reproduce for me on this install in Chrome 55/Mac, or any other browser. I'm assuming the issue you saw on this server was T11998 which was a local configuration issue.

Dec 12 2016, 5:20 PM · Bug Report
chad added a comment to T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.
Dec 12 2016, 5:15 PM · Bug Report
Volans created T11997: When following an anchor link, Chrome 55 no longer scrolls to elements which are completely hidden.
Dec 12 2016, 10:11 AM · Bug Report

Dec 11 2016

epriestley closed T11521: Request Review action should clear "accepted older" status as Resolved.

Oh, I think the edit to the title here is actually misleading, and the author in this scenario never used "Request Review" (this action is only available if the author has previously used "Plan Changes", which they did not appear to in this scenario).

Dec 11 2016, 9:06 PM · Restricted Project, Differential, Bug Report
chad added a comment to T11996: Badly limiting a dashboard widget's "Can View" policy can result in users not being able to see a dashboard.

We have an identical ticket we plan to fix, definitely agree it's a bad experience.

Dec 11 2016, 5:38 PM · Bug Report
mbm added a comment to T11996: Badly limiting a dashboard widget's "Can View" policy can result in users not being able to see a dashboard.

Okay then, I thought this was a bug as it didn't seem to make sense for me as a user. Sorry for taking up your time.

Dec 11 2016, 5:37 PM · Bug Report
chad merged task T11996: Badly limiting a dashboard widget's "Can View" policy can result in users not being able to see a dashboard into T8033: Inform editor when panels have more restrictive policy than dashboard.
Dec 11 2016, 5:33 PM · Bug Report
chad added a comment to T11996: Badly limiting a dashboard widget's "Can View" policy can result in users not being able to see a dashboard.

This is expected behavior. We want to show an error instead of just vanishing the widget.

Dec 11 2016, 5:32 PM · Bug Report
mbm created T11996: Badly limiting a dashboard widget's "Can View" policy can result in users not being able to see a dashboard.
Dec 11 2016, 5:30 PM · Bug Report
chad closed T11990: Outline is invisible on submit buttons as Resolved by committing Restricted Diffusion Commit.
Dec 11 2016, 5:21 PM · Design, Bug Report
epriestley closed T11995: Fatal error while saving global default preferences as Resolved by committing Restricted Diffusion Commit.
Dec 11 2016, 4:28 PM · User Preferences, Bug Report
epriestley closed T11993: New install errors out before "run storage upgrade" message as Resolved by committing Restricted Diffusion Commit.
Dec 11 2016, 4:28 PM · Bug Report, Installing & Upgrading
epriestley added a comment to T11993: New install errors out before "run storage upgrade" message.

Thanks!

Dec 11 2016, 3:19 PM · Bug Report, Installing & Upgrading
epriestley claimed T11993: New install errors out before "run storage upgrade" message.
Dec 11 2016, 3:19 PM · Bug Report, Installing & Upgrading
epriestley added a comment to T11995: Fatal error while saving global default preferences.

Thanks! Yeah, this was just some editing/testing slop on my part. Your suggested fix is correct.

Dec 11 2016, 3:19 PM · User Preferences, Bug Report
epriestley claimed T11995: Fatal error while saving global default preferences.
Dec 11 2016, 3:19 PM · User Preferences, Bug Report
epriestley added a revision to T11993: New install errors out before "run storage upgrade" message: Restricted Differential Revision.
Dec 11 2016, 3:17 PM · Bug Report, Installing & Upgrading
epriestley added a revision to T11995: Fatal error while saving global default preferences: Restricted Differential Revision.
Dec 11 2016, 3:17 PM · User Preferences, Bug Report
lewellyn created T11995: Fatal error while saving global default preferences.
Dec 11 2016, 9:17 AM · User Preferences, Bug Report
chad added a comment to T11994: 'Affected files' doesn't work in 'Commits' Herald rules.

I tried the following, specifically:

Dec 11 2016, 7:52 AM · Bug Report (Needs Information)
chad added a comment to T11994: 'Affected files' doesn't work in 'Commits' Herald rules.

Please read Contributing Bug Reports and fill in all required information for a bug report. Thanks!

Dec 11 2016, 7:39 AM · Bug Report (Needs Information)
razvanm created T11994: 'Affected files' doesn't work in 'Commits' Herald rules.
Dec 11 2016, 4:53 AM · Bug Report (Needs Information)
chad added a revision to T11990: Outline is invisible on submit buttons: Restricted Differential Revision.
Dec 11 2016, 12:58 AM · Design, Bug Report
• Gadget0624 added a comment to T11993: New install errors out before "run storage upgrade" message.

Dec 11 2016, 12:48 AM · Bug Report, Installing & Upgrading
chad added a comment to T11990: Outline is invisible on submit buttons.

Yeah, seems to be a bug in Chrome. I would follow up with them. There is no correct means to style it in Ubuntu, just some hacks.

Dec 11 2016, 12:46 AM · Design, Bug Report
chad added a comment to T11992: daemon hits policy exception repeatedly.

(Feel free to follow up with reproduction steps once you've sorted everything out)

Dec 11 2016, 12:09 AM · Daemons, Policy, Bug Report
chad closed T11992: daemon hits policy exception repeatedly as Invalid.

You have to be up to date and you must provide reproduction information in order to file a bug report. Please use Ponder otherwise. Thanks!

Dec 11 2016, 12:02 AM · Daemons, Policy, Bug Report

Dec 10 2016

avivey created T11993: New install errors out before "run storage upgrade" message.
Dec 10 2016, 11:35 PM · Bug Report, Installing & Upgrading
• sshannin updated the task description for T11992: daemon hits policy exception repeatedly.
Dec 10 2016, 11:31 PM · Daemons, Policy, Bug Report
• sshannin created T11992: daemon hits policy exception repeatedly.
Dec 10 2016, 11:28 PM · Daemons, Policy, Bug Report
chad added a comment to T11990: Outline is invisible on submit buttons.

Unclear if I can globally style these consistently across all browsers / OSs. But no one complained about my select styles yet.

Dec 10 2016, 6:04 PM · Design, Bug Report
chad added a comment to T11990: Outline is invisible on submit buttons.

Ubuntu - Mac

pasted_file (318×484 px, 35 KB)

Dec 10 2016, 5:48 PM · Design, Bug Report
chad added a comment to T11990: Outline is invisible on submit buttons.

The bug seems to be with Chrome/Ubuntu, as it's inconsistent with their other platforms. Did you file a task in their upstream?

Dec 10 2016, 5:47 PM · Design, Bug Report
chad added a comment to T11990: Outline is invisible on submit buttons.

Does it reproduce here as well? We don't take bug reports from that install from non-admins. It's a forked install and not up to date.

Dec 10 2016, 2:54 PM · Design, Bug Report
tgr added a comment to T11990: Outline is invisible on submit buttons.

Chrome 54 / Ubuntu 14.04. Tabbing through the comment edit form fields looks like this (screenshots are from phabricator.wikimedia.org):

phab-outline1.png (306×550 px, 20 KB)

phab-outline2.png (306×545 px, 18 KB)

phab-outline3.png (307×545 px, 18 KB)

Dec 10 2016, 10:30 AM · Design, Bug Report
cspeckmim added a comment to T11990: Outline is invisible on submit buttons.

outline: 4px solid red;

yeehaw

Dec 10 2016, 4:43 AM · Design, Bug Report

Dec 9 2016

chad added a comment to T11990: Outline is invisible on submit buttons.

@tgr can we get confirmation on the browser, please?

Dec 9 2016, 11:52 PM · Design, Bug Report
epriestley added a project to T11990: Outline is invisible on submit buttons: Design.

@chad, it looks like we're just using the browser's default outline for buttons.

Dec 9 2016, 11:28 PM · Design, Bug Report
avivey added a comment to T11990: Outline is invisible on submit buttons.

It's somewhat invisible in Chrome on Windows too (Behold my powers of image editing! And on a Windows machine too!):

pasted_file (112×199 px, 4 KB)

Dec 9 2016, 11:22 PM · Design, Bug Report