Page MenuHomePhabricator
Feed Advanced Search

Dec 8 2016

epriestley moved T8602: "Merge Duplicate Tasks" shows results in wrong order with ElasticSearch from Backlog to ElasticSearch on the Search board.
Dec 8 2016, 6:49 PM · Elasticsearch, Search
epriestley moved T9460: Unable to search for open tasks using Elasticsearch from Backlog to ElasticSearch on the Search board.
Dec 8 2016, 6:49 PM · Elasticsearch, Search
epriestley moved T9893: Support ElasticSearch 2.0 - 5.1 from Backlog to ElasticSearch on the Search board.
Dec 8 2016, 6:49 PM · Elasticsearch, Search
epriestley renamed T8602: "Merge Duplicate Tasks" shows results in wrong order with ElasticSearch from "Merge Duplicate Tasks" shows results in wrong order to "Merge Duplicate Tasks" shows results in wrong order with ElasticSearch.
Dec 8 2016, 6:49 PM · Elasticsearch, Search
epriestley moved T8646: Provide more context for search results, particularly wiki documents from Backlog to v2 on the Search board.
Dec 8 2016, 6:48 PM · Design, Search, Restricted Project
epriestley moved T10656: Modernize global search SearchEngine implementation from Backlog to v2 on the Search board.
Dec 8 2016, 6:47 PM · Search
epriestley added a comment to M1473: Home PanelEngine.

Or: if you aren't comfortable adding labels to a menu, you probably don't have an organizational role that requires you to pin 5 dashboards into subgroups on your homepage, and you can figure out how to customize it later when you need the increased power. Novice users can always use browser bookmarks or normal navigation, or administrators can add links to the global nav if there are actions that some users are consistently having difficulty with.

Dec 8 2016, 6:44 PM
epriestley added a comment to M1473: Home PanelEngine.

We can have an "add this page to the homepage menu" that just adds a link at the bottom of your custom stuff, and/or "Customize Menu" can take you to a modal choice between "add a link" and "do powerful things". But I think most users can handle it -- I don't recall too many issues with project profile menus, and when we removed them we got a fair amount of pushback so it sounds like the full-power version is getting use today.

Dec 8 2016, 6:41 PM
epriestley added a comment to M1473: Home PanelEngine.

Yeah. Default looks like this:

Dec 8 2016, 6:39 PM
epriestley added a comment to M1473: Home PanelEngine.

I think that's reasonable, but I'm not sure we even need to separate out dashboards -- if we do, it prevents me from putting them into functional sections I create with labels (like "Engineering").

Dec 8 2016, 6:36 PM
epriestley added a comment to M1473: Home PanelEngine.

(Or, if you're ambitious, you add 20 different links in 5 categories or whatever, and effectively replace the global menu with your own custom thing full of stuff.)

Dec 8 2016, 6:33 PM
epriestley added a comment to M1473: Home PanelEngine.

I think user links should go first, so they push all the global stuff down, out of the way. You add links for the 3-4 most important things, they show up at the top, and then presumably you aren't too concerned that admins occasionally shuffle the other stuff around since it's out of your way.

Dec 8 2016, 6:32 PM
epriestley added a comment to M1473: Home PanelEngine.

I'm not sure trying to auto-categorize is desirable because it means that stuff like create forms, wiki pages, etc., won't end up in the most logical place. It prevents me from creating an "Engineering" category for a company, or a "Getting Started" category for onboarding users on an open source install.

Dec 8 2016, 6:28 PM
epriestley moved T11932: Manual Activity: Rebuild Search Index from Backlog to Future on the Search board.
Dec 8 2016, 6:23 PM · Search, Guides
epriestley closed T11967: Make xhpast and xhprof binaries automatically deploy in the Phacility cluster as Resolved.

Seems to be working now. ¯\_(ツ)_/¯

Dec 8 2016, 4:16 PM · Ops, Phacility
epriestley added a comment to T11967: Make xhpast and xhprof binaries automatically deploy in the Phacility cluster.

For future reference, here's the sequence of problems I hit:

Dec 8 2016, 3:55 PM · Ops, Phacility
epriestley created T11968: Decide the fate of FutureGraph.
Dec 8 2016, 3:09 PM · Diffusion, Performance, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley created T11967: Make xhpast and xhprof binaries automatically deploy in the Phacility cluster.
Dec 8 2016, 2:50 PM · Ops, Phacility
epriestley added a revision to T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching: Unknown Object (Differential Revision).
Dec 8 2016, 2:44 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a comment to T11961: DiffusionRefNotFoundException when displaying a branch containing a slash ("/") character.

Your config looks very little like the config we recommend. Why are you using try_files instead of rewrite?

Dec 8 2016, 1:30 PM · Bug Report
epriestley closed T11966: sdtyhftuyhf as Invalid.
Dec 8 2016, 1:19 PM · Community, Bug Report
epriestley closed T11963: Company name is missing in the home page as Invalid.
Dec 8 2016, 1:19 PM · Bug Report
epriestley closed T11965: Colour is same as the Title as Invalid.
Dec 8 2016, 1:19 PM · Bug Report
epriestley closed T11964: check the banner as Invalid.
Dec 8 2016, 1:19 PM · Bug Report
epriestley closed T11962: fgyokh as Invalid.
Dec 8 2016, 1:18 PM · Bug Report
cspeckmim awarded T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching a Love token.
Dec 8 2016, 1:08 AM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist

Dec 7 2016

epriestley changed E1202: Advanced Pup Duty to an all day event.
Dec 7 2016, 10:49 PM
epriestley converted E1202: Advanced Pup Duty from an all day event.
Dec 7 2016, 10:49 PM
epriestley added a comment to T11961: DiffusionRefNotFoundException when displaying a branch containing a slash ("/") character.

Can you show me:

Dec 7 2016, 10:35 PM · Bug Report
epriestley added a comment to T11960: I probably screwed up caching since times aren't rendering for me in timestamps.

GREAT NEWS! Times work again for me, personally.

Dec 7 2016, 9:43 PM
epriestley added a comment to T11956: Enhance Countdown to include "count up" functionality.

This is pure scope creep, but I've always found Countdown anticlimactic when it reaches 0. I could imagine having this feature:

Dec 7 2016, 9:42 PM · Countdown, Feature Request
epriestley closed T11960: I probably screwed up caching since times aren't rendering for me in timestamps as Resolved by committing Restricted Diffusion Commit.
Dec 7 2016, 9:34 PM
epriestley closed T11959: Cluster/Databases doc page contains broken link as Resolved by committing Restricted Diffusion Commit.
Dec 7 2016, 9:33 PM · Documentation, Bug Report
epriestley added a revision to T11960: I probably screwed up caching since times aren't rendering for me in timestamps: Unknown Object (Differential Revision).
Dec 7 2016, 8:51 PM
epriestley added a revision to T11959: Cluster/Databases doc page contains broken link: Unknown Object (Differential Revision).
Dec 7 2016, 8:30 PM · Documentation, Bug Report
epriestley added a comment to T11959: Cluster/Databases doc page contains broken link.

The intended target of the link is Cluster: Databases.

Dec 7 2016, 8:29 PM · Documentation, Bug Report
epriestley created T11960: I probably screwed up caching since times aren't rendering for me in timestamps.
Dec 7 2016, 8:26 PM
remusvrm awarded T4548: Support "Mylyn" Eclipse plugin a Like token.
Dec 7 2016, 9:49 AM · Feature Request, Maniphest
epriestley added a comment to T11957: Add MenuEngine to Home.

I can rename them, maybe MenuItem instead of Panel? I think when I wrote the stuff we had some more panel-like items in mind (like M1450) but haven't ended up building many of them, at least so far (cat facts and progress bar are the only non-item-like-ones, I think). Even if we do build richer stuff later I think MenuItem is reasonably clear.

Dec 7 2016, 1:40 AM · Profile Menu Item, Dashboards

Dec 6 2016

epriestley added a comment to T11957: Add MenuEngine to Home.

One thought about binding them to dashboards is that users won't naturally be able to edit the menu anymore, to personalize it. But maybe we can put some kind of override mechanism on top of it.

Dec 6 2016, 7:15 PM · Profile Menu Item, Dashboards
epriestley added a revision to T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching: Unknown Object (Differential Revision).
Dec 6 2016, 5:37 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a comment to E1223: Dentist Appointment.

I hope so!

Dec 6 2016, 5:20 PM
epriestley added a revision to T11922: Upgrading: Changes to Fulltext Indexing (InnoDB Fulltext): Unknown Object (Differential Revision).
Dec 6 2016, 4:31 PM · FreeBSD, Restricted Project, Installing & Upgrading
epriestley added a comment to T11922: Upgrading: Changes to Fulltext Indexing (InnoDB Fulltext).

That's expected if innodb_ft_max_token_size is not defined; specifically if this returns an error:

Dec 6 2016, 4:11 PM · FreeBSD, Restricted Project, Installing & Upgrading
epriestley added a comment to T11922: Upgrading: Changes to Fulltext Indexing (InnoDB Fulltext).

What is innodb_ft_min_token_size set to? The default is 3.

Dec 6 2016, 2:28 PM · FreeBSD, Restricted Project, Installing & Upgrading
epriestley added a revision to T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching: Unknown Object (Differential Revision).
Dec 6 2016, 2:15 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching: Unknown Object (Differential Revision).
Dec 6 2016, 1:12 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching: Unknown Object (Differential Revision).
Dec 6 2016, 1:10 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching: Unknown Object (Differential Revision).
Dec 6 2016, 12:35 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching: Unknown Object (Differential Revision).
Dec 6 2016, 12:19 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching: Unknown Object (Differential Revision).
Dec 6 2016, 12:15 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching: Unknown Object (Differential Revision).
Dec 6 2016, 12:13 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching: Unknown Object (Differential Revision).
Dec 6 2016, 12:08 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley added a revision to T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching: Unknown Object (Differential Revision).
Dec 6 2016, 12:03 PM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
epriestley created E1223: Dentist Appointment.
Dec 6 2016, 12:02 PM
epriestley created T11954: Improve performance of Arcanist/Conduit/Diffusion, primarily through better caching.
Dec 6 2016, 11:25 AM · Performance, Diffusion, Conduit, Infrastructure, Restricted Project, Arcanist
salvian awarded T11922: Upgrading: Changes to Fulltext Indexing (InnoDB Fulltext) a Love token.
Dec 6 2016, 4:23 AM · FreeBSD, Restricted Project, Installing & Upgrading
epriestley added a comment to T9652: Request for test case management application.

See Planning for discussion of updates and timelines.

Dec 6 2016, 4:07 AM · Restricted Project, Unnamed Manual Test Case Application
• naphat awarded T1022: arc patch fails to properly apply a patch which changes a symlink to a real file a Love token.
Dec 6 2016, 2:40 AM · Arcanist
epriestley added a revision to T929: Allow two arbitrary revisions to be compared in Diffusion: Unknown Object (Differential Revision).
Dec 6 2016, 2:21 AM · Diffusion (v3), Restricted Project
epriestley added a revision to T929: Allow two arbitrary revisions to be compared in Diffusion: Unknown Object (Differential Revision).
Dec 6 2016, 1:42 AM · Diffusion (v3), Restricted Project
epriestley added a comment to T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward).

What are the barriers you face to hosting on Phabricator instead of on GitHub?

Dec 6 2016, 12:14 AM · Diffusion, Herald, Bug Report
epriestley closed T11952: Daemons don't notice changes to global default settings as Resolved.
Dec 6 2016, 12:01 AM · Bug Report
epriestley closed T10125: Remove Persona Login Support as Resolved.

The provider is now being removed from Phabricator, so 2016 Week 49 is the last release to include it.

Dec 6 2016, 12:01 AM · Auth

Dec 5 2016

epriestley added a comment to T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward).

Generally, I am leaning toward splitting the "Commit" rule into two rules, "Commit" and "Ref Update".

Dec 5 2016, 11:45 PM · Diffusion, Herald, Bug Report
epriestley added a comment to T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward).

We have some spooky magic around "autoclose" which might make the behavior for "Is on autoclose branch" different than "Is on <specific, named branch>". That said, I'm not sure if it's actually materially different, and these likely end up being more-or-less the same thing when we actually fix them.

Dec 5 2016, 11:29 PM · Diffusion, Herald, Bug Report
epriestley added a comment to T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches.

T11953 isn't exactly the same as this, although they're similar.

Dec 5 2016, 11:23 PM · Diffusion (v3), Restricted Project, Restricted Project, Herald
epriestley reopened T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward) as "Open".
Dec 5 2016, 11:22 PM · Diffusion, Herald, Bug Report
epriestley added a comment to T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward).

Oh, maybe this isn't quite the same as T6522. Pushing another commit to the branch probably fires the rule?

Dec 5 2016, 11:22 PM · Diffusion, Herald, Bug Report
epriestley merged T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward) into T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches.
Dec 5 2016, 11:20 PM · Diffusion (v3), Restricted Project, Restricted Project, Herald
epriestley merged task T11953: Herald rule for commits on autoclose branch didn't trigger when a commit was first pushed to a branch, then to master (fast-forward) into T6522: "Commit's branches contains" condition is not re-evaluated for commits in multiple branches.
Dec 5 2016, 11:20 PM · Diffusion, Herald, Bug Report
epriestley closed T11044: Support partitioning application databases across multiple database hosts as Resolved.

This has been running cleanly in production for roughly two weeks, and appears stable. secure001 stopped writing Files data at F1943597 and we're now at F2078289 on secure003. We saw a couple of minor setup issues (mostly: exception messages not being tailored enough) but no fundamental issues.

Dec 5 2016, 10:54 PM · Clusters, Prioritized
epriestley added a comment to T11952: Daemons don't notice changes to global default settings.

We also made some changes to this recently (D16936, D16983) and it could conceivably be a version issue, but neither of those changes replaced a static cache with a RequestCache or similar, and D16936 is correctly using the RequestCache (which is cleared when the taskmaster de-queues a new task).

Dec 5 2016, 10:35 PM · Bug Report
epriestley added a comment to T11952: Daemons don't notice changes to global default settings.

I can't reproduce this in the Phacility cluster, either. Here's what I did:

Dec 5 2016, 10:32 PM · Bug Report
epriestley added a comment to T11952: Daemons don't notice changes to global default settings.

I'm not immediately able to reproduce this. Here's what I did:

Dec 5 2016, 10:23 PM · Bug Report
epriestley added a comment to T5293: Respect orientation metadata in Pholio and/or allow images to be rotated.

From elsewhere:

Dec 5 2016, 10:02 PM · Files, Pholio
epriestley added a comment to T11940: Commit hooks in hosted Git repositories fail under Git 2.11.0.

I believe this is now resolved at HEAD of master. Let us know if you're still seeing issues after updating.

Dec 5 2016, 8:48 PM · Bug Report
epriestley closed T11940: Commit hooks in hosted Git repositories fail under Git 2.11.0 as Resolved by committing Restricted Diffusion Commit.
Dec 5 2016, 8:45 PM · Bug Report
epriestley added a revision to T11940: Commit hooks in hosted Git repositories fail under Git 2.11.0: Unknown Object (Differential Revision).
Dec 5 2016, 8:13 PM · Bug Report
epriestley updated the task description for T11939: IPv6 Support.
Dec 5 2016, 7:46 PM · Infrastructure
epriestley added a comment to T11939: IPv6 Support.

I believe HEAD of master can now accept IPv6 requests, with the caveat that most of my testing has been at least somewhat synthetic and I haven't set up a legitimate, dedicated, IPv6-only host anywhere to be certain it works. That said, I'm reasonably confident that my synthetic testing was fairly thorough, since not very much code really cares about the remote address and I was able to make legitimate requests to ::1 over HTTP and SSH, and from synthetic IPv6 remote addresses. If you run into issues with sending IPv6 requests to Phabricator, let us know.

Dec 5 2016, 7:31 PM · Infrastructure
epriestley lowered the priority of T11939: IPv6 Support from Normal to Low.
Dec 5 2016, 7:26 PM · Infrastructure
20after4 awarded T11939: IPv6 Support a Love token.
Dec 5 2016, 7:19 PM · Infrastructure
epriestley added a comment to T550: Build an SSH conduit client.

I'm planning to support this in the arc experimental branch, although initial support won't be optimized. We can look at ControlPath and/or adding batching to the protocol layer to improve performance once it works.

Dec 5 2016, 7:18 PM · Prioritized, Arcanist, Restricted Project, Restricted Project, Conduit
epriestley moved T550: Build an SSH conduit client from Backlog to The Queue on the Prioritized board.
Dec 5 2016, 7:07 PM · Prioritized, Arcanist, Restricted Project, Restricted Project, Conduit
epriestley added projects to T550: Build an SSH conduit client: Arcanist, Prioritized.
Dec 5 2016, 7:06 PM · Prioritized, Arcanist, Restricted Project, Restricted Project, Conduit
epriestley merged T11951: Make conduit more secure into T550: Build an SSH conduit client.
Dec 5 2016, 7:05 PM · Prioritized, Arcanist, Restricted Project, Restricted Project, Conduit
epriestley merged task T11951: Make conduit more secure into T550: Build an SSH conduit client.
Dec 5 2016, 7:05 PM · Feature Request
epriestley added a comment to T11951: Make conduit more secure.

I'm going to merge this into T550 since it sounds like that's the immediate way forward, at least.

Dec 5 2016, 7:05 PM · Feature Request
epriestley closed T11946: Global default settings only apply to logged-out users on public installs as Resolved by committing Restricted Diffusion Commit.
Dec 5 2016, 7:00 PM · Config, Bug Report
epriestley added a comment to T11932: Manual Activity: Rebuild Search Index.

The section in T11922 only applies to the storage engine portion of that change, not to reindexing in general, and dropping the index is likely to hurt things overall if we need to do this more in the future (no performance improvement but totally nukes the search index until the reindex occurs).

Dec 5 2016, 6:51 PM · Search, Guides
epriestley added a comment to T11951: Make conduit more secure.

Cool. For context, stuff I expect to do upstream, sooner or later, since I consider it unambiguously good (just not necessarily high priority):

Dec 5 2016, 6:43 PM · Feature Request
epriestley added a revision to T11939: IPv6 Support: Unknown Object (Differential Revision).
Dec 5 2016, 6:34 PM · Infrastructure
epriestley added a comment to T11951: Make conduit more secure.

Can you outline the attack scenario or scenarios you're concerned about?

Dec 5 2016, 6:13 PM · Feature Request
epriestley added a revision to T11939: IPv6 Support: Unknown Object (Differential Revision).
Dec 5 2016, 6:05 PM · Infrastructure
epriestley closed T11943: Search results for Differential Revisions contains a displayed Date which can be confusing which date it is as Wontfix.

Good enough for me.

Dec 5 2016, 5:59 PM · Feature Request
epriestley updated the task description for T11939: IPv6 Support.
Dec 5 2016, 5:58 PM · Infrastructure
epriestley added a revision to T11939: IPv6 Support: Unknown Object (Differential Revision).
Dec 5 2016, 5:43 PM · Infrastructure
epriestley updated the task description for T11939: IPv6 Support.
Dec 5 2016, 5:27 PM · Infrastructure
epriestley added a comment to T11943: Search results for Differential Revisions contains a displayed Date which can be confusing which date it is.

(I don't consider is a bug: we're consistent about showing modified date across all applications which show a date, as far as I can tell, and omitting a label is a product decision.)

Dec 5 2016, 5:22 PM · Feature Request