See T9548#139908 for some discussion.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jun 6 2016
Could someone create a Mercurial bug (https://bz.mercurial-scm.org) with explanation about how Phabricator handles the bundle2 ssh stream? They might be able to give some hints.
I would like to do it, but I'm not sure how Phabricator handles the stream exactly.
My apologies. I will upgrade and post back if issue was fixed for me.
I can't reproduce this. Here's what I did. I set the server timezone to "America/Chicago":
See https://secure.phabricator.com/T10382. I've mitigated by downgrading to 3.4.2 (some other version will probably work too, this just was the first one I tried)
Jun 5 2016
This also reproduced with normal "Edit Projects", it wasn't specific to the bulk editor.
If you come up with reproduction steps, feel free to file a new report.
Jun 4 2016
Jun 3 2016
One of our users was definitely encountering the chat bar issue.
Assuming D16031 is a common element, you can identify all comments with inconsistent state like this:
It's not permanent, but this sequence would cause the problem:
Can you define 'never'? As in, is this the kind of thing that if you accidentally open conpherence once you're forever banished to the land of AJAX bug hell? Or do you mean, at no time during his review process? This has been going on intermittently since February so I am confident all users haven't done this every time.
Is he 100% sure he has never touched the \ key on his keyboard to bring up the chat sidebar?
I spoke with rkeelan/Rob. Here is what he had to say..
I was able to reproduce some flavor of this for inline comments with Quicksand enabled (i.e., the persistent Conpherence chat sidebar open). That's probably T8852, but I expect it to be specific to Quicksand / client-side JS state and impossible to hit without pressing the \ key to open the chat column. I should be able to fix this, but I can't repro it without opening the column.
Another user description of this issue:
There's no possible way that PDF is about inline comments, I think? How do inline comments appear on different reviews which presumably have different files? Or did they happen to affect the same files?
Particularly useful, then, would be to find these inlines in the database and figure out what happened to them.
I have 14.10 on a VM to play with in the meantime.
It might be good to round up any system "commonalities" from users who have experienced this. Perhaps a slowvote poll?
:| yes. these are inlines.
I emailed evan a "print page" pdf of the ticket off of our install.
That's like... 2.00 revisions ago, by maths.
14.04
which ubuntu can we fire up? 16.04?
Haha, okay. I may be headed down the wrong path -- T5031 is almost certainly not related here, because the draft system and EditEngine don't interact directly with inline comments. This is almost certainly also not Quicksand-related either if the inlines appear correctly originally (Quicksand could potentially mangle request in-flight).
INLINE COMMENTS BRAD
Oh, are "comments" in this description inline comments, versus blocks of comment text?
I think that this has only ever happened on Chrome on Ubuntu, and to boot, we've seen client side Ubuntu bugs pop up in the past. (Brad do you remember where?)
Thanks for the quick research/reply.
We can blindly move Differential to EditEngine, which may fix this indirectly, but this is a large amount of work.
Although I'm not sure this has the same root cause as T8852, I can't reproduce that either.
Here's how I attempted to reproduce this:
When the Conpherence column is open, it activates a completely separate browsing mode (Quicksand) where all navigations occur over Ajax. This is expected to have weird bugs associated with it, but this mode is not active if the column is not open. If the users this is affecting have never opened the chat column, I suspect this is not the same as T8852.
We can only move forward with complete reproduction steps that allow us to reproduce this problem in a local environment.
Unfortunately, it would certainly be impossible to reproduce our AD as it is fairly large, but the settings are very straight forward. I found the following in my apache error log, perhaps it's possible to determine what happened based off of this.
None of those screenshots demonstrate inconsistencies on their own.
Okay. I can't reproduce that. Here's what I did.
The author of the revision intended to mark the comment Done, but this didn't happen when he submitted the form. For me that seems to be unexpected behaviour.
The "Inline Comments" section shows new inline comments. It does not show inlines marked "Done".
Jun 2 2016
Confirm bug that is, no idea about SQL query.
I can confirm.
Will the following work to fix this?
If you tell me what username you would like and what your email is, I can create an account for you.
Weird, don't recall that.
(See also T6297.)
You're watching #twitter.
Very confused why I received an email on this task. It says I was CCd, but... I don't see where? How did you create this task?
Thanks for the report, and for including version information.
Ok, thanks
Thanks for the quick turnaround. I'll see if the problem is fixed in 48 hours and let you know.
Thanks for the report! This should be resolved at HEAD of master, and promote to stable in about 48 hours.
Thanks for the report! This should be fixed in HEAD of master, and will promote to stable in about 48 hours. Let us know if you're still seeing issues after updating or if you run into anything else.
The /62/ version of the URI's is something new. All the jobs we created in jenkins have been created with the /CALLSIGN/ version of the URIs. The mercurial plugin for jenkins is most likely looking for the URI property of the jenkins job and matching on that.
Thanks, those specifics are helpful.
Thanks for the report!
Jun 1 2016
Additional clarification. This happens if you give Arcanist an absolute path when doing an arc diff call.