Page MenuHomePhabricator

URI usernames and passwords containing forward slashes are not fully escaped
Closed, ResolvedPublic

Description

I create a credential, the password with a slash. After configured with my project, will meet these error message:

STDERR
[2016-06-02 14:15:06] EXCEPTION: (CommandException) Failed to fetch changes!
COMMAND
git fetch origin '+refs/heads/*:refs/heads/*' --prune

STDOUT
(empty)

STDERR
fatal: unable to access 'https://devops:tUUqFQ5/tfylX9fwiYzH%2BegM%2B1N%3D@gitlab.oursite.cn/module/python-commons.git/': Couldn't resolve host 'devops:tUUqFQ5'
 at [<phabricator>/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php:344]
arcanist(head=master, ref.master=c58f1b9a2507), phabricator(head=master, ref.master=15f14d6c2f20, custom=2), phutil(head=master, ref.master=5eaf0a9f5a35)
  #0 PhabricatorRepositoryPullEngine::executeGitUpdate() called at [<phabricator>/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php:92]
  #1 PhabricatorRepositoryPullEngine::pullRepository() called at [<phabricator>/src/applications/repository/management/PhabricatorRepositoryManagementUpdateWorkflow.php:80]
  #2 PhabricatorRepositoryManagementUpdateWorkflow::execute(PhutilArgumentParser) called at [... (303 more bytes) ... at [<phutil>/src/future/exec/ExecFuture.php:361]
[02-Jun-2016 14:15:06 PRC] arcanist(head=master, ref.master=c58f1b9a2507), phabricator(head=master, ref.master=15f14d6c2f20, custom=2), phutil(head=master, ref.master=5eaf0a9f5a35)
[02-Jun-2016 14:15:06 PRC]   #0 <#3> ExecFuture::resolvex() called at [<phabricator>/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php:493]
[02-Jun-2016 14:15:06 PRC]   #0 <#3> ExecFuture::resolvex() called at [<phabricator>/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php:493]
[02-Jun-2016 14:15:06 PRC]   #1 phlog(PhutilProxyException) called at [<phabricator>/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php:500]
[02-Jun-2016 14:15:06 PRC]   #2 PhabricatorRepositoryPullLocalDaemon::resolveUpdateFuture(PhabricatorRepository, ExecFuture, integer) called at [<phabricator>/src/applications/repository/daemon/PhabricatorRepositoryPullLocalDaemon.php:203]
[02-Jun-2016 14:15:06 PRC]   #3 PhabricatorRepositoryPullLocalDaemon::run() called at [<phutil>/src/daemon/PhutilDaemon.php:183]
[02-Jun-2016 14:15:06 PRC]   #3 PhabricatorRepositoryPullLocalDaemon::run() called at [<phutil>/src/daemon/PhutilDaemon.php:183]
[02-Jun-2016 14:15:06 PRC]   #4 PhutilDaemon::execute() called at [<phutil>/scripts/daemon/exec/exec_daemon.php:125]
[02-Jun-2016 14:15:06 PRC]   #4 PhutilDaemon::execute() called at [<phutil>/scripts/daemon/exec/exec_daemon.php:125]

Event Timeline

epriestley renamed this task from Couldn't resolve host to URI usernames and passwords containing forward slashes are not fully escaped.Jun 2 2016, 1:52 PM
epriestley claimed this task.
epriestley triaged this task as Normal priority.
epriestley added a project: libphutil.

Thanks for the report! This should be fixed in HEAD of master, and will promote to stable in about 48 hours. Let us know if you're still seeing issues after updating or if you run into anything else.