Page MenuHomePhabricator
Feed Advanced Search

Nov 19 2015

epriestley added a comment to T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.

Oh, you removed openTransaction(), so that's probably not the culprit.

Nov 19 2015, 2:09 AM · Harbormaster, Drydock
epriestley added a comment to T9816: Add objectPHID to Harbormaster workers to make root cause analysis easier.

It's vaguely possible that openTransaction() is the culprit. applyPlan() queues a daemon task, and I could imagine the race might be:

Nov 19 2015, 2:08 AM · Harbormaster, Drydock
epriestley closed T9803: Eternally failing mail send task as Invalid.

It sounds like this no longer reproduces for you.

Nov 19 2015, 1:25 AM · Daemons, Mail

Nov 18 2015

epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Nov 18 2015, 11:04 PM · Restricted Project, ApplicationEditor, Transactions
rodbegbie awarded T4214: Allow installs to change or supplement the "Phabricator" icon a Like token.
Nov 18 2015, 7:57 PM · Design
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Nov 18 2015, 7:24 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Nov 18 2015, 6:40 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a comment to T9805: XHProf will not build on PHP7.
  • If the changes are relatively minor, add a bunch more #ifdefs? We already have some of this to deal with prior API changes, and I believe this approach is historically a standard one across other extensions.
    • If the changes are substantial, maybe we need to get more creative.
Nov 18 2015, 4:14 PM · XHProf
vlada awarded T9456: Evaluate upstream support for third-party build systems a Doubloon token.
Nov 18 2015, 2:34 PM · Restricted Project, Harbormaster
epriestley closed T9810: 한글 테스트 중입니다. as Invalid.
Nov 18 2015, 8:10 AM · Android
epriestley closed T9808: Daemon worker garbage collector executes query with inefficient key usage as Resolved by committing Restricted Diffusion Commit.
Nov 18 2015, 1:05 AM · Daemons, Phacility
epriestley added a revision to T9808: Daemon worker garbage collector executes query with inefficient key usage: Unknown Object (Differential Revision).
Nov 18 2015, 1:02 AM · Daemons, Phacility
epriestley created T9808: Daemon worker garbage collector executes query with inefficient key usage.
Nov 18 2015, 12:25 AM · Daemons, Phacility

Nov 17 2015

epriestley added a comment to T9807: `arc land` no longer works with upgraded Mercurial (3.6.1).

If you want to test that something in this vein works, I'm happy to bring it upstream.

Nov 17 2015, 11:14 PM · Arcanist, Mercurial
epriestley added a comment to T9807: `arc land` no longer works with upgraded Mercurial (3.6.1).

We should be able to just omit the final argument if remote is not specified. We can refine that later, but our usage seems like it's in the wrong to me.

Nov 17 2015, 11:13 PM · Arcanist, Mercurial
epriestley added a revision to T9132: Build an ApplicationEditor abstraction: Unknown Object (Differential Revision).
Nov 17 2015, 8:37 PM · Restricted Project, ApplicationEditor, Transactions
epriestley added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.

If a Phurl doesn't have a name, should we still show the empty name property on the object view?

Nov 17 2015, 7:55 PM · Phurl
epriestley closed T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor as Resolved by committing Restricted Diffusion Commit.
Nov 17 2015, 4:37 PM · ApplicationEditor, Paste
epriestley edited the content of Changelog.
Nov 17 2015, 3:56 PM
epriestley created 2015 Week 46 (Mid November).
Nov 17 2015, 3:56 PM
epriestley edited the content of 2015 Week 45 (Early November).
Nov 17 2015, 3:47 PM
epriestley added a comment to T9803: Eternally failing mail send task.

I can't immediately reproduce this. Here's what I did:

Nov 17 2015, 3:33 PM · Daemons, Mail
epriestley closed T9804: ArcanistCSSLintLinter: Parameter passed to "setLine()" must be an integer as Resolved by committing Restricted Diffusion Commit.
Nov 17 2015, 3:14 PM · Lint
epriestley added a comment to T9803: Eternally failing mail send task.

The default value of metamta.email-body-limit is 512KB. Does your server reject 512KB messages, or have you raised this limit, or do you expect 512KB messages to send cleanly?

Nov 17 2015, 12:43 AM · Daemons, Mail

Nov 16 2015

epriestley closed T9802: `arc land` continues when the merge fails as Resolved.
Nov 16 2015, 10:56 PM · Arcanist
epriestley renamed T9800: Upgrading: Possible issue with `xhpast` database for installs that upgraded between October 8, 2012 and October 9, 2012 from Upgrading: Possible issue with `xhpast` database to Upgrading: Possible issue with `xhpast` database for installs that upgraded between October 8, 2012 and October 9, 2012.
Nov 16 2015, 10:06 PM · Installing & Upgrading
epriestley added a comment to T9802: `arc land` continues when the merge fails.

cdda79e9 is not a commit in rARC or rPHU, and the last commit to libphutil was on 12 Nov (while that output shows a change on 13 Nov), and it's impossible for both libraries to have the same commit at HEAD. Is he running a forked version of arc with local modifications?

Nov 16 2015, 9:06 PM · Arcanist
epriestley added a comment to T9802: `arc land` continues when the merge fails.

What version of arc does the user have (per arc version)?

Nov 16 2015, 7:15 PM · Arcanist
epriestley triaged T9802: `arc land` continues when the merge fails as Normal priority.
Nov 16 2015, 7:12 PM · Arcanist
epriestley added a comment to T9770: It is possible to use the same 2FA token more than once.

If you have long-term local access to a user's machine and can install a keylogger, you can just steal the session cookie. Being able to establish a second session instead of stealing the first session cookie is not a meaningful escalation.

Nov 16 2015, 7:09 PM · Security, Auth
epriestley triaged T9770: It is possible to use the same 2FA token more than once as Wishlist priority.
Nov 16 2015, 6:44 PM · Security, Auth
epriestley added a comment to T9773: Unit tests are slow.

Maybe adding --trace will reveal what's going on?

Nov 16 2015, 6:44 PM · Infrastructure
epriestley added a comment to T9771: Objects which are restricted because of Spaces render as "Unknown" instead of "Restricted".

We apply a Space constraint when executing this query and the object never makes it as far as the application. This is broadly by design, as it hugely improves the scalability of Spaces.

Nov 16 2015, 6:31 PM · Policy, Spaces
epriestley renamed T9771: Objects which are restricted because of Spaces render as "Unknown" instead of "Restricted" from "Unknown Object (Passphrase Credential)" in Drydock to Objects which are restricted because of Spaces render as "Unknown" instead of "Restricted".
Nov 16 2015, 6:27 PM · Policy, Spaces
epriestley added a revision to T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor: Unknown Object (Differential Revision).
Nov 16 2015, 6:22 PM · ApplicationEditor, Paste
epriestley renamed T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor from Unable to view raw paste to Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.
Nov 16 2015, 6:18 PM · ApplicationEditor, Paste
epriestley closed T9801: Hardcoded timeout in HarbormasterHTTPRequestBuildStepImplementation class as Wontfix.

Your HTTP request should start a build, it should not wait for the build to complete. See:

Nov 16 2015, 6:17 PM · Harbormaster
epriestley closed T9799: nonsensical conduit.query auth errors/busted on this install as Resolved by committing Restricted Diffusion Commit.
Nov 16 2015, 6:02 PM · Conduit
epriestley added a revision to T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor: Unknown Object (Differential Revision).
Nov 16 2015, 6:02 PM · ApplicationEditor, Paste
epriestley edited P1890 Masterwork From Distant Lands.
Nov 16 2015, 5:38 PM
epriestley edited P1890 Masterwork From Distant Lands.
Nov 16 2015, 5:37 PM
epriestley updated the title for P1889 sadb from untitled to sadb.
Nov 16 2015, 5:37 PM
epriestley added a revision to T9799: nonsensical conduit.query auth errors/busted on this install: Unknown Object (Differential Revision).
Nov 16 2015, 5:30 PM · Conduit
epriestley added a project to T9789: Make it easier to write custom transaction types: Modernization.
Nov 16 2015, 5:29 PM · Modernization, Transactions
epriestley added a comment to T9799: nonsensical conduit.query auth errors/busted on this install.

Never mind, this was straightforward to reproduce:

Nov 16 2015, 5:07 PM · Conduit
epriestley added a comment to T9798: History icon url in the content browser of diffusion does not include file path.

This should be fixed at HEAD. Let us know if you run into anything else.

Nov 16 2015, 5:04 PM · Diffusion
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Nov 16 2015, 5:03 PM
epriestley added a comment to T9799: nonsensical conduit.query auth errors/busted on this install.

Do you have a stack trace in the error log offhand? I can't immediately reproduce this on this install after upgrading. I have a good idea what's going on, but if you have a stack handy that might be faster.

Nov 16 2015, 5:02 PM · Conduit
epriestley closed T9798: History icon url in the content browser of diffusion does not include file path as Resolved by committing Restricted Diffusion Commit.
Nov 16 2015, 5:00 PM · Diffusion
epriestley added a project to T9800: Upgrading: Possible issue with `xhpast` database for installs that upgraded between October 8, 2012 and October 9, 2012: Installing & Upgrading.
Nov 16 2015, 4:59 PM · Installing & Upgrading
epriestley added a comment to T9800: Upgrading: Possible issue with `xhpast` database for installs that upgraded between October 8, 2012 and October 9, 2012.

It looks like this database did exist as of D3659, but the name was mistaken (pushed as xhpast, should have been xhprof). It was renamed in D3670.

Nov 16 2015, 4:59 PM · Installing & Upgrading
epriestley created T9800: Upgrading: Possible issue with `xhpast` database for installs that upgraded between October 8, 2012 and October 9, 2012.
Nov 16 2015, 4:53 PM · Installing & Upgrading
epriestley added a revision to T9798: History icon url in the content browser of diffusion does not include file path: Unknown Object (Differential Revision).
Nov 16 2015, 4:40 PM · Diffusion
epriestley closed T9791: Upgrade PhabricatorMailImplementationSendGridAdapter to use SendGrid v3 API as Wontfix.

The Sendgrid v3 API does not currently include an API method for sending mail.

Nov 16 2015, 4:39 PM · Mail
epriestley added a comment to T9799: nonsensical conduit.query auth errors/busted on this install.

This install is just a little out of date, second issue should be fixed at HEAD.

Nov 16 2015, 4:34 PM · Conduit
epriestley claimed T9799: nonsensical conduit.query auth errors/busted on this install.
Nov 16 2015, 4:33 PM · Conduit
epriestley added a comment to T9798: History icon url in the content browser of diffusion does not include file path.

I was able to reproduce this easily by following your instructions. We'll get this fixed. Thanks for the report!

Nov 16 2015, 4:26 PM · Diffusion
epriestley renamed T9798: History icon url in the content browser of diffusion does not include file path from Bug: history icon url in the content browser of diffusion does not include file path to History icon url in the content browser of diffusion does not include file path.
Nov 16 2015, 4:26 PM · Diffusion
• frans.kasper awarded T9378: Build Projects v3 a Love token.
Nov 16 2015, 12:40 PM · Projects (v3), Prioritized

Nov 15 2015

epriestley awarded T6049: Implement Phurl, a URL shortener/bookmarking application a Piece of Eight token.
Nov 15 2015, 4:51 PM · Phurl
epriestley created T9793: Remarkup tables have uneven top and bottom margins.
Nov 15 2015, 4:14 PM · Remarkup

Nov 14 2015

epriestley added a comment to T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.

I'm partly just guessing here but I think It's almost certainly my fault.

Nov 14 2015, 11:46 PM · ApplicationEditor, Paste
epriestley added a comment to T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.

File should be getting attached to the paste, but isn't. I think I accidentally caused a side effect here when changing how the transaction works.

Nov 14 2015, 11:44 PM · ApplicationEditor, Paste
epriestley claimed T9787: Raw files in Paste no longer attach to Pastes properly after ApplicationEditor.
Nov 14 2015, 11:44 PM · ApplicationEditor, Paste
epriestley closed T9786: Creating Hosted Repo leads to Almanac Exception as Invalid.

User Guide: Prototype Applications

Nov 14 2015, 10:53 PM
stevenjt awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Nov 14 2015, 5:41 PM · Workboards (v3), Restricted Project
epriestley updated subscribers of T8971: Auto-fix patch is wrong when multiple issue affect the same line.
Nov 14 2015, 12:56 AM · Restricted Project, Arcanist
epriestley merged task T9783: Multiple linters affecting same line, one of which applying autocorrect into T8971: Auto-fix patch is wrong when multiple issue affect the same line.
Nov 14 2015, 12:56 AM · Restricted Project, Lint

Nov 13 2015

epriestley updated subscribers of T4863: Allow Workboard Cards to be customized for display.
Nov 13 2015, 7:58 PM · Projects, Wikimedia, Workboards
epriestley merged task T9782: On a dashboard, the Differential panel should show the repository. into T4863: Allow Workboard Cards to be customized for display.
Nov 13 2015, 7:58 PM · Dashboards, Differential
epriestley added a comment to T9770: It is possible to use the same 2FA token more than once.

(HTTP over public wireless has those properties, but using MFA and not using HTTPS is silly and the lack of HTTPS is a far greater problem than the larger MFA vulnerability window.)

Nov 13 2015, 7:56 PM · Security, Auth
epriestley added a comment to T9770: It is possible to use the same 2FA token more than once.

could MITM the connection between the verifier and prover

Nov 13 2015, 7:53 PM · Security, Auth
epriestley added a comment to T9770: It is possible to use the same 2FA token more than once.

There are some attacks that could be performed on such MFA schemes but that are not applicable in phabricator's security model.

Nov 13 2015, 7:40 PM · Security, Auth
epriestley added a comment to T9770: It is possible to use the same 2FA token more than once.

I think the RFC should be followed.

Nov 13 2015, 7:33 PM · Security, Auth
epriestley added a comment to T9773: Unit tests are slow.

I can't reproduce this either, nor does it reproduce on this install.

Nov 13 2015, 7:26 PM · Infrastructure
epriestley added a comment to T9770: It is possible to use the same 2FA token more than once.

I'd like to understand the reason behind this before moving forward.

Nov 13 2015, 7:17 PM · Security, Auth
epriestley closed T9776: Process Herald rules recursively as Wontfix.

I don't want to introduce this level of complexity into Herald.

Nov 13 2015, 6:57 PM · Herald
epriestley added Q219: What is the difference between the individual and corporate CLA? (Answer 252).
Nov 13 2015, 6:50 PM

Nov 12 2015

Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Nov 12 2015, 7:44 PM
epriestley added a member for Blessed Committers: turadg.
Nov 12 2015, 7:23 PM
epriestley closed T9772: Fatal error when running conduit.query as Resolved by committing Restricted Diffusion Commit.
Nov 12 2015, 7:22 PM · ApplicationEditor, Conduit
epriestley added a revision to T9772: Fatal error when running conduit.query: Unknown Object (Differential Revision).
Nov 12 2015, 7:15 PM · ApplicationEditor, Conduit
epriestley claimed T9772: Fatal error when running conduit.query.
Nov 12 2015, 6:47 PM · ApplicationEditor, Conduit
epriestley added a comment to T9770: It is possible to use the same 2FA token more than once.

Is there a specific security purpose behind this? That is, what attack is this measure aimed at defusing?

Nov 12 2015, 7:05 AM · Security, Auth

Nov 11 2015

epriestley added a comment to T9766: Expose conduit API to activate/disable Herald rules.

Just to clarify, you would rather rely on an external script to activate and deactivate this rule every day instead of having a Herald condition like "Current time is between 5PM and 9AM"?

Nov 11 2015, 6:57 PM · Restricted Project, Restricted Project, Conduit, Herald
r0bbie awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Like token.
Nov 11 2015, 4:40 PM · Workboards (v3), Restricted Project
epriestley closed T9765: Add support to Remarkup for "custom local links" eg. within same domain but not handled by phabricator as Wontfix.

I don't plan to support this in the upstream. This configuration is inherently dangerous because the custom application has access to Phabricator's cookies, and not one we recommend.

Nov 11 2015, 4:09 PM · Remarkup
epriestley added a comment to T3670: Add subprojects.

You should be able to batch edit infinite tasks.

Nov 11 2015, 11:16 AM · KDE, Projects (v3), Restricted Project, FreeBSD, Wikimedia

Nov 10 2015

epriestley added a comment to T9760: Autoscaling for Almanac devices.

Right, Almanac does not support autoscaling. We'll have an EC2 blueprint (and similar) in the future which can manage autoscaling more simply. Almanac is the ground level "I have a list of IPs" version of things.

Nov 10 2015, 11:58 PM · Drydock, Almanac
epriestley added a comment to T9760: Autoscaling for Almanac devices.

bin/almanac register is just a shortcut for "put the private half of a key in the right place on disk, and the public half on the specified Almanac device". Maybe a clearer name would be bin/almanac install-keys.

Nov 10 2015, 11:57 PM · Drydock, Almanac
epriestley added a comment to T9760: Autoscaling for Almanac devices.

This just means adding a device interface?

Nov 10 2015, 11:54 PM · Drydock, Almanac
epriestley added a comment to T9760: Autoscaling for Almanac devices.

Right. You just need to:

Nov 10 2015, 11:49 PM · Drydock, Almanac
epriestley added a comment to T9760: Autoscaling for Almanac devices.

Don't do steps (3) or (4)! Those are useless at best, and dangerous at worst.

Nov 10 2015, 11:43 PM · Drydock, Almanac
epriestley added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.
  • The view page doesn't actually show the short URL anywhere. You can copy it from "View URL", but I think this isn't totally obvious, and we probably have enough room to reasonably add it (e.g., "Short URL: ..." under "Original URL: ...").
  • If a link has an alias, "View URL" still links to the non-alias version (e.g. U6 links to /u/6, but a more-preferred link would be /u/bug).
  • The "Remarkup Reference" document (https://secure.phabricator.com/book/phabricator/article/remarkup/) should explain how to use ((6)) and ((bug)). It might be worthwhile to hint these on the U6 page itself, e.g. In Remarkup: ((bug)) in the properties? Not sure how useful/cluttered that would look.
  • Maybe show aliases on the list at /phurl/?
  • Maybe let users search for the link with a particular alias? If I know ((bug)), there's no way for me to actually find the URL object right now. Hovercards would be one fix but just going to Phurl and being able to search for "Alias: bug" is probably good too.
Nov 10 2015, 10:37 PM · Phurl
epriestley added a comment to T7053: Restart daemons automagically.

This also seems to work properly on this host, although I hit the "daemons are not running" setup warning once, presumably by racing their restart. If this is an issue we can tweak how that warning works, I think.

Nov 10 2015, 10:30 PM · Daemons
epriestley added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.

Oh, transaction publishing from Phurl also currently fails in the daemons:

Nov 10 2015, 10:25 PM · Phurl
epriestley added a comment to T7053: Restart daemons automagically.

One possible minor followup to maybe keep on the radar is showing some extra warnings in a few cases:

Nov 10 2015, 10:20 PM · Daemons
epriestley added a comment to T6049: Implement Phurl, a URL shortener/bookmarking application.

A couple of notes so far, after poking at this:

Nov 10 2015, 10:19 PM · Phurl
epriestley closed T9322: Avoid spawning setup errors when changing parameters in application "Config" as Resolved.
Nov 10 2015, 10:15 PM · Phacility Support, Phacility
epriestley added a comment to T9322: Avoid spawning setup errors when changing parameters in application "Config".

The resolution of T7053 should indirectly resolve this.

Nov 10 2015, 10:15 PM · Phacility Support, Phacility