Page MenuHomePhabricator
Feed Advanced Search

Jun 8 2015

epriestley updated the task description for T8478: Loading Conpherence handles may recurse indefinitely.
Jun 8 2015, 9:56 PM
epriestley added a revision to T8478: Loading Conpherence handles may recurse indefinitely: Unknown Object (Differential Revision).
Jun 8 2015, 9:56 PM
epriestley created T8478: Loading Conpherence handles may recurse indefinitely.
Jun 8 2015, 9:31 PM
epriestley added a comment to T8476: Rename `phabricator_repository` database.

As a possible attack on this, we could rename phabricator_pastebin to phabricator_paste first and see how awful that is.

Jun 8 2015, 9:13 PM · Restricted Project, Database, Diffusion
epriestley added a comment to T8475: Clean up remnants of old Differential hunk storage.

Yeah, we migrated a long time ago and also never hit issues.

Jun 8 2015, 9:03 PM · Infrastructure, Restricted Project, Differential
epriestley awarded T8474: Fix linter severity customization a Haypence token.
Jun 8 2015, 8:57 PM · Lint
epriestley added a comment to T8474: Fix linter severity customization.

Haha, thanks for collecting these. I've been meaning to do that...

Jun 8 2015, 8:57 PM · Lint
epriestley created T8473: Garbage collect old notifications.
Jun 8 2015, 8:30 PM · Notifications
epriestley added a comment to T6943: Create "basic" and "advanced" modes in Maniphest Search UI.

To tie in some context:

Jun 8 2015, 7:31 PM · Design, Search, Maniphest
epriestley added a comment to T8453: Searching via custom fields doesn't work.

The index should update without needing the daemons, but that code did get touched in connection with T6367, so maybe I fixed something by accident.

Jun 8 2015, 7:06 PM · Custom Fields
epriestley added a comment to T8453: Searching via custom fields doesn't work.

Seems OK here, here's the create / detail / search UI:

Jun 8 2015, 7:03 PM · Custom Fields
epriestley added a comment to T8453: Searching via custom fields doesn't work.

Thanks!

Jun 8 2015, 7:01 PM · Custom Fields
epriestley added a comment to T8453: Searching via custom fields doesn't work.

One thought -- what type of field were you using? I tried reproing it with an "int" field, but maybe the issue is with certain field types or something like that.

Jun 8 2015, 6:59 PM · Custom Fields
epriestley added a comment to T8455: Herald rules with mailing lists are broken after mailing list -> user migration.

It's only issuing one statement so it will jump from 0% to 100% after adding the key, but it might take a bit if you have a lot of data in the table.

Jun 8 2015, 6:33 PM · Herald, Mailing Lists, Restricted Project
epriestley closed T8467: Ho to change database configuration for phpmailer.smtp-password? as Resolved.

Presuming this is resolved, but let us know if that doesn't work for you.

Jun 8 2015, 6:09 PM · Config
epriestley closed T8471: Add support for dynamic date filter queries as Resolved.

Write "7 days ago" or "-1 day".

Jun 8 2015, 6:03 PM · Maniphest
epriestley added a comment to T8455: Herald rules with mailing lists are broken after mailing list -> user migration.

I believe the error is now fixed at HEAD.

Jun 8 2015, 5:58 PM · Herald, Mailing Lists, Restricted Project
epriestley closed T8463: Username `@mentions` prevent creation of revisions with "data not attached" error as Resolved.

I believe this is now resolved in HEAD, but let me know if you still see it after upgrading.

Jun 8 2015, 5:52 PM · Restricted Project
epriestley closed T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction as Resolved by committing Restricted Diffusion Commit.
Jun 8 2015, 5:50 PM · Herald
epriestley closed T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction, a subtask of T8455: Herald rules with mailing lists are broken after mailing list -> user migration, as Resolved.
Jun 8 2015, 5:50 PM · Herald, Mailing Lists, Restricted Project
epriestley added a comment to T8469: Hard to find New Room workflow.

FWIW, I do think this UI is poorly designed, and it's reasonable for users to find it confusing: it teaches them how to do something, then takes that away from them.

Jun 8 2015, 5:03 PM · Conpherence
epriestley added a revision to T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction: Unknown Object (Differential Revision).
Jun 8 2015, 1:51 PM · Herald
epriestley renamed T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction from herald rules no email sent after migration of mailing list to users to Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction.
Jun 8 2015, 1:49 PM · Herald
epriestley added a comment to T8462: Move object destruction to taskmaster daemons.

Why do you need to destroy enough objects for this to matter?

Jun 8 2015, 1:38 PM · Infrastructure, Daemons
epriestley renamed T8463: Username `@mentions` prevent creation of revisions with "data not attached" error from differential.createrevision failing with "Attempting to access attached data on DifferentialRevision (via getRepository()), but the data is not actually attached" to Username `@mentions` prevent creation of revisions with "data not attached" error.
Jun 8 2015, 1:37 PM · Restricted Project
epriestley added a comment to T8463: Username `@mentions` prevent creation of revisions with "data not attached" error.

D13205 is a possible fix; if that's the issue, a workaround is to avoid mentioning any users with @mentions in the summary, test plan, or other description fields until it lands.

Jun 8 2015, 1:36 PM · Restricted Project
epriestley added a revision to T8463: Username `@mentions` prevent creation of revisions with "data not attached" error: Unknown Object (Differential Revision).
Jun 8 2015, 1:35 PM · Restricted Project
epriestley added a comment to T8463: Username `@mentions` prevent creation of revisions with "data not attached" error.

Do the problematic revisions mention a user with @username in the summary or test plan?

Jun 8 2015, 1:29 PM · Restricted Project
epriestley added a comment to T8463: Username `@mentions` prevent creation of revisions with "data not attached" error.

If it reproduces via the web UI on your install, try to hit it on this install by typing stuff in here:

Jun 8 2015, 1:18 PM · Restricted Project
epriestley added a comment to T8463: Username `@mentions` prevent creation of revisions with "data not attached" error.

Thanks for the stack trace, in any case -- I'll keep digging; if you can come up with a repro case on this install that might help get things resolved faster.

Jun 8 2015, 1:16 PM · Restricted Project
epriestley abandoned D13203: New Revision via Web UI.
Jun 8 2015, 1:12 PM
epriestley added a revision to T8463: Username `@mentions` prevent creation of revisions with "data not attached" error: D13203: New Revision via Web UI.
Jun 8 2015, 1:10 PM · Restricted Project
epriestley retitled D13203: New Revision via Web UI from to New Revision via Web UI.
Jun 8 2015, 1:10 PM
epriestley added a comment to T8463: Username `@mentions` prevent creation of revisions with "data not attached" error.

I'm not immediately able to reproduce this. Does it reproduce for you on this install?

Jun 8 2015, 1:09 PM · Restricted Project
epriestley added a comment to T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction.

On this task, I got the second email, but the addressee list for the first mail was not computed correctly. This might already be resolved by changes attached to T8455, or might be a general issue related to T6367. I'll look into it.

Jun 8 2015, 11:08 AM · Herald
epriestley added a comment to T8467: Ho to change database configuration for phpmailer.smtp-password?.

Use bin/config delete --database phpmailer.smtp-password to delete the database value.

Jun 8 2015, 11:07 AM · Config
epriestley added a comment to T8466: Allow commit message editing in 'arc commit'.

Over time, we've generally increased the barriers faced by new contributors: they were previously lower, and with lower barriers we accepted a number of changes which were net negatives for us in the long run. It is harder to get changes into the upstream today than it was a year ago (and was much harder then than it was in 2011).

Jun 8 2015, 11:04 AM · Arcanist
epriestley added a comment to T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction.

(Test...)

Jun 8 2015, 10:58 AM · Herald
epriestley updated the task description for T8464: Herald "subscribe" rules do not take effect immediately, skipping mail about the first transaction.
Jun 8 2015, 10:47 AM · Herald
epriestley added a comment to T8463: Username `@mentions` prevent creation of revisions with "data not attached" error.

Can you fish the server-side stack trace out of the error log on the server? (Usually /var/log/apache2/error_log or similar.)

Jun 8 2015, 10:45 AM · Restricted Project
epriestley closed T8466: Allow commit message editing in 'arc commit' as Wontfix.

We aren't interested in bringing this upstream.

Jun 8 2015, 10:42 AM · Arcanist
epriestley closed T8465: herald webhook action as Wontfix.

See T5462 for discussion about publishing events into remote systems, and why Herald isn't a good choice for doing this.

Jun 8 2015, 10:37 AM · Herald
maxmind awarded T2000: Image proxying in Remarkup should not activate unless the response is HTTP 200 with valid image data a Like token.
Jun 8 2015, 5:04 AM · Roadmap

Jun 7 2015

• lavahot awarded T3569: Make Phrequent somewhat usable a Love token.
Jun 7 2015, 10:49 PM · Phrequent
epriestley added a revision to T7909: Allow ascending order for Conduit's maniphest.query's "order" parameter (order-created, order-modified): Unknown Object (Differential Revision).
Jun 7 2015, 9:15 PM · Conduit
epriestley added a revision to T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch: Unknown Object (Differential Revision).
Jun 7 2015, 9:15 PM · Restricted Project, FreeBSD, Arcanist
epriestley added a revision to T8441: Integrate Spaces into ApplicationSearch: Unknown Object (Differential Revision).
Jun 7 2015, 9:14 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8441: Integrate Spaces into ApplicationSearch: Unknown Object (Differential Revision).
Jun 7 2015, 8:25 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch: Unknown Object (Differential Revision).
Jun 7 2015, 8:25 PM · Restricted Project, FreeBSD, Arcanist
epriestley added a revision to T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch: Unknown Object (Differential Revision).
Jun 7 2015, 8:06 PM · Restricted Project, FreeBSD, Arcanist
epriestley added a revision to T8441: Integrate Spaces into ApplicationSearch: Unknown Object (Differential Revision).
Jun 7 2015, 8:06 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8441: Integrate Spaces into ApplicationSearch: Unknown Object (Differential Revision).
Jun 7 2015, 7:33 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch: Unknown Object (Differential Revision).
Jun 7 2015, 7:33 PM · Restricted Project, FreeBSD, Arcanist
epriestley added a revision to T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch: Unknown Object (Differential Revision).
Jun 7 2015, 6:59 PM · Restricted Project, FreeBSD, Arcanist
epriestley added a revision to T8441: Integrate Spaces into ApplicationSearch: Unknown Object (Differential Revision).
Jun 7 2015, 6:59 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8441: Integrate Spaces into ApplicationSearch: Unknown Object (Differential Revision).
Jun 7 2015, 5:30 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch: Unknown Object (Differential Revision).
Jun 7 2015, 5:30 PM · Restricted Project, FreeBSD, Arcanist
epriestley added a revision to T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch: Unknown Object (Differential Revision).
Jun 7 2015, 5:00 PM · Restricted Project, FreeBSD, Arcanist
epriestley added a revision to T8441: Integrate Spaces into ApplicationSearch: Unknown Object (Differential Revision).
Jun 7 2015, 5:00 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch: Unknown Object (Differential Revision).
Jun 7 2015, 4:25 PM · Restricted Project, FreeBSD, Arcanist
epriestley added a revision to T8441: Integrate Spaces into ApplicationSearch: Unknown Object (Differential Revision).
Jun 7 2015, 4:25 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a comment to T8461: Better integration with diffusion?.

Can you describe the problem you're facing, not just your desired solution? See:

Jun 7 2015, 1:35 PM · Projects

Jun 6 2015

epriestley added a comment to T8442: Build Space switching UI.

I think these are the plausible-ish icons that we aren't using anywhere else yet -- this might be missing icons or have icons we can't really use:

Jun 6 2015, 4:49 PM · Restricted Project, Spaces, Wikimedia, Policy
epriestley added a comment to T8442: Build Space switching UI.

I really like how that looks.

Jun 6 2015, 4:29 PM · Restricted Project, Spaces, Wikimedia, Policy
epriestley added a comment to T8376: Develop Spaces (v1).

Development Log

Jun 6 2015, 2:26 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley edited the content of Changelog.
Jun 6 2015, 2:01 PM
epriestley created 2015 Week 23 (Early June).
Jun 6 2015, 2:00 PM
epriestley added a comment to T8454: User approval not working.

On the second part, the condition for that query was wrong coming out of D13122: noDisabled changed to isDisabled, but the default value didn't get flipped.

Jun 6 2015, 1:41 PM · People
epriestley added a comment to T8455: Herald rules with mailing lists are broken after mailing list -> user migration.

If you haven't run into it, T8398 has general context and guidance on this change. I've updated it to include the information here.

Jun 6 2015, 1:35 PM · Herald, Mailing Lists, Restricted Project
epriestley updated the task description for T8398: Upgrading: Changes to Mailing Lists.
Jun 6 2015, 1:35 PM · Installing & Upgrading, People, Mail, Guides
epriestley added a comment to T8398: Upgrading: Changes to Mailing Lists.

See T8455 for a discussion of some issues. There are fixes there awaiting review, but if you're a larger install and/or use a lot of mailing lists, you might want to wait for the dust to settle there.

Jun 6 2015, 1:34 PM · Installing & Upgrading, People, Mail, Guides
epriestley added a revision to T8455: Herald rules with mailing lists are broken after mailing list -> user migration: Unknown Object (Differential Revision).
Jun 6 2015, 1:33 PM · Herald, Mailing Lists, Restricted Project
epriestley added a comment to T8455: Herald rules with mailing lists are broken after mailing list -> user migration.

Worth adding: most of these were not intentionally created to refer to mailing lists. I think they used to just refer to plain email addresses, but then some migration in the past detected all of them, automatically created mailing lists for them, and automatically changed the Herald rules to refer to the mailing lists. So, I wouldn't be surprised if many installs run into similar issues.

Jun 6 2015, 1:10 PM · Herald, Mailing Lists, Restricted Project
epriestley added a revision to T8455: Herald rules with mailing lists are broken after mailing list -> user migration: Unknown Object (Differential Revision).
Jun 6 2015, 1:04 PM · Herald, Mailing Lists, Restricted Project
epriestley added a revision to T8455: Herald rules with mailing lists are broken after mailing list -> user migration: Unknown Object (Differential Revision).
Jun 6 2015, 12:55 PM · Herald, Mailing Lists, Restricted Project
epriestley added a revision to T8455: Herald rules with mailing lists are broken after mailing list -> user migration: Unknown Object (Differential Revision).
Jun 6 2015, 12:49 PM · Herald, Mailing Lists, Restricted Project
epriestley added a revision to T8455: Herald rules with mailing lists are broken after mailing list -> user migration: Unknown Object (Differential Revision).
Jun 6 2015, 12:40 PM · Herald, Mailing Lists, Restricted Project
epriestley added a revision to T8455: Herald rules with mailing lists are broken after mailing list -> user migration: Unknown Object (Differential Revision).
Jun 6 2015, 12:33 PM · Herald, Mailing Lists, Restricted Project
epriestley triaged T8455: Herald rules with mailing lists are broken after mailing list -> user migration as Normal priority.
Jun 6 2015, 12:19 PM · Herald, Mailing Lists, Restricted Project
epriestley added a revision to T8455: Herald rules with mailing lists are broken after mailing list -> user migration: Unknown Object (Differential Revision).
Jun 6 2015, 11:40 AM · Herald, Mailing Lists, Restricted Project
epriestley added a revision to T8455: Herald rules with mailing lists are broken after mailing list -> user migration: Unknown Object (Differential Revision).
Jun 6 2015, 11:24 AM · Herald, Mailing Lists, Restricted Project
epriestley claimed T8455: Herald rules with mailing lists are broken after mailing list -> user migration.
Jun 6 2015, 10:53 AM · Herald, Mailing Lists, Restricted Project

Jun 5 2015

epriestley added a comment to T8376: Develop Spaces (v1).

Excerpted from a giant novel I wrote but didn't bother publishing:

Jun 5 2015, 11:05 PM · Prioritized, Policy, Wikimedia, Spaces
epriestley added a revision to T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch: Unknown Object (Differential Revision).
Jun 5 2015, 10:58 PM · Restricted Project, FreeBSD, Arcanist
epriestley added a revision to T8441: Integrate Spaces into ApplicationSearch: Unknown Object (Differential Revision).
Jun 5 2015, 10:58 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch: Unknown Object (Differential Revision).
Jun 5 2015, 10:40 PM · Restricted Project, FreeBSD, Arcanist
epriestley added a revision to T8441: Integrate Spaces into ApplicationSearch: Unknown Object (Differential Revision).
Jun 5 2015, 10:40 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch: Unknown Object (Differential Revision).
Jun 5 2015, 10:23 PM · Restricted Project, FreeBSD, Arcanist
epriestley added a revision to T8441: Integrate Spaces into ApplicationSearch: Unknown Object (Differential Revision).
Jun 5 2015, 10:23 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a comment to T8453: Searching via custom fields doesn't work.

I can't reproduce this:

Jun 5 2015, 10:20 PM · Custom Fields
epriestley moved T8442: Build Space switching UI from Backlog to Unprototype (v1) on the Spaces board.
Jun 5 2015, 8:45 PM · Restricted Project, Spaces, Wikimedia, Policy
epriestley moved T8449: Spaces v1 Errata from Backlog to Unprototype (v1) on the Spaces board.
Jun 5 2015, 8:44 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a revision to T8449: Spaces v1 Errata: Unknown Object (Differential Revision).
Jun 5 2015, 8:43 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley added a comment to T8451: Add agenda and minutes to meeting calendar events.

The lack of formatting in the text area is a bug, tracked in T8032. The intent is for it to always format. Would that be satisfactory?

Jun 5 2015, 8:22 PM · Calendar
epriestley added a comment to T8444: Increase typeahead speed.

Though sometimes I'm typing as fast as I can adding multiple people, in which case I'd still have to wait for the first user before typing the second user?

Jun 5 2015, 8:18 PM · Typeahead, PHUI, Restricted Project
epriestley added a comment to T8450: Can't invite members.

In Phacility, invite members from the instance administration panel instead of from the instance itself:

Jun 5 2015, 8:09 PM · Phacility Support
epriestley added a comment to T8444: Increase typeahead speed.

Alternatively, we could require usernames to contain a minimum of 16 characters with at least one uppercase letter, one symbol, and three or more of the same letter in a row.

Jun 5 2015, 8:06 PM · Typeahead, PHUI, Restricted Project
epriestley added a comment to T8444: Increase typeahead speed.

Oh, so you're typing as fast as you can and immediately tabbing out of the field (in less than a second)?

Jun 5 2015, 8:05 PM · Typeahead, PHUI, Restricted Project
epriestley added a revision to T8449: Spaces v1 Errata: Unknown Object (Differential Revision).
Jun 5 2015, 7:44 PM · Spaces, Wikimedia, Policy, Prioritized
epriestley created T8449: Spaces v1 Errata.
Jun 5 2015, 7:44 PM · Spaces, Wikimedia, Policy, Prioritized