Page MenuHomePhabricator
Create Task
Maniphest T8466

Allow commit message editing in 'arc commit'
Closed, WontfixPublic
Actions

Description

Sometimes it's useful to edit the commit message before arcanist commits a change. Example situations include:

  • Fixing typos
  • Updating the description to account for changes during review
  • LLVM-specific: 'Depends on D1234' is considered undesirable in commit messages and so these must be removed.

While this is possible via the Differential web interface, it would be useful to be able to make these edits from Arcanist.

I've been using a small patch that adds a --edit option to 'arc commit' to provide this feature for about a year. Now that Imagination has signed the corporate CLA I'm able to contribute it. Is it ok to submit the patch to differential?

Event Timeline

• dsandersimgtec created this task.Jun 8 2015, 10:37 AM
• dsandersimgtec raised the priority of this task from to Needs Triage.
• dsandersimgtec updated the task description. (Show Details)
• dsandersimgtec added a project: Arcanist.
• dsandersimgtec added a subscriber: • dsandersimgtec.
epriestley closed this task as Wontfix.Jun 8 2015, 10:42 AM
epriestley claimed this task.
epriestley added a subscriber: epriestley.

We aren't interested in bringing this upstream.

You may be able to make some of these edits with arc diff --edit, particularly edits of the second type.

• dsandersimgtec added a comment.Jun 8 2015, 10:54 AM

That's a shame. I explained my proposed patch when we discussed contribution without a facebook account in July 2014 so I'm a bit disappointed that it's been rejected at this stage.

Oh well, I'll have to maintain the patch out-of-tree.

epriestley added a comment.Jun 8 2015, 11:04 AM

Over time, we've generally increased the barriers faced by new contributors: they were previously lower, and with lower barriers we accepted a number of changes which were net negatives for us in the long run. It is harder to get changes into the upstream today than it was a year ago (and was much harder then than it was in 2011).

If you haven't seen it, there's some discussion here:

https://secure.phabricator.com/book/phabcontrib/article/contributing_code/

• dsandersimgtec added a comment.Jun 8 2015, 12:38 PM

The barriers make sense to me. Having to support something just because it's there can become a significant problem and a high barrier to entry is one way to deal with that. You've probably already thought of this and dismissed it but coupling a high-barrier core project with a lower-barrier proving ground might be worth considering.

At least we've got the CLA sorted. There are non-trivial things I've avoided thinking too much about so far in the absence of any possibility to upstream the resulting work. I'll file tasks for them once I've thought about them properly.

Phabricator · Built by Phacility