Page MenuHomePhabricator
Feed Advanced Search

Jan 8 2015

joshuaspence added a parent task for T6559: Change notification system implementation not to require Flash: T6889: Evaluate PHP alternatives to NodeJS for Aphlict.
Jan 8 2015, 7:45 PM · Aphlict, Wikimedia
joshuaspence claimed T4333: `arc land` should provide a mechanism to land revisions by other authors while preserving authorship meta-data.
Jan 8 2015, 6:48 AM · Arcanist

Jan 7 2015

joshuaspence created T6889: Evaluate PHP alternatives to NodeJS for Aphlict.
Jan 7 2015, 10:58 PM · Aphlict
joshuaspence created T6888: Extending revert edges.
Jan 7 2015, 7:51 PM · Maniphest, Differential

Jan 6 2015

cspeckmim awarded T4706: Maybe make `arc land D123` go look up the branch? a Like token.
Jan 6 2015, 10:05 PM · Prioritized, Restricted Project, Arcanist
joshuaspence added a comment to T6559: Change notification system implementation not to require Flash.

Overall, I'm satisfied that WebSockets aren't a crazy mess anymore, and I think we can move forward to WebSockets only and drop Flash.

Jan 6 2015, 8:49 PM · Aphlict, Wikimedia
joshuaspence reassigned T6559: Change notification system implementation not to require Flash from joshuaspence to epriestley.

Looks like @epriestley has beaten me.

Jan 6 2015, 8:48 PM · Aphlict, Wikimedia
joshuaspence placed T6822: Fix methods which override other methods with the wrong visibility up for grabs.
Jan 6 2015, 10:59 AM · Infrastructure
joshuaspence added a revision to T6822: Fix methods which override other methods with the wrong visibility: Unknown Object (Differential Revision).
Jan 6 2015, 10:58 AM · Infrastructure
joshuaspence added a revision to T6822: Fix methods which override other methods with the wrong visibility: Unknown Object (Differential Revision).
Jan 6 2015, 10:55 AM · Infrastructure
joshuaspence added a revision to T6822: Fix methods which override other methods with the wrong visibility: Unknown Object (Differential Revision).
Jan 6 2015, 10:52 AM · Infrastructure
joshuaspence added a revision to T6822: Fix methods which override other methods with the wrong visibility: Unknown Object (Differential Revision).
Jan 6 2015, 10:51 AM · Infrastructure
joshuaspence added a revision to T6822: Fix methods which override other methods with the wrong visibility: Unknown Object (Differential Revision).
Jan 6 2015, 10:49 AM · Infrastructure
joshuaspence claimed T6822: Fix methods which override other methods with the wrong visibility.

I've been able to knock out a bunch of these.

Jan 6 2015, 10:49 AM · Infrastructure
joshuaspence added a revision to T6822: Fix methods which override other methods with the wrong visibility: Restricted Differential Revision.
Jan 6 2015, 10:47 AM · Infrastructure
joshuaspence added a revision to T6822: Fix methods which override other methods with the wrong visibility: Unknown Object (Differential Revision).
Jan 6 2015, 10:44 AM · Infrastructure
joshuaspence added a revision to T6822: Fix methods which override other methods with the wrong visibility: Unknown Object (Differential Revision).
Jan 6 2015, 10:43 AM · Infrastructure
joshuaspence added a revision to T6822: Fix methods which override other methods with the wrong visibility: Unknown Object (Differential Revision).
Jan 6 2015, 10:37 AM · Infrastructure
joshuaspence added a revision to T6822: Fix methods which override other methods with the wrong visibility: Unknown Object (Differential Revision).
Jan 6 2015, 10:30 AM · Infrastructure
joshuaspence added a revision to T6822: Fix methods which override other methods with the wrong visibility: Unknown Object (Differential Revision).
Jan 6 2015, 10:28 AM · Infrastructure
joshuaspence added a revision to T6822: Fix methods which override other methods with the wrong visibility: Unknown Object (Differential Revision).
Jan 6 2015, 10:21 AM · Infrastructure
joshuaspence added a revision to T6822: Fix methods which override other methods with the wrong visibility: Unknown Object (Differential Revision).
Jan 6 2015, 10:20 AM · Infrastructure
joshuaspence added a revision to T6822: Fix methods which override other methods with the wrong visibility: Unknown Object (Differential Revision).
Jan 6 2015, 10:15 AM · Infrastructure

Jan 5 2015

joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jan 5 2015, 9:10 PM · libphutil, Arcanist
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jan 5 2015, 9:08 PM · libphutil, Arcanist
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jan 5 2015, 9:08 PM · libphutil, Arcanist

Jan 4 2015

joshuaspence added a revision to T6861: PHP sort function is unpredictable to human minds when dealing with mixed types: Unknown Object (Differential Revision).
Jan 4 2015, 9:19 PM · Infrastructure
joshuaspence created T6861: PHP sort function is unpredictable to human minds when dealing with mixed types.
Jan 4 2015, 9:18 PM · Infrastructure
joshuaspence edited P1694 D11044 issues.
Jan 4 2015, 9:10 PM
joshuaspence edited P1693 Masterwork From Distant Lands.
Jan 4 2015, 8:53 PM
joshuaspence added a project to T6859: It is difficult to keep track of used PhabricatorEdgeType IDs: Infrastructure.
Jan 4 2015, 11:45 AM · Infrastructure
joshuaspence created T6859: It is difficult to keep track of used PhabricatorEdgeType IDs.
Jan 4 2015, 11:45 AM · Infrastructure
joshuaspence created T6858: "Depends on Dx" generates a superfluous edge.
Jan 4 2015, 10:20 AM · Differential, Transactions
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jan 4 2015, 10:11 AM · libphutil, Arcanist
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jan 4 2015, 10:06 AM · libphutil, Arcanist
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jan 4 2015, 10:03 AM · libphutil, Arcanist
joshuaspence created T6857: Moved file is showing incorrectly in Differential.
Jan 4 2015, 9:50 AM · Differential
joshuaspence placed T5365: Aphlict client should reconnect after a failure up for grabs.
Jan 4 2015, 9:12 AM · Aphlict
joshuaspence added a revision to T5141: `ArcanistXHPASTLinter` should raise warnings when deprecated functions are used: Unknown Object (Differential Revision).
Jan 4 2015, 7:37 AM · Lint, Arcanist
joshuaspence closed T6843: Write a linter rule to detect duplicate case statements as Resolved.

Closed by commit rARCb31e9c0cfee0.

Jan 4 2015, 7:19 AM · Lint
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jan 4 2015, 3:29 AM · libphutil, Arcanist
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jan 4 2015, 3:14 AM · libphutil, Arcanist
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jan 4 2015, 3:14 AM · libphutil, Arcanist
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jan 4 2015, 3:12 AM · libphutil, Arcanist
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jan 4 2015, 3:02 AM · libphutil, Arcanist
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jan 4 2015, 1:42 AM · libphutil, Arcanist

Jan 3 2015

joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jan 3 2015, 11:25 PM · libphutil, Arcanist
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jan 3 2015, 9:56 PM · libphutil, Arcanist
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jan 3 2015, 1:48 PM · libphutil, Arcanist
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jan 3 2015, 1:42 PM · libphutil, Arcanist
joshuaspence closed T6849: With policies like "'Users A, B, C' and 'Administrators'", the 'Administrators' part is ignored as Resolved.

Closed by commit rPb3e196b69400.

Jan 3 2015, 12:52 PM · Policy
joshuaspence added a revision to T6854: Modify the `lint-test` file format to allow for assertions against linter codes: Unknown Object (Differential Revision).
Jan 3 2015, 8:00 AM · Lint
joshuaspence claimed T6854: Modify the `lint-test` file format to allow for assertions against linter codes.
Jan 3 2015, 7:24 AM · Lint
joshuaspence updated the task description for T6854: Modify the `lint-test` file format to allow for assertions against linter codes.
Jan 3 2015, 7:20 AM · Lint
joshuaspence created T6854: Modify the `lint-test` file format to allow for assertions against linter codes.
Jan 3 2015, 7:19 AM · Lint
joshuaspence added a revision to T6843: Write a linter rule to detect duplicate case statements: Unknown Object (Differential Revision).
Jan 3 2015, 4:11 AM · Lint
joshuaspence added a revision to T6849: With policies like "'Users A, B, C' and 'Administrators'", the 'Administrators' part is ignored: Unknown Object (Differential Revision).
Jan 3 2015, 1:06 AM · Policy
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jan 3 2015, 1:06 AM · libphutil, Arcanist
joshuaspence added a revision to T6852: Buttons break out of box when registering new users: Unknown Object (Differential Revision).
Jan 3 2015, 12:48 AM · People

Jan 2 2015

joshuaspence added a comment to T6853: "Open Revisions Affecting These Files" should weight severity of changes.

Take {D11149} for example. Under "Open Revisions Affecting These Files", the following diffs are listed:

Jan 2 2015, 10:14 PM · Differential
joshuaspence created T6853: "Open Revisions Affecting These Files" should weight severity of changes.
Jan 2 2015, 10:05 PM · Differential
joshuaspence added a comment to T6728: `arc land` should update log message.

From my experience, the commit message is updated. I'm not sure why this wouldn't be happening for you.

Jan 2 2015, 9:19 PM · Arcanist
joshuaspence claimed T6849: With policies like "'Users A, B, C' and 'Administrators'", the 'Administrators' part is ignored.
Jan 2 2015, 9:18 PM · Policy
joshuaspence updated subscribers of T5105: Ensure that `ArcanistTextLinter` respects `.editorconfig` settings.
Jan 2 2015, 9:15 PM · Arcanist
joshuaspence merged task T6739: Arcanist Text Lint: Configuration options for CRLF newlines, charsets etc into T5105: Ensure that `ArcanistTextLinter` respects `.editorconfig` settings.
Jan 2 2015, 9:15 PM · Lint
joshuaspence added a comment to T6806: Raise severity of "phd.user" warning eventually.

One thing I havent quite worked out yet is whether the daemon user (phd in my case) requires a shell and/or home directory. If possible, it's nice to be able to set the shell to something like /bin/false.

Jan 2 2015, 9:10 PM · Daemons
joshuaspence added a comment to T6842: Can't stop daemons if MySQL is down.

We could add a --force mode which would kill the daemons regardless of the status of MySQL. That seems like a reasonable compromise.

Jan 2 2015, 9:01 PM · Daemons
joshuaspence added a comment to T6852: Buttons break out of box when registering new users.

I guess we can remove the TODO comment then?

Jan 2 2015, 8:56 PM · People
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jan 2 2015, 1:24 PM · libphutil, Arcanist
joshuaspence added a revision to T6559: Change notification system implementation not to require Flash: Unknown Object (Differential Revision).
Jan 2 2015, 7:59 AM · Aphlict, Wikimedia
joshuaspence added a comment to T6559: Change notification system implementation not to require Flash.

My intention is to keep the actual message structure the same, so using Flash as a fallback should be possible.

Jan 2 2015, 5:43 AM · Aphlict, Wikimedia
joshuaspence added a comment to T6559: Change notification system implementation not to require Flash.

We could use SockJS or similar to emulate the behaviour for IE8/IE9?

Jan 2 2015, 5:33 AM · Aphlict, Wikimedia
joshuaspence closed T6847: `phutil_symbols.php` does not correctly handle static method calls as Resolved.

Closed by commit rPHU20446fc6b6ac.

Jan 2 2015, 4:19 AM · libphutil
joshuaspence claimed T6830: Improve lint handling of declare() special statement blocks.
Jan 2 2015, 3:13 AM · Lint
joshuaspence claimed T6843: Write a linter rule to detect duplicate case statements.
Jan 2 2015, 3:07 AM · Lint
joshuaspence awarded T4245: Make repository URIs slightly prettier a The World Burns token.
Jan 2 2015, 3:06 AM · Prioritized, Diffusion (v3), KDE, Restricted Project
joshuaspence awarded T6559: Change notification system implementation not to require Flash a Love token.
Jan 2 2015, 3:01 AM · Aphlict, Wikimedia
joshuaspence awarded T4900: Workboards updating in real time a Like token.
Jan 2 2015, 3:00 AM · Workboards (v3), User Delight, Wikimedia
joshuaspence added a parent task for T6559: Change notification system implementation not to require Flash: T4900: Workboards updating in real time.
Jan 2 2015, 2:59 AM · Aphlict, Wikimedia
joshuaspence added a subtask for T4900: Workboards updating in real time: T6559: Change notification system implementation not to require Flash.
Jan 2 2015, 2:59 AM · Workboards (v3), User Delight, Wikimedia
joshuaspence claimed T6559: Change notification system implementation not to require Flash.

I've been pondering a WebSockets implementation and am going to start mucking around with a prototype. I don't think this task is too difficult. In fact, WebSockets probably gives us a few things for free that we had otherwose hacked into the Flash implementation of Aphlict.

Jan 2 2015, 2:54 AM · Aphlict, Wikimedia
joshuaspence claimed T6842: Can't stop daemons if MySQL is down.
Jan 2 2015, 2:52 AM · Daemons
joshuaspence added a revision to T6847: `phutil_symbols.php` does not correctly handle static method calls: Unknown Object (Differential Revision).
Jan 2 2015, 1:03 AM · libphutil
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jan 2 2015, 1:01 AM · libphutil, Arcanist
joshuaspence claimed T6847: `phutil_symbols.php` does not correctly handle static method calls.
Jan 2 2015, 1:01 AM · libphutil
joshuaspence created T6847: `phutil_symbols.php` does not correctly handle static method calls.
Jan 2 2015, 12:52 AM · libphutil

Jan 1 2015

joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jan 1 2015, 11:28 PM · libphutil, Arcanist
joshuaspence added a revision to T5655: Standardize naming conventions: Unknown Object (Differential Revision).
Jan 1 2015, 11:24 PM · libphutil, Arcanist
joshuaspence triaged T6842: Can't stop daemons if MySQL is down as Normal priority.
Jan 1 2015, 9:15 AM · Daemons
joshuaspence triaged T6843: Write a linter rule to detect duplicate case statements as Low priority.
Jan 1 2015, 9:15 AM · Lint
joshuaspence created T6843: Write a linter rule to detect duplicate case statements.
Jan 1 2015, 4:50 AM · Lint
joshuaspence updated the task description for T6842: Can't stop daemons if MySQL is down.
Jan 1 2015, 3:55 AM · Daemons
joshuaspence created T6842: Can't stop daemons if MySQL is down.
Jan 1 2015, 3:54 AM · Daemons
joshuaspence created T6841: Maybe create an annotation for "this is strictly a template class".
Jan 1 2015, 3:49 AM · Lint

Dec 30 2014

joshuaspence triaged T6830: Improve lint handling of declare() special statement blocks as Low priority.
Dec 30 2014, 2:19 PM · Lint
joshuaspence added a project to T6828: Repository import daemon repeatedly crashes and restarts if phabricator.base-uri is not configured: Daemons.
Dec 30 2014, 2:18 PM · Daemons, Diffusion
joshuaspence closed T6829: The `Futures()` function violates naming conventions as Resolved.

Closed by commit rPHU9319f6d50d52.

Dec 30 2014, 12:39 PM · Lint, libphutil
joshuaspence added a revision to T6829: The `Futures()` function violates naming conventions: Unknown Object (Differential Revision).
Dec 30 2014, 12:21 PM · Lint, libphutil
joshuaspence added a revision to T6829: The `Futures()` function violates naming conventions: Unknown Object (Differential Revision).
Dec 30 2014, 12:10 PM · Lint, libphutil
joshuaspence added a revision to T6829: The `Futures()` function violates naming conventions: Unknown Object (Differential Revision).
Dec 30 2014, 12:07 PM · Lint, libphutil