Page MenuHomePhabricator
Feed Advanced Search

May 22 2019

epriestley added a revision to T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits": Restricted Differential Revision.
May 22 2019, 9:31 PM · Diffusion, Differential
epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: Restricted Differential Revision.
May 22 2019, 9:15 PM · Remarkup, Diffusion
epriestley added a revision to T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits": Restricted Differential Revision.
May 22 2019, 9:15 PM · Diffusion, Differential
epriestley added a comment to T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits".

(This is mostly for my own notes and contains roughly zero insight.)

May 22 2019, 6:07 PM · Diffusion, Differential
epriestley added a comment to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion.

See also T13290. Now that full URIs count as mentions (D20527), the text "Differential Revision: ..." in commits is counting as a mention, and "mentioning" the associated revision.

May 22 2019, 11:51 AM · Remarkup, Diffusion

May 21 2019

epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: Restricted Differential Revision.
May 21 2019, 7:01 PM · Remarkup, Diffusion
epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: Restricted Differential Revision.
May 21 2019, 4:46 PM · Remarkup, Diffusion

May 20 2019

epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: Restricted Differential Revision.
May 20 2019, 6:45 PM · Remarkup, Diffusion
epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: Restricted Differential Revision.
May 20 2019, 6:39 PM · Remarkup, Diffusion
epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: Restricted Differential Revision.
May 20 2019, 6:23 PM · Remarkup, Diffusion
epriestley added a revision to T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion: Restricted Differential Revision.
May 20 2019, 4:59 PM · Remarkup, Diffusion
epriestley updated the task description for T13284: When a previously non-permanent ref is marked permanent, unpublished commits reachable from that ref are not published.
May 20 2019, 11:47 AM · Diffusion

May 19 2019

epriestley updated the task description for T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion.
May 19 2019, 8:48 PM · Remarkup, Diffusion

May 17 2019

epriestley updated the task description for T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion.
May 17 2019, 3:13 PM · Remarkup, Diffusion
epriestley triaged T13291: Implement a "{src ...}" rule in Remarkup for referencing source files in Diffusion as Normal priority.
May 17 2019, 2:22 PM · Remarkup, Diffusion
epriestley closed T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time as Resolved.

This stuff is largely resolved, but survived by a few remaining issues in T13290.

May 17 2019, 2:18 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added subtasks for T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits": T4453: When multiple commits correspond to a single revision, Differential updates to show one of them arbitrarily, T7333: Empty commits get same revision as parent.
May 17 2019, 2:17 PM · Diffusion, Differential
epriestley triaged T13290: Clean up remaining "Autoclose" behaviors related to "One Revision, Many Commits" as Normal priority.
May 17 2019, 2:15 PM · Diffusion, Differential

May 10 2019

epriestley added a subtask for T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover: T13287: Build general healthcheck infrastructure for monitoring services.
May 10 2019, 5:45 PM · Clusters, Diffusion
epriestley triaged T13286: When nodes in a cluster repository fail, reads are still routed with the same weight and failed reads do not recover as Normal priority.
May 10 2019, 5:24 PM · Clusters, Diffusion

May 9 2019

epriestley removed a subtask for T7443: Include full link to Maniphest tasks in commit messages: T5378: Phabricator full task URLs for that instance do not provide hover/popup text (like T1234 does).
May 9 2019, 6:23 PM · Diffusion, Arcanist
epriestley added a comment to T13125: Plans: Code coverage reporting.

PHI1231 would like API access to coverage.

May 9 2019, 5:51 PM · Diffusion, Plans
epriestley moved T11372: Multiple coverage columns for different types of code coverage from Backlog to Coverage on the Diffusion board.
May 9 2019, 5:05 PM · Diffusion, Restricted Project
epriestley edited projects for T11372: Multiple coverage columns for different types of code coverage, added: Diffusion; removed Feature Request.
May 9 2019, 5:05 PM · Diffusion, Restricted Project
epriestley closed T6737: Task doesn't get "mentioned in revision N" log record if revision comment contains "fix" or "fixed" and auto-close is off for the repository as Resolved.

My expectation is that this is effectively resolved by T13277. Since "Autoclose" is no longer a separate permission from "Publish", commits should now always mention + close or never mention + close.

May 9 2019, 5:05 PM · Transactions, Diffusion
epriestley moved T13284: When a previously non-permanent ref is marked permanent, unpublished commits reachable from that ref are not published from Backlog to "Track Only" on the Diffusion board.
May 9 2019, 5:03 PM · Diffusion
epriestley moved T9524: Show aggregate subdirectory coverage in Diffusion browse views from Backlog to Coverage on the Diffusion board.
May 9 2019, 5:00 PM · Diffusion, Restricted Project
epriestley moved T13125: Plans: Code coverage reporting from Backlog to Coverage on the Diffusion board.
May 9 2019, 5:00 PM · Diffusion, Plans

May 4 2019

epriestley added a comment to T13284: When a previously non-permanent ref is marked permanent, unpublished commits reachable from that ref are not published.

Probably, push another commit to Y

May 4 2019, 5:28 PM · Diffusion

May 3 2019

epriestley updated the task description for T13284: When a previously non-permanent ref is marked permanent, unpublished commits reachable from that ref are not published.
May 3 2019, 5:37 PM · Diffusion
epriestley triaged T13284: When a previously non-permanent ref is marked permanent, unpublished commits reachable from that ref are not published as Low priority.
May 3 2019, 5:35 PM · Diffusion
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": Restricted Differential Revision.
May 3 2019, 5:11 PM · Plans, Diffusion
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: Restricted Differential Revision.
May 3 2019, 3:00 PM · Diffusion, Harbormaster, Herald, Audit
epriestley moved T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time from Backlog to Next on the Herald board.
May 3 2019, 5:11 AM · Diffusion, Harbormaster, Herald, Audit
epriestley moved T13166: Herald "block" and "send an email" actions are mutually exclusive, which isn't intuitive from Backlog to Far Future on the Herald board.
May 3 2019, 4:40 AM · Diffusion, Herald

May 1 2019

epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: Restricted Differential Revision.
May 1 2019, 3:47 PM · Diffusion, Harbormaster, Herald, Audit
epriestley updated the task description for T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time.
May 1 2019, 3:45 PM · Diffusion, Harbormaster, Herald, Audit

Apr 23 2019

epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: Restricted Differential Revision.
Apr 23 2019, 6:35 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: Restricted Differential Revision.
Apr 23 2019, 6:05 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": Restricted Differential Revision.
Apr 23 2019, 5:28 PM · Plans, Diffusion
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": Restricted Differential Revision.
Apr 23 2019, 4:55 PM · Plans, Diffusion
epriestley updated the task description for T13280: Permanent Refs Errata.
Apr 23 2019, 4:28 PM · Diffusion
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": Restricted Differential Revision.
Apr 23 2019, 2:14 PM · Plans, Diffusion
epriestley added a comment to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time.

PHI1159 would like build failures exposed to Herald to trigger audits. See also PHI953. See also PHI901.

Apr 23 2019, 1:39 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a comment to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time.

In PHI1008, when commit X reverts commit Y, we don't write a revert edge between X and revisions associated with Y. We should.

Apr 23 2019, 1:32 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": Restricted Differential Revision.
Apr 23 2019, 12:12 AM · Plans, Diffusion

Apr 22 2019

epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": Restricted Differential Revision.
Apr 22 2019, 11:10 PM · Plans, Diffusion
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: Restricted Differential Revision.
Apr 22 2019, 10:51 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: Restricted Differential Revision.
Apr 22 2019, 10:26 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: Restricted Differential Revision.
Apr 22 2019, 7:51 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: Restricted Differential Revision.
Apr 22 2019, 7:34 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: Restricted Differential Revision.
Apr 22 2019, 7:06 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a revision to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: Restricted Differential Revision.
Apr 22 2019, 6:47 PM · Diffusion, Harbormaster, Herald, Audit
epriestley moved T10945: Replace "repository.query" with "diffusion.repository.search" in Arcanist from Backlog to Staging Areas on the Diffusion board.
Apr 22 2019, 6:10 PM · Restricted Project, Conduit, Arcanist, Diffusion
epriestley moved T11502: Expose raw Git refs in the Diffusion UI, but very subtly from Backlog to "Track Only" on the Diffusion board.
Apr 22 2019, 6:10 PM · Restricted Project, Diffusion
epriestley moved T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance from Backlog to "Track Only" on the Diffusion board.
Apr 22 2019, 6:07 PM · Plans, Diffusion
epriestley renamed T8370: Index "TODO" comments and other references present in source code from Allow mentions in commit contents to Index "TODO" comments and other references present in source code.
Apr 22 2019, 6:06 PM · Transactions, Diffusion
epriestley moved T13280: Permanent Refs Errata from Backlog to "Track Only" on the Diffusion board.
Apr 22 2019, 6:04 PM · Diffusion

Apr 20 2019

joshuaspence added a comment to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".

I believe there is very little reason for the "Autoclose" and "Publish" behaviors to actually be separate. That is, there are very few use cases where users want a commit to trigger only Herald or only feed or only audits. These use cases do exist (see T9210 for an example of "Herald, No Feed") but they're overwhelmingly niche and off-label.

Apr 20 2019, 2:19 AM · Plans, Diffusion

Apr 18 2019

epriestley added a revision to T13280: Permanent Refs Errata: Restricted Differential Revision.
Apr 18 2019, 1:58 PM · Diffusion
epriestley added a comment to T13280: Permanent Refs Errata.

The git fetch change in D20421 does actually affect non-bare repositories:

Apr 18 2019, 1:53 PM · Diffusion
epriestley closed T5963: Hosted repos could set default branch in HEAD to help new clones as Resolved by committing Restricted Diffusion Commit.
Apr 18 2019, 12:46 PM · Diffusion
epriestley changed the status of T12967: Mercurical branches don't display tracking status properly from Wontfix to Resolved by committing Restricted Diffusion Commit.
Apr 18 2019, 12:40 PM · Diffusion, Bug Report
epriestley updated the task description for T13280: Permanent Refs Errata.
Apr 18 2019, 12:10 PM · Diffusion
epriestley triaged T13280: Permanent Refs Errata as Normal priority.
Apr 18 2019, 12:09 PM · Diffusion

Apr 16 2019

epriestley updated the task description for T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time.
Apr 16 2019, 5:58 PM · Diffusion, Harbormaster, Herald, Audit
epriestley added a comment to T13278: Improve repository Staging Areas.

APIs: Currently, diffusion.repository.search does not expose staging information.

Apr 16 2019, 4:53 PM · Plans, Diffusion
epriestley added a comment to T13278: Improve repository Staging Areas.

With changes in T13277, I think we're ready to start making ref staging the default behavior in hosted repositories even without T8093 (which will give us some tools to improve things later, but seems like it's generally in good shape).

Apr 16 2019, 4:38 PM · Plans, Diffusion
epriestley renamed T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs" from In repositories, realign "Track Only", "Autoclose" and "Publish/Notify" toward "Permanent Refs" to In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".
Apr 16 2019, 3:06 PM · Plans, Diffusion
epriestley renamed T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs" from Update Diffusion "Track Only" for all ref types to In repositories, realign "Track Only", "Autoclose" and "Publish/Notify" toward "Permanent Refs".
Apr 16 2019, 3:03 PM · Plans, Diffusion
epriestley added a revision to T5963: Hosted repos could set default branch in HEAD to help new clones: Restricted Differential Revision.
Apr 16 2019, 1:31 PM · Diffusion
epriestley added a comment to T5963: Hosted repos could set default branch in HEAD to help new clones.

Empirically, on modern git:

Apr 16 2019, 1:27 PM · Diffusion
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": Restricted Differential Revision.
Apr 16 2019, 12:44 PM · Plans, Diffusion

Apr 15 2019

epriestley added a revision to T12300: git push --mirror --force does not work on Phacility with repo that has refs/pull: Restricted Differential Revision.
Apr 15 2019, 7:55 PM · Diffusion, Git
epriestley closed T12300: git push --mirror --force does not work on Phacility with repo that has refs/pull as Resolved.

This is a duplicate of T8936 and resolved by D20420.

Apr 15 2019, 7:55 PM · Diffusion, Git
epriestley closed T12300: git push --mirror --force does not work on Phacility with repo that has refs/pull, a subtask of T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs", as Resolved.
Apr 15 2019, 7:55 PM · Plans, Diffusion
epriestley added a parent task for T12300: git push --mirror --force does not work on Phacility with repo that has refs/pull: T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".
Apr 15 2019, 7:55 PM · Diffusion, Git
epriestley added a subtask for T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": T12300: git push --mirror --force does not work on Phacility with repo that has refs/pull.
Apr 15 2019, 7:55 PM · Plans, Diffusion
epriestley edited projects for T12300: git push --mirror --force does not work on Phacility with repo that has refs/pull, added: Diffusion; removed Customer Impact, Bug Report.
Apr 15 2019, 7:52 PM · Diffusion, Git
epriestley closed T12967: Mercurical branches don't display tracking status properly as Wontfix.

D20433 deprecates "Track Only", mooting this.

Apr 15 2019, 7:29 PM · Diffusion, Bug Report
epriestley added a revision to T12967: Mercurical branches don't display tracking status properly: Restricted Differential Revision.
Apr 15 2019, 7:28 PM · Diffusion, Bug Report
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": Restricted Differential Revision.
Apr 15 2019, 7:28 PM · Plans, Diffusion
epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": Restricted Differential Revision.
Apr 15 2019, 7:20 PM · Plans, Diffusion
epriestley updated the task description for T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".
Apr 15 2019, 5:37 PM · Plans, Diffusion
epriestley closed T8936: Unable to identify the reftype of 'refs/remotes/origin/master'. Rejecting push. as Resolved.

After D20420, we accept these refs.

Apr 15 2019, 5:14 PM · Diffusion
epriestley closed T8936: Unable to identify the reftype of 'refs/remotes/origin/master'. Rejecting push., a subtask of T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs", as Resolved.
Apr 15 2019, 5:14 PM · Plans, Diffusion
epriestley closed T9383: Support `git notes`, a subtask of T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs", as Resolved.
Apr 15 2019, 5:14 PM · Plans, Diffusion
epriestley closed T9383: Support `git notes` as Resolved.

D20420 accepts these refs. We don't show notes in the UI, but we have no outstanding customer requests for this.

Apr 15 2019, 5:14 PM · KDE, Git, Diffusion
epriestley closed T10964: When a branch in Diffusion is not tracked, the UI should be explicit about it, a subtask of T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance, as Wontfix.
Apr 15 2019, 5:12 PM · Plans, Diffusion
epriestley closed T10964: When a branch in Diffusion is not tracked, the UI should be explicit about it as Wontfix.

See T13277. I'm moving us away from "Track Only", and our behavior is already reasonable under "Fetch Rules" + "Permanent Refs".

Apr 15 2019, 5:12 PM · Diffusion
epriestley closed T10964: When a branch in Diffusion is not tracked, the UI should be explicit about it, a subtask of T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs", as Wontfix.
Apr 15 2019, 5:12 PM · Plans, Diffusion
epriestley added a subtask for T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": T10964: When a branch in Diffusion is not tracked, the UI should be explicit about it.
Apr 15 2019, 5:11 PM · Plans, Diffusion
epriestley added a parent task for T10964: When a branch in Diffusion is not tracked, the UI should be explicit about it: T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".
Apr 15 2019, 5:11 PM · Diffusion
epriestley closed T13034: Diffusion "Branches: None" should be more clear that it means "Branches: No Tracked Branches", a subtask of T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs", as Wontfix.
Apr 15 2019, 5:10 PM · Plans, Diffusion
epriestley closed T13034: Diffusion "Branches: None" should be more clear that it means "Branches: No Tracked Branches" as Wontfix.

See T13277. I'd like to move away from "Track Only".

Apr 15 2019, 5:10 PM · Diffusion
epriestley added a subtask for T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": T13034: Diffusion "Branches: None" should be more clear that it means "Branches: No Tracked Branches".
Apr 15 2019, 5:10 PM · Plans, Diffusion
epriestley added a parent task for T13034: Diffusion "Branches: None" should be more clear that it means "Branches: No Tracked Branches": T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".
Apr 15 2019, 5:10 PM · Diffusion
epriestley removed a project from T13041: In Herald Commit rules, "Reviewer" and "On Autoclose Branch" have been deprecated: Differential.
Apr 15 2019, 5:08 PM · Diffusion, Herald
epriestley renamed T13041: In Herald Commit rules, "Reviewer" and "On Autoclose Branch" have been deprecated from In Herald Commit rules, "Commit Fields > Reviewer" has ancient, misleading behavior to In Herald Commit rules, "Reviewer" and "On Autoclose Branch" have been deprecated.
Apr 15 2019, 5:08 PM · Diffusion, Herald
epriestley added a comment to T13041: In Herald Commit rules, "Reviewer" and "On Autoclose Branch" have been deprecated.

D20427 is a similar change, that deprecates the "Commit is on autoclose branch" field. This fields is now always true by definition, because Herald does not run until a commit is reachable from a permanent ref (previously called an "autoclose branch").

Apr 15 2019, 5:05 PM · Diffusion, Herald