Changes connected to T13277 likely moot this. If users are pushing temporary personal branches to a repository, configure "Permanent Refs" to exclude them. Commits pushed to these branches will no longer publish feed stories, trigger audits, etc.

Apr 15 2019, 3:55 PM · Diffusion, Feed, Feature Request

epriestley closed T9210: break apart Publish/Notify repo setting as Wontfix.

I'm going to WONTFIX this since T13277 has generally taken us in the other direction. "Publish" now controls everything (audit, feed, email/notifications, Herald, closing tasks and revisions).

Apr 15 2019, 3:54 PM · Restricted Project, Restricted Project, Diffusion

epriestley closed T9210: break apart Publish/Notify repo setting, a subtask of T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs", as Wontfix.

Apr 15 2019, 3:54 PM · Plans, Diffusion

epriestley added a subtask for T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": T9210: break apart Publish/Notify repo setting.

Apr 15 2019, 3:40 PM · Plans, Diffusion

epriestley added a parent task for T9210: break apart Publish/Notify repo setting: T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".

Apr 15 2019, 3:40 PM · Restricted Project, Restricted Project, Diffusion

epriestley moved T9210: break apart Publish/Notify repo setting from Backlog to "Track Only" on the Diffusion board.

Apr 15 2019, 3:40 PM · Restricted Project, Restricted Project, Diffusion

epriestley moved T9383: Support `git notes` from Backlog to "Track Only" on the Diffusion board.

Apr 15 2019, 3:40 PM · KDE, Git, Diffusion

epriestley moved T10093: When builds fail because the staging area was not pushed, make the cause clear from Backlog to Staging Areas on the Diffusion board.

Apr 15 2019, 3:39 PM · Haskell.org, Restricted Project, Harbormaster (v3), Diffusion, Feature Request

epriestley moved T13278: Improve repository Staging Areas from Backlog to Staging Areas on the Diffusion board.

Apr 15 2019, 3:39 PM · Plans, Diffusion

epriestley moved T6737: Task doesn't get "mentioned in revision N" log record if revision comment contains "fix" or "fixed" and auto-close is off for the repository from Backlog to "Track Only" on the Diffusion board.

Apr 15 2019, 3:39 PM · Transactions, Diffusion

epriestley moved T6537: The "Skip Past This Commit" results in exception (diffusion svn blame view) from Backlog to Subversion on the Diffusion board.

Apr 15 2019, 3:38 PM · Subversion, Diffusion

epriestley moved T5963: Hosted repos could set default branch in HEAD to help new clones from Backlog to "Track Only" on the Diffusion board.

Apr 15 2019, 3:38 PM · Diffusion

epriestley closed T1203: Tags & branch merge labels in commit history view as Wontfix.

No outstanding customer requests for this.

Apr 15 2019, 3:37 PM · Diffusion

epriestley moved T13034: Diffusion "Branches: None" should be more clear that it means "Branches: No Tracked Branches" from Backlog to "Track Only" on the Diffusion board.

Apr 15 2019, 3:34 PM · Diffusion

epriestley moved T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time from Backlog to "Track Only" on the Diffusion board.

Apr 15 2019, 3:34 PM · Diffusion, Harbormaster, Herald, Audit

epriestley added a project to T13276: Fix several audit-adjacent issues, including races when multiple closing commits are discovered at the same time: Diffusion.

Apr 15 2019, 3:34 PM · Diffusion, Harbormaster, Herald, Audit

epriestley moved T13041: In Herald Commit rules, "Reviewer" and "On Autoclose Branch" have been deprecated from Backlog to "Track Only" on the Diffusion board.

Apr 15 2019, 3:34 PM · Diffusion, Herald

epriestley moved T13109: Improve cluster write feedback and write routing from Backlog to Clusters on the Diffusion board.

Apr 15 2019, 3:33 PM · Diffusion

epriestley moved T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs" from Backlog to "Track Only" on the Diffusion board.

Apr 15 2019, 3:30 PM · Plans, Diffusion

epriestley closed T12749: Performance test and tune DiffusionHistoryListView, a subtask of T12824: Redesign Diffusion, as Wontfix.

Apr 15 2019, 3:30 PM · Design, Diffusion

epriestley closed T12749: Performance test and tune DiffusionHistoryListView as Wontfix.

There's no specific performance/scale issue here, so waiting until one arises or this pops up on a profile.

Apr 15 2019, 3:30 PM · Performance, Diffusion

epriestley moved T13211: Improve intracluster synchronization routing from Backlog to Clusters on the Diffusion board.

Apr 15 2019, 2:45 PM · Clusters, Diffusion

epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": Restricted Differential Revision.

Apr 15 2019, 1:57 PM · Plans, Diffusion

epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": Restricted Differential Revision.

Apr 15 2019, 1:29 PM · Plans, Diffusion

Apr 14 2019

epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": Restricted Differential Revision.

Apr 14 2019, 8:50 PM · Plans, Diffusion

epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": Restricted Differential Revision.

Apr 14 2019, 8:27 PM · Plans, Diffusion

epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": Restricted Differential Revision.

Apr 14 2019, 8:14 PM · Plans, Diffusion

epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": Restricted Differential Revision.

Apr 14 2019, 7:24 PM · Plans, Diffusion

epriestley updated the task description for T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".

Apr 14 2019, 6:58 PM · Plans, Diffusion

epriestley added a revision to T8936: Unable to identify the reftype of 'refs/remotes/origin/master'. Rejecting push.: Restricted Differential Revision.

Apr 14 2019, 6:57 PM · Diffusion

epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": Restricted Differential Revision.

Apr 14 2019, 6:57 PM · Plans, Diffusion

epriestley added a revision to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs": Restricted Differential Revision.

Apr 14 2019, 6:39 PM · Plans, Diffusion

epriestley updated the task description for T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".

Apr 14 2019, 6:29 PM · Plans, Diffusion

epriestley updated the task description for T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".

Apr 14 2019, 6:29 PM · Plans, Diffusion

epriestley added a comment to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".

Okay. I'm not crazy, I'm just really bad at reading.

Apr 14 2019, 6:08 PM · Plans, Diffusion

epriestley added a comment to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".

Examining "master" (branch) at "02f94cd7d2885de502d03934af3a0c24453e8e58" (autoclose: Y).
Skipping, HEAD is known.
Examining "stable" (branch) at "d3df0a49f92a8be2f5b8a030af2f8fa5471cc45d" (autoclose: Y).
Skipping, HEAD is known.
Examining "refs/pull/846/merge" (ref) at "d816dc011f935fdda9468c905e4af4c7fc73b322" (autoclose: N).
Skipping, HEAD is known.
Examining "refs/pull/839/head" (ref) at "d3df0a49f92a8be2f5b8a030af2f8fa5471cc45d" (autoclose: N).
Skipping, HEAD is known.
Examining "refs/pull/846/head" (ref) at "1263f335abfc5bcf7b5e2c60ae0632b4660815d8" (autoclose: N).
Skipping, HEAD is known.
< ... >
< ... many many non-branch refs properly identified as non-autoclosing ... >
< ... >
Examining "refs/pull/4/head" (ref) at "e282a7707da11e3e2bca2b3a41925aeefd4f22c9" (autoclose: N).
Skipping, HEAD is known.

Apr 14 2019, 6:01 PM · Plans, Diffusion

epriestley added a comment to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".

Only branches can be "Autoclose".

Apr 14 2019, 5:58 PM · Plans, Diffusion

epriestley added a comment to T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".

Apr 14 2019, 5:56 PM · Plans, Diffusion

Apr 8 2019

davidgiga1993 added a comment to T7000: 404 when accessing repo via http.

This issue is still relevant and reproducible in the current release.
Here are the steps to reproduce it:

Apr 8 2019, 1:25 PM · Diffusion

Apr 6 2019

epriestley updated the task description for T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".

Apr 6 2019, 5:15 PM · Plans, Diffusion

epriestley triaged T13278: Improve repository Staging Areas as Normal priority.

Apr 6 2019, 5:14 PM · Plans, Diffusion

epriestley updated the task description for T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs".

Apr 6 2019, 5:10 PM · Plans, Diffusion

epriestley triaged T13277: In repositories, realign "Track Only", "Autoclose", and "Publish/Notify" toward "Permanent Refs" as Normal priority.

Apr 6 2019, 4:52 PM · Plans, Diffusion

Mar 26 2019

epriestley closed T12980: Diffusion search throws exception on older git as Wontfix.

Presumably obsolete since this hasn't cropped up again.

Mar 26 2019, 10:19 PM · Diffusion

Mar 25 2019

epriestley closed T13270: Diffusion [Code] button always goes to root of repo as Resolved by committing Restricted Diffusion Commit.

Mar 25 2019, 9:45 PM · Diffusion

epriestley added a revision to T13270: Diffusion [Code] button always goes to root of repo: Restricted Differential Revision.

Mar 25 2019, 9:34 PM · Diffusion

epriestley claimed T13270: Diffusion [Code] button always goes to root of repo.

Mar 25 2019, 9:32 PM · Diffusion

avivey created T13270: Diffusion [Code] button always goes to root of repo.

Mar 25 2019, 8:49 PM · Diffusion

Mar 19 2019

epriestley closed T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery" as Resolved.

I believe this is now resolved. See D20291 for technical details on the main issue and T13266 for a followup.

Mar 19 2019, 8:45 PM · Diffusion

Mar 18 2019

epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

I also checked for more leftovers in instances/, but it looks like we don't have any non-default paging there.

Mar 18 2019, 10:23 PM · Diffusion

epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

I've poked around a fair bit locally, although I'm not totally confident I got every combination of paging columns and queries. I think anything that was missed is very likely to produce an explicit error rather than mysterious behavior, so I'm not too worried about it. Stuff to keep an eye on:

Mar 18 2019, 10:12 PM · Diffusion

epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": Restricted Differential Revision.

Mar 18 2019, 9:52 PM · Diffusion

epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": Restricted Differential Revision.

Mar 18 2019, 9:40 PM · Diffusion

epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": Restricted Differential Revision.

Mar 18 2019, 9:04 PM · Diffusion

epriestley claimed T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

Mar 18 2019, 9:02 PM · Diffusion

epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": Restricted Differential Revision.

Mar 18 2019, 7:01 PM · Diffusion

epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": Restricted Differential Revision.

Mar 18 2019, 6:19 PM · Diffusion

Mar 7 2019

epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

An adjacent issue is that the current behavior of overheated queries is to return a partial result set and set a flag. The goal of this behavior is to let us show some results if we find some results, but it may be surprising if the caller doesn't handle overheated queries, since they may look like a queries which simply failed to match anything.

Mar 7 2019, 6:43 PM · Diffusion

epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

The hypothetical steps above do, in fact, reproduce this:

Mar 7 2019, 6:17 PM · Diffusion

Mar 1 2019

epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": Restricted Differential Revision.

Mar 1 2019, 3:16 PM · Diffusion

epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

somewhat tricky to explain, and somewhat tricky to resolve

Mar 1 2019, 4:19 AM · Diffusion

epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": Restricted Differential Revision.

Mar 1 2019, 3:47 AM · Diffusion

epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": Restricted Differential Revision.

Mar 1 2019, 3:28 AM · Diffusion

epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

From onsite:

Mar 1 2019, 2:53 AM · Diffusion

Feb 28 2019

reed added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

and now when I re-run the command again, it gets another 7 commits and fails again. So, perhaps by me viewing the commit, I kick off a job that rebuilds something on the backend?

Feb 28 2019, 10:16 PM · Diffusion

reed added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

It's now failing on this one (consistently if I keep running it):

Feb 28 2019, 10:10 PM · Diffusion

epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

Thanks. That looks like a perfectly normal object to me so I'm not sure what could cause it to fail to load.

Feb 28 2019, 9:31 PM · Diffusion

reed added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

mysql> SELECT * FROM phabricator_repository.repository_commit WHERE id = 71471;
+-------+--------------+--------------------------------+------------------------------------------+------------+------------+-------------+---------+--------------+--------------------+-----------------------+
| id    | repositoryID | phid                           | commitIdentifier                         | epoch      | authorPHID | auditStatus | summary | importStatus | authorIdentityPHID | committerIdentityPHID |
+-------+--------------+--------------------------------+------------------------------------------+------------+------------+-------------+---------+--------------+--------------------+-----------------------+
| 71471 |           41 | PHID-CMIT-ohupojjoniypwpghvlr2 | 43034ccb9eac4ca8a655f655b726f73c5e551413 | 1438182566 | NULL       | none        |         |         1024 | NULL               | NULL                  |
+-------+--------------+--------------------------------+------------------------------------------+------------+------------+-------------+---------+--------------+--------------------+-----------------------+
1 row in set (0.01 sec)

Feb 28 2019, 9:28 PM · Diffusion

epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

Here's what's happening in general:

Feb 28 2019, 1:55 PM · Diffusion

reed updated the task description for T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

Feb 28 2019, 8:36 AM · Diffusion

reed updated the task description for T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

Feb 28 2019, 8:36 AM · Diffusion