Page MenuHomePhabricator
Feed Advanced Search

Mar 11 2019

epriestley added a comment to T10578: Provide 'Sort by Points' option in workboards.

We could lock this order into "drag to column" interactions only once those are built (i.e., not support "drag to position" -- basically, when you drop a card, we fling it into the correct position, even if that position is at the bottom of the column far off the screen). This will be somewhat confusing but maybe the least-bad of the options.

Mar 11 2019, 2:27 PM · Workboards (v3), Feature Request
epriestley closed T6502: Policy to define who can move cards in a workboard, a subtask of T5474: Support workboard column triggers which activate when a task is dropped into a column, as Wontfix.
Mar 11 2019, 2:19 PM · Workboards (v3), Restricted Project
epriestley closed T6502: Policy to define who can move cards in a workboard as Wontfix.

To summarize the state of the world here:

Mar 11 2019, 2:18 PM · Projects, Wikimedia, Policy, Workboards
epriestley closed T6502: Policy to define who can move cards in a workboard, a subtask of T7410: Allow a project's workboard to be disabled so that tagged tasks no longer show meaningless "(Backlog)", as Wontfix.
Mar 11 2019, 2:18 PM · Projects, Wikimedia, Workboards
epriestley moved T10578: Provide 'Sort by Points' option in workboards from Backlog to v3 on the Workboards board.
Mar 11 2019, 1:31 PM · Workboards (v3), Feature Request
epriestley moved T12175: Simultaneous task moving on workboards results in error from Backlog to v3 on the Workboards board.
Mar 11 2019, 1:31 PM · Workboards (v3), Bug Report
epriestley updated the task description for T13074: Plans: Workboard triggers, groups, and subproject columns.
Mar 11 2019, 1:30 PM · Workboards (v3), Plans, Projects
epriestley added a revision to T10722: Communicate drag policies clearly in the workboard/list UIs: Unknown Object (Differential Revision).
Mar 11 2019, 6:01 AM · Workboards (v3), Bug Report
epriestley added a revision to T13074: Plans: Workboard triggers, groups, and subproject columns: Unknown Object (Differential Revision).
Mar 11 2019, 5:34 AM · Workboards (v3), Plans, Projects
epriestley added a revision to T10333: Add groups to workboard columns: Unknown Object (Differential Revision).
Mar 11 2019, 5:26 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley claimed T10333: Add groups to workboard columns.
Mar 11 2019, 5:24 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley added a revision to T10333: Add groups to workboard columns: Unknown Object (Differential Revision).
Mar 11 2019, 5:12 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley added a revision to T10333: Add groups to workboard columns: Unknown Object (Differential Revision).
Mar 11 2019, 5:01 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley added a revision to T10333: Add groups to workboard columns: Unknown Object (Differential Revision).
Mar 11 2019, 4:56 AM · Restricted Project, Restricted Project, Workboards (v3)
epriestley added a revision to T10333: Add groups to workboard columns: Unknown Object (Differential Revision).
Mar 11 2019, 12:32 AM · Restricted Project, Restricted Project, Workboards (v3)

Mar 10 2019

epriestley added a revision to T10333: Add groups to workboard columns: Unknown Object (Differential Revision).
Mar 10 2019, 4:22 PM · Restricted Project, Restricted Project, Workboards (v3)

Mar 9 2019

epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 8:34 PM · Plans
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 7:16 PM · Plans
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 7:15 PM · Plans
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 7:12 PM · Plans
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 6:58 PM · Plans
epriestley updated the task description for T13263: Plans: 2019 Week 11-15 Bonus Content.
Mar 9 2019, 6:50 PM · Plans
epriestley added a project to T13263: Plans: 2019 Week 11-15 Bonus Content: Plans.
Mar 9 2019, 6:43 PM · Plans
epriestley triaged T13263: Plans: 2019 Week 11-15 Bonus Content as Normal priority.
Mar 9 2019, 6:43 PM · Plans
epriestley renamed T13249: 2019 Week 7 - 10 Bonus Content from 2019 Week 7 - 9 Bonus Content to 2019 Week 7 - 10 Bonus Content.
Mar 9 2019, 6:42 PM · Plans
epriestley added a comment to T10333: Add groups to workboard columns.

This now exists for priorities. I'd like to get at least one more grouping (likely: assignee) built before calling this resolved since "Priority" has some magic interaction with "subpriority". I'm moving toward getting rid of "subpriority" in D20263, but I'm not yet completely sure that it'll stick.

Mar 9 2019, 6:38 PM · Restricted Project, Restricted Project, Workboards (v3)
epriestley closed T8135: drag & drop on a workboard sorted by priority behavior is surprising as Resolved.

Drag-and-drop between columns on a priority-sorted board no longer changes priority. See T13074 for continuing adjacent work.

Mar 9 2019, 6:37 PM · Restricted Project, Workboards (v3), Restricted Project
epriestley closed T10334: On workboards, distinguish between "drag to column" and "drag to specific place in column", a subtask of T8135: drag & drop on a workboard sorted by priority behavior is surprising, as Resolved.
Mar 9 2019, 6:36 PM · Restricted Project, Workboards (v3), Restricted Project
epriestley closed T10334: On workboards, distinguish between "drag to column" and "drag to specific place in column" as Resolved.

Some adjacent work in T13074 may build on this, and we might do "drag + shift" at some point, but this is substantially resolved.

Mar 9 2019, 6:35 PM · Workboards (v3)

Mar 8 2019

epriestley edited the content of Changelog.
Mar 8 2019, 3:10 PM
epriestley created 2019 Week 9 (Very Late February).
Mar 8 2019, 3:09 PM
epriestley created 2019 Week 10 (Early March).
Mar 8 2019, 3:08 PM

Mar 7 2019

epriestley closed T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc), a subtask of T13088: Plans: Harbormaster UI usability and interconnectedness, as Resolved.
Mar 7 2019, 10:53 PM · Plans, Harbormaster
epriestley closed T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc) as Resolved.
Mar 7 2019, 10:53 PM · Plans, Harbormaster
epriestley added a revision to T13074: Plans: Workboard triggers, groups, and subproject columns: Unknown Object (Differential Revision).
Mar 7 2019, 7:41 PM · Workboards (v3), Plans, Projects
epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

An adjacent issue is that the current behavior of overheated queries is to return a partial result set and set a flag. The goal of this behavior is to let us show some results if we find some results, but it may be surprising if the caller doesn't handle overheated queries, since they may look like a queries which simply failed to match anything.

Mar 7 2019, 6:43 PM · Diffusion
epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

The hypothetical steps above do, in fact, reproduce this:

Mar 7 2019, 6:17 PM · Diffusion
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Mar 7 2019, 2:22 PM · Plans, Harbormaster
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: Unknown Object (Differential Revision).
Mar 7 2019, 1:02 PM · Plans
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: Unknown Object (Differential Revision).
Mar 7 2019, 4:52 AM · Plans
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: Unknown Object (Differential Revision).
Mar 7 2019, 4:42 AM · Plans
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: Unknown Object (Differential Revision).
Mar 7 2019, 12:26 AM · Plans
epriestley updated the task description for T13249: 2019 Week 7 - 10 Bonus Content.
Mar 7 2019, 12:07 AM · Plans

Mar 6 2019

epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Mar 6 2019, 5:39 PM · Plans, Harbormaster
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: Unknown Object (Differential Revision).
Mar 6 2019, 5:39 PM · Plans
epriestley added a revision to T13249: 2019 Week 7 - 10 Bonus Content: Unknown Object (Differential Revision).
Mar 6 2019, 4:36 PM · Plans
epriestley added a comment to T13074: Plans: Workboard triggers, groups, and subproject columns.

In the future, when a board can be ordered/grouped by author or assignee (or maybe custom fields), what should dragging a card within a column do?

Mar 6 2019, 3:11 PM · Workboards (v3), Plans, Projects
epriestley updated the task description for T13249: 2019 Week 7 - 10 Bonus Content.
Mar 6 2019, 2:54 PM · Plans
epriestley closed T11415: Would like people who can't edit Harbormaster plans to be able to run them as Resolved by committing Restricted Diffusion Commit.
Mar 6 2019, 2:01 PM · Restricted Project, Harbormaster, Feature Request
epriestley closed T11415: Would like people who can't edit Harbormaster plans to be able to run them, a subtask of T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc), as Resolved.
Mar 6 2019, 2:01 PM · Plans, Harbormaster

Mar 5 2019

epriestley added a revision to T8135: drag & drop on a workboard sorted by priority behavior is surprising: Unknown Object (Differential Revision).
Mar 5 2019, 7:13 PM · Restricted Project, Workboards (v3), Restricted Project
epriestley added a revision to T10333: Add groups to workboard columns: Unknown Object (Differential Revision).
Mar 5 2019, 7:13 PM · Restricted Project, Restricted Project, Workboards (v3)
epriestley updated the task description for T13249: 2019 Week 7 - 10 Bonus Content.
Mar 5 2019, 5:57 PM · Plans
epriestley added a revision to T10333: Add groups to workboard columns: Unknown Object (Differential Revision).
Mar 5 2019, 3:21 PM · Restricted Project, Restricted Project, Workboards (v3)
epriestley added a revision to T13253: Plans: Daemon Status Reporting: Unknown Object (Differential Revision).
Mar 5 2019, 1:36 AM · Plans, Daemons

Mar 4 2019

epriestley created E1697: Path of Exile: Synthesis.
Mar 4 2019, 3:43 PM

Mar 2 2019

epriestley added a revision to T10334: On workboards, distinguish between "drag to column" and "drag to specific place in column": Unknown Object (Differential Revision).
Mar 2 2019, 3:49 PM · Workboards (v3)
epriestley added a comment to T10333: Add groups to workboard columns.

Technical stuff:

Mar 2 2019, 3:32 PM · Restricted Project, Restricted Project, Workboards (v3)
epriestley closed T13262: Dummy as Invalid.
Mar 2 2019, 3:18 PM
epriestley added a comment to T13253: Plans: Daemon Status Reporting.

Some old migrations call PhabricatorSearchWorker::queueDocumentForIndexing(). This no longer works after D20200 because the PHP implementation expects a dateCreated column to exist, but it won't exist until 20190220.daemon_worker.completed.02.sql runs.

Mar 2 2019, 2:04 PM · Plans, Daemons

Mar 1 2019

epriestley added a revision to T10334: On workboards, distinguish between "drag to column" and "drag to specific place in column": Unknown Object (Differential Revision).
Mar 1 2019, 11:24 PM · Workboards (v3)
epriestley added a comment to T10722: Communicate drag policies clearly in the workboard/list UIs.

Currently, if a card requires MFA to edit, we're unable to prompt the user. We likely should be able to do a prompt inline. This should also probably have a warning icon on the card itself.

Mar 1 2019, 10:46 PM · Workboards (v3), Bug Report
epriestley added a revision to T13121: Remove "-q" from SSH commands executed by `bin/remote` and similar cluster commands: Unknown Object (Differential Revision).
Mar 1 2019, 5:53 PM · Phacility, Ops
epriestley added a revision to T13121: Remove "-q" from SSH commands executed by `bin/remote` and similar cluster commands: Unknown Object (Differential Revision).
Mar 1 2019, 5:52 PM · Phacility, Ops
epriestley added a comment to T13121: Remove "-q" from SSH commands executed by `bin/remote` and similar cluster commands.

Another possible approach is to use -o LogLevel=ERROR. This gets us into trouble if there are useful INFO messages other than "permanently added X to list of known hosts", but presumably all the important stuff is rasied at ERROR or better.

Mar 1 2019, 5:43 PM · Phacility, Ops
epriestley added a comment to T13121: Remove "-q" from SSH commands executed by `bin/remote` and similar cluster commands.

For Drydock/Harbormaster, the only real way forward I see here is:

Mar 1 2019, 5:38 PM · Phacility, Ops
epriestley added a comment to T13261: Update upstream build steps to include timeouts and limits.

Currently, properties on upstream build steps are driven by CustomFields. T13248 briefly discusses a bit of context.

Mar 1 2019, 5:23 PM · Harbormaster
epriestley updated the task description for T13257: Plans: Unbeta New Harbormaster Log UI.
Mar 1 2019, 5:20 PM · Plans, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Mar 1 2019, 5:20 PM · Plans, Harbormaster
epriestley updated the task description for T13088: Plans: Harbormaster UI usability and interconnectedness.
Mar 1 2019, 5:19 PM · Plans, Harbormaster
epriestley triaged T13261: Update upstream build steps to include timeouts and limits as Normal priority.
Mar 1 2019, 5:19 PM · Harbormaster
epriestley added a comment to T13248: Support enabling and disabling (and making other adjustments to) custom fields based on object subtypes.

(This is likely to be very long, very rambling, and not particularly enlightening or useful.)

Mar 1 2019, 4:55 PM · Custom Fields, Maniphest
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Mar 1 2019, 3:54 PM · Plans, Harbormaster
epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": Unknown Object (Differential Revision).
Mar 1 2019, 3:16 PM · Diffusion
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Mar 1 2019, 2:13 PM · Plans, Harbormaster
epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

somewhat tricky to explain, and somewhat tricky to resolve

Mar 1 2019, 4:19 AM · Diffusion
epriestley closed T13260: Google auth fails and throws exception about missing client state parameter as Resolved by committing Restricted Diffusion Commit.
Mar 1 2019, 3:50 AM · Auth
epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": Unknown Object (Differential Revision).
Mar 1 2019, 3:47 AM · Diffusion
epriestley added a revision to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery": Unknown Object (Differential Revision).
Mar 1 2019, 3:28 AM · Diffusion
epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

From onsite:

Mar 1 2019, 2:53 AM · Diffusion

Feb 28 2019

epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

Thanks. That looks like a perfectly normal object to me so I'm not sure what could cause it to fail to load.

Feb 28 2019, 9:31 PM · Diffusion
epriestley added a comment to T2543: Add a formal "Draft" / "Not Yet Ready for Review" state to Differential.

You will soon be able to give builds different "Hold Drafts" behaviors. See T13258.

Feb 28 2019, 9:29 PM · Customer Impact, Restricted Project, Restricted Project, Prioritized, Differential
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Feb 28 2019, 9:24 PM · Plans, Harbormaster
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Feb 28 2019, 9:12 PM · Plans, Harbormaster
epriestley updated the task description for T784: Allow Differential changesets to be marked with various attributes.
Feb 28 2019, 8:54 PM · Restricted Project, Restricted Project, Restricted Project, Differential, Arcanist
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Restricted Differential Revision.
Feb 28 2019, 8:05 PM · Plans, Harbormaster
epriestley added a comment to T11415: Would like people who can't edit Harbormaster plans to be able to run them.

After D20229, the rules are:

Feb 28 2019, 7:44 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a revision to T11415: Would like people who can't edit Harbormaster plans to be able to run them: Unknown Object (Differential Revision).
Feb 28 2019, 7:41 PM · Restricted Project, Harbormaster, Feature Request
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Feb 28 2019, 7:41 PM · Plans, Harbormaster
epriestley added a comment to T9614: Require "Can Edit" permission on a build plan to pause or abort corresponding builds.

I'll call this out in the changelog, but behavior here is changing slightly (see T13258 and T11415):

Feb 28 2019, 7:30 PM · Harbormaster (v3), Restricted Project
epriestley added a revision to T13258: Plans: Harbormaster Build Plan Flags ("Does Not Block Promotion", etc): Unknown Object (Differential Revision).
Feb 28 2019, 7:01 PM · Plans, Harbormaster
epriestley added a comment to T13260: Google auth fails and throws exception about missing client state parameter.

I'll update the documentation/setup guidance in the upstream.

Feb 28 2019, 6:44 PM · Auth
epriestley added a revision to T13260: Google auth fails and throws exception about missing client state parameter: Unknown Object (Differential Revision).
Feb 28 2019, 6:42 PM · Auth
epriestley claimed T13260: Google auth fails and throws exception about missing client state parameter.
Feb 28 2019, 6:36 PM · Auth
epriestley added a comment to T13260: Google auth fails and throws exception about missing client state parameter.

Great! Thanks for the report, and for your help tracking this down by going through the diagnostic steps.

Feb 28 2019, 6:29 PM · Auth
epriestley updated the task description for T12164: Put an indirection layer between author/committer strings and user accounts.
Feb 28 2019, 5:29 PM · Customer Impact, Diffusion (v3)
epriestley added a comment to T13259: Rebuilding repository identities throws exception for inability to identify a valid object in query "DiffusionCommitQuery".

Here's what's happening in general:

Feb 28 2019, 1:55 PM · Diffusion
epriestley added a comment to T13260: Google auth fails and throws exception about missing client state parameter.

I can't immediately reproduce this: I can log into my local development install and into secure.phabricator.com using Google OAuth without any issues right now.

Feb 28 2019, 1:41 PM · Auth
spawnlt awarded T13074: Plans: Workboard triggers, groups, and subproject columns a Party Time token.
Feb 28 2019, 1:12 PM · Workboards (v3), Plans, Projects
spawnlt awarded T5474: Support workboard column triggers which activate when a task is dropped into a column a Party Time token.
Feb 28 2019, 1:03 PM · Workboards (v3), Restricted Project