Page MenuHomePhabricator
Feed All Stories

Oct 5 2018

epriestley added a revision to T13202: Plans: 2018 Week 38-40 Bonus Content: Unknown Object (Differential Revision).
Oct 5 2018, 6:14 PM · Plans
epriestley updated the task description for T13202: Plans: 2018 Week 38-40 Bonus Content.
Oct 5 2018, 5:52 PM · Plans
epriestley added a revision to T13202: Plans: 2018 Week 38-40 Bonus Content: Unknown Object (Differential Revision).
Oct 5 2018, 5:52 PM · Plans
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

For now, I just hard-wiped the cache and regenerated the documentation again. ¯\_(ツ)_/¯

Oct 5 2018, 4:15 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

The file cache says that these files have already been parsed and contain no atoms, so the rest of the program behavior is expected after that. I'm not sure how this state came to exist.

Oct 5 2018, 4:03 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].
  • DivinerPublisher->publishAtoms() is being passed nothing, so it's correctly deleting everything.
  • The graph cache is empty.
  • The actual atom.cache file on disk is empty.
  • The input to the cache is empty.
  • The files aren't being passed to the atomizer rules (although the rules appear to be applying correctly).
Oct 5 2018, 3:36 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

So, so far it looks like the database is in a "good" state but the publish workflow incorrectly deleted all the articles. From previous efforts, I believe dropping the cache fixes this issue.

Oct 5 2018, 3:26 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

But note that the graphHash and nodeHash columns are 0, which I believe is a signal that these nodes have been deleted (I haven't touched this code in a while).

Oct 5 2018, 3:21 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

Oh, the contrib stuff got separated into a different book and has fully unpublished:

Oct 5 2018, 1:27 PM · Diviner
epriestley added a comment to T13206: Diviner publishing can fail resoundingly with unusual file permissions [was: User documentation on "secure" is occasionally unpublishing].

The "Contributor Introduction" document, specifically, seems to have unpublished. Let me see what I can dig up about the current database state.

Oct 5 2018, 1:14 PM · Diviner

Oct 4 2018

epriestley updated the task description for T13202: Plans: 2018 Week 38-40 Bonus Content.
Oct 4 2018, 10:45 PM · Plans
epriestley added a comment to T5097: `arc lint --everything` uses a large amount of memory in when executed in large repositories.

"Yes", but post- T13098.

Oct 4 2018, 1:46 PM · Arcanist
joshuaspence added a comment to T5097: `arc lint --everything` uses a large amount of memory in when executed in large repositories.

@epriestley, would you be open to making the chunk size configurable? Changing the chunk size from 32 to 512 reduced the amount of time required for us to lint ~1500 TypeScript files from 370 seconds to 66 seconds.

Oct 4 2018, 3:00 AM · Arcanist

Oct 3 2018

epriestley updated the task description for T13202: Plans: 2018 Week 38-40 Bonus Content.
Oct 3 2018, 3:15 PM · Plans
epriestley updated the task description for T13202: Plans: 2018 Week 38-40 Bonus Content.
Oct 3 2018, 2:54 PM · Plans
epriestley renamed T2780: Under "cmd.exe" in Windows, "^C" causes "arc.bat" to annoyingly prompt the user "Terminate batch job? [Y/N]" from Replace arc.bat with something better to Under "cmd.exe" in Windows, "^C" causes "arc.bat" to annoyingly prompt the user "Terminate batch job? [Y/N]".
Oct 3 2018, 2:52 PM · Arcanist, Windows
epriestley updated the task description for T13202: Plans: 2018 Week 38-40 Bonus Content.
Oct 3 2018, 1:30 AM · Plans

Oct 2 2018

epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): Unknown Object (Differential Revision).
Oct 2 2018, 6:38 PM · Arcanist, Windows
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): Unknown Object (Differential Revision).
Oct 2 2018, 6:35 PM · Arcanist, Windows
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): Unknown Object (Differential Revision).
Oct 2 2018, 6:25 PM · Arcanist, Windows
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): Unknown Object (Differential Revision).
Oct 2 2018, 6:08 PM · Arcanist, Windows
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): Unknown Object (Differential Revision).
Oct 2 2018, 5:57 PM · Arcanist, Windows
epriestley added a revision to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): Unknown Object (Differential Revision).
Oct 2 2018, 5:51 PM · Arcanist, Windows
epriestley added a comment to T13098: Plans: Arcanist toolsets and extensions.

In retrospect, I should have rigged the hash for the the "Remove libphutil" commit to have some cool recognizable prefix like de1e7ed, since half of arcanist/ now ends up there on git blame.

Oct 2 2018, 5:05 PM · Arcanist, Plans
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

Also, guess what this checkbox does on Windows 10?

Oct 2 2018, 4:57 PM · Arcanist, Windows
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

Consider this script:

Oct 2 2018, 4:56 PM · Arcanist, Windows
epriestley lowered the priority of T2465: Context not available for revisions created on Windows from High to Low.
Oct 2 2018, 1:05 PM · Windows, Subversion, Arcanist
epriestley moved T9441: Cygwin PHP segfaults with arcanist from Backlog to Far Future on the Windows board.
Oct 2 2018, 1:05 PM · Windows, Arcanist
epriestley moved T2780: Under "cmd.exe" in Windows, "^C" causes "arc.bat" to annoyingly prompt the user "Terminate batch job? [Y/N]" from Backlog to Far Future on the Windows board.
Oct 2 2018, 1:03 PM · Windows, Arcanist
epriestley renamed T8075: arc patch fails on Windows with SVN (because it uses "cd", not "setCWD") from arc patch fails on Windows with SVN to arc patch fails on Windows with SVN (because it uses "cd", not "setCWD").
Oct 2 2018, 1:03 PM · Windows, Arcanist
epriestley moved T8855: Add Powershell support to Arcanist documentation from Backlog to Powershell on the Windows board.
Oct 2 2018, 1:01 PM · Windows, Arcanist
epriestley moved T2465: Context not available for revisions created on Windows from Backlog to Diff on the Windows board.
Oct 2 2018, 1:00 PM · Windows, Subversion, Arcanist
epriestley moved T4964: Windows installer for Arcanist from Backlog to Far Future on the Windows board.
Oct 2 2018, 1:00 PM · Windows, Arcanist, Setup, Wikimedia
epriestley moved T10910: Creating an arc diff from a working directory that is not the repository root from Backlog to Diff on the Windows board.
Oct 2 2018, 1:00 PM · Windows, Arcanist, Bug Report
epriestley moved T11072: Arcanist reports that it cannot generate a diff from SVN repo even though there are changes in the working copy from Backlog to Diff on the Windows board.
Oct 2 2018, 1:00 PM · Windows, Arcanist, Bug Report
epriestley renamed T9956: Arcanist failed patch lint on windows (because "cp" does not exist) from Arcanist failed patch lint on windows to Arcanist failed patch lint on windows (because "cp" does not exist).
Oct 2 2018, 12:59 PM · Windows, Bug Report
epriestley closed T9956: Arcanist failed patch lint on windows (because "cp" does not exist) as Resolved.

This was almost certainly resolved by D16273.

Oct 2 2018, 12:59 PM · Windows, Bug Report
epriestley moved T7527: `arc lint` doesn't show lint warnings in powershell, cmd.exe, and git bash from Backlog to Lint on the Windows board.
Oct 2 2018, 12:58 PM · Windows, Lint
epriestley moved T9047: arc lint can not find php and phpcs from Backlog to Lint on the Windows board.
Oct 2 2018, 12:58 PM · Windows, Lint, Arcanist
epriestley moved T6925: XHPAST is out of date on Windows from Backlog to XHPAST on the Windows board.
Oct 2 2018, 12:57 PM · Windows, XHPAST
epriestley moved T5730: `arc lint --everything` reporting all symbols missing in libphutil/ on Windows? from Backlog to XHPAST on the Windows board.
Oct 2 2018, 12:57 PM · Lint, Windows, Arcanist
epriestley changed the visibility for T3271: Before launching $EDITOR from arc, print that we're doing it.
Oct 2 2018, 12:56 PM · Arcanist
epriestley added a subtask for T13098: Plans: Arcanist toolsets and extensions: T3271: Before launching $EDITOR from arc, print that we're doing it.
Oct 2 2018, 12:56 PM · Arcanist, Plans
epriestley added a parent task for T3271: Before launching $EDITOR from arc, print that we're doing it: T13098: Plans: Arcanist toolsets and extensions.
Oct 2 2018, 12:56 PM · Arcanist
epriestley added a subtask for T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): T9444: The function phutil_console_get_terminal_width needs to work with Windows.
Oct 2 2018, 12:54 PM · Arcanist, Windows
epriestley added a parent task for T9444: The function phutil_console_get_terminal_width needs to work with Windows: T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).
Oct 2 2018, 12:54 PM · Windows, libphutil
epriestley added a parent task for T5724: ANSI color escape sequences seem broken for arc in git bash on windows: T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).
Oct 2 2018, 12:53 PM · Windows, Arcanist
epriestley added a subtask for T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): T5724: ANSI color escape sequences seem broken for arc in git bash on windows.
Oct 2 2018, 12:53 PM · Arcanist, Windows
epriestley merged T6473: Provide Arcanist option to disable ANSI colours / Disable ANSI colours on Windows into T5724: ANSI color escape sequences seem broken for arc in git bash on windows.
Oct 2 2018, 12:53 PM · Windows, Arcanist
epriestley merged task T6473: Provide Arcanist option to disable ANSI colours / Disable ANSI colours on Windows into T5724: ANSI color escape sequences seem broken for arc in git bash on windows.
Oct 2 2018, 12:53 PM · libphutil, Arcanist
epriestley closed T12687: When submitting an arc diff, svn diff or updating a revision a Parse Exception ocurrs in Windows as Invalid.

No clue how to reproduce this.

Oct 2 2018, 12:51 PM · Windows, Bug Report (Needs Information)
epriestley updated the task description for T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).
Oct 2 2018, 12:50 PM · Arcanist, Windows
epriestley closed T8821: arc commands (diff, version) fails on Windows - terrible fix inside as Resolved.

I believe this is essentially just T13209.

Oct 2 2018, 12:50 PM · Windows, libphutil, Arcanist
epriestley closed T8821: arc commands (diff, version) fails on Windows - terrible fix inside, a subtask of T13209: How To Properly Escape Commands on Windows (A Dark Tragedy), as Resolved.
Oct 2 2018, 12:50 PM · Arcanist, Windows
epriestley added a parent task for T8821: arc commands (diff, version) fails on Windows - terrible fix inside: T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).
Oct 2 2018, 12:49 PM · Windows, libphutil, Arcanist
epriestley added a subtask for T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): T8821: arc commands (diff, version) fails on Windows - terrible fix inside.
Oct 2 2018, 12:49 PM · Arcanist, Windows
epriestley closed T11105: ExecFuture performs blocking reads on Windows, causing deadlocks with `arc lint`, a subtask of T3272: Route ExecFuture stdout/stderr through the filesystem on Windows, as Resolved.
Oct 2 2018, 12:48 PM · Arcanist, Windows
epriestley closed T11105: ExecFuture performs blocking reads on Windows, causing deadlocks with `arc lint` as Resolved.

Changes in T13209 make this the only mode.

Oct 2 2018, 12:48 PM · Windows, Arcanist, Lint, Bug Report
epriestley added a parent task for T11105: ExecFuture performs blocking reads on Windows, causing deadlocks with `arc lint`: T3272: Route ExecFuture stdout/stderr through the filesystem on Windows.
Oct 2 2018, 12:48 PM · Windows, Arcanist, Lint, Bug Report
epriestley added a subtask for T3272: Route ExecFuture stdout/stderr through the filesystem on Windows: T11105: ExecFuture performs blocking reads on Windows, causing deadlocks with `arc lint`.
Oct 2 2018, 12:48 PM · Arcanist, Windows
epriestley closed T3272: Route ExecFuture stdout/stderr through the filesystem on Windows as Resolved.
Oct 2 2018, 12:48 PM · Arcanist, Windows
epriestley closed T3272: Route ExecFuture stdout/stderr through the filesystem on Windows, a subtask of T13209: How To Properly Escape Commands on Windows (A Dark Tragedy), as Resolved.
Oct 2 2018, 12:48 PM · Arcanist, Windows
epriestley added a parent task for T3272: Route ExecFuture stdout/stderr through the filesystem on Windows: T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).
Oct 2 2018, 12:47 PM · Arcanist, Windows
epriestley added a subtask for T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): T3272: Route ExecFuture stdout/stderr through the filesystem on Windows.
Oct 2 2018, 12:47 PM · Arcanist, Windows
epriestley added a comment to T3272: Route ExecFuture stdout/stderr through the filesystem on Windows.

D11688 implemented this.

Oct 2 2018, 12:47 PM · Arcanist, Windows
epriestley added a comment to T13156: Plans: Improve Phacility UI for managing instance managers and cards.

...we currently can not suspend instances through the web UI. The non-hacky way to fix this...

Oct 2 2018, 12:35 PM · Plans, Phacility
epriestley updated the task description for T13156: Plans: Improve Phacility UI for managing instance managers and cards.
Oct 2 2018, 12:30 PM · Plans, Phacility
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

I think I'm done for the night, but we're down to 18 failing tests under Windows.

Oct 2 2018, 2:03 AM · Arcanist, Windows
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

PHP7 introduces random_bytes(), which is a more accessible pseudorandom source on Windows than the other sources we use.

Oct 2 2018, 1:55 AM · Arcanist, Windows
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

ArcanistLinterTestCase->lintFile() has a bug where it does this:

Oct 2 2018, 1:27 AM · Arcanist, Windows
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

A lot of tests fail on Windows if core.autocrlf is set to convert "\n" line endings to "\r\n" line endings on checkout, which is the default behavior. In theory, this is fixable, but I'm not sure it's really worthwhile. At the least, I first want to get things passing without dealing with these tests.

Oct 2 2018, 1:08 AM · Arcanist, Windows

Oct 1 2018

epriestley closed T8298: Fix Windows Escaping as Resolved.

Evolved into T13209.

Oct 1 2018, 11:42 PM · Windows
epriestley closed T8298: Fix Windows Escaping, a subtask of T8291: arc version fails on Windows, as Resolved.
Oct 1 2018, 11:42 PM · Windows, Arcanist
epriestley closed T8298: Fix Windows Escaping, a subtask of T6966: Windows quoting conventions still bad, as Resolved.
Oct 1 2018, 11:42 PM · Windows, Arcanist
epriestley added a subtask for T13098: Plans: Arcanist toolsets and extensions: T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).
Oct 1 2018, 11:40 PM · Arcanist, Plans
epriestley added a parent task for T13209: How To Properly Escape Commands on Windows (A Dark Tragedy): T13098: Plans: Arcanist toolsets and extensions.
Oct 1 2018, 11:40 PM · Arcanist, Windows
20after4 added a comment to T13208: Workboard queries may vanish or fail to persist (spooky).

It seems to be a fairly recent problem so there must be some code change that started triggering it. The worst part, IMO, is that the workboard breaks in a not-entirely-obvious way instead of falling back to a default query. It took me a while to debug the issue the first time it occurred.

Oct 1 2018, 11:34 PM · Workboards
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

On startup on Windows, arc currently complains that cURL isn't enabled. It gives you some okay-ish instructions for enabling it.

Oct 1 2018, 11:18 PM · Arcanist, Windows
epriestley added a comment to T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).

I'm currently trying to update my Surface Pro so I can look at making arc unit in the wilds branch pass on Windows. I've restarted to install more updates about 5 times, am currently stuck at "Feature update to Windows 10, version 1803 - Downloading - 0%" which appears to just be not working.

Oct 1 2018, 10:56 PM · Arcanist, Windows
epriestley updated the task description for T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).
Oct 1 2018, 10:35 PM · Arcanist, Windows
epriestley added a comment to T13208: Workboard queries may vanish or fail to persist (spooky).

There should be no code anywhere in Phabricator to delete saved queries. The expectation is that they are never deleted or garbage collected because they may have been embedded in other pages, sent via email, etc., and deleting a saved query will break any use of the link in a permanent/external context. The table is expected to grow without bound, although at a slow enough rate that it does not create a maintainability issue.

Oct 1 2018, 9:59 PM · Workboards
Krinkle added a comment to T13208: Workboard queries may vanish or fail to persist (spooky).

[..] the issue is actually with persisting the query in the first place, not deleting it?

Oct 1 2018, 9:42 PM · Workboards
20after4 added a comment to T13208: Workboard queries may vanish or fail to persist (spooky).

Could it be that a user assigns it to one of their "personal" custom queries and then later they delete that query by way of the maniphest saved query ui?

Oct 1 2018, 9:37 PM · Workboards
20after4 added a comment to T13208: Workboard queries may vanish or fail to persist (spooky).

I'm not sure what's caused this either but I've seen it twice on wikimedia's production install.

Oct 1 2018, 9:36 PM · Workboards
epriestley updated the task description for T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).
Oct 1 2018, 9:14 PM · Arcanist, Windows
epriestley added a comment to T13202: Plans: 2018 Week 38-40 Bonus Content.

welcome back little comment border :) you have been missed

Oct 1 2018, 8:29 PM · Plans
epriestley added a comment to T13202: Plans: 2018 Week 38-40 Bonus Content.

I cut the Week 39 release with that stuff and am deploying it to secure now. I'm going to send it to repo006 if that goes cleanly to deal with PHI894.

Oct 1 2018, 8:23 PM · Plans
epriestley created 2018 Week 39 (Very Early October).
Oct 1 2018, 8:21 PM
epriestley edited the content of Changelog.
Oct 1 2018, 8:20 PM
epriestley renamed T13202: Plans: 2018 Week 38-40 Bonus Content from Plans: 2018 Week 38-39 Bonus Content to Plans: 2018 Week 38-40 Bonus Content.
Oct 1 2018, 8:08 PM · Plans
epriestley updated the task description for T13209: How To Properly Escape Commands on Windows (A Dark Tragedy).
Oct 1 2018, 7:42 PM · Arcanist, Windows
epriestley triaged T13209: How To Properly Escape Commands on Windows (A Dark Tragedy) as Normal priority.
Oct 1 2018, 6:38 PM · Arcanist, Windows
epriestley updated the task description for T13202: Plans: 2018 Week 38-40 Bonus Content.
Oct 1 2018, 6:12 PM · Plans
epriestley added a revision to T13202: Plans: 2018 Week 38-40 Bonus Content: Unknown Object (Differential Revision).
Oct 1 2018, 6:08 PM · Plans
epriestley updated the task description for T13202: Plans: 2018 Week 38-40 Bonus Content.
Oct 1 2018, 6:00 PM · Plans
epriestley updated the task description for T13202: Plans: 2018 Week 38-40 Bonus Content.
Oct 1 2018, 5:56 PM · Plans
epriestley added a revision to T13202: Plans: 2018 Week 38-40 Bonus Content: Unknown Object (Differential Revision).
Oct 1 2018, 5:52 PM · Plans
epriestley added a revision to T13202: Plans: 2018 Week 38-40 Bonus Content: Restricted Differential Revision.
Oct 1 2018, 5:27 PM · Plans
epriestley added a revision to T13202: Plans: 2018 Week 38-40 Bonus Content: Restricted Differential Revision.
Oct 1 2018, 5:16 PM · Plans
epriestley added a comment to T13208: Workboard queries may vanish or fail to persist (spooky).

My expectation is that no upstream code exists to ever delete saved queries. My guess is that either:

Oct 1 2018, 4:48 PM · Workboards