Page MenuHomePhabricator
Feed Advanced Search

Apr 11 2018

epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Apr 11 2018, 9:47 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Apr 11 2018, 9:30 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Apr 11 2018, 9:15 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Apr 11 2018, 8:45 PM · Plans, Files, Differential, Diffusion
epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.
  • Source view rendering in Paste has a missing background color.
Apr 11 2018, 7:06 PM · Plans, Files, Differential, Diffusion

Apr 9 2018

amckinley claimed T12857: Temporary directory fullness can cause daemon issues?.
Apr 9 2018, 6:08 PM · Diffusion, Ops, Daemons, Phacility
epriestley closed T13015: Improve color readability for change age in Diffusion blame view as Resolved by committing Restricted Diffusion Commit.
Apr 9 2018, 1:11 PM · Design, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Apr 9 2018, 1:09 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13015: Improve color readability for change age in Diffusion blame view: Restricted Differential Revision.
Apr 9 2018, 1:09 PM · Design, Diffusion
epriestley added a comment to T13015: Improve color readability for change age in Diffusion blame view.

This feels a bit like a return to the era of "epriestley design", but I think it's an improvement overall:

Apr 9 2018, 1:05 PM · Design, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Apr 9 2018, 12:40 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Apr 9 2018, 12:26 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Apr 9 2018, 12:20 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Apr 9 2018, 12:16 PM · Plans, Files, Differential, Diffusion
epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

Still needs work:

Apr 9 2018, 12:15 PM · Plans, Files, Differential, Diffusion

Apr 8 2018

epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Apr 8 2018, 7:53 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Apr 8 2018, 4:34 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Apr 8 2018, 3:13 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Apr 8 2018, 1:33 PM · Plans, Files, Differential, Diffusion
epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.
  • The secret $1-2,7-9 syntax for highlighting multiple noncontiguous blocks of lines in Diffusion is no longer supported.
Apr 8 2018, 1:31 PM · Plans, Files, Differential, Diffusion

Apr 5 2018

epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Apr 5 2018, 6:40 PM · Plans, Files, Differential, Diffusion
epriestley closed T2442: Show images in Diffusion diffs as Resolved.

This will ultimately be covered by T13105.

Apr 5 2018, 5:54 PM · Wikimedia, Diffusion
epriestley closed T8407: Control diffusion's syntax highlighting, a subtask of T5698: Github-style Remarkup previews on a checked-in resource, as Resolved.
Apr 5 2018, 5:52 PM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup
epriestley closed T8407: Control diffusion's syntax highlighting, a subtask of T12824: Redesign Diffusion, as Resolved.
Apr 5 2018, 5:52 PM · Design, Diffusion
epriestley closed T8407: Control diffusion's syntax highlighting as Resolved.

Effectively now covered by T13105.

Apr 5 2018, 5:52 PM · Diffusion
epriestley closed T3788: Improve encoding management in Diffusion as Resolved.

See T13105 for browse cases (and perhaps diff cases, eventually).

Apr 5 2018, 5:51 PM · Restricted Project, Diffusion
epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.
  • If a file is non-UTF8, we should try the repository's "Encoding" as a default (or maybe just remove this feature).
Apr 5 2018, 5:50 PM · Plans, Files, Differential, Diffusion
epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

Junk I'm about to break in Diffusion (but plan to restore):

Apr 5 2018, 5:38 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Apr 5 2018, 4:17 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Apr 5 2018, 2:33 PM · Plans, Files, Differential, Diffusion

Apr 3 2018

tekacs added a comment to T8936: Unable to identify the reftype of 'refs/remotes/origin/master'. Rejecting push..

As with @michaeloa's case above, this is a blocker to porting repos of ours over (from Gitlab EE, in our case) for testing purposes.

Apr 3 2018, 1:03 PM · Diffusion

Mar 30 2018

epriestley updated the task description for T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance.
Mar 30 2018, 9:31 PM · Plans, Diffusion
epriestley updated the task description for T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance.
Mar 30 2018, 9:30 PM · Plans, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Mar 30 2018, 6:15 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Mar 30 2018, 4:48 PM · Plans, Files, Differential, Diffusion

Mar 29 2018

epriestley added a revision to T8951: Allow Diffusion repositories to disable "push" Herald Rules to improve support for importing large repositories by pushing them: Restricted Differential Revision.
Mar 29 2018, 2:22 PM · Restricted Project, Diffusion, Herald

Mar 28 2018

bhchandra added a comment to T10767: fold empty directories in Browse view.

okay. thanks!

Mar 28 2018, 6:44 PM · Restricted Project, Diffusion, Feature Request
epriestley added a comment to T10767: fold empty directories in Browse view.

See Planning.

Mar 28 2018, 6:43 PM · Restricted Project, Diffusion, Feature Request
bhchandra added a comment to T10767: fold empty directories in Browse view.

Hello @epriestley, could you please provide any update on this task?
Won'tFix or InQueue ?

Mar 28 2018, 6:38 PM · Restricted Project, Diffusion, Feature Request
WTreutterer added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

Changeset rPfb4ce851c4ae: Add a PDF document "rendering" engine allows to view PDFs from the Files application. However, {Fxxx, ...} references to a PDF file in Phriction still only allow to download the file or open a lightbox with only an icon (again with a download link).

Mar 28 2018, 8:08 AM · Plans, Files, Differential, Diffusion

Mar 26 2018

epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Mar 26 2018, 2:23 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Mar 26 2018, 2:20 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Mar 26 2018, 2:16 PM · Plans, Files, Differential, Diffusion

Mar 23 2018

epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Mar 23 2018, 8:49 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Mar 23 2018, 2:41 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Mar 23 2018, 2:06 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Mar 23 2018, 12:10 PM · Plans, Files, Differential, Diffusion
mydeveloperday added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

I really like this, Remarkup idea, I think there are many text based files that people add to reviews which would be easily transformed to something more readable by being transfer directly to Remarkup, even for example something as simple as CSV,

Mar 23 2018, 11:27 AM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Mar 23 2018, 11:04 AM · Plans, Files, Differential, Diffusion

Mar 22 2018

epriestley added a comment to T13111: Periodically run `git prune` on Git working copies.

That's a reasonable point. The details of PHI386 weren't very indicative one way or another since I didn't end up GC'ing the repository multiple times. I suppose I can go GC it again during the deployment window this week and see how long it takes.

Mar 22 2018, 8:27 PM · Phacility, Diffusion
asherkin added a comment to T13111: Periodically run `git prune` on Git working copies.

Previously, in PHI386, an unusually large repository for the same instance took about 5 hours to git gc.

Mar 22 2018, 8:23 PM · Phacility, Diffusion
epriestley added a revision to T13109: Improve cluster write feedback and write routing: Restricted Differential Revision.
Mar 22 2018, 8:09 PM · Diffusion
epriestley added a revision to T13109: Improve cluster write feedback and write routing: Restricted Differential Revision.
Mar 22 2018, 7:56 PM · Diffusion
epriestley added a comment to T13109: Improve cluster write feedback and write routing.

Modify the PushEvent table to contain more information about locks and waits (e.g., active queue status; how long the push waited for the write lock; how long the push spent synchronizing).

Mar 22 2018, 7:27 PM · Diffusion
epriestley triaged T13111: Periodically run `git prune` on Git working copies as Normal priority.
Mar 22 2018, 4:56 PM · Phacility, Diffusion
epriestley added a revision to T13109: Improve cluster write feedback and write routing: Restricted Differential Revision.
Mar 22 2018, 2:11 AM · Diffusion

Mar 19 2018

epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Mar 19 2018, 7:40 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Mar 19 2018, 5:59 PM · Plans, Files, Differential, Diffusion
epriestley added a revision to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Restricted Differential Revision.
Mar 19 2018, 4:42 PM · Plans, Files, Differential, Diffusion
epriestley triaged T13109: Improve cluster write feedback and write routing as Normal priority.
Mar 19 2018, 2:07 PM · Diffusion
epriestley added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

Ideally, I think Diffusion, Files and Paste should all have the highlighting/encoding options and share more of the same code, with Diffusion being distinguished by having blame (and, I suppose, symbol linking) available.

Mar 19 2018, 1:48 PM · Plans, Files, Differential, Diffusion
avivey added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

I'm wondering how this should interact with T8407: Control diffusion's syntax highlighting.

Mar 19 2018, 1:11 PM · Plans, Files, Differential, Diffusion
mydeveloperday added a comment to T13105: Plans: Rich presentation and diff rendering pipelines for various file types.

It would be great if there was an ability for installations to write custom viewers for formats that are either more obscure (MIF Framemaker format), or even in house formats (.myformat)

Mar 19 2018, 11:18 AM · Plans, Files, Differential, Diffusion

Mar 16 2018

epriestley moved T13105: Plans: Rich presentation and diff rendering pipelines for various file types from Backlog to Soon on the Plans board.
Mar 16 2018, 10:57 PM · Plans, Files, Differential, Diffusion

Mar 14 2018

epriestley updated the task description for T13105: Plans: Rich presentation and diff rendering pipelines for various file types.
Mar 14 2018, 6:24 PM · Plans, Files, Differential, Diffusion
epriestley updated the task description for T13105: Plans: Rich presentation and diff rendering pipelines for various file types.
Mar 14 2018, 2:55 PM · Plans, Files, Differential, Diffusion
epriestley updated the task description for T13105: Plans: Rich presentation and diff rendering pipelines for various file types.
Mar 14 2018, 2:48 PM · Plans, Files, Differential, Diffusion
epriestley closed T2849: Implement alternate markup engines (Markdown, reStructuredText, ...), a subtask of T2815: Render Remarkup files in Diffusion, as Wontfix.
Mar 14 2018, 6:45 AM · Diffusion
epriestley closed T5698: Github-style Remarkup previews on a checked-in resource as Wontfix.

See followup in T13105.

Mar 14 2018, 6:45 AM · User Delight, KDE, Haskell.org, Wikimedia, Restricted Project, Diffusion, Remarkup
epriestley added a project to T13105: Plans: Rich presentation and diff rendering pipelines for various file types: Plans.
Mar 14 2018, 6:43 AM · Plans, Files, Differential, Diffusion
epriestley triaged T13105: Plans: Rich presentation and diff rendering pipelines for various file types as Normal priority.
Mar 14 2018, 6:43 AM · Plans, Files, Differential, Diffusion

Mar 7 2018

epriestley updated the task description for T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance.
Mar 7 2018, 1:58 AM · Plans, Diffusion

Mar 5 2018

epriestley moved T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance from Backlog to Tentative on the Plans board.
Mar 5 2018, 3:03 PM · Plans, Diffusion

Feb 27 2018

bcooksley added a comment to T13092: Diffusion tagging can't handle projects with similar names.

Okay. For the sake of 100% clarity it would be nice if the timeline story did show why the action was taken as it isn't immediately clear (unless you've read the documentation of course) why it was removed.

Feb 27 2018, 8:05 AM · Herald, Diffusion, Projects

Feb 26 2018

epriestley added a comment to T13092: Diffusion tagging can't handle projects with similar names.

I'll make a note on T12455, but we might be able to render this timeline story more clearly, e.g. "X added project Y (which automatically removed Z, a subproject)" but I think this is likely fairly natural/obvious in most cases and I'm not sure if it's trivial to completely explain in the timeline.

Feb 26 2018, 6:16 PM · Herald, Diffusion, Projects
bcooksley added a comment to T13092: Diffusion tagging can't handle projects with similar names.

Ah, that would certainly explain it. Sorry for the noise - when entering this I did wonder if I had missed something as it didn't make sense that a name collision would be able to cause this.

Feb 26 2018, 6:02 PM · Herald, Diffusion, Projects
epriestley updated the task description for T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance.
Feb 26 2018, 4:36 PM · Plans, Diffusion
epriestley closed T13092: Diffusion tagging can't handle projects with similar names as Resolved.

"Plasma on Wayland" is a subproject of "Plasma".

Feb 26 2018, 3:17 PM · Herald, Diffusion, Projects
bcooksley created T13092: Diffusion tagging can't handle projects with similar names.
Feb 26 2018, 9:04 AM · Herald, Diffusion, Projects

Feb 25 2018

epriestley added a project to T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance: Plans.
Feb 25 2018, 3:28 PM · Plans, Diffusion

Feb 22 2018

epriestley updated the task description for T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance.
Feb 22 2018, 3:58 PM · Plans, Diffusion

Feb 14 2018

michaeloa added a comment to T8936: Unable to identify the reftype of 'refs/remotes/origin/master'. Rejecting push..

So, in my case this turned out to be a well-known issue with git --mirror and the way pull-requests/branches are set up. I was able to clean up the issue for my purposes with this one-liner in the bare repository:

Feb 14 2018, 11:43 AM · Diffusion
epriestley triaged T13075: Plans: Diffusion authors, Herald ref rules, parsing, performance as Normal priority.
Feb 14 2018, 1:33 AM · Plans, Diffusion
epriestley merged task T8747: "Path Does Not Exist" error caused by not standard characters into T7339: Raise a setup warning when the "en_US.UTF-8" locale is unavailable.
Feb 14 2018, 1:25 AM · Diffusion

Feb 13 2018

michaeloa added a comment to T8936: Unable to identify the reftype of 'refs/remotes/origin/master'. Rejecting push..

I'm seeing this currently on our brand-new phabricator install. git push --mirror worked for the first repository installed, but now on the second, this is happening.

Feb 13 2018, 7:53 PM · Diffusion

Feb 12 2018

epriestley closed T1816: Support downloading a compressed working copy (tar/zip) of a repository at a specific commit or tag as Wontfix.

This is something we could reasonably build now, but I think we're unlikely to build it without a customer request and an actual use case. Closing until those materialize.

Feb 12 2018, 10:56 PM · Drydock, Diffusion
epriestley added a comment to T8951: Allow Diffusion repositories to disable "push" Herald Rules to improve support for importing large repositories by pushing them.

Sorry, the only way to influence feature development is through a support pact. See also Planning.

Feb 12 2018, 4:48 PM · Restricted Project, Diffusion, Herald
siepkes added a comment to T8951: Allow Diffusion repositories to disable "push" Herald Rules to improve support for importing large repositories by pushing them.

@epriestley Would you guys be open for a patch for this? How would you like to see this implemented in order to be acceptable for you guys?

Feb 12 2018, 9:21 AM · Restricted Project, Diffusion, Herald

Feb 10 2018

epriestley moved T13041: In Herald Commit rules, "Reviewer" and "On Autoclose Branch" have been deprecated from Backlog to Far Future Work on the Differential board.
Feb 10 2018, 7:40 PM · Diffusion, Herald

Feb 5 2018

epriestley closed T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails as Resolved by committing Restricted Diffusion Commit.
Feb 5 2018, 8:23 PM · Diffusion

Feb 4 2018

epriestley added a revision to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails: Restricted Differential Revision.
Feb 4 2018, 3:53 PM · Diffusion
epriestley added a comment to T12807: Diffusion's "Grep File Content" doesn't work with UTF characters.

See T13060 and T7339 for followups and additional discussion.

Feb 4 2018, 3:01 PM · Diffusion, Bug Report
epriestley added a revision to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails: Restricted Differential Revision.
Feb 4 2018, 2:09 PM · Diffusion
epriestley added a revision to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails: Restricted Differential Revision.
Feb 4 2018, 2:01 PM · Diffusion

Feb 3 2018

epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

I think I didn't kick Apache hard enough since I eventually rammed this through with setlocale().

Feb 3 2018, 4:20 PM · Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

setlocale(...) doesn't (?) appear to work from within Apache (?).

Feb 3 2018, 4:15 PM · Diffusion
epriestley renamed T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails from Commits may partially fail to import when affecting files with UTF8 characters to When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.
Feb 3 2018, 4:07 PM · Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

Thankfully, it seems that setlocale(LC_ALL, 'en_US.UTF-8'); from within PHP does work, so we don't need to figure out what PAM initialization cache file Ubuntu is actually reading LANG settings from.

Feb 3 2018, 4:02 PM · Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

sudo update-locale LC_ALL=en_US.UTF-8 LANG=en_US.UTF-8 also does not work, although this is apparently just a Perl script that rewrites /etc/default/locale for you.

Feb 3 2018, 3:54 PM · Diffusion
epriestley added a comment to T13060: When LANG=POSIX, executing commands with UTF8 characters in the argument list fails.

Setting LANG in /etc/environment had no effect on anything.

Feb 3 2018, 3:50 PM · Diffusion