Page MenuHomePhabricator
Feed Advanced Search

Sep 12 2017

epriestley updated the task description for T11932: Manual Activity: Rebuild Search Index.
Sep 12 2017, 3:25 PM · Search, Guides
epriestley closed T12443: Applying fulltext limits first causes missing results, a subtask of T12974: Upgrading: "Ferret" Fulltext Engine, as Resolved.
Sep 12 2017, 3:09 PM · Installing & Upgrading, Search
epriestley closed T12443: Applying fulltext limits first causes missing results as Resolved.

This is resolved by the Ferret engine, which can execute all parts of the query logic in MySQL.

Sep 12 2017, 3:09 PM · Restricted Project, Search, Bug Report
epriestley closed T6721: Would like ability to search tasks by title as Resolved.

This is resolved by the Ferret engine, using title:...:

Sep 12 2017, 3:08 PM · Search, Maniphest
epriestley closed T6721: Would like ability to search tasks by title, a subtask of T12974: Upgrading: "Ferret" Fulltext Engine, as Resolved.
Sep 12 2017, 3:08 PM · Installing & Upgrading, Search
epriestley closed T12928: Tokens in the form "v0.1" are not handled well by the MySQL FULLTEXT index, a subtask of T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size, as Resolved.
Sep 12 2017, 3:07 PM · Restricted Project, Search
epriestley closed T12928: Tokens in the form "v0.1" are not handled well by the MySQL FULLTEXT index as Resolved.

This is resolved by the Ferret engine:

Sep 12 2017, 3:07 PM · Customer Impact, Search
epriestley closed T12928: Tokens in the form "v0.1" are not handled well by the MySQL FULLTEXT index, a subtask of T12974: Upgrading: "Ferret" Fulltext Engine, as Resolved.
Sep 12 2017, 3:07 PM · Installing & Upgrading, Search
ftdysa awarded T12974: Upgrading: "Ferret" Fulltext Engine a Mountain of Wealth token.
Sep 12 2017, 2:54 PM · Installing & Upgrading, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 12 2017, 2:48 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 12 2017, 2:36 PM · Restricted Project, Search
epriestley added a comment to T784: Allow Differential changesets to be marked with various attributes.

See also PHI64.

Sep 12 2017, 1:18 AM · Restricted Project, Restricted Project, Restricted Project, Differential, Arcanist

Sep 11 2017

epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 11 2017, 11:45 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 11 2017, 11:43 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 11 2017, 11:38 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 11 2017, 11:31 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 11 2017, 11:29 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 11 2017, 11:21 PM · Restricted Project, Search
epriestley closed T12932: GC old Differential changesets into File storage as Wontfix.

Per above, not planning to actually go forward with the GC step since the impact isn't ultimately very large.

Sep 11 2017, 11:09 PM · Files, Differential, Phacility, Ops
epriestley added projects to T12978: Phacility Cluster Maintenance: 2017 Week 37: Phacility, Ops.
Sep 11 2017, 11:09 PM · Ops, Phacility
epriestley added a comment to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size.

From T12932, I don't think it's especially promising as a way forward, so I'm just going take an operations pathway instead (see T12978), so I expect to just move to unprototype the Ferret engine here.

Sep 11 2017, 11:05 PM · Restricted Project, Search
epriestley created T12978: Phacility Cluster Maintenance: 2017 Week 37.
Sep 11 2017, 11:03 PM · Ops, Phacility
epriestley added a comment to T12932: GC old Differential changesets into File storage.

Looking at the actual data, I'm less sure this is actually a good strategy. Here's the data for this install, considering the production configuration of storage.mysql-engine.max-size as 65535:

Sep 11 2017, 4:00 PM · Files, Differential, Phacility, Ops
epriestley added a revision to T12932: GC old Differential changesets into File storage: Unknown Object (Differential Revision).
Sep 11 2017, 3:51 PM · Files, Differential, Phacility, Ops
epriestley added a revision to T12932: GC old Differential changesets into File storage: Unknown Object (Differential Revision).
Sep 11 2017, 3:31 PM · Files, Differential, Phacility, Ops
epriestley added a comment to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size.

The actual indexes are fairly large (3GB for ~500MB of task data, although lispum tasks have an exceptionally large amount of text).

Sep 11 2017, 12:31 PM · Restricted Project, Search
epriestley added a comment to T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud).

I expect T12819 will ultimately remove all tables with FULLTEXT indexes, which should moot this.

Sep 11 2017, 12:05 PM
epriestley added a parent task for T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud): T12974: Upgrading: "Ferret" Fulltext Engine.
Sep 11 2017, 12:04 PM
epriestley added a subtask for T12974: Upgrading: "Ferret" Fulltext Engine: T11741: Quickstart can fail to initialize databases if MyISAM is not available (currently, only in Google Cloud).
Sep 11 2017, 12:04 PM · Installing & Upgrading, Search
epriestley closed T10560: Find ways to detect/fix/warn about MySQL indexes with poor cardinality estimates as Resolved.

bin/storage adjust and bin/storage upgrade now run ANALYZE, unless users opt-out with flags.

Sep 11 2017, 12:04 PM · Infrastructure
epriestley closed T10773: When the search table is marked as crashed, bin/storage should automatically repair it as Wontfix.

We generally stopped seeing this after moving to InnoDB FULLTEXT, which seems less prone to table crashes than MyISAM FULLTEXT was. See also T12819 for the fate of InnoDB FULLTEXT.

Sep 11 2017, 12:02 PM · Database, Feature Request

Sep 10 2017

epriestley edited the content of Changelog.
Sep 10 2017, 12:08 PM

Sep 9 2017

epriestley created T12977: Project "Chad's House" suggests #chad_s_house on this install but that doesn't link.
Sep 9 2017, 11:41 PM · Projects

Sep 8 2017

epriestley created 2017 Week 36 (Early September).
Sep 8 2017, 6:54 PM
epriestley added a comment to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size.

All the search which was previously driven by InnoDB FULLTEXT is now driven by the Ferret engine on this install.

Sep 8 2017, 5:57 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 8 2017, 4:13 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 8 2017, 3:16 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 8 2017, 3:08 PM · Restricted Project, Search

Sep 7 2017

epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 11:31 PM · Restricted Project, Search
epriestley closed T12976: Use a server for pygments? as Resolved.

Calling this resolved since there's no remaining upstream action, feel free to send diffs for lexers if you build them.

Sep 7 2017, 8:43 PM · Differential
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 8:40 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 8:20 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 8:07 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 8:02 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 7:50 PM · Restricted Project, Search
epriestley added a comment to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size.

Here's a closer look at what's probably happening:

Sep 7 2017, 7:42 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 7:34 PM · Restricted Project, Search
epriestley added a comment to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size.

I briefly hit a bizarre case where a Ferret engine query took 10 seconds to find a document in 163 projects. However, running ANALYZE TABLE on the ngrams table resolved this completely. I suspect the ngrams join may require some tweaking (and maybe a bin/storage analyze). Analyzing the Maniphest table actually seems to improve performance by ~50% too (???) although that's not a very scientific measurement.

Sep 7 2017, 7:32 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 7:14 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 7:06 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 7:06 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 5:30 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 5:23 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 5:06 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 4:54 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 4:46 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 4:13 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 7 2017, 3:49 PM · Restricted Project, Search
epriestley added a comment to T12976: Use a server for pygments?.

Yeah -- we'll take the patch in the latter case (porting lexers to PHP) but may not have time to review them for a while. We aren't interested in any version of options/support for using HTTP to talk to Pygments in the upstream.

Sep 7 2017, 2:55 PM · Differential
epriestley added a comment to T12976: Use a server for pygments?.

The only way forward on Pygments performance with upstream support is porting language lexers to PHP. Writing, deploying, and supporting an additional service is an enormous amount of work for us and not a solution I'm interested in pursuing for this problem: it burdens us with a large ongoing support cost instead of very small mostly-one-time lexer porting costs.

Sep 7 2017, 11:45 AM · Differential

Sep 6 2017

epriestley added a member for Phacility Documentation Editors: amckinley.
Sep 6 2017, 8:49 PM
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 6 2017, 7:30 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 6 2017, 7:15 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Restricted Differential Revision.
Sep 6 2017, 5:50 PM · Restricted Project, Search
epriestley closed T5853: Hint to blocking reviewers that they're blocking in earlier acceptance emails as Wontfix.

See PHI54 for some additional discussion.

Sep 6 2017, 5:30 PM · Restricted Project, Differential
epriestley closed T12118: Differential email does not contain reviewers/subscribers information anymore as Resolved by committing Restricted Diffusion Commit.
Sep 6 2017, 5:23 PM · Restricted Project, Differential, Bug Report
epriestley added a revision to T12118: Differential email does not contain reviewers/subscribers information anymore: Unknown Object (Differential Revision).
Sep 6 2017, 4:45 PM · Restricted Project, Differential, Bug Report
20after4 awarded T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size a Party Time token.
Sep 6 2017, 3:51 PM · Restricted Project, Search

Sep 5 2017

epriestley added a revision to T9846: Diff on `arc lint` misleading when the replacement has newlines: Unknown Object (Differential Revision).
Sep 5 2017, 11:53 PM · Restricted Project, Arcanist, Lint
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 5 2017, 11:32 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 5 2017, 11:00 PM · Restricted Project, Search
epriestley added a comment to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size.

Unclear if building a search engine by just doing a lot of JOINs actually scales or not. Seems OK here.

Sep 5 2017, 7:47 PM · Restricted Project, Search
epriestley closed T12975: Unable to update Credential on URI when credential policy is set to other user as Resolved by committing Restricted Diffusion Commit.
Sep 5 2017, 6:56 PM · Passphrase, Diffusion
epriestley added a revision to T9846: Diff on `arc lint` misleading when the replacement has newlines: Unknown Object (Differential Revision).
Sep 5 2017, 6:50 PM · Restricted Project, Arcanist, Lint
epriestley added a revision to T12975: Unable to update Credential on URI when credential policy is set to other user: Unknown Object (Differential Revision).
Sep 5 2017, 6:34 PM · Passphrase, Diffusion
epriestley claimed T12975: Unable to update Credential on URI when credential policy is set to other user.
Sep 5 2017, 6:27 PM · Passphrase, Diffusion
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 5 2017, 5:34 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 5 2017, 4:48 PM · Restricted Project, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 5 2017, 4:30 PM · Restricted Project, Search
epriestley added a comment to T9948: Modernize "arc land" for Mercurial: bookmark-to-branch, branch-to-self, multiple heads.

See also PHI45.

Sep 5 2017, 2:24 PM · Mercurial, Arcanist

Sep 2 2017

epriestley closed T8291: arc version fails on Windows as Resolved by committing Restricted Diffusion Commit.
Sep 2 2017, 1:06 AM · Windows, Arcanist
epriestley added a revision to T8291: arc version fails on Windows: Unknown Object (Differential Revision).
Sep 2 2017, 1:04 AM · Windows, Arcanist
epriestley claimed T8291: arc version fails on Windows.

See also PHI52.

Sep 2 2017, 12:06 AM · Windows, Arcanist

Sep 1 2017

epriestley edited the content of Changelog.
Sep 1 2017, 8:58 PM
epriestley created 2017 Week 35 (Very Early September).
Sep 1 2017, 8:58 PM
• tomekj2ee awarded T12974: Upgrading: "Ferret" Fulltext Engine a Like token.
Sep 1 2017, 5:37 PM · Installing & Upgrading, Search
chad awarded T12974: Upgrading: "Ferret" Fulltext Engine a 100 token.
Sep 1 2017, 5:08 PM · Installing & Upgrading, Search
epriestley added projects to T12974: Upgrading: "Ferret" Fulltext Engine: Search, Installing & Upgrading.
Sep 1 2017, 5:06 PM · Installing & Upgrading, Search
epriestley added a parent task for T6721: Would like ability to search tasks by title: T12974: Upgrading: "Ferret" Fulltext Engine.
Sep 1 2017, 5:06 PM · Search, Maniphest
epriestley added subtasks for T12974: Upgrading: "Ferret" Fulltext Engine: T6721: Would like ability to search tasks by title, T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size, T12928: Tokens in the form "v0.1" are not handled well by the MySQL FULLTEXT index, T12443: Applying fulltext limits first causes missing results.
Sep 1 2017, 5:06 PM · Installing & Upgrading, Search
epriestley added a parent task for T12443: Applying fulltext limits first causes missing results: T12974: Upgrading: "Ferret" Fulltext Engine.
Sep 1 2017, 5:06 PM · Restricted Project, Search, Bug Report
epriestley created T12974: Upgrading: "Ferret" Fulltext Engine.
Sep 1 2017, 5:05 PM · Installing & Upgrading, Search
epriestley added a revision to T12819: InnoDB FULLTEXT appears to fail catastrophically once it reaches a moderate size: Unknown Object (Differential Revision).
Sep 1 2017, 4:22 PM · Restricted Project, Search

Aug 31 2017

epriestley added a comment to T4181: Document (the lack of) init scripts for phd, and be more explicit about `phd launch`.

No, we don't want to bring anything upstream if we don't support or maintain it.

Aug 31 2017, 10:21 PM · Phabricator
epriestley closed T9846: Diff on `arc lint` misleading when the replacement has newlines as Resolved by committing Restricted Diffusion Commit.
Aug 31 2017, 8:29 PM · Restricted Project, Arcanist, Lint
epriestley added a revision to T9846: Diff on `arc lint` misleading when the replacement has newlines: Unknown Object (Differential Revision).
Aug 31 2017, 8:06 PM · Restricted Project, Arcanist, Lint
epriestley added a revision to T9846: Diff on `arc lint` misleading when the replacement has newlines: Unknown Object (Differential Revision).
Aug 31 2017, 7:38 PM · Restricted Project, Arcanist, Lint
epriestley added a revision to T9846: Diff on `arc lint` misleading when the replacement has newlines: Restricted Differential Revision.
Aug 31 2017, 7:25 PM · Restricted Project, Arcanist, Lint
epriestley added a revision to T9846: Diff on `arc lint` misleading when the replacement has newlines: Unknown Object (Differential Revision).
Aug 31 2017, 4:18 PM · Restricted Project, Arcanist, Lint
epriestley added a revision to T9846: Diff on `arc lint` misleading when the replacement has newlines: Restricted Differential Revision.
Aug 31 2017, 3:40 PM · Restricted Project, Arcanist, Lint