Page MenuHomePhabricator
Feed Advanced Search

May 30 2016

epriestley renamed T11051: "Explain Why" isn't properly explaining why revisions were closed from Diffusion closed an unrelated differential task after pushing a commit to "Explain Why" isn't properly explaining why revisions were closed.
May 30 2016, 1:55 PM · Restricted Project, Differential, Bug Report
epriestley added a comment to T11051: "Explain Why" isn't properly explaining why revisions were closed.

Here are the commit hash and tree hash of the commit:

May 30 2016, 1:55 PM · Restricted Project, Differential, Bug Report
epriestley edited the content of Changelog.
May 30 2016, 3:01 AM
epriestley created 2016 Week 22 (Very Late May).
May 30 2016, 3:01 AM
epriestley added a comment to T11051: "Explain Why" isn't properly explaining why revisions were closed.

Is it OK if I look at some of the data on your instance to diagnose this? I expect to look at this information:

May 30 2016, 2:26 AM · Restricted Project, Differential, Bug Report
epriestley added a project to T4453: When multiple commits correspond to a single revision, Differential updates to show one of them arbitrarily: Prioritized.
May 30 2016, 2:22 AM · Restricted Project, Prioritized, Differential

May 28 2016

epriestley added a comment to T8787: Add support for U2F MFA once browser implementations improve and compatible hardware is more widely available.

Phabricator also does not support OpenID and we specifically declined to support it in T524#35252.

May 28 2016, 5:10 PM · Haskell.org, Auth
epriestley awarded Blog Post: Differential a Pterodactyl token.
May 28 2016, 3:37 PM

May 27 2016

epriestley added a comment to T11050: Allow resigning from a review you are not directly responsible for.

I think it may be reasonable to allow users to resign from reviews they are only indirect reviewers for, but wouldn't pursue this until after T10967.

May 27 2016, 7:56 PM · Prioritized, Restricted Project, Differential, Feature Request
epriestley added a comment to T11049: Differential home page and "Differential Revisions" Panel not showing same results.

Yeah the way that flow works is real dumb / undiscoverable / confusing / hard to use right now. It works great if you know the secret magic, but the secret magic is pretty secret.

May 27 2016, 4:17 PM · Bug Report
epriestley added Q406: How do I limit the permissions to create a new project only to administrators? (Answer 384).
May 27 2016, 3:49 PM
epriestley added a comment to T11049: Differential home page and "Differential Revisions" Panel not showing same results.

There's some discussion of the behavior of limits in T9372#175512 / D15923.

May 27 2016, 3:47 PM · Bug Report
epriestley added a comment to T11049: Differential home page and "Differential Revisions" Panel not showing same results.

What query is the query panel actually executing? Does it look exactly like this?

May 27 2016, 3:29 PM · Bug Report
epriestley added a comment to T4292: Implement repository replication.

Strategy I'm pursuing (for Git) is:

May 27 2016, 2:02 PM · Restricted Project, Diffusion
epriestley closed T11048: Testing as Spite.
May 27 2016, 1:48 PM · Feature Request
epriestley added a comment to Q402: Why do my daemons keep <dying> ?.

You can email me directly at epriestley@phacility.com, or create a private thread in Conpherence on this install via the icon in the header.

May 27 2016, 1:08 PM · Daemons
epriestley triaged T11047: Entering wrong or empty paths renders configtool unusable as Wishlist priority.

This needs to be the default behavior. For example, if you update lib-important-security/ and the new version has a bug which causes it to fatal, Phabricator must also fatal. It is not acceptable to just skip the extension and start without loading a library that may have important security/policy code an install could rely on, because this could make the install vulnerable to security or policy threats which you expect to be protected from.

May 27 2016, 12:29 PM · Config, Bug Report
epriestley closed T9643: XHPast Parse error when extracting i18n, a subtask of T5267: Localize Phabricator, as Resolved.
May 27 2016, 3:11 AM · Prioritized, Localization
epriestley closed T9643: XHPast Parse error when extracting i18n as Resolved by committing Restricted Diffusion Commit.
May 27 2016, 3:11 AM · XHPAST
epriestley added a revision to T5267: Localize Phabricator: Unknown Object (Differential Revision).
May 27 2016, 3:01 AM · Prioritized, Localization
epriestley added a revision to T9643: XHPast Parse error when extracting i18n: Unknown Object (Differential Revision).
May 27 2016, 3:01 AM · XHPAST
epriestley added a subtask for T5267: Localize Phabricator: T9643: XHPast Parse error when extracting i18n.
May 27 2016, 2:48 AM · Prioritized, Localization
epriestley added a parent task for T9643: XHPast Parse error when extracting i18n: T5267: Localize Phabricator.
May 27 2016, 2:48 AM · XHPAST
epriestley merged T8700: Add missing Translations into T5267: Localize Phabricator.
May 27 2016, 2:46 AM · Prioritized, Localization
epriestley merged task T8700: Add missing Translations into T5267: Localize Phabricator.
May 27 2016, 2:46 AM · Localization
epriestley added a comment to T8700: Add missing Translations.

I'm going to merge this into T5267, which discusses a larger-scale effort to translate Phabricator in the relatively near term. We'll be interested in feedback like this once that's a little further along.

May 27 2016, 2:45 AM · Localization
epriestley merged T1139: Internationalize Phabricator into T5267: Localize Phabricator.
May 27 2016, 2:37 AM · Prioritized, Localization
epriestley merged task T1139: Internationalize Phabricator into T5267: Localize Phabricator.
May 27 2016, 2:37 AM · Localization
epriestley added a comment to T1139: Internationalize Phabricator.

I'm going to merge this into T5267, which is more actionable in the short term.

May 27 2016, 2:37 AM · Localization
epriestley moved T8153: Improve detection and recovery when resources are mangled outside of Drydock's control from Backlog to Preflight on the Prioritized board.
May 27 2016, 2:17 AM · Prioritized, Drydock
epriestley moved T11044: Support partitioning application databases across multiple database hosts from Backlog to Preflight on the Prioritized board.
May 27 2016, 2:17 AM · Clusters, Prioritized

May 26 2016

epriestley added a project to T11045: Inching an install toward repository clustering: Guides.
May 26 2016, 8:24 PM · Guides, Clusters
epriestley created T11045: Inching an install toward repository clustering.
May 26 2016, 8:24 PM · Guides, Clusters
epriestley created T11044: Support partitioning application databases across multiple database hosts.
May 26 2016, 8:06 PM · Clusters, Prioritized
epriestley added a project to T8153: Improve detection and recovery when resources are mangled outside of Drydock's control: Prioritized.
May 26 2016, 7:45 PM · Prioritized, Drydock
epriestley added a comment to T11042: Cluster documentation leads you slightly awry about "read only mode".

I think I didn't actually do these things, I did a different and more horrible set of things and then wrote these great instructions to avoid all the msitakes I made. I'll attempt to let dump pierce through read-only, or find some other solution if that isn't straightforward.

May 26 2016, 7:45 PM · Clusters, Bug Report
epriestley claimed T11042: Cluster documentation leads you slightly awry about "read only mode".
May 26 2016, 7:20 PM · Clusters, Bug Report
epriestley added a comment to T11043: Database status page throws an exception if `mysql.host` not explicitly set in a clustered environment.

Should be fixed in HEAD of master. Thanks for the report!

May 26 2016, 7:17 PM · Database, Clusters, Bug Report
epriestley closed T11043: Database status page throws an exception if `mysql.host` not explicitly set in a clustered environment as Resolved by committing Restricted Diffusion Commit.
May 26 2016, 7:14 PM · Database, Clusters, Bug Report
epriestley added a revision to T11043: Database status page throws an exception if `mysql.host` not explicitly set in a clustered environment: Unknown Object (Differential Revision).
May 26 2016, 7:13 PM · Database, Clusters, Bug Report
epriestley added projects to T11043: Database status page throws an exception if `mysql.host` not explicitly set in a clustered environment: Clusters, Database.
May 26 2016, 7:03 PM · Database, Clusters, Bug Report
epriestley claimed T11043: Database status page throws an exception if `mysql.host` not explicitly set in a clustered environment.
May 26 2016, 7:03 PM · Database, Clusters, Bug Report
epriestley added a comment to T11043: Database status page throws an exception if `mysql.host` not explicitly set in a clustered environment.

Ah! I got a repro.

May 26 2016, 7:03 PM · Database, Clusters, Bug Report
epriestley added a comment to T11043: Database status page throws an exception if `mysql.host` not explicitly set in a clustered environment.

I can't immediately reproduce this. Here's things running fine with mysql.host set to a bogus value:

May 26 2016, 6:30 PM · Database, Clusters, Bug Report
epriestley reopened T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches as "Open".

(I marked D15981 as fixing this but I'm going to leave it open for confirmation since I'm not completely sure there weren't more cases that I missed.)

May 26 2016, 5:47 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley closed T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches as Resolved by committing Restricted Diffusion Commit.
May 26 2016, 5:47 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley closed T11041: Not possible to move a URI without destroying the old one as Invalid.

After you created the second URI, you can switch the first one to active IO back, so there the error messages does not work:

May 26 2016, 5:31 PM · Diffusion, Bug Report
epriestley moved T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches from Backlog to Paused on the Prioritized board.

T6102 and the downstream also contain discussion of a second case which does center around exact matches -- searching for "Wikidata" -- but I can't reproduce it at HEAD:

May 26 2016, 5:29 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley added a comment to T11041: Not possible to move a URI without destroying the old one.

I can't reproduce this. Here's the first repository (I/O off, disabled);

May 26 2016, 5:21 PM · Diffusion, Bug Report
epriestley added a comment to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches.

D15981 doesn't, strictly speaking, prioritize exact matches. However, it should fix the underlying issue.

May 26 2016, 5:11 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley added a revision to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches: Unknown Object (Differential Revision).
May 26 2016, 5:06 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search
epriestley added a comment to T11040: Linking Workboard lanes to Task activities.

I don't understand the root problem this is seeking to solve. Please read Describing Root Problems carefully and try to follow the instructions there to describe a problem we can solve.

May 26 2016, 2:54 PM · Workboards, Feature Request
epriestley added a revision to T5267: Localize Phabricator: Unknown Object (Differential Revision).
May 26 2016, 2:49 PM · Prioritized, Localization
epriestley added a revision to T5267: Localize Phabricator: Unknown Object (Differential Revision).
May 26 2016, 2:37 PM · Prioritized, Localization
epriestley added a revision to T4103: Implement "Role Profiles" to provide search, homepage and application defaults: Unknown Object (Differential Revision).
May 26 2016, 1:54 PM · Prioritized, Restricted Project, Restricted Project, Applications, Dashboards
epriestley added a revision to T5267: Localize Phabricator: Unknown Object (Differential Revision).
May 26 2016, 1:54 PM · Prioritized, Localization
d.maznekov awarded T10922: Upgrading: New Repository UI, APIs, and URI management a Like token.
May 26 2016, 1:25 PM · Diffusion (v3), Installing & Upgrading
epriestley added a comment to T10922: Upgrading: New Repository UI, APIs, and URI management.

To edit project tags for a repository, navigate to the repository main page, then click Manage Repository → Edit Basic Information and add project tags to the "Tags" field.

May 26 2016, 1:14 PM · Diffusion (v3), Installing & Upgrading
epriestley added a comment to T11038: Herald rules linked to projects don't work as expected.

I don't think the behavior of the fields is unclear and we haven't seen other users run into this particular difficulty.

May 26 2016, 1:06 PM · Owners, Herald, Bug Report
epriestley added Q396: How are you suppose to work with Phabricator when you have revisions based on revisions? (Answer 382).
May 26 2016, 12:58 PM
• felix.rently awarded T3569: Make Phrequent somewhat usable a Like token.
May 26 2016, 12:54 PM · Phrequent
epriestley closed T11039: Trello to Phabricator Migration issue with trello_create.py and trello_makePHIDs.py as Invalid.

Unfortunately, we can't help you with this problem. We didn't write this script, do not maintain it, and have never seen it before. You should try getting in touch with the script maintainers instead. We don't have the resources to provide support for third-party code.

May 26 2016, 12:39 PM · Bug Report
epriestley added a comment to T4334: Support PHP5.4+ syntax in XHPAST.

That seems fine to me.

May 26 2016, 12:35 PM · XHPAST
• spiridon-alexandru awarded T3569: Make Phrequent somewhat usable a Like token.
May 26 2016, 12:28 PM · Phrequent
epriestley closed T11038: Herald rules linked to projects don't work as expected as Invalid.

Code being owned by a package does not tag it with a project.

May 26 2016, 6:19 AM · Owners, Herald, Bug Report
epriestley added a comment to T10811: `phd-daemon` crash after automatic restart following config change.

D15977 improves some behaviors slightly and adds more extensive logging for signal handling. I don't think I caught anything with real meat to it.

May 26 2016, 3:23 AM · Daemons, Bug Report
epriestley added a revision to T10811: `phd-daemon` crash after automatic restart following config change: Unknown Object (Differential Revision).
May 26 2016, 3:19 AM · Daemons, Bug Report
epriestley added a revision to T4103: Implement "Role Profiles" to provide search, homepage and application defaults: Unknown Object (Differential Revision).
May 26 2016, 1:40 AM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley added a comment to T10811: `phd-daemon` crash after automatic restart following config change.

D15975 should fix the (Exception) No such daemon "39084:6ra7uz"! error. I'm not sure if it will do anything for stability or not, but it should reduce noise. I didn't uncover anything interesting in resolving it (it wasn't really even a race, just a fairly straightforward set of state management bugs).

May 26 2016, 1:17 AM · Daemons, Bug Report
epriestley added a revision to T10811: `phd-daemon` crash after automatic restart following config change: Unknown Object (Differential Revision).
May 26 2016, 1:13 AM · Daemons, Bug Report
epriestley added a comment to Q402: Why do my daemons keep <dying> ?.

This is almost certainly not a resource problem, but I have no idea what it is.

May 26 2016, 12:36 AM · Daemons

May 25 2016

epriestley added a comment to T4103: Implement "Role Profiles" to provide search, homepage and application defaults.

My tentative plan here is:

May 25 2016, 11:06 PM · Prioritized, Restricted Project, Restricted Project, Dashboards, Applications
epriestley added a comment to Q402: Why do my daemons keep <dying> ?.

I actually have no clue. There are AMIs for it in AWS but maybe that's unrelated or related in some complicated way.

May 25 2016, 10:28 PM · Daemons
epriestley added a comment to Q402: Why do my daemons keep <dying> ?.

(By "provide instructions to construct a similar system", I mean something we can do in a few minutes, like launch a VM in AWS. I don't see any CloudLinux 6.8 AMIs offhand there, though.)

May 25 2016, 10:26 PM · Daemons
epriestley added a comment to Q402: Why do my daemons keep <dying> ?.
  • Do they die after 5 minutes if you start them manually?
  • Can you give us access to this system, or provide instructions for us to construct a similar system? We haven't seen this on any production system we manage, but do have other installs reporting some possibly-related issues.
May 25 2016, 10:23 PM · Daemons
epriestley renamed T9028: Phabricator handles commits which are published and later deleted poorly from Deleting a branch does not delete associated audits to Phabricator handles commits which are published and later deleted poorly.
May 25 2016, 9:38 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley added a comment to T9028: Phabricator handles commits which are published and later deleted poorly.

A sub-problem here is that if daemons discover commits but those commits are deleted before they can be processed, the tasks fail forever. This is normally unusual (git won't GC the commits for a few weeks, which often gives the daemons enough time to process them) but cases like fiddling with tracking, re-cloning a repository, everyone going on vacation for a couple weeks, or clustering an observed repository can exacerbate them.

May 25 2016, 9:22 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley moved T9028: Phabricator handles commits which are published and later deleted poorly from Backlog to Preflight on the Prioritized board.
May 25 2016, 9:20 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley added a project to T9028: Phabricator handles commits which are published and later deleted poorly: Prioritized.
May 25 2016, 9:19 PM · Restricted Project, Prioritized, Audit, Restricted Project
epriestley added a revision to T5267: Localize Phabricator: Unknown Object (Differential Revision).
May 25 2016, 9:06 PM · Prioritized, Localization
epriestley added a comment to T11036: Put subproject columns on workboards.

parrot

May 25 2016, 7:44 PM · Workboards (v3), Projects (v3)
epriestley created T11037: `bin/phd status` is misleading about local / remote daemons.
May 25 2016, 7:15 PM · Daemons, Restricted Project
epriestley added a comment to T11036: Put subproject columns on workboards.

For prioritization, I estimate we can complete this within 6 hours. It may all be straightforward and easier than that, but there are enough weird edge cases and UI implications that I don't want to commit to a best-case estimate.

May 25 2016, 6:41 PM · Workboards (v3), Projects (v3)
epriestley created T11036: Put subproject columns on workboards.
May 25 2016, 6:39 PM · Workboards (v3), Projects (v3)
epriestley added a comment to T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier.

Almanac Blueprints aren't mentioned downstream but I think are also a fairly good fit for this:

May 25 2016, 5:46 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
epriestley added a comment to T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier.

Yeah, I don't think this helps at all if there are 50 results, but I don't think we can do anything about that. Better solution is to fix the workflow somehow (nuance, subprojects, etc).

May 25 2016, 5:40 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
epriestley added a comment to T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier.

The original use case on the downstream task (https://phabricator.wikimedia.org/T234) was this:

May 25 2016, 5:39 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
epriestley added a comment to T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier.

I think users are probably mostly only using this UI to browse things anyway, so it's likely OK to "slow it down" a bit visually, since that could make it easier to navigate if we save users from needing to go look up information in a new window.

May 25 2016, 5:31 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
epriestley added a comment to T8951: Allow Diffusion repositories to disable "push" Herald Rules to improve support for importing large repositories by pushing them.

(Although we do formally support and have documentation for the the "import, then make hosted" and "copy the whole working directory into place" methods of repository import now, both of which skip the pre-receive rules.)

May 25 2016, 5:13 PM · Restricted Project, Diffusion, Herald
epriestley added a comment to T8951: Allow Diffusion repositories to disable "push" Herald Rules to improve support for importing large repositories by pushing them.

Disabling Herald there only disables the post-push, at-discovery-time rules, not the pre-push pre-receive-commit-hook rules.

May 25 2016, 5:12 PM · Restricted Project, Diffusion, Herald
epriestley added a comment to T6523: Allow creating/adding images to mocks with a vanilla upload control.

My plan is to put an on-hover (always available on mobile) edit icon on top of the thumbs on the edit UI, similar to how the interaction works on workboard cards:

May 25 2016, 4:48 PM · Prioritized, Pholio, Wikimedia
epriestley added a project to T6523: Allow creating/adding images to mocks with a vanilla upload control: Prioritized.
May 25 2016, 4:45 PM · Prioritized, Pholio, Wikimedia
epriestley added a project to T6916: Allow video embed in remarkup: Prioritized.
May 25 2016, 4:43 PM · Prioritized, Remarkup
epriestley added a comment to T6916: Allow video embed in remarkup.
  • We'll bring something similar to D11297 upstream.
  • T6674 discusses an issue where some mime types (notably, OGG) may ambiguously be audio or video. At a minimum, we'll provide {Fxxx, layout=video} or similar to force ambiguous types to render as a specific type. This may not really be much of a problem, but if we don't have an easy, reliable way to automatically detect whether a given .ogg file has video we aren't planning to put a tremendous amount of effort into detecting it correctly at this time.
May 25 2016, 4:43 PM · Prioritized, Remarkup
epriestley created T11035: Only evaluate newly added mentions/subscribers when applying transactions to remarkup blocks.
May 25 2016, 4:36 PM · Prioritized, Wikimedia, Remarkup
epriestley created T11034: Provide more information about projects, etc. in tokenizer browse dialog to make distinguishing between similar projects easier.
May 25 2016, 4:27 PM · Restricted Project, Design, Typeahead, Prioritized, Wikimedia
epriestley added a project to T3353: Make Phriction Document changes reviewable: Prioritized.
May 25 2016, 4:21 PM · Restricted Project, Prioritized, Phriction
epriestley added a project to T7643: Improve prose diffs (was: description changes don't generate usable diffs): Prioritized.
May 25 2016, 4:21 PM · Prioritized, Transactions
epriestley added a project to T4788: Allow "Edit Dependencies" both ways (blocking and depending): Prioritized.
May 25 2016, 4:21 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley added a project to T8510: Typeahead project proposals in Maniphest advanced search do not always include exact matches: Prioritized.
May 25 2016, 4:21 PM · Typeahead, Prioritized, Wikimedia, Infrastructure, Search