Removing commented out code
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Apr 9 2016
Apr 9 2016
lpriestley retitled D15665: First stab at a badges typeahead from to First stab at a badges typeahead.
Apr 7 2016
Apr 7 2016
Make badges searchable by name
lpriestley closed T10690: Allow badges to be searched by name, a subtask of T6526: Implement "Badges" or "Medals", for annotating special users, as Resolved.
lpriestley closed T10690: Allow badges to be searched by name as Resolved by committing rP1f423c3bd105: Make badges searchable by name.
lpriestley closed D15656: Make badges searchable by name by committing rP1f423c3bd105: Make badges searchable by name.
Removing obsolete method
lpriestley awarded C144: Dark Souls III Release a The World Burns token.
lpriestley added a revision to T10690: Allow badges to be searched by name: D15656: Make badges searchable by name.
Apr 5 2016
Apr 5 2016
lpriestley committed rP9518a1a9a642: Add `badges.edit` and `badges.search` to Conduit API (authored by lpriestley).
Add `badges.edit` and `badges.search` to Conduit API
Copy pasta
lpriestley added a comment to T10671: Implement `badges.search` and `badges.edit` Conduit API methods.
I expect two more diffs for this task: one for awarding/revoking badges in the badges.edit API call, and one for querying who awarded whom.
lpriestley retitled D15622: Add `badges.edit` and `badges.search` to Conduit API from to Add `badges.edit` and `badges.search` to Conduit API.
Apr 4 2016
Apr 4 2016
lpriestley added a comment to T10671: Implement `badges.search` and `badges.edit` Conduit API methods.
Yeah, I was pondering the award/revoke flow. PasteEditConduitAPIMethod is so bare bones as an example, and PhabricatorBadgesEditEngine is so different from other edit engines... I'm just not sure how that will hook into the badges edit API method.
lpriestley added a comment to T10671: Implement `badges.search` and `badges.edit` Conduit API methods.
Is there a reason, other than scope, why we're not implementing a badges.create Conduit API method? Or any of the other ones?
Apr 3 2016
Apr 3 2016
lpriestley committed rP88d15ce79910: Adding awarder info to recipient list on badge view (authored by lpriestley).
Adding awarder info to recipient list on badge view
lpriestley closed T8940: Annotate badges with awarder, date as Resolved by committing rP88d15ce79910: Adding awarder info to recipient list on badge view.
lpriestley retitled D15590: Adding awarder info to recipient list on badge view from to Adding awarder info to recipient list on badge view.
What's left is adding Awarded by ... to recipient list on badge view:
Fixing the badges query, yet again
redundundun
lpriestley retitled D15589: Fixing the badges query, yet again from to Fixing the badges query, yet again.
lpriestley committed rP219357aa9fa3: Adding awarder info to badge cards displayed on user profile pages (authored by lpriestley).
Adding awarder info to badge cards displayed on user profile pages
Apr 2 2016
Apr 2 2016
lpriestley added a comment to D15570: Adding awarder info to badge cards displayed on user profile pages.
Do you think that until we implement a custom behavior, that we could make that handle not appear as a link? Or is that too involved?
lpriestley added inline comments to D15570: Adding awarder info to badge cards displayed on user profile pages.
lpriestley added inline comments to D15570: Adding awarder info to badge cards displayed on user profile pages.
lpriestley updated the diff for D15570: Adding awarder info to badge cards displayed on user profile pages.
Fixing a regression - empty badges box if all badges are archived
lpriestley updated the diff for D15570: Adding awarder info to badge cards displayed on user profile pages.
Optimizing badges and awards queries to only fetch data that's relevant
lpriestley awarded D15567: Update Calendar Edit for new UI a Like token.
lpriestley added a comment to D15570: Adding awarder info to badge cards displayed on user profile pages.
This diff intentionally doesn't include the "recipient list on the badge page" part of this task:
lpriestley retitled D15570: Adding awarder info to badge cards displayed on user profile pages from to Adding awarder info to badge cards displayed on user profile pages.
Apr 1 2016
Apr 1 2016
We currently track awarderPHID in the badges_award table. Do we still need an awarderPHID in badges_badge table?
Allow ordering of badges by quality
Updating to shoddiness
cburroughs awarded T9007: Allow Badges to be ordered by quality a Manufacturing Defect? token.
Haha. Yes, well, you claim in another file that it was WoW colors. Get your story straight, @chad !
Did I get the colors wrong? I thought I copied them as they were...
lpriestley retitled D15555: Allow ordering of badges by quality from to Allow ordering of badges by quality.
Mar 31 2016
Mar 31 2016
lpriestley committed rP00425cac94d5: Converting badge quality property from color to an integer representation for… (authored by lpriestley).
Converting badge quality property from color to an integer representation for…
lpriestley updated the diff for D15551: Converting badge quality property from color to an integer representation for later sorting purposes.
Moving things around
lpriestley retitled D15551: Converting badge quality property from color to an integer representation for later sorting purposes from to Converting badge quality property from color to an integer representation for later sorting purposes.
Mar 30 2016
Mar 30 2016
This is done. Minor followup: T10698.
lpriestley committed rP0ea738f18fd2: Changing criteria for showing badges in object timeline view (authored by lpriestley).
Changing criteria for showing badges in object timeline view
lpriestley updated the task description for T10698: Comment previews should display user badges under the author's profile image..
Mar 29 2016
Mar 29 2016
Okay I agree that it would be nice to show badges under all instance of the profile image if it has the appropriate size.
lpriestley committed rP8d67629e9ec0: Fix translation of badge feed stories. (authored by lpriestley).
Fix translation of badge feed stories.
lpriestley closed T10688: Badge translation error as Resolved by committing rP8d67629e9ec0: Fix translation of badge feed stories..
Also... I added Chad this time
lpriestley retitled D15547: Fix translation of badge feed stories. from to Fix translation of badge feed stories..
lpriestley added a revision to T10688: Badge translation error: D15547: Fix translation of badge feed stories..
How do I reproduce this error?
Mar 28 2016
Mar 28 2016
What is your reasoning for wanting to show badges in previews?
lpriestley updated the diff for D15543: Changing criteria for showing badges in object timeline view.
Switching to local variable
lpriestley updated the diff for D15543: Changing criteria for showing badges in object timeline view.
Not sure why this works better, but moved the badge-showing logic to the event view
Are you sure the profile image in the preview should have badges? Depending on the timing and on other things happening with the object, the preview won't be able to predict if it's a major event or not...
lpriestley added inline comments to D15543: Changing criteria for showing badges in object timeline view.
lpriestley added inline comments to D15543: Changing criteria for showing badges in object timeline view.
lpriestley retitled D15543: Changing criteria for showing badges in object timeline view from to Changing criteria for showing badges in object timeline view.
lpriestley committed rP878b9413091c: Show "no badges" text in people profiles with archived badges only (authored by lpriestley).
Show "no badges" text in people profiles with archived badges only
lpriestley updated the diff for D15538: Show "no badges" text in people profiles with archived badges only.
empty $badges should be of type array
lpriestley retitled D15538: Show "no badges" text in people profiles with archived badges only from to Show "no badges" text in people profiles with archived badges only.
Closing this, because it seems to be done, the way the title is written. All other related plans have their own tasks.
lpriestley closed T8996: Move Badge awards to be an actual object, not an edge, a subtask of T8940: Annotate badges with awarder, date, as Resolved.
Pretty sure I covered all the badge transactions.
lpriestley committed rPa4270e5413b4: Archiving badge needs meaningful Badge timeline event title (authored by lpriestley).
Archiving badge needs meaningful Badge timeline event title
lpriestley retitled D15536: Archiving badge needs meaningful Badge timeline event title from to Archiving badge needs meaningful Badge timeline event title.