Page MenuHomePhabricator

First stab at a badges typeahead
ClosedPublic

Authored by lpriestley on Apr 9 2016, 6:41 PM.

Details

Summary

Ref T10702

Test Plan

Open a user profile, attempt to award an archived or previously awarded badge, badges dialog should provide a typeahead, and the suggestions should offer details about whether a badge is archived or already awarded.

Diff Detail

Repository
rP Phabricator
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

lpriestley updated this revision to Diff 37751.Apr 9 2016, 6:41 PM
lpriestley retitled this revision from to First stab at a badges typeahead.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley updated this revision to Diff 37753.Apr 9 2016, 6:56 PM
lpriestley edited edge metadata.

Removing commented out code

epriestley accepted this revision.Apr 9 2016, 7:42 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/badges/controller/PhabricatorBadgesAwardController.php
20–21

For consistency, maybe rename this to badgePHIDs since it's a list now.

src/applications/badges/typeahead/PhabricatorBadgesDatasource.php
28

This will load some extra data we don't need. Use a separate awardquery to just fetch awards to the recipient instead.

This revision is now accepted and ready to land.Apr 9 2016, 7:42 PM
lpriestley updated this revision to Diff 37789.Apr 11 2016, 5:32 PM
lpriestley marked 2 inline comments as done.
lpriestley edited edge metadata.

Specifying awards query in badges datasource

This revision was automatically updated to reflect the committed changes.