Page MenuHomePhabricator

First stab at a badges typeahead
ClosedPublic

Authored by lpriestley on Apr 9 2016, 6:41 PM.
Tags
None
Referenced Files
F18032643: D15665.id37789.diff
Sun, Aug 3, 12:29 AM
F17957450: D15665.diff
Fri, Aug 1, 6:17 AM
F17899789: D15665.id37751.diff
Tue, Jul 29, 8:45 AM
Unknown Object (File)
Jul 4 2025, 12:17 AM
Unknown Object (File)
Jun 16 2025, 12:49 AM
Unknown Object (File)
Jun 15 2025, 11:37 PM
Unknown Object (File)
Jun 1 2025, 7:05 PM
Unknown Object (File)
May 30 2025, 11:08 PM
Subscribers

Details

Summary

Ref T10702

Test Plan

Open a user profile, attempt to award an archived or previously awarded badge, badges dialog should provide a typeahead, and the suggestions should offer details about whether a badge is archived or already awarded.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley retitled this revision from to First stab at a badges typeahead.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley edited edge metadata.

Removing commented out code

epriestley edited edge metadata.
epriestley added inline comments.
src/applications/badges/controller/PhabricatorBadgesAwardController.php
20–21

For consistency, maybe rename this to badgePHIDs since it's a list now.

src/applications/badges/typeahead/PhabricatorBadgesDatasource.php
28

This will load some extra data we don't need. Use a separate awardquery to just fetch awards to the recipient instead.

This revision is now accepted and ready to land.Apr 9 2016, 7:42 PM
lpriestley marked 2 inline comments as done.
lpriestley edited edge metadata.

Specifying awards query in badges datasource

This revision was automatically updated to reflect the committed changes.