Paths

Table of Contentst

Differential D15555

Allow ordering of badges by quality
ClosedPublic
Actions

Authored by lpriestley on Apr 1 2016, 12:06 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T9007: Allow Badges to be ordered by quality

Commits

rP7a6acd57faac: Allow ordering of badges by quality

Summary

Ref T9007

Test Plan

Navigate to "Advanced Search" in Badges, order by rarity, then by commonality. Rarest and most common badges should be ordered, respectively.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 37506.Apr 1 2016, 12:06 AM

lpriestley retitled this revision from to Allow ordering of badges by quality.

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T9007: Allow Badges to be ordered by quality.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 1 2016, 12:06 AM

Herald added a subscriber: Korvin. · View Herald Transcript

epriestley accepted this revision.Apr 1 2016, 12:32 AM

epriestley edited edge metadata.

epriestley added inline comments.

src/applications/badges/query/PhabricatorBadgesQuery.php
114	Maybe `'shoddiness'`? :3
127	This one should just be `int`.
128	(You can omit this if you want, `false` is the default.)

This revision is now accepted and ready to land.Apr 1 2016, 12:32 AM

Updating to shoddiness

Closed by commit rP7a6acd57faac: Allow ordering of badges by quality (authored by lpriestley, committed by lpriestley). · Explain WhyApr 1 2016, 7:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

badges/

query/

PhabricatorBadgesQuery.php

32 lines

Diff 37523

View Options

src/applications/badges/query/PhabricatorBadgesQuery.php

Allow ordering of badges by qualityClosedPublicActions