So this would work in theory, but the problem is that the buildNavigation() method in PhabricatorProfileMenuEngine.php is called twice. The first time, the selection is properly set, but the second time around, it's reset back to the original buggy behavior. Wanted to know if I'm generally in the right direction or if I should pivot before it's too late.
Feed Advanced Search
Feb 5 2019
Feb 5 2019
spawnlt awarded T7930: Let Calendar provide date services to other applications a Party Time token.
Nov 20 2018
Nov 20 2018
clemvangelis awarded T7930: Let Calendar provide date services to other applications a Like token.
Jan 8 2018
Jan 8 2018
mpadourek awarded T7930: Let Calendar provide date services to other applications a Like token.
Dec 7 2017
Dec 7 2017
lpriestley added a comment to D18821: WIP Menu item that is a link to a state of a builtin menu item should display consistent selection behavior.
Dec 5 2017
Dec 5 2017
lpriestley committed rP46d496b8cc06: Fix error for URL's that could mean several commits (authored by lpriestley).
Fix error for URL's that could mean several commits
lpriestley updated the diff for D18816: Fix error for URL's that could mean several commits.
Make ambiguous commit identifier bold in the warning message
epriestley awarded D18816: Fix error for URL's that could mean several commits a Dat Boi token.
Dec 4 2017
Dec 4 2017
lpriestley added a comment to D18816: Fix error for URL's that could mean several commits.
- The commit identifier in the warning message isn't bold... should it be?
- The repository/branch in the crumbs isn't a link... should it be? I looked at the crumbs code a bit and I think I'd have to add a new parameter to pass to crumbs so that we can have a link without a branch appended to it.
lpriestley updated the diff for D18816: Fix error for URL's that could mean several commits.
Conforming to best practices for commit lists
Dec 3 2017
Dec 3 2017
lpriestley requested review of D18816: Fix error for URL's that could mean several commits.
Dec 1 2017
Dec 1 2017
lpriestley committed rP42034e6739eb: Property list view on Diffusion commits should show build status but not… (authored by lpriestley).
Property list view on Diffusion commits should show build status but not…
Nov 30 2017
Nov 30 2017
Nov 28 2017
Nov 28 2017
lpriestley added a comment to T12544: Cannot add invitees to all future instances of a recurring event.
@epriestley what do you think of creating another column in the calendar_eventinvitee table, something like a bool futureStatus so that when we get a list of invitees back, we can check for that flag. I think this would mean a lot of date comparisons (seems inefficient), and I'm not quite sure when to populate event stubs. For example, if the futureStatus flag is set to true for instance 10, and there are stubs for instances 15 and 20, when would 15 and 20 get converted to have the updated status?
lpriestley requested review of D18803: Fixes T13026, Makes recurring event stubs inherit host's RSVP status.
Aug 25 2017
Aug 25 2017
shandor awarded T7930: Let Calendar provide date services to other applications a Party Time token.
Mar 28 2017
Mar 28 2017
johnny-bit awarded T6049: Implement Phurl, a URL shortener/bookmarking application a Love token.
Feb 12 2017
Feb 12 2017
johnny-bit awarded T7930: Let Calendar provide date services to other applications a Love token.
Feb 3 2017
Feb 3 2017
friesenschrauber awarded T7930: Let Calendar provide date services to other applications a Love token.
Feb 2 2017
Feb 2 2017
jayaura awarded T7930: Let Calendar provide date services to other applications a Love token.
Nov 29 2016
Nov 29 2016
cguenther awarded T7930: Let Calendar provide date services to other applications a Love token.
Nov 3 2016
Nov 3 2016
rencris awarded T7930: Let Calendar provide date services to other applications a Love token.
May 23 2016
May 23 2016
lpriestley committed rP627b95bf78d3: Remove calendar panel in profile and make calendar box header a link to… (authored by lpriestley).
Remove calendar panel in profile and make calendar box header a link to…
lpriestley retitled D15967: Remove calendar panel in profile and make calendar box header a link to user's calendar from to Remove calendar panel in profile and make calendar box header a link to user's calendar.
lpriestley committed rP359e8d4aa59e: Hover hint on calendar list items should appear on the most convenient side… (authored by lpriestley).
Hover hint on calendar list items should appear on the most convenient side…
lpriestley committed rPde645301b57f: Adding a calendar preview panel to people profile (authored by lpriestley).
Adding a calendar preview panel to people profile
lpriestley retitled D15964: Hover hint on calendar list items should appear on the most convenient side of the item from to Hover hint on calendar list items should appear on the most convenient side of the item.
lpriestley updated the diff for D15851: Adding a calendar preview panel to people profile.
Query for events that were not cancelled instead of filtering out cancelled events later.
lpriestley added a comment to D15851: Adding a calendar preview panel to people profile.
This fixed the border on the panel:
but this means that the week panel in day view is going to be max width. Personally, I think it looks okay, but maybe there's a reason not to do this?
lpriestley updated the diff for D15851: Adding a calendar preview panel to people profile.
Css change to make week preview on day view border better
May 5 2016
May 5 2016
lpriestley updated the diff for D15851: Adding a calendar preview panel to people profile.
This particular change was for testing and doesn't seem right anyways.
lpriestley retitled D15851: Adding a calendar preview panel to people profile from to Adding a calendar preview panel to people profile.
Apr 21 2016
Apr 21 2016
lpriestley committed rPbd8969a23cd9: Calendar event list items 'Attending:' field should only show users who have… (authored by lpriestley).
Calendar event list items 'Attending:' field should only show users who have…
lpriestley retitled D15779: Calendar event list items 'Attending:' field should only show users who have confirmed attendance from to Calendar event list items 'Attending:' field should only show users who have confirmed attendance.
peter.schlaile awarded T7931: Create Calendar triggers which notify users before meetings a Like token.
Apr 20 2016
Apr 20 2016
lpriestley added a comment to T8897: "Attending" in Calendar list view shows all users, not just attending users.
A few possible directions:
lpriestley committed rPd9275da2d4bd: Better wording for cancelling/reinstating recurring events (authored by lpriestley).
Better wording for cancelling/reinstating recurring events
lpriestley retitled D15770: Better wording for cancelling/reinstating recurring events from to Better wording for cancelling/reinstating recurring events.
lpriestley added a comment to T10744: Parent event has "Cancel Recurrence" action, but should say "Cancel All Recurrences" or similar.
Yeah, I think the dialog should clarify.
lpriestley added a comment to T10744: Parent event has "Cancel Recurrence" action, but should say "Cancel All Recurrences" or similar.
I just think it might not look pretty on standard resolutions (like my Mac)
lpriestley added a comment to T10744: Parent event has "Cancel Recurrence" action, but should say "Cancel All Recurrences" or similar.
Alternatively, we can make reinstating a series un-cancel all cancelled instances. That would make some sense to me.
lpriestley added a comment to T10744: Parent event has "Cancel Recurrence" action, but should say "Cancel All Recurrences" or similar.
"Cancel All Recurrences" works because it will keep already cancelled instances that way. When you reinstate the series, all the individually cancelled instances won't be un-cancelled, so "Reinstate All Instances" doesn't really cover it. It should be more like "Reinstate All Previously Un-cancelled Instances". How would we put that succinctly?
lpriestley committed rPeeccaf99b6cd: When scrolling forward a month in calendar date picker from 1/31, next chosen… (authored by lpriestley).
When scrolling forward a month in calendar date picker from 1/31, next chosen…
lpriestley updated the diff for D15727: When scrolling forward a month in calendar date picker from 1/31, next chosen date should be 2/29, not 3/1..
celerity
Apr 15 2016
Apr 15 2016
lpriestley updated the diff for D15727: When scrolling forward a month in calendar date picker from 1/31, next chosen date should be 2/29, not 3/1..
cleanup
lpriestley retitled D15727: When scrolling forward a month in calendar date picker from 1/31, next chosen date should be 2/29, not 3/1. from to When scrolling forward a month in calendar date picker from 1/31, next chosen date should be 2/29, not 3/1..
lpriestley committed rP42a877622859: Time controls should format end date value correctly (not 5:0 PM) (authored by lpriestley).
Time controls should format end date value correctly (not 5:0 PM)
lpriestley updated the diff for D15725: Time controls should format end date value correctly (not 5:0 PM).
celery sticks
lpriestley added inline comments to D15725: Time controls should format end date value correctly (not 5:0 PM).
lpriestley updated the diff for D15725: Time controls should format end date value correctly (not 5:0 PM).
oops, wrong direction
lpriestley retitled D15725: Time controls should format end date value correctly (not 5:0 PM) from to Time controls should format end date value correctly (not 5:0 PM).
lpriestley committed rP7b27653f5714: Fixing UI Example that use badge qualities (authored by lpriestley).
Fixing UI Example that use badge qualities
lpriestley closed T10706: Update old badge quality constants in PHUIBadgeExample, a subtask of T6526: Implement "Badges" or "Medals", for annotating special users, as Resolved.
lpriestley closed T10706: Update old badge quality constants in PHUIBadgeExample as Resolved by committing rP7b27653f5714: Fixing UI Example that use badge qualities.
lpriestley retitled D15723: Fixing UI Example that use badge qualities from to Fixing UI Example that use badge qualities.
lpriestley committed rP899856a1d41b: Links on badge card should be accessible (authored by lpriestley).
Links on badge card should be accessible
Apr 14 2016
Apr 14 2016
slashsBin awarded T7924: Unprototype Calendar (v1) a Love token.
Apr 13 2016
Apr 13 2016
lpriestley updated the diff for D15699: Links on badge card should be accessible.
Fixing where new behavior is initialized
lpriestley updated the diff for D15699: Links on badge card should be accessible.
Correct way to specify the link color for badge view?
lpriestley retitled D15699: Links on badge card should be accessible from to Links on badge card should be accessible.
Apr 11 2016
Apr 11 2016
First stab at a badges typeahead
lpriestley updated the diff for D15665: First stab at a badges typeahead.
Specifying awards query in badges datasource