Page MenuHomePhabricator
Feed Advanced Search

Feb 5 2019

spawnlt awarded T7930: Let Calendar provide date services to other applications a Party Time token.
Feb 5 2019, 9:32 AM · Calendar

Nov 20 2018

clemvangelis awarded T7930: Let Calendar provide date services to other applications a Like token.
Nov 20 2018, 8:45 AM · Calendar

Jan 8 2018

mpadourek awarded T7930: Let Calendar provide date services to other applications a Like token.
Jan 8 2018, 10:42 AM · Calendar

Dec 7 2017

lpriestley added a comment to D18821: WIP Menu item that is a link to a state of a builtin menu item should display consistent selection behavior.

So this would work in theory, but the problem is that the buildNavigation() method in PhabricatorProfileMenuEngine.php is called twice. The first time, the selection is properly set, but the second time around, it's reset back to the original buggy behavior. Wanted to know if I'm generally in the right direction or if I should pivot before it's too late.

Dec 7 2017, 10:21 PM
lpriestley requested review of D18821: WIP Menu item that is a link to a state of a builtin menu item should display consistent selection behavior.
Dec 7 2017, 10:19 PM
lpriestley added a revision to T12949: If a ProfileMenu has Link items, and one or more have the request URI as the link target, highlight the first one: D18821: WIP Menu item that is a link to a state of a builtin menu item should display consistent selection behavior.
Dec 7 2017, 10:18 PM · Dashboards

Dec 5 2017

lpriestley created T13028: Crumbs on a page that shows options for an ambiguous commit identifier should link to the repository.
Dec 5 2017, 7:39 PM · Diffusion
lpriestley committed rP46d496b8cc06: Fix error for URL's that could mean several commits (authored by lpriestley).
Fix error for URL's that could mean several commits
Dec 5 2017, 7:25 PM
lpriestley closed D18816: Fix error for URL's that could mean several commits.
Dec 5 2017, 7:25 PM
lpriestley updated the diff for D18816: Fix error for URL's that could mean several commits.

Make ambiguous commit identifier bold in the warning message

Dec 5 2017, 7:22 PM
epriestley awarded D18816: Fix error for URL's that could mean several commits a Dat Boi token.
Dec 5 2017, 2:36 PM

Dec 4 2017

lpriestley added a comment to D18816: Fix error for URL's that could mean several commits.
  • The commit identifier in the warning message isn't bold... should it be?
  • The repository/branch in the crumbs isn't a link... should it be? I looked at the crumbs code a bit and I think I'd have to add a new parameter to pass to crumbs so that we can have a link without a branch appended to it.
Dec 4 2017, 7:30 PM
lpriestley updated the diff for D18816: Fix error for URL's that could mean several commits.

Conforming to best practices for commit lists

Dec 4 2017, 7:28 PM

Dec 3 2017

lpriestley requested review of D18816: Fix error for URL's that could mean several commits.
Dec 3 2017, 8:27 PM
lpriestley added a revision to T13001: Ambiguous commits should prompt you to select from options: D18816: Fix error for URL's that could mean several commits.
Dec 3 2017, 8:26 PM · Diffusion

Dec 1 2017

lpriestley committed rP42034e6739eb: Property list view on Diffusion commits should show build status but not… (authored by lpriestley).
Property list view on Diffusion commits should show build status but not…
Dec 1 2017, 6:16 PM
lpriestley closed D18813: Property list view on Diffusion commits should show build status but not Subscriptions, Projects, or Tokens.
Dec 1 2017, 6:16 PM

Nov 30 2017

lpriestley updated the summary of D18813: Property list view on Diffusion commits should show build status but not Subscriptions, Projects, or Tokens.
Nov 30 2017, 10:48 PM
lpriestley requested review of D18813: Property list view on Diffusion commits should show build status but not Subscriptions, Projects, or Tokens.
Nov 30 2017, 9:57 PM
lpriestley added a revision to T13019: Build Status is integrated into Diffusion in a hacky way: D18813: Property list view on Diffusion commits should show build status but not Subscriptions, Projects, or Tokens.
Nov 30 2017, 9:56 PM · Diffusion, Harbormaster

Nov 28 2017

lpriestley added a comment to T12544: Cannot add invitees to all future instances of a recurring event.

@epriestley what do you think of creating another column in the calendar_eventinvitee table, something like a bool futureStatus so that when we get a list of invitees back, we can check for that flag. I think this would mean a lot of date comparisons (seems inefficient), and I'm not quite sure when to populate event stubs. For example, if the futureStatus flag is set to true for instance 10, and there are stubs for instances 15 and 20, when would 15 and 20 get converted to have the updated status?

Nov 28 2017, 11:16 PM · Calendar, Bug Report
lpriestley added a task to D18803: Fixes T13026, Makes recurring event stubs inherit host's RSVP status: T13026: Stubs of recurring Calendar events should inherit the host's RSVP status.
Nov 28 2017, 9:03 PM
lpriestley added a revision to T13026: Stubs of recurring Calendar events should inherit the host's RSVP status: D18803: Fixes T13026, Makes recurring event stubs inherit host's RSVP status.
Nov 28 2017, 9:03 PM · Calendar
lpriestley requested review of D18803: Fixes T13026, Makes recurring event stubs inherit host's RSVP status.
Nov 28 2017, 9:02 PM
lpriestley created T13026: Stubs of recurring Calendar events should inherit the host's RSVP status.
Nov 28 2017, 8:56 PM · Calendar

Aug 25 2017

shandor awarded T7930: Let Calendar provide date services to other applications a Party Time token.
Aug 25 2017, 11:24 AM · Calendar

Mar 28 2017

johnny-bit awarded T6049: Implement Phurl, a URL shortener/bookmarking application a Love token.
Mar 28 2017, 7:59 PM · Phurl

Feb 12 2017

johnny-bit awarded T7930: Let Calendar provide date services to other applications a Love token.
Feb 12 2017, 10:35 AM · Calendar

Feb 3 2017

friesenschrauber awarded T7930: Let Calendar provide date services to other applications a Love token.
Feb 3 2017, 7:28 PM · Calendar

Feb 2 2017

jayaura awarded T7930: Let Calendar provide date services to other applications a Love token.
Feb 2 2017, 6:15 PM · Calendar

Nov 29 2016

cguenther awarded T7930: Let Calendar provide date services to other applications a Love token.
Nov 29 2016, 1:10 AM · Calendar

Nov 3 2016

rencris awarded T7930: Let Calendar provide date services to other applications a Love token.
Nov 3 2016, 7:08 PM · Calendar

May 23 2016

lpriestley committed rP627b95bf78d3: Remove calendar panel in profile and make calendar box header a link to… (authored by lpriestley).
Remove calendar panel in profile and make calendar box header a link to…
May 23 2016, 6:33 PM
lpriestley closed D15967: Remove calendar panel in profile and make calendar box header a link to user's calendar by committing rP627b95bf78d3: Remove calendar panel in profile and make calendar box header a link to….
May 23 2016, 6:33 PM
lpriestley added a revision to T9606: "Calendar" tab on user profiles is pretty junky: D15967: Remove calendar panel in profile and make calendar box header a link to user's calendar.
May 23 2016, 6:20 PM · Calendar
lpriestley retitled D15967: Remove calendar panel in profile and make calendar box header a link to user's calendar from to Remove calendar panel in profile and make calendar box header a link to user's calendar.
May 23 2016, 6:20 PM
lpriestley committed rP359e8d4aa59e: Hover hint on calendar list items should appear on the most convenient side… (authored by lpriestley).
Hover hint on calendar list items should appear on the most convenient side…
May 23 2016, 5:49 PM
lpriestley closed D15964: Hover hint on calendar list items should appear on the most convenient side of the item by committing rP359e8d4aa59e: Hover hint on calendar list items should appear on the most convenient side….
May 23 2016, 5:49 PM
lpriestley committed rPde645301b57f: Adding a calendar preview panel to people profile (authored by lpriestley).
Adding a calendar preview panel to people profile
May 23 2016, 5:39 PM
lpriestley closed D15851: Adding a calendar preview panel to people profile by committing rPde645301b57f: Adding a calendar preview panel to people profile.
May 23 2016, 5:39 PM
lpriestley added a revision to T9606: "Calendar" tab on user profiles is pretty junky: D15964: Hover hint on calendar list items should appear on the most convenient side of the item.
May 23 2016, 5:28 PM · Calendar
lpriestley added a task to D15964: Hover hint on calendar list items should appear on the most convenient side of the item: T9606: "Calendar" tab on user profiles is pretty junky.
May 23 2016, 5:28 PM
lpriestley retitled D15964: Hover hint on calendar list items should appear on the most convenient side of the item from to Hover hint on calendar list items should appear on the most convenient side of the item.
May 23 2016, 5:26 PM
lpriestley updated the diff for D15851: Adding a calendar preview panel to people profile.

Query for events that were not cancelled instead of filtering out cancelled events later.

May 23 2016, 4:46 PM
lpriestley added a comment to D15851: Adding a calendar preview panel to people profile.

This fixed the border on the panel:

Screen Shot 2016-05-23 at 9.38.34 AM.png (495×385 px, 25 KB)

but this means that the week panel in day view is going to be max width. Personally, I think it looks okay, but maybe there's a reason not to do this?
Screen Shot 2016-05-23 at 9.38.17 AM.png (781×1 px, 77 KB)

May 23 2016, 4:42 PM
lpriestley updated the diff for D15851: Adding a calendar preview panel to people profile.

Css change to make week preview on day view border better

May 23 2016, 4:41 PM

May 5 2016

lpriestley updated the diff for D15851: Adding a calendar preview panel to people profile.

This particular change was for testing and doesn't seem right anyways.

May 5 2016, 4:21 PM
lpriestley retitled D15851: Adding a calendar preview panel to people profile from to Adding a calendar preview panel to people profile.
May 5 2016, 4:17 PM
lpriestley added a revision to T9606: "Calendar" tab on user profiles is pretty junky: D15851: Adding a calendar preview panel to people profile.
May 5 2016, 4:17 PM · Calendar

Apr 21 2016

lpriestley committed rPbd8969a23cd9: Calendar event list items 'Attending:' field should only show users who have… (authored by lpriestley).
Calendar event list items 'Attending:' field should only show users who have…
Apr 21 2016, 6:12 PM
lpriestley closed T8897: "Attending" in Calendar list view shows all users, not just attending users as Resolved by committing rPbd8969a23cd9: Calendar event list items 'Attending:' field should only show users who have….
Apr 21 2016, 6:11 PM · Calendar
lpriestley closed D15779: Calendar event list items 'Attending:' field should only show users who have confirmed attendance by committing rPbd8969a23cd9: Calendar event list items 'Attending:' field should only show users who have….
Apr 21 2016, 6:11 PM
lpriestley retitled D15779: Calendar event list items 'Attending:' field should only show users who have confirmed attendance from to Calendar event list items 'Attending:' field should only show users who have confirmed attendance.
Apr 21 2016, 5:21 PM
lpriestley added a revision to T8897: "Attending" in Calendar list view shows all users, not just attending users: D15779: Calendar event list items 'Attending:' field should only show users who have confirmed attendance.
Apr 21 2016, 5:21 PM · Calendar
peter.schlaile awarded T7931: Create Calendar triggers which notify users before meetings a Like token.
Apr 21 2016, 11:39 AM · Calendar

Apr 20 2016

lpriestley added a comment to T8897: "Attending" in Calendar list view shows all users, not just attending users.

A few possible directions:

Apr 20 2016, 6:19 PM · Calendar
lpriestley committed rPd9275da2d4bd: Better wording for cancelling/reinstating recurring events (authored by lpriestley).
Better wording for cancelling/reinstating recurring events
Apr 20 2016, 5:11 PM
lpriestley closed T10744: Parent event has "Cancel Recurrence" action, but should say "Cancel All Recurrences" or similar as Resolved by committing rPd9275da2d4bd: Better wording for cancelling/reinstating recurring events.
Apr 20 2016, 5:11 PM · Calendar
lpriestley closed D15770: Better wording for cancelling/reinstating recurring events by committing rPd9275da2d4bd: Better wording for cancelling/reinstating recurring events.
Apr 20 2016, 5:11 PM
lpriestley retitled D15770: Better wording for cancelling/reinstating recurring events from to Better wording for cancelling/reinstating recurring events.
Apr 20 2016, 4:54 PM
lpriestley added a revision to T10744: Parent event has "Cancel Recurrence" action, but should say "Cancel All Recurrences" or similar: D15770: Better wording for cancelling/reinstating recurring events.
Apr 20 2016, 4:54 PM · Calendar
lpriestley added a comment to T10744: Parent event has "Cancel Recurrence" action, but should say "Cancel All Recurrences" or similar.

Yeah, I think the dialog should clarify.

Apr 20 2016, 4:36 PM · Calendar
lpriestley added a comment to T10744: Parent event has "Cancel Recurrence" action, but should say "Cancel All Recurrences" or similar.

I just think it might not look pretty on standard resolutions (like my Mac)

Apr 20 2016, 4:35 PM · Calendar
lpriestley added a comment to T10744: Parent event has "Cancel Recurrence" action, but should say "Cancel All Recurrences" or similar.

Alternatively, we can make reinstating a series un-cancel all cancelled instances. That would make some sense to me.

Apr 20 2016, 4:32 PM · Calendar
lpriestley added a comment to T10744: Parent event has "Cancel Recurrence" action, but should say "Cancel All Recurrences" or similar.

"Cancel All Recurrences" works because it will keep already cancelled instances that way. When you reinstate the series, all the individually cancelled instances won't be un-cancelled, so "Reinstate All Instances" doesn't really cover it. It should be more like "Reinstate All Previously Un-cancelled Instances". How would we put that succinctly?

Apr 20 2016, 4:30 PM · Calendar
lpriestley committed rPeeccaf99b6cd: When scrolling forward a month in calendar date picker from 1/31, next chosen… (authored by lpriestley).
When scrolling forward a month in calendar date picker from 1/31, next chosen…
Apr 20 2016, 4:16 PM
lpriestley closed D15727: When scrolling forward a month in calendar date picker from 1/31, next chosen date should be 2/29, not 3/1. by committing rPeeccaf99b6cd: When scrolling forward a month in calendar date picker from 1/31, next chosen….
Apr 20 2016, 4:15 PM
lpriestley closed T9295: Date chooser picket fence issue with next month as Resolved by committing rPeeccaf99b6cd: When scrolling forward a month in calendar date picker from 1/31, next chosen….
Apr 20 2016, 4:15 PM · Calendar
lpriestley updated the diff for D15727: When scrolling forward a month in calendar date picker from 1/31, next chosen date should be 2/29, not 3/1..

celerity

Apr 20 2016, 4:15 PM

Apr 15 2016

lpriestley updated the diff for D15727: When scrolling forward a month in calendar date picker from 1/31, next chosen date should be 2/29, not 3/1..

cleanup

Apr 15 2016, 8:55 PM
lpriestley retitled D15727: When scrolling forward a month in calendar date picker from 1/31, next chosen date should be 2/29, not 3/1. from to When scrolling forward a month in calendar date picker from 1/31, next chosen date should be 2/29, not 3/1..
Apr 15 2016, 8:54 PM
lpriestley added a revision to T9295: Date chooser picket fence issue with next month: D15727: When scrolling forward a month in calendar date picker from 1/31, next chosen date should be 2/29, not 3/1..
Apr 15 2016, 8:54 PM · Calendar
lpriestley committed rP42a877622859: Time controls should format end date value correctly (not 5:0 PM) (authored by lpriestley).
Time controls should format end date value correctly (not 5:0 PM)
Apr 15 2016, 7:18 PM
lpriestley closed D15725: Time controls should format end date value correctly (not 5:0 PM) by committing rP42a877622859: Time controls should format end date value correctly (not 5:0 PM).
Apr 15 2016, 7:18 PM
lpriestley closed T9296: Default "one hour jump" logic not formatted correctly as Resolved by committing rP42a877622859: Time controls should format end date value correctly (not 5:0 PM).
Apr 15 2016, 7:18 PM · Calendar
lpriestley updated the diff for D15725: Time controls should format end date value correctly (not 5:0 PM).

celery sticks

Apr 15 2016, 7:17 PM
lpriestley added inline comments to D15725: Time controls should format end date value correctly (not 5:0 PM).
Apr 15 2016, 7:17 PM
lpriestley updated the diff for D15725: Time controls should format end date value correctly (not 5:0 PM).

oops, wrong direction

Apr 15 2016, 7:12 PM
lpriestley retitled D15725: Time controls should format end date value correctly (not 5:0 PM) from to Time controls should format end date value correctly (not 5:0 PM).
Apr 15 2016, 7:11 PM
lpriestley added a revision to T9296: Default "one hour jump" logic not formatted correctly: D15725: Time controls should format end date value correctly (not 5:0 PM).
Apr 15 2016, 7:11 PM · Calendar
lpriestley committed rP7b27653f5714: Fixing UI Example that use badge qualities (authored by lpriestley).
Fixing UI Example that use badge qualities
Apr 15 2016, 6:06 PM
lpriestley closed T10706: Update old badge quality constants in PHUIBadgeExample, a subtask of T6526: Implement "Badges" or "Medals", for annotating special users, as Resolved.
Apr 15 2016, 6:05 PM · Restricted Project, Badges (v0), People
lpriestley closed T10706: Update old badge quality constants in PHUIBadgeExample as Resolved by committing rP7b27653f5714: Fixing UI Example that use badge qualities.
Apr 15 2016, 6:05 PM · Badges (v0)
lpriestley closed D15723: Fixing UI Example that use badge qualities by committing rP7b27653f5714: Fixing UI Example that use badge qualities.
Apr 15 2016, 6:05 PM
lpriestley retitled D15723: Fixing UI Example that use badge qualities from to Fixing UI Example that use badge qualities.
Apr 15 2016, 5:52 PM
lpriestley added a revision to T10706: Update old badge quality constants in PHUIBadgeExample: D15723: Fixing UI Example that use badge qualities.
Apr 15 2016, 5:52 PM · Badges (v0)
lpriestley closed T10710: Badge cards that use `PHUIBadgeView` should not flip the card if a link on the card is clicked, a subtask of T6526: Implement "Badges" or "Medals", for annotating special users, as Resolved.
Apr 15 2016, 2:56 PM · Restricted Project, Badges (v0), People
lpriestley closed T10710: Badge cards that use `PHUIBadgeView` should not flip the card if a link on the card is clicked as Resolved.
Apr 15 2016, 2:56 PM · Badges (v0)
lpriestley committed rP899856a1d41b: Links on badge card should be accessible (authored by lpriestley).
Links on badge card should be accessible
Apr 15 2016, 2:55 PM
lpriestley closed D15699: Links on badge card should be accessible by committing rP899856a1d41b: Links on badge card should be accessible.
Apr 15 2016, 2:55 PM

Apr 14 2016

slashsBin awarded T7924: Unprototype Calendar (v1) a Love token.
Apr 14 2016, 6:38 PM · Restricted Project, Prioritized, Calendar

Apr 13 2016

lpriestley updated the diff for D15699: Links on badge card should be accessible.

Fixing where new behavior is initialized

Apr 13 2016, 6:48 PM
lpriestley updated the diff for D15699: Links on badge card should be accessible.

Correct way to specify the link color for badge view?

Apr 13 2016, 6:31 PM
lpriestley added a revision to T10710: Badge cards that use `PHUIBadgeView` should not flip the card if a link on the card is clicked: D15699: Links on badge card should be accessible.
Apr 13 2016, 4:32 PM · Badges (v0)
lpriestley retitled D15699: Links on badge card should be accessible from to Links on badge card should be accessible.
Apr 13 2016, 4:32 PM

Apr 11 2016

lpriestley closed T10702: "Award Badge" action on user profiles should use a typeahead for badge selection as Resolved.
Apr 11 2016, 9:14 PM · Badges (v0)
lpriestley closed T10702: "Award Badge" action on user profiles should use a typeahead for badge selection, a subtask of T6526: Implement "Badges" or "Medals", for annotating special users, as Resolved.
Apr 11 2016, 9:14 PM · Restricted Project, Badges (v0), People
lpriestley committed rP85d2fda08259: First stab at a badges typeahead (authored by lpriestley).
First stab at a badges typeahead
Apr 11 2016, 5:33 PM
lpriestley closed D15665: First stab at a badges typeahead by committing rP85d2fda08259: First stab at a badges typeahead.
Apr 11 2016, 5:33 PM
lpriestley updated the diff for D15665: First stab at a badges typeahead.

Specifying awards query in badges datasource

Apr 11 2016, 5:32 PM