Page MenuHomePhabricator

Make badges searchable by name
ClosedPublic

Authored by lpriestley on Apr 7 2016, 7:13 PM.
Tags
None
Referenced Files
F13471995: D15656.diff
Wed, Jul 17, 9:56 AM
F13457545: D15656.id37731.diff
Sun, Jul 14, 6:39 PM
F13449360: D15656.diff
Sat, Jul 13, 7:09 AM
F13443048: D15656.id37729.diff
Fri, Jul 12, 6:07 PM
F13440810: D15656.id37729.diff
Fri, Jul 12, 8:24 AM
F13429971: D15656.diff
Wed, Jul 10, 4:52 AM
F13419289: D15656.diff
Mon, Jul 8, 2:34 AM
F13399055: D15656.diff
Thu, Jul 4, 9:00 AM
Subscribers

Details

Summary

Closes T10690

Test Plan

Open Badges application, go to Advanced Search, search for a badge by its name and see result.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley retitled this revision from to Make badges searchable by name.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/badges/query/PhabricatorBadgesSearchEngine.php
17–18

I think you can just delete this method completely now -- it's no longer required for searchengines which implement buildCusotmSearchFields().

This revision is now accepted and ready to land.Apr 7 2016, 7:19 PM
lpriestley edited edge metadata.

Removing obsolete method

This revision was automatically updated to reflect the committed changes.