Page MenuHomePhabricator

Make badges searchable by name
ClosedPublic

Authored by lpriestley on Apr 7 2016, 7:13 PM.
Tags
None
Referenced Files
F15579790: D15656.id.diff
Wed, May 7, 1:35 AM
F15566184: D15656.id37732.diff
Thu, May 1, 3:50 PM
F15562198: D15656.id37729.diff
Wed, Apr 30, 1:02 AM
F15549314: D15656.id.diff
Sun, Apr 27, 5:03 AM
F15546205: D15656.diff
Sat, Apr 26, 2:27 PM
F15539382: D15656.id37732.diff
Fri, Apr 25, 1:25 AM
F15511042: D15656.id37729.diff
Wed, Apr 16, 11:41 PM
F15469262: D15656.diff
Apr 4 2025, 11:13 AM
Subscribers

Details

Summary

Closes T10690

Test Plan

Open Badges application, go to Advanced Search, search for a badge by its name and see result.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley retitled this revision from to Make badges searchable by name.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/badges/query/PhabricatorBadgesSearchEngine.php
17–18

I think you can just delete this method completely now -- it's no longer required for searchengines which implement buildCusotmSearchFields().

This revision is now accepted and ready to land.Apr 7 2016, 7:19 PM
lpriestley edited edge metadata.

Removing obsolete method

This revision was automatically updated to reflect the committed changes.