Page MenuHomePhabricator

Make badges searchable by name
ClosedPublic

Authored by lpriestley on Apr 7 2016, 7:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 30, 6:58 PM
Unknown Object (File)
Tue, Jan 28, 4:06 PM
Unknown Object (File)
Fri, Jan 24, 10:05 PM
Unknown Object (File)
Tue, Jan 21, 3:07 PM
Unknown Object (File)
Tue, Jan 21, 11:53 AM
Unknown Object (File)
Mon, Jan 13, 10:26 PM
Unknown Object (File)
Dec 31 2024, 7:17 PM
Unknown Object (File)
Dec 17 2024, 5:36 AM
Subscribers

Details

Summary

Closes T10690

Test Plan

Open Badges application, go to Advanced Search, search for a badge by its name and see result.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

lpriestley retitled this revision from to Make badges searchable by name.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
epriestley edited edge metadata.
epriestley added inline comments.
src/applications/badges/query/PhabricatorBadgesSearchEngine.php
17–18

I think you can just delete this method completely now -- it's no longer required for searchengines which implement buildCusotmSearchFields().

This revision is now accepted and ready to land.Apr 7 2016, 7:19 PM
lpriestley edited edge metadata.

Removing obsolete method

This revision was automatically updated to reflect the committed changes.