Page MenuHomePhabricator
Feed Advanced Search

Feb 22 2016

joshuaspence added a comment to T10406: Archived repositories aren't imported.

Even if that means data loss?

Feb 22 2016, 6:02 AM · Bug Report, Diffusion
chad added a comment to T10406: Archived repositories aren't imported.

My expectation is "archive" means "mark as deleted" in Phabricator.

Feb 22 2016, 6:01 AM · Bug Report, Diffusion
joshuaspence added a comment to T10406: Archived repositories aren't imported.

I disagree that this is the expected behavior, especially if this occurs on hosted repositories (which I can't confirm because I don't have any). If this occurs with hosted repositories, then archived repositories will be forever lost when replacing the repository hosting tier.

Feb 22 2016, 5:59 AM · Bug Report, Diffusion
chad added a comment to T10406: Archived repositories aren't imported.

I'm missing something I think, this sounds like expected behavior with a reasonable workaround. What's the bug?

Feb 22 2016, 5:58 AM · Bug Report, Diffusion
joshuaspence created T10406: Archived repositories aren't imported.
Feb 22 2016, 5:38 AM · Bug Report, Diffusion
ppggff added a comment to T10264: git clone using http hangs after update.

test:

php test.php 31 && tail test.txt
php test.php 30 && tail test.txt
Feb 22 2016, 3:39 AM · Bug Report, Diffusion
ppggff added a comment to T10264: git clone using http hangs after update.

Does changing window to 31 actually fix it for you?

Feb 22 2016, 3:32 AM · Bug Report, Diffusion
epriestley added a comment to T10264: git clone using http hangs after update.

Does changing window to 31 actually fix it for you?

Feb 22 2016, 3:30 AM · Bug Report, Diffusion
ppggff added a comment to T10264: git clone using http hangs after update.

Still hang...
dumping decompressed result shows input was truncated.

Feb 22 2016, 3:29 AM · Bug Report, Diffusion

Feb 21 2016

epriestley closed T10264: git clone using http hangs after update as Resolved.

Thanks for verifying the fix!

Feb 21 2016, 9:16 PM · Bug Report, Diffusion
dpatou added a comment to T10264: git clone using http hangs after update.

I can confirm it now works properly for me (5.6) at HEAD.

Feb 21 2016, 9:15 PM · Bug Report, Diffusion

Feb 20 2016

epriestley added a comment to T10264: git clone using http hangs after update.

I think this is now resolved for PHP 5.6 at HEAD of master.

Feb 20 2016, 10:58 PM · Bug Report, Diffusion
epriestley added a revision to T10264: git clone using http hangs after update: Restricted Differential Revision.
Feb 20 2016, 7:55 PM · Bug Report, Diffusion
epriestley added a comment to T10264: git clone using http hangs after update.

Never mind, that patch doesn't work.

Feb 20 2016, 7:44 PM · Bug Report, Diffusion
epriestley added a comment to T10264: git clone using http hangs after update.
Edit: don't bother with this.
Feb 20 2016, 7:24 PM · Bug Report, Diffusion
epriestley added a comment to T10264: git clone using http hangs after update.

Yeah, I'd like to avoid that "simple workaround" of 200 lines of spaghetti if I can, since I'd guess this task is going to go through 50 more rounds if I have to implement that.

Feb 20 2016, 4:52 PM · Bug Report, Diffusion
dpatou added a comment to T10264: git clone using http hangs after update.

This comment seem to indicate 5.6 indeed broke file_get_contents("compress.zlib://php://input"). I didn't delve much into the proposed workaround yet but it might give a hint of what's going on.

Feb 20 2016, 4:23 PM · Bug Report, Diffusion
epriestley added a comment to T10264: git clone using http hangs after update.

Alright, thanks. Both you and @ppggff have PHP 5.6, I'll see if I can reproduce with 5.6.

Feb 20 2016, 3:34 PM · Bug Report, Diffusion
dpatou added a comment to T10264: git clone using http hangs after update.

@epriestley yes, pretty much the same ones :

[Sat Feb 20 09:04:56.337247 2016] [:error] [pid 5801] [client 86.219.113.93:56185] PHP Warning:  file_get_contents(): cannot represent a stream of type Input as a File Descriptor in /home/w4w/domains/REDACTED/phabricator/support/PhabricatorStartup.php on line 144
[Sat Feb 20 09:04:56.350142 2016] [:error] [pid 5801] [client 86.219.113.93:56185] PHP Warning:  file_get_contents(compress.zlib://php://input): failed to open stream: operation failed in /home/w4w/domains/REDACTED/phabricator/support/PhabricatorStartup.php on line 144

Ubuntu 14.04
Apache : 2.4.16
Php : 5.6.12-1
Php being through mod_php

Feb 20 2016, 3:29 PM · Bug Report, Diffusion
epriestley moved T10395: Deploy SSH keys associated with a repository from Backlog to Needs Information on the Feature Request board.
Feb 20 2016, 12:36 PM · Feature Request (Needs Information), Diffusion
epriestley reopened T10264: git clone using http hangs after update as "Open".

@dpatou Do you have errors in your error log similar to the ones @ppggff describes?

Feb 20 2016, 12:32 PM · Bug Report, Diffusion
dpatou added a comment to T10264: git clone using http hangs after update.

@epriestley Reverting both 5e375482 and 8269fd6e make me able to clone normally again.

Feb 20 2016, 8:21 AM · Bug Report, Diffusion
urzds added a comment to T6171: Transaction abort on first push via SSH to empty Mercurial repository.

This implies a question: Could it be Phabricator which modifies the stream between the client and the server in an illegal way? Or is this some bug in Mercurial itself?

Feb 20 2016, 12:13 AM · Mercurial, Diffusion
urzds added a comment to T6171: Transaction abort on first push via SSH to empty Mercurial repository.

Reading the code around /usr/lib/python2.7/dist-packages/mercurial/sshserver.py:32:

def getargs(self, args):
    data = {}
    keys = args.split()
    for n in xrange(len(keys)):
        argline = self.fin.readline()[:-1]
        arg, l = argline.split()
        if arg not in keys:
            raise util.Abort("unexpected parameter %r" % arg)
        if arg == '*':
            star = {}
            for k in xrange(int(l)):
                argline = self.fin.readline()[:-1]
                arg, l = argline.split()
                val = self.fin.read(int(l))
                star[arg] = val
            data['*'] = star
        else:
            val = self.fin.read(int(l))
            data[arg] = val
    return [data[k] for k in keys]
Feb 20 2016, 12:08 AM · Mercurial, Diffusion

Feb 19 2016

epriestley updated subscribers of T10395: Deploy SSH keys associated with a repository.

The expectation is that you create a "Bot" account, and add keys to that account.

Feb 19 2016, 7:55 PM · Feature Request (Needs Information), Diffusion
chad added a project to T10395: Deploy SSH keys associated with a repository: Diffusion.
Feb 19 2016, 7:16 PM · Feature Request (Needs Information), Diffusion
epriestley closed T10391: Folders missing in Diffusion repository browser as Resolved.

I think this issue was fixed by 58c2141 (Feb 16) which hasn't promoted to stable yet. You can either upgrade to master now, or it should promote to stable in about 24 hours. If you want, you can subscribe to the Changelog to keep track of when we promote.

Feb 19 2016, 5:04 PM · Diffusion, Bug Report
lucaro added a comment to T10391: Folders missing in Diffusion repository browser.

Yes, the affected repositories are mercurial, there are several. The version is the latest stable one (https://secure.phabricator.com/w/changelog/2016.07/). I have not yet found a way to reproduce this behavior nor can I tell what the affected repositories have in common (not all are affected).

Feb 19 2016, 5:03 PM · Diffusion, Bug Report
epriestley added a comment to T10391: Folders missing in Diffusion repository browser.

Just to confirm, this is a Mercurial repository, right? (I'm assuming it is because of default instead of master, but just want to make sure.)

Feb 19 2016, 4:58 PM · Diffusion, Bug Report
chad added a comment to T10391: Folders missing in Diffusion repository browser.

Please fill out a full bug report, including your version and steps to reproduce. See Contributing Bug Reports.

Feb 19 2016, 4:57 PM · Diffusion, Bug Report
lucaro created T10391: Folders missing in Diffusion repository browser.
Feb 19 2016, 4:53 PM · Diffusion, Bug Report
epriestley closed T10341: Exception: Cursor "56217" does not identify a valid object in query "DiffusionCommitQuery". as Resolved.

It sounds like no one can reproduce this problem anymore. If anyone runs into this again and can figure out reproduction steps, feel free to file a new task with details.

Feb 19 2016, 3:17 PM · Diffusion, Dashboards, Bug Report
epriestley closed T10389: File listing is truncated in repository view as Resolved.

I think this issue was fixed by 58c2141 (Feb 16), which is a little ahead of where you are. You can update to master to pick it up right away, or it should be available in stable in about 24 hours (if you want, you can subscribe to the Changelog page to keep an eye on when we promote to stable).

Feb 19 2016, 2:55 PM · Diffusion, Bug Report
mrjoops added a comment to T10389: File listing is truncated in repository view.

phabricator

70c679110e1d4632d19ca160379f83f6f20d79d1 (Sat, Feb 13)

arcanist

ed476cf8489c4bf41b7a0075f15d40820d640fe4 (Sat, Feb 13)

phutil

9c472e7c9b64395424c6cd25734bf239cb3c113d (Sat, Jan 23)
Feb 19 2016, 2:52 PM · Diffusion, Bug Report
epriestley added a comment to T10389: File listing is truncated in repository view.

Can you either confirm that you're running HEAD of master, or tell me what version of Phabricator are you currently running?

Feb 19 2016, 2:36 PM · Diffusion, Bug Report
mrjoops added a comment to T1130: Add Mercurial tag/bookmark support to Diffusion.

Our projects make heavy use of mercurial tags too, for version tagging and it would be great to see them in Phabricator to easily compare files between versions (they're way more easy to remember than changeset hashes).

Feb 19 2016, 2:34 PM · Mercurial, Diffusion
mrjoops updated the task description for T10389: File listing is truncated in repository view.
Feb 19 2016, 2:10 PM · Diffusion, Bug Report
mrjoops created T10389: File listing is truncated in repository view.
Feb 19 2016, 2:10 PM · Diffusion, Bug Report
• tailsu added a comment to T4801: Error with unclear next steps from `git push` to hosted repository.

I got this:

Feb 19 2016, 12:37 PM · Git, Diffusion
ppggff added a comment to T10264: git clone using http hangs after update.

I got the same problem with HEAD of master.
it seems relate to clone a git repo with gziped post data by http.

Feb 19 2016, 9:26 AM · Bug Report, Diffusion

Feb 18 2016

dpatou added a comment to T10264: git clone using http hangs after update.

@epriestley I will try reverting theses commits when I get a stable ssh into my phab instance and keep you posted.

Feb 18 2016, 7:53 PM · Bug Report, Diffusion
eadler moved T9554: Trigger "import" heuristics for imported repositories from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Feb 18 2016, 6:33 PM · Diffusion, Restricted Project, Restricted Project
eadler moved T9287: Working with many repositories from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Feb 18 2016, 6:31 PM · Restricted Project, Restricted Project, Diffusion
eadler moved T5715: Diffusion commit count is incorrect after forced push from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Feb 18 2016, 6:31 PM · Restricted Project, Diffusion
epriestley added a comment to T10264: git clone using http hangs after update.

@dpatou Does reverting both 5e375482 and 8269fd6e fix the issue for you?

Feb 18 2016, 6:20 PM · Bug Report, Diffusion
dpatou added a comment to T10264: git clone using http hangs after update.

I still can't git clone, but if I create an empty folder, init a repo in it, put my phab-hosted repo as origin remote and pull/merge into master, it works just fine great (just as cloning would/should)

Feb 18 2016, 6:09 PM · Bug Report, Diffusion
chad updated subscribers of T6636: Show Audit status of referenced commits in Maniphest.
Feb 18 2016, 3:08 PM · Audit, Diffusion, Maniphest
JOY added a project to Q317: Guidelines to add Github repo to Diffusion: Diffusion.
Feb 18 2016, 7:34 AM · Diffusion

Feb 17 2016

dpatou added a comment to T10264: git clone using http hangs after update.

I'm in the middle of a trip right now so can't test as much as I'd like but i'm still having the issue. On my desktop computer I can pull pretty fine the repos that were previously cloned but on this freshly reinstalled laptop I can't clone repositories, hanging forever after the git-upload-pack with connection left untouched, as the other comments stated here.

Feb 17 2016, 11:10 PM · Bug Report, Diffusion
JOY added a comment to T10341: Exception: Cursor "56217" does not identify a valid object in query "DiffusionCommitQuery"..

The issue disappears today! I don't know why.

Feb 17 2016, 11:39 AM · Diffusion, Dashboards, Bug Report
fanis added a comment to T10326: Property Lists use "Projects", not "Tags".

To add to this, viewing a Task shows "Projects" whereas editing it shows "Tags". This caused confusion to one of my users, who couldn't find where to update the Projects while editing a task.

Feb 17 2016, 10:55 AM · Projects, Diffusion, Bug Report
Krinkle added a comment to T7628: Diffusion commit pages should mention plain commit hash somewhere.

Thanks!
Macro yaaay:

Feb 17 2016, 1:24 AM · Diffusion

Feb 16 2016

epriestley moved T9554: Trigger "import" heuristics for imported repositories from v3 to Backlog on the Diffusion board.
Feb 16 2016, 9:52 PM · Diffusion, Restricted Project, Restricted Project
epriestley moved T10304: Truncated repository browser view in Diffusion for large Mercurial repositories from Backlog to vNext on the Diffusion board.
Feb 16 2016, 9:44 PM · Diffusion (v3), Bug Report
epriestley moved T10337: Implement `diffusion.search` and think about `diffusion.edit` from Backlog to vNext on the Diffusion board.
Feb 16 2016, 9:44 PM · Diffusion (v3), Restricted Project, Projects, Feature Request
epriestley moved T10366: General support for multiple URIs for a repository from Backlog to vNext on the Diffusion board.
Feb 16 2016, 9:43 PM · Diffusion (v3), Restricted Project, Feature Request
avivey added a comment to T10366: General support for multiple URIs for a repository.

Also probably related to T8831.

Feb 16 2016, 6:25 PM · Diffusion (v3), Restricted Project, Feature Request
eadler updated the task description for T10366: General support for multiple URIs for a repository.
Feb 16 2016, 5:47 PM · Diffusion (v3), Restricted Project, Feature Request
eadler moved T10366: General support for multiple URIs for a repository from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Feb 16 2016, 5:08 PM · Diffusion (v3), Restricted Project, Feature Request
eadler created T10366: General support for multiple URIs for a repository.
Feb 16 2016, 5:08 PM · Diffusion (v3), Restricted Project, Feature Request
aik099 added a comment to T6477: Branch/Tags custom fields not populated for SVN commits.

Thanks.

Feb 16 2016, 1:50 PM · Diffusion
epriestley added a comment to T6477: Branch/Tags custom fields not populated for SVN commits.

I think the script was removed around the time AphrontSite was written, because it was using a pretty hacky approach to figure out the right controller. You can now find the current controller in DarkConsole → Request → Controller:

Feb 16 2016, 1:14 PM · Diffusion
aik099 added a comment to T6477: Branch/Tags custom fields not populated for SVN commits.

After recent upgrade I no longer have this ./scripts/aphront/aphrontpath.php file. Was it moved to different place?

Feb 16 2016, 11:33 AM · Diffusion

Feb 15 2016

JOY added a comment to T10356: Unhandled Exception ("FilesystemException") after adding Github repo.

Deleted JS directory.
/daemon/ link shows no failing task recently:

pasted_file (831×1 px, 135 KB)

Feb 15 2016, 7:41 AM · Diffusion, Bug Report
avivey added a comment to T10356: Unhandled Exception ("FilesystemException") after adding Github repo.

Delete the JS directory, and visit the /edit page; It should show information about the state of the daemons.
Look also at the daemons console (Navigate to /daemon/), and look for failing daemons and logs.

Feb 15 2016, 5:14 AM · Diffusion, Bug Report
JOY updated the task description for T10356: Unhandled Exception ("FilesystemException") after adding Github repo.
Feb 15 2016, 5:11 AM · Diffusion, Bug Report
JOY added a comment to T10356: Unhandled Exception ("FilesystemException") after adding Github repo.

deamon is running as root user

Feb 15 2016, 5:11 AM · Diffusion, Bug Report
avivey added a comment to T10356: Unhandled Exception ("FilesystemException") after adding Github repo.

/var/repo/ needs to be owned by the daemon user (The user that phd runs as), and the daemons need to be running.
When importing git/mercurial repos, the daemons copy all the content to /var/repo/CALLSIGN; That doesn't happen with SVN, which is why you didn't run into this before.

Feb 15 2016, 4:46 AM · Diffusion, Bug Report
JOY added a project to T10356: Unhandled Exception ("FilesystemException") after adding Github repo: Diffusion.
Feb 15 2016, 4:33 AM · Diffusion, Bug Report

Feb 13 2016

JOY updated the task description for T10341: Exception: Cursor "56217" does not identify a valid object in query "DiffusionCommitQuery"..
Feb 13 2016, 2:29 AM · Diffusion, Dashboards, Bug Report

Feb 12 2016

chad added a comment to T10341: Exception: Cursor "56217" does not identify a valid object in query "DiffusionCommitQuery"..

2 days is a very long time to import. I'd wait until it's finished (we should still fix the error if we can reproduce it)

Feb 12 2016, 6:30 PM · Diffusion, Dashboards, Bug Report
JOY added a comment to T10341: Exception: Cursor "56217" does not identify a valid object in query "DiffusionCommitQuery"..

2016-02-13_0-48-25.jpg (314×435 px, 75 KB)

Not yet Chad

Feb 12 2016, 5:50 PM · Diffusion, Dashboards, Bug Report
chad added a comment to T10341: Exception: Cursor "56217" does not identify a valid object in query "DiffusionCommitQuery"..

Is the import complete?

Feb 12 2016, 5:44 PM · Diffusion, Dashboards, Bug Report
JOY added a comment to T10341: Exception: Cursor "56217" does not identify a valid object in query "DiffusionCommitQuery"..
In T10341#158952, @chad wrote:

Is this Subversion?

Feb 12 2016, 5:44 PM · Diffusion, Dashboards, Bug Report
JOY updated the task description for T10341: Exception: Cursor "56217" does not identify a valid object in query "DiffusionCommitQuery"..
Feb 12 2016, 5:43 PM · Diffusion, Dashboards, Bug Report
epriestley added a comment to T10264: git clone using http hangs after update.

I believe this is now fixed at HEAD of master. It should promote to stable tomorrow morning.

Feb 12 2016, 4:09 PM · Bug Report, Diffusion
epriestley closed T10264: git clone using http hangs after update as Resolved by committing Restricted Diffusion Commit.
Feb 12 2016, 4:09 PM · Bug Report, Diffusion
chad added a comment to T10341: Exception: Cursor "56217" does not identify a valid object in query "DiffusionCommitQuery"..

Is this Subversion?

Feb 12 2016, 4:05 PM · Diffusion, Dashboards, Bug Report
chad added a comment to T10341: Exception: Cursor "56217" does not identify a valid object in query "DiffusionCommitQuery"..

Unfortunately we can't fix bugs we can't see (well, usually). If you have further details (like what type of repository) or errors in your Apache log, please post them.

Feb 12 2016, 3:59 PM · Diffusion, Dashboards, Bug Report
JOY added a comment to T10341: Exception: Cursor "56217" does not identify a valid object in query "DiffusionCommitQuery"..

Hi @chad , I added some info. I don't know the real reason honestly.

Feb 12 2016, 3:58 PM · Diffusion, Dashboards, Bug Report
JOY updated the task description for T10341: Exception: Cursor "56217" does not identify a valid object in query "DiffusionCommitQuery"..
Feb 12 2016, 3:57 PM · Diffusion, Dashboards, Bug Report
chad added a comment to T10341: Exception: Cursor "56217" does not identify a valid object in query "DiffusionCommitQuery"..

Please see Contributing Bug Reports. Specifically we can't take a bug report without you providing the reproduction steps. How can we reproduce this error?

Feb 12 2016, 3:30 PM · Diffusion, Dashboards, Bug Report
epriestley added a revision to T10264: git clone using http hangs after update: Restricted Differential Revision.
Feb 12 2016, 12:25 PM · Bug Report, Diffusion
epriestley added a comment to T10264: git clone using http hangs after update.

Awesome, thanks for testing! I think this should be an easy fix, now.

Feb 12 2016, 12:12 PM · Bug Report, Diffusion
sicnervo added a comment to T10264: git clone using http hangs after update.

I think that may be important:

Feb 12 2016, 11:48 AM · Bug Report, Diffusion
urzds added a comment to T10326: Property Lists use "Projects", not "Tags".

To prevent confusion with Git/Hg/Svn tags: What about "Label"?

Feb 12 2016, 9:23 AM · Projects, Diffusion, Bug Report
dtf added a comment to T10264: git clone using http hangs after update.

Confirm. After deleting of mentioned line on top of stable everything clones fine.

Feb 12 2016, 7:56 AM · Bug Report, Diffusion
davidgiga1993 added a comment to T10264: git clone using http hangs after update.

I just tested it and it seems like removing the line solves the problem.

Feb 12 2016, 5:39 AM · Bug Report, Diffusion
JOY added projects to T10341: Exception: Cursor "56217" does not identify a valid object in query "DiffusionCommitQuery".: Dashboards, Diffusion.
Feb 12 2016, 3:31 AM · Diffusion, Dashboards, Bug Report
epriestley edited projects for T10264: git clone using http hangs after update, added: Bug Report; removed Bug Report (Needs Information).
Feb 12 2016, 2:24 AM · Bug Report, Diffusion
epriestley renamed T10337: Implement `diffusion.search` and think about `diffusion.edit` from Supporting custom fields for repositories and/or query projects for repositories and/or vice-versa to Implement `diffusion.search` and think about `diffusion.edit`.
Feb 12 2016, 2:23 AM · Diffusion (v3), Restricted Project, Projects, Feature Request
epriestley added a comment to T10337: Implement `diffusion.search` and think about `diffusion.edit`.

I'm just going to co-opt this as a subtask for that piece since you already tagged it so nicely.

Feb 12 2016, 2:21 AM · Diffusion (v3), Restricted Project, Projects, Feature Request
epriestley added a comment to T10337: Implement `diffusion.search` and think about `diffusion.edit`.

(This is adjacent to T4245 and should be happening fairly soon -- next big-ticket item I'm currently planning to hit after subprojects/workboards calm down.)

Feb 12 2016, 1:12 AM · Diffusion (v3), Restricted Project, Projects, Feature Request
epriestley added a comment to T10264: git clone using http hangs after update.

Oh, and make sure you restart fully after changing the code -- I suspect that might have been the cause of the revert not fixing things earlier. Here's a guide if you aren't sure how:

Feb 12 2016, 1:09 AM · Bug Report, Diffusion
eadler added a comment to T10337: Implement `diffusion.search` and think about `diffusion.edit`.

right, I wasn't sure if it was a special case of either of those, but I figured I'd ask just in case.

Feb 12 2016, 1:09 AM · Diffusion (v3), Restricted Project, Projects, Feature Request
eadler updated the task description for T10337: Implement `diffusion.search` and think about `diffusion.edit`.
Feb 12 2016, 1:08 AM · Diffusion (v3), Restricted Project, Projects, Feature Request
epriestley added a comment to T10264: git clone using http hangs after update.

Can anyone who is able to reproduce this let me know if this fixes it?

Feb 12 2016, 1:07 AM · Bug Report, Diffusion
epriestley added a comment to T10337: Implement `diffusion.search` and think about `diffusion.edit`.

This will be supported by diffusion.search out of T5873. See also T10329.

Feb 12 2016, 1:05 AM · Diffusion (v3), Restricted Project, Projects, Feature Request
eadler moved T10337: Implement `diffusion.search` and think about `diffusion.edit` from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Feb 12 2016, 12:55 AM · Diffusion (v3), Restricted Project, Projects, Feature Request
eadler created T10337: Implement `diffusion.search` and think about `diffusion.edit`.
Feb 12 2016, 12:54 AM · Diffusion (v3), Restricted Project, Projects, Feature Request