Page MenuHomePhabricator
Feed Advanced Search

Oct 15 2015

epriestley added a revision to T9456: Evaluate upstream support for third-party build systems: Unknown Object (Differential Revision).
Oct 15 2015, 1:54 AM · Restricted Project, Harbormaster
epriestley added a revision to T9456: Evaluate upstream support for third-party build systems: Unknown Object (Differential Revision).
Oct 15 2015, 1:40 AM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

So if I set that up to push a tag, will that be guaranteed to be on the remote before the build starts?

Oct 15 2015, 1:39 AM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

haha

Oct 15 2015, 1:23 AM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

sorry I broke CircleCI ;_;

Oct 15 2015, 1:22 AM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

Oh, it's actually been ~down for ~4 hours? Roughly since I touched it earlier this afternoon. o.O

Oct 15 2015, 1:21 AM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

Specifically, this is workable because requests like this are handled in a desirable way (note loldoesnotexist branch, which does not exist):

Oct 15 2015, 1:20 AM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

Here's the specific flow that I think is workable:

Oct 15 2015, 1:15 AM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

Okay, it looks like we can pass any ref-like thing as revision and pretty much whatever we want as branch, and branch is just completely ignored if revision is present, so building tags isn't an issue. We should be able to do a proper integration here cleanly.

Oct 15 2015, 12:57 AM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

oh

Oct 15 2015, 12:51 AM · Restricted Project, Harbormaster
epriestley added a comment to T9456: Evaluate upstream support for third-party build systems.

You can currently configure a "Staging Area", which will cause arc diff to push to a tag in an arbitrary remote as a side effect. I generally think this is a better way forward than pushing to named branches in the "real" remote, because it doesn't imply an end state where your remote has "master", "develop", and a million named branches that you can't get rid of. T8092 and linked tasks discuss eventually moving beyond this and virtualizing these refs so they're invisible to users but visible to the build system (for hosted repositories), but just using a different remote is approximately as good today.

Oct 15 2015, 12:46 AM · Restricted Project, Harbormaster
epriestley added Q173: How to disable MySQL file storage (Answer 209).
Oct 15 2015, 12:16 AM
epriestley added Q174: Should / Can I Reuse an Almanac Device (Answer 208).
Oct 15 2015, 12:14 AM
epriestley added Q175: Should I Reuse Device Keys? (Answer 207).
Oct 15 2015, 12:09 AM

Oct 14 2015

epriestley added a comment to T9529: Upload coverage to a diff.

It looks like that code isn't interacting with Harbormaster at all and is making an HTTP request to Changes directly from inside a Herald action. We (fairly strongly) discourage this as a way to communicate with external systems (see T5462 for discussion/rationale -- it's synchronous and blocks the UI, error handling can't happen properly, and there's no way to retry if it fails). There is no build target available during the execution of Herald actions and I can't really come up with a reasonable way to generate one.

Oct 14 2015, 11:49 PM · Restricted Project, Restricted Project, Conduit, Differential, Harbormaster
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

Phabricator is not a good fit for your workflow, then, and never will be.

Oct 14 2015, 11:08 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Arcanist, Differential
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

For example, here's a reasonable way you might perform these changes:

Oct 14 2015, 11:06 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Arcanist, Differential
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

Increasing max_allowed_packet to a much larger number (say, 512MB) will likely resolve the 2013 error.

Oct 14 2015, 10:58 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Arcanist, Differential
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

What is max_allowed_packet set to in MySQL?

Oct 14 2015, 10:46 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Arcanist, Differential
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

Differential just can't load the change set into its database.

Oct 14 2015, 10:21 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Arcanist, Differential
epriestley added a comment to T9570: Can a hosted Phacility instance be exported?.

Yes, with caveats. See T7148 for discussion of why this is complex. Roughly, here's the state of the world today:

Oct 14 2015, 9:04 PM · Phacility Support
epriestley edited projects for T9570: Can a hosted Phacility instance be exported?, added: Phacility Support; removed Support.
Oct 14 2015, 8:53 PM · Phacility Support
epriestley updated subscribers of T9456: Evaluate upstream support for third-party build systems.

For those of you using CircleCI, what sort of integration are you hoping for?

Oct 14 2015, 8:51 PM · Restricted Project, Harbormaster
turadg awarded T182: Commit into repository directly from differential a Orange Medal token.
Oct 14 2015, 8:34 PM · Haskell.org, Restricted Project, Differential
epriestley added a comment to T9252: Unprototype Drydock (v1).

Progress here:

Oct 14 2015, 8:04 PM · Prioritized, Drydock
epriestley added a comment to T9519: Design the Drydock Blueprint selection mechanism.

It's just this thing, basically:

Oct 14 2015, 7:53 PM · Drydock
epriestley added a comment to T9519: Design the Drydock Blueprint selection mechanism.

I'm broadly pretty happy with this after using it for a bit, at least for use cases we have today. It does feel a little bit labor intensive, but not overwhelmingly so, and all the stuff is pretty well linked up so once you get the hang of it you're almost always only a click away from wherever you want to be to do the next thing. It's also reassuring to be able to go to a blueprint and check what might be using it at a glance.

Oct 14 2015, 7:21 PM · Drydock
epriestley added a comment to T182: Commit into repository directly from differential.

General progress update here: this now works, technically. Almost every part of it -- particularly, the UI -- is still total garbage for now, but if you ship a revision against rGITTEST up to this server you'll get a "Land Revision" button on it which has worked twice in the past and might work again. I would recommend extending the list of pasta varieties found in the pasta file if you want to try this (the button should appear and function without requiring the revision to be accepted for now, and everyone has write access to the repo anyway).

Oct 14 2015, 7:08 PM · Haskell.org, Restricted Project, Differential
epriestley added a revision to T182: Commit into repository directly from differential: Unknown Object (Differential Revision).
Oct 14 2015, 5:39 PM · Haskell.org, Restricted Project, Differential
epriestley edited P1865 syncProviders.php.
Oct 14 2015, 4:56 PM
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

Releeph will execute all the same core display code and have all the same ingrained workflow assumptions. If your changes are too big to review in Differential, they will also be too big to review in Audit, and Releeph will not have dedicated review tools.

Oct 14 2015, 4:03 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Arcanist, Differential
epriestley closed T9568: Passphrase credentials do not preserve "Space" when edited as Resolved by committing Restricted Diffusion Commit.
Oct 14 2015, 3:15 PM · Passphrase
epriestley updated subscribers of T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
Oct 14 2015, 3:08 PM · Restricted Project, FreeBSD, Arcanist
epriestley merged task T9569: arc tasks --unassigned displays assigned tasks into T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.
Oct 14 2015, 3:08 PM · Arcanist
epriestley added a revision to T9568: Passphrase credentials do not preserve "Space" when edited: Unknown Object (Differential Revision).
Oct 14 2015, 2:51 PM · Passphrase
epriestley claimed T9568: Passphrase credentials do not preserve "Space" when edited.
Oct 14 2015, 2:49 PM · Passphrase
epriestley edited the content of Phacility Cluster Devices.
Oct 14 2015, 1:44 PM
epriestley edited the content of Adding Hardware.
Oct 14 2015, 1:41 PM
epriestley created T9568: Passphrase credentials do not preserve "Space" when edited.
Oct 14 2015, 1:35 PM · Passphrase
epriestley added a revision to T9252: Unprototype Drydock (v1): Unknown Object (Differential Revision).
Oct 14 2015, 12:26 PM · Prioritized, Drydock
epriestley added a revision to T9252: Unprototype Drydock (v1): Unknown Object (Differential Revision).
Oct 14 2015, 12:02 PM · Prioritized, Drydock
epriestley closed T9565: webhook support as Invalid.

Please read this document carefully before filing a feature request:

Oct 14 2015, 11:49 AM · Notifications
epriestley added a comment to T7478: Inbound email is wrapped when sent from Gmail.

I'm not sure there's anything we can really do about this. Gmail is applying a destructive transformation to outbound mail, and there is no inverse function we can apply to restore the original mail.

Oct 14 2015, 10:46 AM · Mail
epriestley added a comment to T9529: Upload coverage to a diff.

It's supposed to be sent with the call to the external build system, but that doesn't seem to work either -- the build target phid received is always ''.

Oct 14 2015, 10:27 AM · Restricted Project, Restricted Project, Conduit, Differential, Harbormaster

Oct 13 2015

epriestley added a comment to T9562: Show only the first N branches/tags on commits in Diffusion, with a "Show all..." link.

I'd be inclined to show N branches, for some small value of N like 3 or 5 or 10, with a link to "Show 1,695 more branches which contain this commit...".

Oct 13 2015, 11:25 PM · Diffusion (v3), Restricted Project
epriestley added a revision to T182: Commit into repository directly from differential: Unknown Object (Differential Revision).
Oct 13 2015, 10:37 PM · Haskell.org, Restricted Project, Differential
epriestley added a comment to T9505: Show landing branch information in Differential revision detail.

Actually I think we can go even deeper (T3462).

Oct 13 2015, 10:03 PM · Differential
epriestley added a revision to T182: Commit into repository directly from differential: Unknown Object (Differential Revision).
Oct 13 2015, 4:39 PM · Haskell.org, Restricted Project, Differential
epriestley added a comment to T9558: Unhandled Exception on adding a Phabricator user to a Maniphest custom field.

This has been fixed in master and cherry-picked into stable (as rPc0a52201). You should be able to update to pick up the fix.

Oct 13 2015, 3:43 PM · Custom Fields, Maniphest
epriestley closed T9558: Unhandled Exception on adding a Phabricator user to a Maniphest custom field as Resolved by committing Restricted Diffusion Commit.
Oct 13 2015, 3:41 PM · Custom Fields, Maniphest
epriestley added a comment to T5000: Using Differential with plain Git, without requiring Arc.

Unfortunately, no part of that sounds well-aligned with our thinking about the roles for these applications or our roadmap for the products. If your development workflow routinely has changes which are too large for Differential to reasonably accommodate (20K+ lines?), it is far outside of my experience in software development and Phabricator is probably not a good tool to use for this workflow.

Oct 13 2015, 3:39 PM · KDE, FreeBSD, Restricted Project, Haskell.org, Differential, Arcanist
Feed Story Failed to Render (PhabricatorApplicationTransactionFeedStory)
Exception: Unknown edge constant "59"!
Oct 13 2015, 2:52 PM
epriestley claimed T9558: Unhandled Exception on adding a Phabricator user to a Maniphest custom field.
Oct 13 2015, 2:51 PM · Custom Fields, Maniphest
epriestley added a revision to T9558: Unhandled Exception on adding a Phabricator user to a Maniphest custom field: Unknown Object (Differential Revision).
Oct 13 2015, 2:51 PM · Custom Fields, Maniphest
epriestley closed T9557: aa as Spite.
Oct 13 2015, 11:30 AM · Blessed Reviewers, Phabricator
epriestley updated subscribers of T9530: Release Server / Workflow app / Future of Releeph .

Not sure if any of this is relevant to T8297, but everyone loves walls of text!

Oct 13 2015, 10:55 AM · Restricted Project, Harbormaster
epriestley added a comment to T8297: Differential Revision's repository is reassigned when the commit is pushed to a separate repository.

I think that change is tentatively within the realm of reason, but I have some concerns.

Oct 13 2015, 10:54 AM · Diffusion
epriestley removed subtasks for T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch: T9452: Cloudsme, T9469: Redirect loop after fresh installation, T9478: Working with harbormaster.sendmessage, T9500: Active dashboards not shown with "Active" search filter, T9512: "Change Password" should prompt users to "Reset Password" if no password has been set, T9511: asdasda, T9510: sadasdasd.
Oct 13 2015, 12:59 AM · Restricted Project, Typeahead, Audit
epriestley removed a parent task for T9469: Redirect loop after fresh installation: T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch.
Oct 13 2015, 12:59 AM · Installing & Upgrading
epriestley removed a parent task for T9478: Working with harbormaster.sendmessage: T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch.
Oct 13 2015, 12:59 AM · Arcanist, Herald, Harbormaster
epriestley removed a parent task for T9500: Active dashboards not shown with "Active" search filter: T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch.
Oct 13 2015, 12:59 AM · Dashboards
epriestley removed a parent task for T9452: Cloudsme: T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch.
Oct 13 2015, 12:59 AM · Roadmap
epriestley removed a parent task for T9510: sadasdasd: T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch.
Oct 13 2015, 12:59 AM
epriestley removed a parent task for T9512: "Change Password" should prompt users to "Reset Password" if no password has been set: T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch.
Oct 13 2015, 12:59 AM · Restricted Project, Auth
epriestley removed a parent task for T9511: asdasda: T9362: Support viewerprojects() and implement viewerpackages() in Audit ApplicationSearch.
Oct 13 2015, 12:59 AM
epriestley closed T7375: Replace `hg locate` with `hg files` if `hg` is 3.2 or newer as Resolved by committing Restricted Diffusion Commit.
Oct 13 2015, 12:53 AM · Diffusion, Mercurial
epriestley updated the task description for T9554: Trigger "import" heuristics for imported repositories.
Oct 13 2015, 12:45 AM · Diffusion, Restricted Project, Restricted Project
epriestley created T9554: Trigger "import" heuristics for imported repositories.
Oct 13 2015, 12:45 AM · Diffusion, Restricted Project, Restricted Project
epriestley added a comment to T9553: www.googleapis.com refuses GET with Content-Length.

You have a version of cURL which has a bug with Content-Length (see T8654 for discussion), but your version of libphutil should include a workaround, so I'm not sure what's up. I can't reproduce this problem on this server.

Oct 13 2015, 12:35 AM · libphutil
epriestley added a comment to T9551: Strip strange characters out of project hashtags, or support parsing strange hashtag characters in other contexts.

At HEAD:

Oct 13 2015, 12:05 AM · Prioritized, Projects

Oct 12 2015

epriestley added a revision to T9551: Strip strange characters out of project hashtags, or support parsing strange hashtag characters in other contexts: Unknown Object (Differential Revision).
Oct 12 2015, 11:55 PM · Prioritized, Projects
epriestley added a comment to T9553: www.googleapis.com refuses GET with Content-Length.

Can you show me the output of these commands on the server?

Oct 12 2015, 11:50 PM · libphutil
epriestley added a revision to T9551: Strip strange characters out of project hashtags, or support parsing strange hashtag characters in other contexts: Unknown Object (Differential Revision).
Oct 12 2015, 11:08 PM · Prioritized, Projects
epriestley added a revision to T182: Commit into repository directly from differential: Unknown Object (Differential Revision).
Oct 12 2015, 10:48 PM · Haskell.org, Restricted Project, Differential
epriestley added a revision to T182: Commit into repository directly from differential: Unknown Object (Differential Revision).
Oct 12 2015, 9:12 PM · Haskell.org, Restricted Project, Differential
epriestley added a revision to T9519: Design the Drydock Blueprint selection mechanism: Unknown Object (Differential Revision).
Oct 12 2015, 9:12 PM · Drydock
epriestley moved T9551: Strip strange characters out of project hashtags, or support parsing strange hashtag characters in other contexts from Backlog to The Queue on the Prioritized board.
Oct 12 2015, 6:58 PM · Prioritized, Projects
epriestley claimed T9551: Strip strange characters out of project hashtags, or support parsing strange hashtag characters in other contexts.
Oct 12 2015, 6:57 PM · Prioritized, Projects
epriestley merged task T7305: project hashtags should work better re: spaces into T9551: Strip strange characters out of project hashtags, or support parsing strange hashtag characters in other contexts.
Oct 12 2015, 6:57 PM · Projects
epriestley updated subscribers of T9551: Strip strange characters out of project hashtags, or support parsing strange hashtag characters in other contexts.
Oct 12 2015, 6:57 PM · Prioritized, Projects
epriestley merged task T9480: Nicer slugs for project tags into T9551: Strip strange characters out of project hashtags, or support parsing strange hashtag characters in other contexts.
Oct 12 2015, 6:57 PM · Projects
epriestley merged task T7341: Colons ":" in project names create unusable hashtags into T9551: Strip strange characters out of project hashtags, or support parsing strange hashtag characters in other contexts.
Oct 12 2015, 6:57 PM · Projects
epriestley added a comment to T9551: Strip strange characters out of project hashtags, or support parsing strange hashtag characters in other contexts.

Other known demons are spaces (T7305), colons (T7341), and sort-of-but-not-really hyphens (T9480).

Oct 12 2015, 6:17 PM · Prioritized, Projects
epriestley added a comment to T182: Commit into repository directly from differential.

Blueprint selection (which got more details in T9519) is now in a rough-but-functional state so I expect the rest of this to move forward shortly.

Oct 12 2015, 1:56 PM · Haskell.org, Restricted Project, Differential
epriestley added a revision to T9519: Design the Drydock Blueprint selection mechanism: Unknown Object (Differential Revision).
Oct 12 2015, 1:26 PM · Drydock
epriestley closed T9550: Atom editor not present in the default uri.allowed-editor-protocols config as Wontfix.

You can change the configuration. This protocol is not prevalent enough to motivate us to include it by default in the upstream.

Oct 12 2015, 1:17 PM · Config

Oct 11 2015

CaptSpot awarded T1139: Internationalize Phabricator a Like token.
Oct 11 2015, 3:16 PM · Localization
CaptSpot awarded T3569: Make Phrequent somewhat usable a Like token.
Oct 11 2015, 2:16 PM · Phrequent
epriestley updated subscribers of T5791: Write Herald rules for outbound mail.
Oct 11 2015, 11:47 AM · Restricted Project, Restricted Project, FreeBSD, Mail
epriestley merged task T9549: No special header about repository and/or projects on emails sent from diffusion new commit into T5791: Write Herald rules for outbound mail.
Oct 11 2015, 11:47 AM · Diffusion

Oct 10 2015

epriestley added a comment to T9548: Support Mercurial's bundle2 wire protocol.

Particularly, the command server wire protocol is completely different from the HTTP/SSH wire protocol (and pretty reasonable overall, although it's solving a much simpler problem).

Oct 10 2015, 6:04 PM · Diffusion, Mercurial
epriestley added a comment to T9548: Support Mercurial's bundle2 wire protocol.

We have some CommandServer stuff too, although I don't think it has ever been reachable from the UI. I don't remember if the original use case was improving arc performance or improving import/parser performance.

Oct 10 2015, 6:01 PM · Diffusion, Mercurial
epriestley added a comment to T9548: Support Mercurial's bundle2 wire protocol.

So we probably need to special case the unbundle command, decode the response, build additional parts from stderr, and then insert them into the response.

Oct 10 2015, 5:23 PM · Diffusion, Mercurial
epriestley added a comment to T9548: Support Mercurial's bundle2 wire protocol.

I suspect it's worthwhile for us to support bundle2 eventually. As far as I can tell from my investigations in T9450:

Oct 10 2015, 5:18 PM · Diffusion, Mercurial
epriestley added a comment to T9535: Option to CC or use a mailing list for project reviewers.

Technically, we could implement "To", "Cc", "Any Recipient", and maybe "Sending application" or "Object type" outbound Herald fields today so you could write some variant of this:

Oct 10 2015, 3:43 PM · Restricted Project, Differential
epriestley closed T9450: "abort: not a Mercurial bundle" with Mercurial 3.5>= as Resolved by committing Restricted Diffusion Commit.
Oct 10 2015, 2:15 PM · Mercurial
epriestley updated the task description for T9546: Phame "Oblivious" skin a few rough edges.
Oct 10 2015, 1:55 PM · Phame
epriestley edited the content of 2015 Week 41 (Early October).
Oct 10 2015, 1:55 PM
epriestley updated the task description for T9546: Phame "Oblivious" skin a few rough edges.
Oct 10 2015, 1:52 PM · Phame
epriestley added a comment to T9360: Unbeta Phame.

Well, I don't expect to actually fix any of this for like 20-30 years, I'm just filing it.

Oct 10 2015, 1:48 PM · Phame