Redesign-specific.

"Audit" is basically "Query commits", just a little un-modern / funky.

T8238#116697

I think the root cause of this issue is non-utf8 rawDiffs failing to encode when being passed to the publisher.

Yeah, the diff contains invalid UTF8:

Well, I think we're in a bad position, because this code:

to line 27 of AphrontJSONResponse (right after it constructs the JSON), shows:

to line 147 of PhabricatorConduitAPIController shows that the diff content does pass through this line at least once.

Adding file_put_contents('/tmp/diff3', $result); on line 92 of PhabricatorConduitAPIController.php shows that the result is still correctly stored at this point.

at line 136 of DiffusionQueryConduitAPIMethod on the storage tier results in the file having the diff content, so the issue must be further on than this.

When I change line 119 of DiffusionQueryConduitAPIMethod.php to:

I'm like 95% sure this has something to do with the content of the actual diff returned, like UTF-8 encoding or something like that...

Something is totally whack with the cluster configuration in the latest HEAD. For some reason, the storage tier is now constructing a Conduit client to code.pageuppeople.com, even though it should just run the command locally. Even worse, the $is_cluster_request variable is set to true, yet it still constructs a new Conduit client.

For some reason, the storage tier is attempting to forward the request on to another machine inside the cluster (presumably itself?) and is then recursing. This makes no sense given that the code in src/applications/diffusion/conduit/DiffusionQueryConduitAPIMethod.php at line 123 is designed to prevent recursion.

I ran the query directly against the Conduit API on the storage machine, from my local machine, and it returns an empty response (so it's got nothing to do with the requesting machine):

I modified diffusion.rawdiffquery to do the following before returning the result:

One thing I was thinking: having the ability to ignore commits in Herald based on tag would solve this, you could just set Herald to ignore any tag matching phabricator/diff/\d+

This error is probably similar, at this URL:

Ok, so that definitely fixed the error. Now it presents the page correctly, but notes:

I think this is now fixed (in the sense of "not broken anymore", not in the sense of "working as nicely as it possibly could"). Let me know if that's not the case.

See also T8597. Two specific areas for improvement:

Two fixes here:

Actually, this doesn't look like a bug, but a settings issue. Though it should probably fail more gracefully.

Yeah this does already work (I've used it before). The HTTPS URL is just the same URL as the Diffusion page, even when the repository is hosted externally (SSH also works).

I believe this works currently, it's just not surfaced in the UI.

I ran chown -R git:wwwgrp-phabricator . in the storage folder which fixed it. Although it is a little concerning that it started happening for no reason (and has been working fine for ages).

Request aborted by debug time limit after 5 seconds.

Can you do this to get a stack trace?

I'm unable to reproduce this problem. We routinely run daemons for long periods of time without issues. See:

So far, I have come up with two different approaches to this. One of the major issues with this change is that we don't have a way to just connect to an arbitrary database with Lisk. Migrations which expect to change the phabricator_pastebin database, for example, cannot use PhabricatorPaste (which tries to connect to the phabricator_paste database, which doesn't yet exist). Furthermore, theses migrations cannot use LiskRawMigrationIterator either, because there is currently no easy way to construct an AphrontDatabaseConnection which connects to an arbitrary database.

It will be possible to define this rule locally after T5681, but I don't anticipate bringing it upstream.

In T7471#119519, @nj2408zjw wrote:

In T7471#118340, @harpyham wrote:

Login as webuser , run svn checkout command and accept the certificate permanently .

like this:
#cd /tmp
#su wwwrun -s /bin/sh
#svn co https://ip/svn/pro/xxxxxx
... select permanently ...
#exit

Refresh phabricator's web page.

Hi, how can I check what's the "webuser" of mine?

Hm, I see. Thanks for the explanation.

If you want to pick some unobjectionable "default" token which is not a valid tag or branch name in Git or Mercurial (and, ideally, unlikely to ever be a valid ref in any VCS) I'm happy to implement that and shove it in the documentation. Not great, but seems least-bad to me.

I think the original form only worked by accident, we don't use it in the UI anywhere. This behavior likely changed when I fixed T7100.

I've tried many methods, but only this work.
Set your host (displays in your certificate) in /etc/host such as

192.168.1.100 certicaficate_hostname

I hadn't tried to test that! You appear to be correct.

It looks like if the ;<commit hash> exits, diffusion ignores the master part:

Try installing the libiconv package from here: https://www.gnu.org/software/libiconv/ and run

git push origin --all

I got bored and went ahead with this.

In T7471#118340, @harpyham wrote:

Login as webuser , run svn checkout command and accept the certificate permanently .

like this:
#cd /tmp
#su wwwrun -s /bin/sh
#svn co https://ip/svn/pro/xxxxxx
... select permanently ...
#exit

Refresh phabricator's web page.

As a possible attack on this, we could rename phabricator_pastebin to phabricator_paste first and see how awful that is.

In T7471#118340, @harpyham wrote:

Login as webuser , run svn checkout command and accept the certificate permanently .

like this:
#cd /tmp
#su wwwrun -s /bin/sh
#svn co https://ip/svn/pro/xxxxxx
... select permanently ...
#exit

Refresh phabricator's web page.

git: error while loading shared libraries: libiconv.so.2: cannot open shared object file: No such file or directory

Can we get a fund initiative for making Fund work like Kickstarter? :P

Note that it takes your money immediately -- not when a specific goal is reached (so it's not like Kickstarter) -- but I'll, uh, do this proportionately sooner relative to how much funding I3 gets I guess, unless someone wants to separately prioritize making Fund work like Kickstarter.

Well we do have an app for crowd funding. In some regards, it feels wrong to use it, but then again, I'll even chip in just to help out. We don't have a great means of getting people to the initiative though, so this task is the sole promotion point.