Page MenuHomePhabricator
Feed Advanced Search

Apr 11 2015

epriestley added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

I'm still blocking D8685 for no particular reason, that might be a good place to start. I think grouping the menu up probably makes more sense -- at least as a starting point -- than trying to build a unified object relationship dialog (which feels hard to get right, offhand).

Apr 11 2015, 9:36 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
chad added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

Do you think theres a path to just having a generalized "Object Relationship Dialog", or is that likely too complicated? It'd obviously be nice to compress the action links.

Apr 11 2015, 9:33 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

I don't expect this to meaningfully impact performance unless we end up with a really fancy animation when cards fly around.

Apr 11 2015, 8:49 PM · Workboards (v3), User Delight, Wikimedia
epriestley added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

Can we just change "Select" into two buttons "Blocks" and "Blocking" (or whatever language, those hurt my head)

Apr 11 2015, 8:39 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
chad added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

Can we just change "Select" into two buttons "Blocks" and "Blocking" (or whatever language, those hurt my head)

Apr 11 2015, 8:32 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
quiddity added a comment to T4900: Workboards updating in real time.

Quick note, that performance would be my biggest concern as an end-user.
When we were using Trello, it would frequently cause my (firefox) browser to "freeze" for 30-60 seconds at a time, whilst medium to large size boards were loading, and dragging cards around was usually sluggish-feeling. e.g. https://trello.com/b/k5N0ivoM/research-and-data
Versus my experience with Phabricator so far, which has been that medium size boards load quite rapidly, and dragging cards around feels quite responsive. e.g. (1,600+ cards) https://phabricator.wikimedia.org/tag/flow/

Apr 11 2015, 8:15 PM · Workboards (v3), User Delight, Wikimedia
qgil added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

Thank you for the quick reply. We'll see.

Apr 11 2015, 8:02 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

@chad, do you have any clever design ideas on this? The best thing I can come up with is sticking a dropdown in the dialog, but that feels really clunky and hard to use to me.

Apr 11 2015, 7:48 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
epriestley added a comment to T4900: Workboards updating in real time.

I'd guess the simple version (just a "something on this workboard has changed" notification) is about 2 hours of work, and needs to happen first anyway.

Apr 11 2015, 7:24 PM · Workboards (v3), User Delight, Wikimedia
qgil added a comment to T4788: Allow "Edit Dependencies" both ways (blocking and depending).

Would you be able to give a rough estimate for paid prioritization of this task?

Apr 11 2015, 7:19 PM · Prioritized, FreeBSD, User Delight, Maniphest, Wikimedia
chad added a comment to T4900: Workboards updating in real time.

oh-no-you-didnt-1.jpg (324×432 px, 80 KB)

Apr 11 2015, 7:15 PM · Workboards (v3), User Delight, Wikimedia
qgil updated subscribers of T4900: Workboards updating in real time.

Would you be able to give a rough estimate for paid prioritization of this task?

Apr 11 2015, 7:13 PM · Workboards (v3), User Delight, Wikimedia

Apr 7 2015

chad closed T7737: "Done" button has misleading UI states, a subtask of T1460: Add "Done" link to an inline comment, as Resolved.
Apr 7 2015, 6:57 PM · User Delight, Differential

Apr 5 2015

chad merged T7763: Hard to add files on mobile into T5187: Make "Upload File" dialog have a vanilla file upload control.
Apr 5 2015, 1:55 AM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia

Apr 2 2015

epriestley closed T7720: Incorrect "Unsubmitted" state detection for Audit inline comments, a subtask of T1460: Add "Done" link to an inline comment, as Resolved.
Apr 2 2015, 2:28 PM · User Delight, Differential
epriestley added subtasks for T1460: Add "Done" link to an inline comment: T7720: Incorrect "Unsubmitted" state detection for Audit inline comments, T7719: Impossible to submit "Done" inline comment state without adding a comment.
Apr 2 2015, 2:25 PM · User Delight, Differential
epriestley added a subtask for T1460: Add "Done" link to an inline comment: T7737: "Done" button has misleading UI states.
Apr 2 2015, 2:24 PM · User Delight, Differential
epriestley added a parent task for T4100: Support query parameterization in typeaheads: T7729: No Typeahead on Herald object rule creation.
Apr 2 2015, 1:17 PM · Typeahead, User Delight, Maniphest

Mar 31 2015

epriestley added a revision to T4100: Support query parameterization in typeaheads: Restricted Differential Revision.
Mar 31 2015, 8:20 PM · Typeahead, User Delight, Maniphest
chad added a comment to T1460: Add "Done" link to an inline comment.

Mostly we're trying to convey more with less color. These new items take up more space, but color/visual impact should be roughly the same. The blue stands out quite a bit, still.

Mar 31 2015, 1:32 AM · User Delight, Differential
joshuaspence added a comment to T1460: Add "Done" link to an inline comment.

(At the same time, I hesitate a bit because having the icons up there be totally different for every comment is also weird.)

New inline comments are really awesome overall, though.

Mar 31 2015, 12:55 AM · User Delight, Differential

Mar 30 2015

epriestley added a comment to T1460: Add "Done" link to an inline comment.

(At the same time, I hesitate a bit because having the icons up there be totally different for every comment is also weird.)

Mar 30 2015, 11:26 PM · User Delight, Differential
chad added a comment to T1460: Add "Done" link to an inline comment.

Easy enough to do

Mar 30 2015, 11:24 PM · User Delight, Differential
chad added a comment to T1460: Add "Done" link to an inline comment.

Easy enough to do

Mar 30 2015, 11:24 PM · User Delight, Differential
epriestley added a comment to T1460: Add "Done" link to an inline comment.

At first actual-real-use, this state feels a little weird to me (the "Not Done", specifically). Maybe we should just hide the checkbox element on drafts, now that we aren't letting you pre-check your own comments?

Mar 30 2015, 11:22 PM · User Delight, Differential

Mar 29 2015

epriestley added a project to T4100: Support query parameterization in typeaheads: Typeahead.
Mar 29 2015, 11:56 PM · Typeahead, User Delight, Maniphest

Mar 27 2015

epriestley added a revision to T1460: Add "Done" link to an inline comment: Restricted Differential Revision.
Mar 27 2015, 11:57 PM · User Delight, Differential
chad added a comment to T1460: Add "Done" link to an inline comment.

@csilvers D12171 is the next UI piece to land, once that's polished up we'll look at the comments-table

Mar 27 2015, 8:47 PM · User Delight, Differential
csilvers added a comment to T1460: Add "Done" link to an inline comment.

This feature is a big hit over here at khan academy!

Mar 27 2015, 8:37 PM · User Delight, Differential

Mar 26 2015

aik099 added a comment to T1460: Add "Done" link to an inline comment.
  • the left margin of Done checkbox is incorrect, which results in left checkbox edge being cut off
  • the vertical align links is incorrect
Mar 26 2015, 6:20 PM · User Delight, Differential
chad added a revision to T1460: Add "Done" link to an inline comment: Restricted Differential Revision.
Mar 26 2015, 5:00 PM · User Delight, Differential
epriestley added a comment to T1460: Add "Done" link to an inline comment.

See some discussion in T7660.

Mar 26 2015, 11:56 AM · User Delight, Differential
aik099 added a comment to T1460: Add "Done" link to an inline comment.

When user have checked "Done" checkbox in inline comment, but haven't used large commenting form at the bottom, then comment end up in fixedState = 'draft' and no indication elsewhere is found:

  • after large comment form indicating, that there are drafts
  • in the list the yellow speech bubble
Mar 26 2015, 7:54 AM · User Delight, Differential

Mar 25 2015

chad added a revision to T1460: Add "Done" link to an inline comment: Restricted Differential Revision.
Mar 25 2015, 7:48 PM · User Delight, Differential

Mar 22 2015

epriestley added a revision to T1460: Add "Done" link to an inline comment: Restricted Differential Revision.
Mar 22 2015, 1:38 PM · User Delight, Differential
epriestley added a revision to T1460: Add "Done" link to an inline comment: Restricted Differential Revision.
Mar 22 2015, 1:29 PM · User Delight, Differential
epriestley added a revision to T1460: Add "Done" link to an inline comment: Restricted Differential Revision.
Mar 22 2015, 1:03 PM · User Delight, Differential

Mar 21 2015

epriestley added a revision to T1460: Add "Done" link to an inline comment: Restricted Differential Revision.
Mar 21 2015, 5:50 PM · User Delight, Differential

Mar 17 2015

epriestley updated subscribers of T5187: Make "Upload File" dialog have a vanilla file upload control.
Mar 17 2015, 10:25 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia

Mar 15 2015

epriestley added a comment to T5187: Make "Upload File" dialog have a vanilla file upload control.

After T7149, drag-and-drop uploads support arbitrarily large files and resumable uploads for files larger than the chunk threshold (currently 8MB).

Mar 15 2015, 7:28 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia

Mar 12 2015

jdloft added a comment to T5793: Add support for personal workboards.

What if the "flags" app had a workboard and you could manage your flagged issues as if you had a personal project. /a crazy thought.

Mar 12 2015, 10:16 PM · User Delight, Wikimedia, Workboards

Mar 11 2015

• chasemp added a comment to T5793: Add support for personal workboards.

What if the "flags" app had a workboard and you could manage your flagged issues as if you had a personal project. /a crazy thought.

Mar 11 2015, 9:19 PM · User Delight, Wikimedia, Workboards

Mar 10 2015

epriestley added a revision to T1460: Add "Done" link to an inline comment: Restricted Differential Revision.
Mar 10 2015, 1:48 AM · User Delight, Differential

Mar 9 2015

epriestley added a revision to T1460: Add "Done" link to an inline comment: Restricted Differential Revision.
Mar 9 2015, 10:59 PM · User Delight, Differential
epriestley added a revision to T1460: Add "Done" link to an inline comment: Restricted Differential Revision.
Mar 9 2015, 7:52 PM · User Delight, Differential
epriestley added a revision to T1460: Add "Done" link to an inline comment: Restricted Differential Revision.
Mar 9 2015, 7:43 PM · User Delight, Differential
epriestley added a revision to T1460: Add "Done" link to an inline comment: Restricted Differential Revision.
Mar 9 2015, 7:18 PM · User Delight, Differential
epriestley added a revision to T1460: Add "Done" link to an inline comment: Restricted Differential Revision.
Mar 9 2015, 6:56 PM · User Delight, Differential

Mar 8 2015

epriestley added a revision to T1460: Add "Done" link to an inline comment: Restricted Differential Revision.
Mar 8 2015, 8:09 PM · User Delight, Differential
epriestley added a comment to T1460: Add "Done" link to an inline comment.

For the actual inline, here's the set of elements I'd like to try starting with:

Mar 8 2015, 7:53 PM · User Delight, Differential

Mar 6 2015

lfaraone created T7477: Handle inbound email with phabricator address in the CC.
Mar 6 2015, 6:36 PM · llvm, Restricted Project, Restricted Project, Mail

Mar 4 2015

chad moved T1460: Add "Done" link to an inline comment from Backlog to v2 (UI/Mobile) on the Differential board.
Mar 4 2015, 5:08 PM · User Delight, Differential

Mar 3 2015

epriestley added a parent task for T1460: Add "Done" link to an inline comment: T7447: Bring inline comments forward across revision updates.
Mar 3 2015, 10:31 PM · User Delight, Differential

Feb 27 2015

• sshannin created T7393: ui.custom_header setting isn't in User Interface Config group.
Feb 27 2015, 12:27 AM

Feb 26 2015

joshuaspence updated the task description for T5296: Allow user-defined date format.
Feb 26 2015, 1:16 AM · Calendar, User Delight, User Preferences

Feb 24 2015

chad added a parent task for T1460: Add "Done" link to an inline comment: T7358: When Replying to an Inline Comment, provide original context in email?.
Feb 24 2015, 2:28 PM · User Delight, Differential

Feb 17 2015

epriestley added a parent task for T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges: T7303: Provide OAuth access to Conduit.
Feb 17 2015, 10:44 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit

Feb 16 2015

johnny-bit added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

Is upgrading as painless as a "sudo apt-get upgrade mysql" -- or am I asking for huge amounts of trouble with that level of naivete on my production install?

Feb 16 2015, 11:07 PM · Support Impact, Remarkup
epriestley added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

Sorry, I pretty much have no idea.

Feb 16 2015, 10:46 PM · Support Impact, Remarkup
• mholden added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

Is upgrading as painless as a "sudo apt-get upgrade mysql" -- or am I asking for huge amounts of trouble with that level of naivete on my production install?

Feb 16 2015, 10:45 PM · Support Impact, Remarkup
epriestley added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

The simplest fix for this would be to make the pre-5.5 sorting collation utf8_general_ci. Most columns with sort collations have only ASCII text (email addresses, usernames, callsigns) but these do not:

Feb 16 2015, 10:35 PM · Support Impact, Remarkup
epriestley added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

Aaah, okay. Upgrading to MySQL 5.5 or newer and running bin/storage adjust will fix this. I'll look into getting it fixed for older MySQL versions.

Feb 16 2015, 10:27 PM · Support Impact, Remarkup
• mholden added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

./bin/search index --type USER had no effect.

Feb 16 2015, 10:25 PM · Support Impact, Remarkup
epriestley added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

There is also a very small chance that running this will fix it:

Feb 16 2015, 10:00 PM · Support Impact, Remarkup
epriestley added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

Hmm, I'm not sure then. Can you show me the output of this?

Feb 16 2015, 9:58 PM · Support Impact, Remarkup
• mholden added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

And, my head commit is at 5a9d70707b9e16169b8a298135b36dd133e2ae

Feb 16 2015, 9:48 PM · Support Impact, Remarkup
• mholden added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

And, my head commit is at 5a9d70707b9e16169b8a298135b36dd133e2ae

Feb 16 2015, 9:48 PM · Support Impact, Remarkup
• mholden added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

Nope, no adjustments

Feb 16 2015, 9:48 PM · Support Impact, Remarkup
• mholden added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

I updated about to the upstream 2 hours ago, I didn't notice any adjustments when I ran my "update.sh" script.

Feb 16 2015, 9:47 PM · Support Impact, Remarkup
epriestley added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

Just a guess. I actually can't reproduce this, though, at least immediately:

Feb 16 2015, 9:46 PM · Support Impact, Remarkup
• mholden added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

:p So is that a known bug, expected behavior?

Feb 16 2015, 9:45 PM · Support Impact, Remarkup
epriestley claimed T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

I am a master sleuth.

Feb 16 2015, 9:44 PM · Support Impact, Remarkup
• mholden added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

Actually yes, I believe they do

Feb 16 2015, 9:43 PM · Support Impact, Remarkup
epriestley added a comment to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems.

Do all the problematic users have uppercase letters in their names?

Feb 16 2015, 9:43 PM · Support Impact, Remarkup
• mholden added projects to T7287: Collation of "sort" columns in MySQL prior to 5.5 causes uppercase/lowercase problems: Remarkup, User Delight.
Feb 16 2015, 9:43 PM · Support Impact, Remarkup

Feb 15 2015

chad updated subscribers of T5187: Make "Upload File" dialog have a vanilla file upload control.
Feb 15 2015, 12:39 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia

Feb 9 2015

qgil updated the task description for T5187: Make "Upload File" dialog have a vanilla file upload control.
Feb 9 2015, 10:28 AM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia

Jan 27 2015

matmarex added a revision to T5187: Make "Upload File" dialog have a vanilla file upload control: Restricted Differential Revision.
Jan 27 2015, 6:51 AM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia
matmarex claimed T5187: Make "Upload File" dialog have a vanilla file upload control.

It would be a lot simpler to use HTML 5 File API together with a regular <input type=file /> field. This won't help the IE8s of the world, but will help users of non-standard, but modern operating systems and browsers.

Jan 27 2015, 6:44 AM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia

Jan 20 2015

epriestley moved T6405: Support for Gmail Inbox actions from Do After Launch to Do Eventually on the Phacility board.
Jan 20 2015, 10:03 PM · Restricted Project, Phacility, Mail

Jan 19 2015

epriestley merged T6984: Differential <> Maniphest Task Relationship via Conduit. into T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.
Jan 19 2015, 2:39 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit

Jan 13 2015

chad updated subscribers of T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.
Jan 13 2015, 5:35 AM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit

Jan 11 2015

epriestley added a comment to T6856: Make Project Images that match Typeahead choices.

Remaining work here is:

Jan 11 2015, 5:48 PM · Design, Projects

Jan 9 2015

lpriestley added a revision to T6856: Make Project Images that match Typeahead choices: Restricted Differential Revision.
Jan 9 2015, 9:28 PM · Design, Projects

Jan 8 2015

epriestley closed T6559: Change notification system implementation not to require Flash, a subtask of T4900: Workboards updating in real time, as Resolved.
Jan 8 2015, 6:03 PM · Workboards (v3), User Delight, Wikimedia

Jan 6 2015

btrahan merged T6876: Differential should preserve inline comments in code through revision updates into T1460: Add "Done" link to an inline comment.
Jan 6 2015, 6:06 PM · User Delight, Differential
epriestley updated subscribers of T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.
Jan 6 2015, 2:57 AM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
chad updated the task description for T1460: Add "Done" link to an inline comment.
Jan 6 2015, 1:32 AM · User Delight, Differential
chad merged T6873: Differential could provide actual content of context lines of code for inline comments into T1460: Add "Done" link to an inline comment.
Jan 6 2015, 1:30 AM · User Delight, Differential
epriestley added a project to T1460: Add "Done" link to an inline comment: User Delight.
Jan 6 2015, 1:11 AM · User Delight, Differential

Jan 5 2015

epriestley added a comment to T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges.

Particularly after strengthening the "prototype" barrier, this is more of a "users want it" issue than a "this has high support costs" issue.

Jan 5 2015, 11:49 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
epriestley edited projects for T5873: Update Conduit for ApplicationTransactions, CustomFields and Edges, added: User Delight; removed Support Impact, High Support Impact.
Jan 5 2015, 11:48 PM · Haskell.org, Restricted Project, Restricted Project, ApplicationEditor, FreeBSD, Restricted Project, User Delight, Phacility, Custom Fields, Transactions, Conduit
chad added a comment to T6856: Make Project Images that match Typeahead choices.

We'll want to use the background colors for tags, and maybe with the checkered tag just use a simple grey background.

Jan 5 2015, 5:24 PM · Design, Projects
epriestley reassigned T6856: Make Project Images that match Typeahead choices from chad to lpriestley.

Projects currently have a small "typeahead/tokenizer" icon (which appears in typeaheads) and a larger "profile picture".

Jan 5 2015, 5:06 PM · Design, Projects
nateguchi2 updated subscribers of T5187: Make "Upload File" dialog have a vanilla file upload control.

+1 for mobile browsers

Jan 5 2015, 2:01 PM · Prioritized, FreeBSD, User Delight, Remarkup, Files, Wikimedia

Jan 4 2015

epriestley added a parent task for T4100: Support query parameterization in typeaheads: T6860: Allow creation of parameterized application policies.
Jan 4 2015, 4:28 PM · Typeahead, User Delight, Maniphest
chad added a revision to T6856: Make Project Images that match Typeahead choices: Restricted Differential Revision.
Jan 4 2015, 1:04 AM · Design, Projects

Jan 3 2015

chad renamed T6856: Make Project Images that match Typeahead choices from Move project images to FontAwesome to Make Project Images that match Typeahead choices.
Jan 3 2015, 7:04 PM · Design, Projects
chad added projects to T6856: Make Project Images that match Typeahead choices: Design, User Delight.
Jan 3 2015, 6:07 PM · Design, Projects

Jan 2 2015

Krenair claimed T5296: Allow user-defined date format.
Jan 2 2015, 4:26 PM · Calendar, User Delight, User Preferences