Maniphest T7737

"Done" button has misleading UI states
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	epriestley
	Apr 2 2015, 2:24 PM

Tags

Referenced Files

None

Subscribers

Description

This is maybe just not in HEAD yet, but:

On a draft inline comment, there's a subtle hover state around "Not Done" which changes the border from grey to brown, even though the button is not clickable.
As a reviewer/auditor, the "√ Done" state has a "cursor: pointer", implying that the button can be interacted with, even though the button is not clickable.

Revisions and Commits

rP Phabricator
	D12313	rPcefdca164422 Fix two minor CSS states with Done button

Related Objects
Search...

		Status	Assigned	Task
				Restricted Maniphest Task
		Resolved	epriestley	T1315 Phacility Launch Status
		Resolved	epriestley	T2795 Phacility (Mid Priority)
		Resolved	chad	T2637 Unbeta Pholio
				Restricted Maniphest Task
		Resolved	epriestley	T5644 Add controls to prevent `pygmentize` from saturating system resources
		Resolved	epriestley	T5179 Unearth Differential rendering technical debt
		Duplicate	epriestley	T5654 Show more context for inline comments in Differential timeline
		Wontfix	epriestley	T5742 Add commentor column to "Revision Update History" table
				Restricted Maniphest Task
		Resolved	epriestley	T7358 When Replying to an Inline Comment, provide original context in email?
		Resolved	epriestley	T1460 Add "Done" link to an inline comment
		Resolved	chad	T7737 "Done" button has misleading UI states

Event Timeline

epriestley created this task.Apr 2 2015, 2:24 PM

epriestley raised the priority of this task from to Low.

epriestley updated the task description. (Show Details)

epriestley added projects: Diffusion, Differential, Design.

epriestley added a parent task: T1460: Add "Done" link to an inline comment.

epriestley added a subscriber: epriestley.

chad added a revision: D12313: Fix two minor CSS states with Done button.Apr 7 2015, 6:02 PM

chad closed this task as Resolved by committing rPcefdca164422: Fix two minor CSS states with Done button.Apr 7 2015, 6:57 PM

chad added a commit: rPcefdca164422: Fix two minor CSS states with Done button.