I think some user has somehow managed to end up with two drafts for the same revision. The right fix is probably to remove one and then adjust again.

I'm getting the following error when trying to apply storage adjustments:

Closed by commit rPORG73f7c4030a9a.

APC is mostly-dead for php >= 5.4, and OpCache is "core" and "supported" for php >=5.5.

Yes, the current implementation doesn't pursue that optimization because it's simpler to omit it and simpler to debug issues when the queries only do one thing each.

Perhaps I'm misunderstanding, but it seems like storage adjust could be made more efficient. Each time you alter a table, MySQL makes a copy of it, alters the copy then replaces the original with the modified one. If we perform several alters, this adds up to several table copies. On large tables this takes considerable time.

T6395 identified a new stack trace for empty commits.

Yeah, I think publishing feed stories and sending emails from importing repositories is badsauce. Patch in a moment.

if I export myself LC_ALL=C it just works.
don't know why it was failing from the patches you have provided me

We can not parse every language. In the very narrow case of patch files, we probably can, but we depend on parsing the output from many other commands to detect specific errors in all of Git, Mercurial and Subversion. For example, sometimes a command exits with, say, exit code 1, but several different errors can actually cause that exit code, and we want to act differently depending on which error occurred. The only way we can tell which error occurred is to look at the program output. To parse error messages in every language we would need to hard-code every translation and keep that list up to date, which is unreasonable.

I’m confused. Will what it parses depend on the languages installed/available and setup on the server?
I would expect the patch parser to recognize patch files of any language, without depending on runtime environment languages.

tested with both applied and still fails with LC_ALL=fr_FR.UTF8

Yep, all yours.

(whoops, I don't know why I selected "resolve" and not "reassign")

Cool if I yoink this? Yoink back if you're working on it.

@bapt, @ite-klass - could someone please test D9922 + D9938? We have tons of trouble testing this stuff since we run all english otherwise.

Closed by commit rP9dd09f717192.

This is now fixed. See rPe6d946661ddf296d44063f12e44925a35271cc6f for an example that was broken on this install and subsequently fixed.

Awesome, thanks for the quick fix. Can you tell me how to make it re-parse commits that are stuck?

Closed by commit rPba2963ecb3bb.

Well, I think I solved the mystery... See D10723.

No errors in log there either, running ./bin/repository importing ZU --trace just gives the query:

>>> [2] <connect> phabricator_repository
<<< [2] <connect> 1,219 us
>>> [3] <query> SELECT * FROM `repository` r  WHERE (r.callsign IN ('ZU')) ORDER BY r.id DESC
<<< [3] <query> 385 us
>>> [4] <query> SELECT repositoryID, commitIdentifier, importStatus FROM `repository_commit`
        WHERE repositoryID IN (333) AND (importStatus & 15) != 15
<<< [4] <query> 2,382 us
rZU68059b3473d53c28e4ddffb3cd0bac79ed719fbb Herald
rZU011a6af20dac1cae5efc9ab191645248f315e85e Herald

Does anyone have any errors in their log?

we seem to reproduce this here now on at least a few commits.

Support Impact several people have has issues this week after upgrading.

Closed by commit rPac83ff706023.

I think we should just remove Gravatar support completely. I don't think it's valuable enough to justify the complexity that supporting it implies.

Thanks @chad
I think gravatar option ( default = false ) is needed.

Please see T6261#78678

@chad
I think T6322 is different a little bit.
Change user picture was success, but it took very long time to see edit picture page.
Please check this,

Re-opening as people will still likely hit this case and it's likely fixable.

Closed by commit rP3dd92a78ac2a.

Closed by commit rPaf4ebc67c66f.

The same error happens in differential, when you have a renamed file. You get the message "This file was changed only by adding or removing whitespace. Show File Contents", and clicking Show File Contents throws this error (in core.pkg.js line 333).

secret commits

Those seem reasonable to me, yeah.

Closed by commit rPee8004ab4d7d.

@epriestley, what do you see worth putting on "Roadmap". SaaS? Harbormaster? Spaces?

Oh, I'm actually misunderstanding this a little bit.

Yeah, just make it a full dialog / workflow. No need for two different forms.

We could also remove this interface completely, or replace it with the full-power interface and remove the "quick" flavor.

See also T4016.

Other installs should NOT run bin/storage adjust yet: we have some things that still need cleanup.

Closed by commit rP45bb77531c79.

Note that the other potential issue identified here - https://secure.phabricator.com/D10490#90899 - is not fixed by these changes. "bin/migrate" started to feel a bit crazy magical to me and otherwise I think we can deal with this unaddressed problem if / when we create it.

Closed by commit rPc0848bca6d91.